graphql_devise 0.10.1 → 0.11.0

data/spec/services/mount_method/option_validators/provided_operations_validator_spec.rb

@@ -0,0 +1,57 @@
+require 'spec_helper'
+
+RSpec.describe GraphqlDevise::MountMethod::OptionValidators::ProvidedOperationsValidator do
+  describe '#validate!' do
+    subject { -> { described_class.new(options: provided_operations, supported_operations: supported_operations).validate! } }
+
+    let(:supported_operations) { { operation1: 'irrelevant', operation2: 'irrelevant', operation3: 'irrelevant' } }
+
+    context 'when skip option is provided' do
+      let(:provided_operations) { double(:clean_options, only: [], skip: skipped, operations: {}) }
+
+      context 'when all skipped are supported' do
+        let(:skipped) { [:operation2, :operation3] }
+
+        it { is_expected.not_to raise_error }
+      end
+
+      context 'when skipped contains unsupported operations' do
+        let(:skipped) { [:operation2, :operation3, :invalid] }
+
+        it { is_expected.to raise_error(GraphqlDevise::InvalidMountOptionsError, 'skip option contains unsupported operations: "invalid". Check for typos.') }
+      end
+    end
+
+    context 'when only option is provided' do
+      let(:provided_operations) { double(:clean_options, skip: [], only: only, operations: {}) }
+
+      context 'when all only are supported' do
+        let(:only) { [:operation2, :operation3] }
+
+        it { is_expected.not_to raise_error }
+      end
+
+      context 'when only contains unsupported operations' do
+        let(:only) { [:operation2, :operation3, :invalid] }
+
+        it { is_expected.to raise_error(GraphqlDevise::InvalidMountOptionsError, 'only option contains unsupported operations: "invalid". Check for typos.') }
+      end
+    end
+
+    context 'when operations option is provided' do
+      let(:provided_operations) { double(:clean_options, only: [], skip: [], operations: operations) }
+
+      context 'when all operations are supported' do
+        let(:operations) { { operation2: 'irrelevant', operation3: 'irrelevant' } }
+
+        it { is_expected.not_to raise_error }
+      end
+
+      context 'when operations contains unsupported operations' do
+        let(:operations) { { operation2: 'irrelevant', operation3: 'irrelevant', invalid: 'invalid' } }
+
+        it { is_expected.to raise_error(GraphqlDevise::InvalidMountOptionsError, 'operations option contains unsupported operations: "invalid". Check for typos.') }
+      end
+    end
+  end
+end

data/spec/services/mount_method/option_validators/skip_only_validator_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+RSpec.describe GraphqlDevise::MountMethod::OptionValidators::SkipOnlyValidator do
+  describe '#validate!' do
+    subject { -> { described_class.new(options: options).validate! } }
+
+    context 'when only `only` key is set' do
+      let(:options) { double(:clean_options, only: [:irrelevant], skip: []) }
+
+      it { is_expected.not_to raise_error }
+    end
+
+    context 'when only `skip` key is set' do
+      let(:options) { double(:clean_options, skip: [:irrelevant], only: []) }
+
+      it { is_expected.not_to raise_error }
+    end
+
+    context 'when `skip` and `only` keys are set' do
+      let(:options) { double(:clean_options, only: [:irrelevant], skip: [:irrelevant]) }
+
+      it { is_expected.to raise_error(GraphqlDevise::InvalidMountOptionsError, "Can't specify both `skip` and `only` options when mounting the route.") }
+    end
+
+    context 'when neither `skip` nor `only are set`' do
+      let(:options) { double(:clean_options, skip: [], only: []) }
+
+      it { is_expected.not_to raise_error }
+    end
+  end
+end

data/spec/services/mount_method/option_validators/supported_operations_validator_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+RSpec.describe GraphqlDevise::MountMethod::OptionValidators::SupportedOperationsValidator do
+  describe '#validate!' do
+    subject { -> { described_class.new(provided_operations: provided_operations, supported_operations: supported_operations, key: key).validate! } }
+
+    let(:supported_operations) { [:operation1, :operation2, :operation3] }
+    let(:key)                  { :only }
+
+    context 'when custom operations are all supported' do
+      let(:provided_operations) { [:operation2, :operation3] }
+
+      it { is_expected.not_to raise_error }
+    end
+
+    context 'when no operations are provided' do
+      let(:provided_operations) { [] }
+
+      it { is_expected.not_to raise_error }
+    end
+
+    context 'when default_operations are empty' do
+      let(:supported_operations) { [] }
+      let(:provided_operations) { [:invalid] }
+
+      it { is_expected.to raise_error(GraphqlDevise::InvalidMountOptionsError, 'only option contains unsupported operations: "invalid". Check for typos.') }
+    end
+
+    context 'when not all custom operations are supported' do
+      let(:provided_operations) { [:operation2, :operation3, :unsupported] }
+
+      it { is_expected.to raise_error(GraphqlDevise::InvalidMountOptionsError, 'only option contains unsupported operations: "unsupported". Check for typos.') }
+    end
+  end
+end

data/spec/services/mount_method/options_validator_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+RSpec.describe GraphqlDevise::MountMethod::OptionsValidator do
+  describe '#validate!' do
+    subject { -> { described_class.new([validator1, validator2]).validate! } }
+
+    let(:validator1) { double(:validator1, 'validate!': nil) }
+    let(:validator2) { double(:validator2, 'validate!': nil) }
+
+    context 'when first validator fails' do
+      before { allow(validator1).to receive(:validate!).and_raise(GraphqlDevise::InvalidMountOptionsError, 'validator1 error') }
+
+      context 'when second validator fails' do
+        before { allow(validator2).to receive(:validate!).and_raise(GraphqlDevise::InvalidMountOptionsError, 'validator2 error') }
+
+        it { is_expected.to raise_error(GraphqlDevise::InvalidMountOptionsError, 'validator1 error') }
+      end
+
+      context 'when second validator does not fail' do
+        it { is_expected.to raise_error(GraphqlDevise::InvalidMountOptionsError, 'validator1 error') }
+      end
+    end
+
+    context 'when first validator does not fail' do
+      context 'when second validator fails' do
+        before { allow(validator2).to receive(:validate!).and_raise(GraphqlDevise::InvalidMountOptionsError, 'validator2 error') }
+
+        it { is_expected.to raise_error(GraphqlDevise::InvalidMountOptionsError, 'validator2 error') }
+      end
+
+      context 'when second validator does not fail' do
+        it { is_expected.not_to raise_error }
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: graphql_devise
 version: !ruby/object:Gem::Version
-  version: 0.10.1
+  version: 0.11.0
 platform: ruby
 authors:
 - Mario Celi
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-03-21 00:00:00.000000000 Z
+date: 2020-04-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: devise_token_auth
@@ -169,30 +169,30 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -273,22 +273,7 @@ files:
 - app/controllers/graphql_devise/application_controller.rb
 - app/controllers/graphql_devise/concerns/set_user_by_token.rb
 - app/controllers/graphql_devise/graphql_controller.rb
-- app/graphql/graphql_devise/mutations/base.rb
-- app/graphql/graphql_devise/mutations/login.rb
-- app/graphql/graphql_devise/mutations/logout.rb
-- app/graphql/graphql_devise/mutations/resend_confirmation.rb
-- app/graphql/graphql_devise/mutations/send_password_reset.rb
-- app/graphql/graphql_devise/mutations/sign_up.rb
-- app/graphql/graphql_devise/mutations/update_password.rb
-- app/graphql/graphql_devise/resolvers/base.rb
-- app/graphql/graphql_devise/resolvers/check_password_token.rb
-- app/graphql/graphql_devise/resolvers/confirm_account.rb
-- app/graphql/graphql_devise/resolvers/dummy.rb
 - app/graphql/graphql_devise/schema.rb
-- app/graphql/graphql_devise/types/authenticatable_type.rb
-- app/graphql/graphql_devise/types/credential_type.rb
-- app/graphql/graphql_devise/types/mutation_type.rb
-- app/graphql/graphql_devise/types/query_type.rb
 - app/helpers/graphql_devise/application_helper.rb
 - app/helpers/graphql_devise/mailer_helper.rb
 - app/models/graphql_devise/concerns/model.rb
@@ -299,28 +284,49 @@ files:
 - bin/rails
 - bin/setup
 - config/locales/en.yml
-- gemfiles/.bundle/config
-- gemfiles/rails4.2_graphql1.8.gemfile
-- gemfiles/rails5.0_graphql1.8.gemfile
-- gemfiles/rails5.0_graphql1.9.gemfile
-- gemfiles/rails5.1_graphql1.8.gemfile
-- gemfiles/rails5.1_graphql1.9.gemfile
-- gemfiles/rails5.2_graphql1.10.gemfile
-- gemfiles/rails5.2_graphql1.8.gemfile
-- gemfiles/rails5.2_graphql1.9.gemfile
-- gemfiles/rails6.0_graphql1.10.gemfile
-- gemfiles/rails6.0_graphql1.8.gemfile
-- gemfiles/rails6.0_graphql1.9.gemfile
-- gemfiles/rails6.0_graphql_edge.gemfile
-- gemfiles/rails_edge_graphql_edge.gemfile
 - graphql_devise.gemspec
 - lib/generators/graphql_devise/install_generator.rb
 - lib/graphql_devise.rb
 - lib/graphql_devise/concerns/controller_methods.rb
+- lib/graphql_devise/default_operations/mutations.rb
+- lib/graphql_devise/default_operations/resolvers.rb
 - lib/graphql_devise/detailed_user_error.rb
 - lib/graphql_devise/engine.rb
 - lib/graphql_devise/error_codes.rb
+- lib/graphql_devise/mount_method/operation_preparer.rb
+- lib/graphql_devise/mount_method/operation_preparers/custom_operation_preparer.rb
+- lib/graphql_devise/mount_method/operation_preparers/default_operation_preparer.rb
+- lib/graphql_devise/mount_method/operation_preparers/gql_name_setter.rb
+- lib/graphql_devise/mount_method/operation_preparers/mutation_field_setter.rb
+- lib/graphql_devise/mount_method/operation_preparers/resolver_type_setter.rb
+- lib/graphql_devise/mount_method/operation_preparers/resource_name_setter.rb
+- lib/graphql_devise/mount_method/operation_sanitizer.rb
+- lib/graphql_devise/mount_method/option_sanitizer.rb
+- lib/graphql_devise/mount_method/option_sanitizers/array_checker.rb
+- lib/graphql_devise/mount_method/option_sanitizers/class_checker.rb
+- lib/graphql_devise/mount_method/option_sanitizers/hash_checker.rb
+- lib/graphql_devise/mount_method/option_sanitizers/string_checker.rb
+- lib/graphql_devise/mount_method/option_validators/provided_operations_validator.rb
+- lib/graphql_devise/mount_method/option_validators/skip_only_validator.rb
+- lib/graphql_devise/mount_method/option_validators/supported_operations_validator.rb
+- lib/graphql_devise/mount_method/options_validator.rb
+- lib/graphql_devise/mount_method/supported_options.rb
+- lib/graphql_devise/mutations/base.rb
+- lib/graphql_devise/mutations/login.rb
+- lib/graphql_devise/mutations/logout.rb
+- lib/graphql_devise/mutations/resend_confirmation.rb
+- lib/graphql_devise/mutations/send_password_reset.rb
+- lib/graphql_devise/mutations/sign_up.rb
+- lib/graphql_devise/mutations/update_password.rb
 - lib/graphql_devise/rails/routes.rb
+- lib/graphql_devise/resolvers/base.rb
+- lib/graphql_devise/resolvers/check_password_token.rb
+- lib/graphql_devise/resolvers/confirm_account.rb
+- lib/graphql_devise/resolvers/dummy.rb
+- lib/graphql_devise/types/authenticatable_type.rb
+- lib/graphql_devise/types/credential_type.rb
+- lib/graphql_devise/types/mutation_type.rb
+- lib/graphql_devise/types/query_type.rb
 - lib/graphql_devise/user_error.rb
 - lib/graphql_devise/version.rb
 - spec/dummy/README.md
@@ -409,6 +415,23 @@ files:
 - spec/requests/queries/check_password_token_spec.rb
 - spec/requests/queries/confirm_account_spec.rb
 - spec/requests/user_controller_spec.rb
+- spec/services/mount_method/operation_preparer_spec.rb
+- spec/services/mount_method/operation_preparers/custom_operation_preparer_spec.rb
+- spec/services/mount_method/operation_preparers/default_operation_preparer_spec.rb
+- spec/services/mount_method/operation_preparers/gql_name_setter_spec.rb
+- spec/services/mount_method/operation_preparers/mutation_field_setter_spec.rb
+- spec/services/mount_method/operation_preparers/resolver_type_setter_spec.rb
+- spec/services/mount_method/operation_preparers/resource_name_setter_spec.rb
+- spec/services/mount_method/operation_sanitizer_spec.rb
+- spec/services/mount_method/option_sanitizer_spec.rb
+- spec/services/mount_method/option_sanitizers/array_checker_spec.rb
+- spec/services/mount_method/option_sanitizers/class_checker_spec.rb
+- spec/services/mount_method/option_sanitizers/hash_checker_spec.rb
+- spec/services/mount_method/option_sanitizers/string_checker_spec.rb
+- spec/services/mount_method/option_validators/provided_operations_validator_spec.rb
+- spec/services/mount_method/option_validators/skip_only_validator_spec.rb
+- spec/services/mount_method/option_validators/supported_operations_validator_spec.rb
+- spec/services/mount_method/options_validator_spec.rb
 - spec/spec_helper.rb
 - spec/support/contexts/graphql_request.rb
 - spec/support/factory_bot.rb
@@ -537,3 +560,20 @@ test_files:
 - spec/factories/users_customers.rb
 - spec/generators/graphql_devise/install_generator_spec.rb
 - spec/rails_helper.rb
+- spec/services/mount_method/option_sanitizers/class_checker_spec.rb
+- spec/services/mount_method/option_sanitizers/array_checker_spec.rb
+- spec/services/mount_method/option_sanitizers/hash_checker_spec.rb
+- spec/services/mount_method/option_sanitizers/string_checker_spec.rb
+- spec/services/mount_method/option_sanitizer_spec.rb
+- spec/services/mount_method/options_validator_spec.rb
+- spec/services/mount_method/operation_preparer_spec.rb
+- spec/services/mount_method/operation_preparers/gql_name_setter_spec.rb
+- spec/services/mount_method/operation_preparers/default_operation_preparer_spec.rb
+- spec/services/mount_method/operation_preparers/resolver_type_setter_spec.rb
+- spec/services/mount_method/operation_preparers/resource_name_setter_spec.rb
+- spec/services/mount_method/operation_preparers/mutation_field_setter_spec.rb
+- spec/services/mount_method/operation_preparers/custom_operation_preparer_spec.rb
+- spec/services/mount_method/option_validators/supported_operations_validator_spec.rb
+- spec/services/mount_method/option_validators/provided_operations_validator_spec.rb
+- spec/services/mount_method/option_validators/skip_only_validator_spec.rb
+- spec/services/mount_method/operation_sanitizer_spec.rb

data/gemfiles/.bundle/config

@@ -1,2 +0,0 @@
----
-BUNDLE_RETRY: "1"

data/gemfiles/rails4.2_graphql1.8.gemfile

@@ -1,10 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "sqlite3", "~> 1.3.6"
-gem "bundler", "~> 1.17"
-gem "rails", github: "rails/rails", branch: "4-2-stable"
-gem "graphql", "~> 1.8.0"
-
-gemspec path: "../"

data/gemfiles/rails5.0_graphql1.8.gemfile

@@ -1,11 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "sqlite3", "~> 1.3.6"
-gem "rails", github: "rails/rails", branch: "5-0-stable"
-gem "graphql", "~> 1.8.0"
-gem "devise_token_auth", "0.1.43"
-gem "devise", ">= 4.0"
-
-gemspec path: "../"

data/gemfiles/rails5.0_graphql1.9.gemfile

@@ -1,9 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "sqlite3", "~> 1.3.6"
-gem "rails", github: "rails/rails", branch: "5-0-stable"
-gem "graphql", "~> 1.9.0"
-
-gemspec path: "../"

data/gemfiles/rails5.1_graphql1.8.gemfile

@@ -1,11 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "sqlite3", "~> 1.3.6"
-gem "rails", github: "rails/rails", branch: "5-1-stable"
-gem "graphql", "~> 1.8.0"
-gem "devise_token_auth", "0.1.43"
-gem "devise", ">= 4.3"
-
-gemspec path: "../"

data/gemfiles/rails5.1_graphql1.9.gemfile

@@ -1,9 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "sqlite3", "~> 1.3.6"
-gem "rails", github: "rails/rails", branch: "5-1-stable"
-gem "graphql", "~> 1.9.0"
-
-gemspec path: "../"

data/gemfiles/rails5.2_graphql1.10.gemfile

@@ -1,9 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "sqlite3", "~> 1.3.6"
-gem "rails", github: "rails/rails", branch: "5-2-stable"
-gem "graphql", "~> 1.10.0"
-
-gemspec path: "../"

data/gemfiles/rails5.2_graphql1.8.gemfile

@@ -1,11 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "sqlite3", "~> 1.3.6"
-gem "rails", github: "rails/rails", branch: "5-2-stable"
-gem "graphql", "~> 1.8.0"
-gem "devise_token_auth", "0.1.43"
-gem "devise", ">= 4.4.2"
-
-gemspec path: "../"

data/gemfiles/rails5.2_graphql1.9.gemfile

@@ -1,9 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "sqlite3", "~> 1.3.6"
-gem "rails", github: "rails/rails", branch: "5-2-stable"
-gem "graphql", "~> 1.9.0"
-
-gemspec path: "../"