graphql 2.6.9 → 2.6.14

data/lib/graphql/static_validation/rules/fields_will_merge_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
     class FieldsWillMergeError < StaticValidation::Error
@@ -11,6 +12,9 @@ module GraphQL
         @field_name = field_name
         @kind = kind
         @conflicts = []
+        # Indexes of `@nodes`, so that `add_conflict` doesn't compare `node` with each one
+        @node_ids = {}.compare_by_identity #: Hash[GraphQL::Language::Nodes::AbstractNode, bool]
+        @nodes_by_location = nil #: Hash[Integer?, Hash[Integer?, Array[GraphQL::Language::Nodes::AbstractNode]]]?
       end
 
       def message
@@ -31,11 +35,19 @@ module GraphQL
         # Check if we already have an error for this exact node.
         # Use object identity first (fast path), then fall back to
         # value + location comparison for duplicate AST nodes.
-        if nodes.any? { |n| n.equal?(node) || (n.line == node.line && n.col == node.col && n == node) }
+        return if @node_ids.key?(node)
+
+        nodes_at_line = (@nodes_by_location ||= {})[node.line] ||= {}
+        nodes_at_location = nodes_at_line[node.col]
+        if nodes_at_location
           # already have an error for this node
-          return
+          return if nodes_at_location.any? { |n| n == node }
+          nodes_at_location << node
+        else
+          nodes_at_line[node.col] = [node]
         end
 
+        @node_ids[node] = true
         @nodes << node
         @conflicts << conflict_str
       end

data/lib/graphql/static_validation/rules/fragment_names_are_unique.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
+    #--
+    # @requires_ancestor: GraphQL::StaticValidation::BaseVisitor
     module FragmentNamesAreUnique
 
       def initialize(*)

data/lib/graphql/static_validation/rules/fragment_names_are_unique_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
     class FragmentNamesAreUniqueError < StaticValidation::Error

data/lib/graphql/static_validation/rules/fragment_spreads_are_possible.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
+    #--
+    # @requires_ancestor: GraphQL::StaticValidation::BaseVisitor
     module FragmentSpreadsArePossible
       def initialize(*)
         super

data/lib/graphql/static_validation/rules/fragment_spreads_are_possible_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
     class FragmentSpreadsArePossibleError < StaticValidation::Error

data/lib/graphql/static_validation/rules/fragment_types_exist.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
+    #--
+    # @requires_ancestor: GraphQL::StaticValidation::BaseVisitor
     module FragmentTypesExist
       def on_fragment_definition(node, _parent)
         if validate_type_exists(node)

data/lib/graphql/static_validation/rules/fragment_types_exist_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
     class FragmentTypesExistError < StaticValidation::Error

data/lib/graphql/static_validation/rules/fragments_are_finite.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
+    #--
+    # @requires_ancestor: GraphQL::StaticValidation::BaseVisitor
     module FragmentsAreFinite
       def on_document(_n, _p)
         super

data/lib/graphql/static_validation/rules/fragments_are_finite_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
     class FragmentsAreFiniteError < StaticValidation::Error

data/lib/graphql/static_validation/rules/fragments_are_named.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
+    #--
+    # @requires_ancestor: GraphQL::StaticValidation::BaseVisitor
     module FragmentsAreNamed
       def on_fragment_definition(node, _parent)
         if node.name.nil?

data/lib/graphql/static_validation/rules/fragments_are_named_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
     class FragmentsAreNamedError < StaticValidation::Error

data/lib/graphql/static_validation/rules/fragments_are_on_composite_types.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
+    #--
+    # @requires_ancestor: GraphQL::StaticValidation::BaseVisitor
     module FragmentsAreOnCompositeTypes
       def on_fragment_definition(node, parent)
         validate_type_is_composite(node) && super

data/lib/graphql/static_validation/rules/fragments_are_on_composite_types_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
     class FragmentsAreOnCompositeTypesError < StaticValidation::Error

data/lib/graphql/static_validation/rules/fragments_are_used.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
+    #--
+    # @requires_ancestor: GraphQL::StaticValidation::BaseVisitor
     module FragmentsAreUsed
       def on_document(node, parent)
         super

data/lib/graphql/static_validation/rules/fragments_are_used_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
     class FragmentsAreUsedError < StaticValidation::Error

data/lib/graphql/static_validation/rules/input_object_names_are_unique.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
+    #--
+    # @requires_ancestor: GraphQL::StaticValidation::BaseVisitor
     module InputObjectNamesAreUnique
       def on_input_object(node, parent)
         validate_input_fields(node)

data/lib/graphql/static_validation/rules/input_object_names_are_unique_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
     class InputObjectNamesAreUniqueError < StaticValidation::Error

data/lib/graphql/static_validation/rules/mutation_root_exists.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
+    #--
+    # @requires_ancestor: GraphQL::StaticValidation::BaseVisitor
     module MutationRootExists
       def on_operation_definition(node, _parent)
         if node.operation_type == 'mutation' && context.query.types.mutation_root.nil?

data/lib/graphql/static_validation/rules/mutation_root_exists_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
     class MutationRootExistsError < StaticValidation::Error

data/lib/graphql/static_validation/rules/no_definitions_are_present.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
+    #--
+    # @requires_ancestor: GraphQL::StaticValidation::BaseVisitor
     module NoDefinitionsArePresent
       include GraphQL::StaticValidation::Error::ErrorHelper
 

data/lib/graphql/static_validation/rules/no_definitions_are_present_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
     class NoDefinitionsArePresentError < StaticValidation::Error

data/lib/graphql/static_validation/rules/not_single_subscription_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
     class NotSingleSubscriptionError < StaticValidation::Error

data/lib/graphql/static_validation/rules/one_of_input_objects_are_valid.rb

@@ -1,6 +1,10 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
+    #--
+    # @requires_ancestor: GraphQL::StaticValidation::BaseVisitor
+    # @requires_ancestor: GraphQL::StaticValidation::RequiredInputObjectAttributesArePresent
     module OneOfInputObjectsAreValid
       def on_input_object(node, parent)
         return super unless parent.is_a?(GraphQL::Language::Nodes::Argument)

data/lib/graphql/static_validation/rules/one_of_input_objects_are_valid_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
     class OneOfInputObjectsAreValidError < StaticValidation::Error

data/lib/graphql/static_validation/rules/operation_names_are_valid.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
+    #--
+    # @requires_ancestor: GraphQL::StaticValidation::BaseVisitor
     module OperationNamesAreValid
       def initialize(*)
         super

data/lib/graphql/static_validation/rules/operation_names_are_valid_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
     class OperationNamesAreValidError < StaticValidation::Error

data/lib/graphql/static_validation/rules/query_root_exists.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
+    #--
+    # @requires_ancestor: GraphQL::StaticValidation::BaseVisitor
     module QueryRootExists
       def on_operation_definition(node, _parent)
         if (node.operation_type == 'query' || node.operation_type.nil?) && context.query.types.query_root.nil?

data/lib/graphql/static_validation/rules/query_root_exists_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
     class QueryRootExistsError < StaticValidation::Error

data/lib/graphql/static_validation/rules/required_arguments_are_present.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
+    #--
+    # @requires_ancestor: GraphQL::StaticValidation::BaseVisitor
     module RequiredArgumentsArePresent
       def initialize(*)
         super
@@ -29,7 +32,7 @@ module GraphQL
           required_argument_names = @required_args_cache[defn]
         else
           args = @types.arguments(defn)
-          required_argument_names = nil
+          required_argument_names = nil #: untyped
           if !args.empty?
             args.each do |a|
               if a.type.kind.non_null? && !a.default_value? && @types.argument(defn, a.name)

data/lib/graphql/static_validation/rules/required_arguments_are_present_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
     class RequiredArgumentsArePresentError < StaticValidation::Error

data/lib/graphql/static_validation/rules/required_input_object_attributes_are_present.rb

@@ -1,6 +1,10 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
+    #--
+    # @requires_ancestor: GraphQL::StaticValidation::BaseVisitor
+    # @requires_ancestor: GraphQL::StaticValidation::ArgumentsAreDefined
     module RequiredInputObjectAttributesArePresent
       def on_input_object(node, parent)
         if parent.is_a? GraphQL::Language::Nodes::Argument

data/lib/graphql/static_validation/rules/required_input_object_attributes_are_present_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
     class RequiredInputObjectAttributesArePresentError < StaticValidation::Error

data/lib/graphql/static_validation/rules/subscription_root_exists_and_single_subscription_selection.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
+    #--
+    # @requires_ancestor: GraphQL::StaticValidation::BaseVisitor
     module SubscriptionRootExistsAndSingleSubscriptionSelection
       def on_operation_definition(node, parent)
         if node.operation_type == "subscription"
@@ -9,18 +12,53 @@ module GraphQL
               'Schema is not configured for subscriptions',
               nodes: node
             ))
-          elsif node.selections.size != 1
-            add_error(GraphQL::StaticValidation::NotSingleSubscriptionError.new(
-              'A subscription operation may only have one selection',
-              nodes: node,
-            ))
           else
+            root_fields = subscription_root_fields(node)
+            if root_fields.map { |field| field.alias || field.name }.uniq.size != 1
+              add_error(GraphQL::StaticValidation::NotSingleSubscriptionError.new(
+                'A subscription operation may only have one selection',
+                nodes: node,
+              ))
+            elsif root_fields.any? { |field| field.name.start_with?("__") }
+              add_error(GraphQL::StaticValidation::NotSingleSubscriptionError.new(
+                'A subscription operation may not select an introspection field',
+                nodes: node,
+              ))
+            end
             super
           end
         else
           super
         end
       end
+
+      private
+
+      def subscription_root_fields(node)
+        root_type = context.types.subscription_root
+        fields = []
+        selections = node.selections.dup
+        visited_fragments = {}
+
+        while (selection = selections.pop)
+          case selection
+          when GraphQL::Language::Nodes::Field
+            fields << selection
+          when GraphQL::Language::Nodes::FragmentSpread
+            next if visited_fragments[selection.name]
+            visited_fragments[selection.name] = true
+            fragment = context.fragments[selection.name]
+            selections << fragment if fragment
+          when GraphQL::Language::Nodes::InlineFragment, GraphQL::Language::Nodes::FragmentDefinition
+            fragment_type = (selection_type = selection.type) ? @types.type(selection_type.name) : root_type
+            if fragment_type && fragment_type.kind.composite? && @types.possible_types(fragment_type).include?(root_type)
+              selections.concat(selection.selections)
+            end
+          end
+        end
+
+        fields
+      end
     end
   end
 end

data/lib/graphql/static_validation/rules/subscription_root_exists_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
     class SubscriptionRootExistsError < StaticValidation::Error

data/lib/graphql/static_validation/rules/unique_directives_per_location.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
+    #--
+    # @requires_ancestor: GraphQL::StaticValidation::BaseVisitor
     module UniqueDirectivesPerLocation
       DIRECTIVE_NODE_HOOKS = [
         :on_fragment_definition,

data/lib/graphql/static_validation/rules/unique_directives_per_location_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
     class UniqueDirectivesPerLocationError < StaticValidation::Error

data/lib/graphql/static_validation/rules/variable_default_values_are_correctly_typed.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
+    #--
+    # @requires_ancestor: GraphQL::StaticValidation::BaseVisitor
     module VariableDefaultValuesAreCorrectlyTyped
       def on_variable_definition(node, parent)
         if !node.default_value.nil?

data/lib/graphql/static_validation/rules/variable_default_values_are_correctly_typed_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
     class VariableDefaultValuesAreCorrectlyTypedError < StaticValidation::Error

data/lib/graphql/static_validation/rules/variable_names_are_unique.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
+    #--
+    # @requires_ancestor: GraphQL::StaticValidation::BaseVisitor
     module VariableNamesAreUnique
       def on_operation_definition(node, parent)
         var_defns = node.variables

data/lib/graphql/static_validation/rules/variable_names_are_unique_error.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# typed: true
 module GraphQL
   module StaticValidation
     class VariableNamesAreUniqueError < StaticValidation::Error