graphql 2.5.9 → 2.5.26

data/lib/graphql/tracing/detailed_trace.rb

@@ -1,18 +1,34 @@
 # frozen_string_literal: true
+if defined?(ActiveRecord)
+  require "graphql/tracing/detailed_trace/active_record_backend"
+end
 require "graphql/tracing/detailed_trace/memory_backend"
 require "graphql/tracing/detailed_trace/redis_backend"
 
 module GraphQL
   module Tracing
-    # `DetailedTrace` can make detailed profiles for a subset of production traffic.
+    # `DetailedTrace` can make detailed profiles for a subset of production traffic. Install it in Rails with `rails generate graphql:detailed_trace`.
     #
     # When `MySchema.detailed_trace?(query)` returns `true`, a profiler-specific `trace_mode: ...` will be used for the query,
     # overriding the one in `context[:trace_mode]`.
     #
-    # __Redis__: The sampler stores its results in a provided Redis database. Depending on your needs,
-    # You can configure this database to retail all data (persistent) or to expire data according to your rules.
+    # By default, the detailed tracer calls `.inspect` on application objects returned from fields. You can customize
+    # this behavior by extending {DetailedTrace} and overriding {#inspect_object}. You can opt out of debug annotations
+    # entirely with `use ..., debug: false` or for a single query with `context: { detailed_trace_debug: false }`.
+    #
+    # You can store saved traces in two ways:
+    #
+    # - __ActiveRecord__: With `rails generate graphql:detailed_trace`, a new migration will be added to your app.
+    # That table will be used to store trace data.
+    #
+    # - __Redis__: Pass `redis: ...` to save trace data to a Redis database. Depending on your needs,
+    # you can configure this database to retain all data (persistent) or to expire data according to your rules.
+    #
     # If you need to save traces indefinitely, you can download them from Perfetto after opening them there.
     #
+    # @example Installing with Rails
+    #   rails generate graphql:detailed_trace # optional: --redis
+    #
     # @example Adding the sampler to your schema
     #   class MySchema < GraphQL::Schema
     #     # Add the sampler:
@@ -27,24 +43,48 @@ module GraphQL
     #   end
     #
     # @see Graphql::Dashboard GraphQL::Dashboard for viewing stored results
+    #
+    # @example Customizing debug output in traces
+    #   class CustomDetailedTrace < GraphQL::Tracing::DetailedTrace
+    #     def inspect_object(object)
+    #       if object.is_a?(SomeThing)
+    #         # handle it specially ...
+    #       else
+    #         super
+    #        end
+    #     end
+    #   end
+    #
+    # @example disabling debug annotations completely
+    #    use DetailedTrace, debug: false, ...
+    #
+    # @example disabling debug annotations for one query
+    #    MySchema.execute(query_str, context: { detailed_trace_debug: false })
+    #
     class DetailedTrace
       # @param redis [Redis] If provided, profiles will be stored in Redis for later review
       # @param limit [Integer] A maximum number of profiles to store
-      def self.use(schema, trace_mode: :profile_sample, memory: false, redis: nil, limit: nil)
+      # @param debug [Boolean] if `false`, it won't create `debug` annotations in Perfetto traces (reduces overhead)
+      # @param model_class [Class<ActiveRecord::Base>] Overrides {ActiveRecordBackend::GraphqlDetailedTrace} if present
+      def self.use(schema, trace_mode: :profile_sample, memory: false, debug: debug?, redis: nil, limit: nil, model_class: nil)
         storage = if redis
           RedisBackend.new(redis: redis, limit: limit)
         elsif memory
           MemoryBackend.new(limit: limit)
+        elsif defined?(ActiveRecord)
+          ActiveRecordBackend.new(limit: limit, model_class: model_class)
         else
-          raise ArgumentError, "Pass `redis: ...` to store traces in Redis for later review"
+          raise ArgumentError, "To store traces, install ActiveRecord or provide `redis: ...`"
         end
-        schema.detailed_trace = self.new(storage: storage, trace_mode: trace_mode)
+        detailed_trace = self.new(storage: storage, trace_mode: trace_mode, debug: debug)
+        schema.detailed_trace = detailed_trace
         schema.trace_with(PerfettoTrace, mode: trace_mode, save_profile: true)
       end
 
-      def initialize(storage:, trace_mode:)
+      def initialize(storage:, trace_mode:, debug:)
         @storage = storage
         @trace_mode = trace_mode
+        @debug = debug
       end
 
       # @return [Symbol] The trace mode to use when {Schema.detailed_trace?} returns `true`
@@ -55,6 +95,11 @@ module GraphQL
         @storage.save_trace(operation_name, duration_ms, begin_ms, trace_data)
       end
 
+      # @return [Boolean]
+      def debug?
+        @debug
+      end
+
       # @param last [Integer]
       # @param before [Integer] Timestamp in milliseconds since epoch
       # @return [Enumerable<StoredTrace>]
@@ -77,6 +122,24 @@ module GraphQL
         @storage.delete_all_traces
       end
 
+      def inspect_object(object)
+        self.class.inspect_object(object)
+      end
+
+      def self.inspect_object(object)
+        if defined?(ActiveRecord::Relation) && object.is_a?(ActiveRecord::Relation)
+          "#{object.class}, .to_sql=#{object.to_sql.inspect}"
+        else
+          object.inspect
+        end
+      end
+
+      # Default debug setting
+      # @return [true]
+      def self.debug?
+        true
+      end
+
       class StoredTrace
         def initialize(id:, operation_name:, duration_ms:, begin_ms:, trace_data:)
           @id = id

data/lib/graphql/tracing/null_trace.rb

@@ -4,6 +4,6 @@ require "graphql/tracing/trace"
 
 module GraphQL
   module Tracing
-    NullTrace = Trace.new
+    NullTrace = Trace.new.freeze
   end
 end

data/lib/graphql/tracing/perfetto_trace.rb

@@ -60,11 +60,52 @@ module GraphQL
       DA_FETCH_KEYS_IID = 13
       DA_STR_VAL_NIL_IID = 14
 
+      REVERSE_DEBUG_NAME_LOOKUP = {
+        DA_OBJECT_IID => "object",
+        DA_RESULT_IID => "result",
+        DA_ARGUMENTS_IID => "arguments",
+        DA_FETCH_KEYS_IID => "fetch keys",
+      }
+
+      DEBUG_INSPECT_CATEGORY_IIDS = [15]
+      DA_DEBUG_INSPECT_CLASS_IID = 16
+      DEBUG_INSPECT_EVENT_NAME_IID = 17
+      DA_DEBUG_INSPECT_FOR_IID = 18
+
       # @param active_support_notifications_pattern [String, RegExp, false] A filter for `ActiveSupport::Notifications`, if it's present. Or `false` to skip subscribing.
       def initialize(active_support_notifications_pattern: nil, save_profile: false, **_rest)
         super
         @active_support_notifications_pattern = active_support_notifications_pattern
         @save_profile = save_profile
+
+        query = if @multiplex
+          @multiplex.queries.first
+        else
+          @query # could still be nil in some initializations
+        end
+
+        @detailed_trace = query&.schema&.detailed_trace || DetailedTrace
+        @create_debug_annotations = if (ctx = query&.context).nil? || (ctx_debug = ctx[:detailed_trace_debug]).nil?
+          @detailed_trace.debug?
+        else
+          ctx_debug
+        end
+
+        @arguments_filter = if (ctx = query&.context) && (dtf = ctx[:detailed_trace_filter])
+          dtf
+        elsif defined?(ActiveSupport::ParameterFilter)
+          fp = if defined?(Rails) && Rails.application && (app_config = Rails.application.config.filter_parameters).present? && !app_config.empty?
+            app_config
+          elsif ActiveSupport.respond_to?(:filter_parameters)
+            ActiveSupport.filter_parameters
+          else
+            EmptyObjects::EMPTY_ARRAY
+          end
+          ActiveSupport::ParameterFilter.new(fp, mask: ArgumentsFilter::FILTERED)
+        else
+          ArgumentsFilter.new
+        end
+
         Fiber[:graphql_flow_stack] = nil
         @sequence_id = object_id
         @pid = Process.pid
@@ -110,6 +151,10 @@ module GraphQL
         @objects_counter_id = :objects_counter.object_id
         @fibers_counter_id = :fibers_counter.object_id
         @fields_counter_id = :fields_counter.object_id
+        @counts_objects = [@objects_counter_id]
+        @counts_objects_and_fields = [@objects_counter_id, @fields_counter_id]
+        @counts_fibers = [@fibers_counter_id]
+        @counts_fibers_and_objects = [@fibers_counter_id, @objects_counter_id]
         @begin_validate = nil
         @begin_time = nil
         @packets = []
@@ -132,16 +177,19 @@ module GraphQL
               EventCategory.new(name: "ActiveSupport::Notifications", iid: ACTIVE_SUPPORT_NOTIFICATIONS_CATEGORY_IIDS.first),
               EventCategory.new(name: "Authorized", iid: AUTHORIZED_CATEGORY_IIDS.first),
               EventCategory.new(name: "Resolve Type", iid: RESOLVE_TYPE_CATEGORY_IIDS.first),
+              EventCategory.new(name: "Debug Inspect", iid: DEBUG_INSPECT_CATEGORY_IIDS.first),
             ],
             debug_annotation_names: [
-              DebugAnnotationName.new(name: "object", iid: DA_OBJECT_IID),
-              DebugAnnotationName.new(name: "arguments", iid: DA_ARGUMENTS_IID),
-              DebugAnnotationName.new(name: "result", iid: DA_RESULT_IID),
-              DebugAnnotationName.new(name: "fetch keys", iid: DA_FETCH_KEYS_IID),
+              *REVERSE_DEBUG_NAME_LOOKUP.map { |(iid, name)| DebugAnnotationName.new(name: name, iid: iid) },
+              DebugAnnotationName.new(name: "inspect instance of", iid: DA_DEBUG_INSPECT_CLASS_IID),
+              DebugAnnotationName.new(name: "inspecting for", iid: DA_DEBUG_INSPECT_FOR_IID)
             ],
             debug_annotation_string_values: [
               InternedString.new(str: "(nil)", iid: DA_STR_VAL_NIL_IID),
             ],
+            event_names: [
+              EventName.new(name: "#{(@detailed_trace.is_a?(Class) ? @detailed_trace : @detailed_trace.class).name}#inspect_object", iid: DEBUG_INSPECT_EVENT_NAME_IID)
+            ],
           ),
           trusted_packet_sequence_id: @sequence_id,
           sequence_flags: 2,
@@ -180,11 +228,9 @@ module GraphQL
         @packets << trace_packet(
           type: TrackEvent::Type::TYPE_SLICE_BEGIN,
           track_uuid: fid,
-          name: "Multiplex",
-          debug_annotations: [
-            payload_to_debug("query_string", multiplex.queries.map(&:sanitized_query_string).join("\n\n"))
-          ]
-        )
+          name: "Multiplex"
+        ) { [ payload_to_debug("query_string", multiplex.queries.map(&:sanitized_query_string).join("\n\n")) ] }
+
         result = super
 
         @packets << trace_packet(
@@ -207,9 +253,9 @@ module GraphQL
         packet = trace_packet(
           type: TrackEvent::Type::TYPE_SLICE_BEGIN,
           track_uuid: fid,
-          name: query.context.current_path.join("."),
+          name: query.context.current_path&.join(".") || field.path,
           category_iids: FIELD_EXECUTE_CATEGORY_IIDS,
-          extra_counter_track_uuids: [@objects_counter_id],
+          extra_counter_track_uuids: @counts_objects,
           extra_counter_values: [count_allocations],
         )
         @packets << packet
@@ -218,19 +264,23 @@ module GraphQL
       end
 
       def end_execute_field(field, object, arguments, query, app_result)
+        end_ts = ts
         start_field = fiber_flow_stack.pop
-        start_field.track_event = dup_with(start_field.track_event, {
-          debug_annotations: [
-            payload_to_debug(nil, object.object, iid: DA_OBJECT_IID, intern_value: true),
-            payload_to_debug(nil, arguments, iid: DA_ARGUMENTS_IID),
-            payload_to_debug(nil, app_result, iid: DA_RESULT_IID, intern_value: true)
-          ]
-        })
+        if @create_debug_annotations
+          start_field.track_event = dup_with(start_field.track_event,{
+            debug_annotations: [
+                payload_to_debug(nil, (object.is_a?(GraphQL::Schema::Object) ? object.object : object), iid: DA_OBJECT_IID, intern_value: true),
+                payload_to_debug(nil, arguments, iid: DA_ARGUMENTS_IID),
+                payload_to_debug(nil, app_result, iid: DA_RESULT_IID, intern_value: true)
+              ]
+            })
+        end
 
         @packets << trace_packet(
+          timestamp: end_ts,
           type: TrackEvent::Type::TYPE_SLICE_END,
           track_uuid: fid,
-          extra_counter_track_uuids: [@objects_counter_id, @fields_counter_id],
+          extra_counter_track_uuids: @counts_objects_and_fields,
           extra_counter_values: [count_allocations, count_fields],
         )
         super
@@ -240,22 +290,24 @@ module GraphQL
         @packets << trace_packet(
           type: TrackEvent::Type::TYPE_SLICE_BEGIN,
           track_uuid: fid,
-          extra_counter_track_uuids: [@objects_counter_id],
+          extra_counter_track_uuids: @counts_objects,
           extra_counter_values: [count_allocations],
-          name: "Analysis",
-          debug_annotations: [
-            payload_to_debug("analyzers_count", analyzers.size),
-            payload_to_debug("analyzers", analyzers),
-          ]
-        )
+          name: "Analysis") {
+            [
+              payload_to_debug("analyzers_count", analyzers.size),
+              payload_to_debug("analyzers", analyzers),
+            ]
+          }
         super
       end
 
       def end_analyze_multiplex(m, analyzers)
+        end_ts = ts
         @packets << trace_packet(
+          timestamp: end_ts,
           type: TrackEvent::Type::TYPE_SLICE_END,
           track_uuid: fid,
-          extra_counter_track_uuids: [@objects_counter_id],
+          extra_counter_track_uuids: @counts_objects,
           extra_counter_values: [count_allocations],
         )
         super
@@ -265,50 +317,57 @@ module GraphQL
         @packets << trace_packet(
           type: TrackEvent::Type::TYPE_SLICE_BEGIN,
           track_uuid: fid,
-          extra_counter_track_uuids: [@objects_counter_id],
+          extra_counter_track_uuids: @counts_objects,
           extra_counter_values: [count_allocations],
           name: "Parse"
         )
         result = super
+        end_ts = ts
         @packets << trace_packet(
+          timestamp: end_ts,
           type: TrackEvent::Type::TYPE_SLICE_END,
           track_uuid: fid,
-          extra_counter_track_uuids: [@objects_counter_id],
+          extra_counter_track_uuids: @counts_objects,
           extra_counter_values: [count_allocations],
         )
         result
       end
 
       def begin_validate(query, validate)
-        @packets << @begin_validate = trace_packet(
+        @begin_validate = trace_packet(
           type: TrackEvent::Type::TYPE_SLICE_BEGIN,
           track_uuid: fid,
-          extra_counter_track_uuids: [@objects_counter_id],
+          extra_counter_track_uuids: @counts_objects,
           extra_counter_values: [count_allocations],
-          name: "Validate",
-          debug_annotations: [
-            payload_to_debug("validate?", validate),
-          ]
-        )
+          name: "Validate") {
+            [payload_to_debug("validate?", validate)]
+          }
+
+        @packets << @begin_validate
         super
       end
 
       def end_validate(query, validate, validation_errors)
+        end_ts = ts
         @packets << trace_packet(
+          timestamp: end_ts,
           type: TrackEvent::Type::TYPE_SLICE_END,
           track_uuid: fid,
-          extra_counter_track_uuids: [@objects_counter_id],
+          extra_counter_track_uuids: @counts_objects,
           extra_counter_values: [count_allocations],
         )
-        @begin_validate.track_event = dup_with(
-          @begin_validate.track_event,
-          {
-            debug_annotations: [
-              @begin_validate.track_event.debug_annotations.first,
-              payload_to_debug("valid?", validation_errors.empty?)
-            ]
-          }
-        )
+
+        if @create_debug_annotations
+          new_bv_track_event = dup_with(
+            @begin_validate.track_event, {
+              debug_annotations: [
+                @begin_validate.track_event.debug_annotations.first,
+                payload_to_debug("valid?", validation_errors.empty?)
+              ]
+            }
+          )
+          @begin_validate.track_event = new_bv_track_event
+        end
         super
       end
 
@@ -318,7 +377,7 @@ module GraphQL
           track_uuid: fid,
           name: "Create Execution Fiber",
           category_iids: DATALOADER_CATEGORY_IIDS,
-          extra_counter_track_uuids: [@fibers_counter_id, @objects_counter_id],
+          extra_counter_track_uuids: @counts_fibers_and_objects,
           extra_counter_values: [count_fibers(1), count_allocations]
         )
         @packets << track_descriptor_packet(@did, fid, "Exec Fiber ##{fid}")
@@ -331,7 +390,7 @@ module GraphQL
           track_uuid: fid,
           name: "Create Source Fiber",
           category_iids: DATALOADER_CATEGORY_IIDS,
-          extra_counter_track_uuids: [@fibers_counter_id, @objects_counter_id],
+          extra_counter_track_uuids: @counts_fibers_and_objects,
           extra_counter_values: [count_fibers(1), count_allocations]
         )
         @packets << track_descriptor_packet(@did, fid, "Source Fiber ##{fid}")
@@ -385,7 +444,7 @@ module GraphQL
           track_uuid: fid,
           name: "Fiber Exit",
           category_iids: DATALOADER_CATEGORY_IIDS,
-          extra_counter_track_uuids: [@fibers_counter_id],
+          extra_counter_track_uuids: @counts_fibers,
           extra_counter_values: [count_fibers(-1)],
         )
         super
@@ -415,31 +474,34 @@ module GraphQL
         fds = @flow_ids[source]
         fds_copy = fds.dup
         fds.clear
+
         packet = trace_packet(
           type: TrackEvent::Type::TYPE_SLICE_BEGIN,
           track_uuid: fid,
           name_iid: @source_name_iids[source.class],
           category_iids: DATALOADER_CATEGORY_IIDS,
           flow_ids: fds_copy,
-          extra_counter_track_uuids: [@objects_counter_id],
-          extra_counter_values: [count_allocations],
-          debug_annotations: [
-            payload_to_debug(nil, source.pending.values, iid: DA_FETCH_KEYS_IID, intern_value: true),
-            *(source.instance_variables - [:@pending, :@fetching, :@results, :@dataloader]).map { |iv|
-              payload_to_debug(iv.to_s, source.instance_variable_get(iv), intern_value: true)
-            }
-          ]
-        )
+          extra_counter_track_uuids: @counts_objects,
+          extra_counter_values: [count_allocations]) {
+            [
+              payload_to_debug(nil, source.pending.values, iid: DA_FETCH_KEYS_IID, intern_value: true),
+              *(source.instance_variables - [:@pending, :@fetching, :@results, :@dataloader]).map { |iv|
+                payload_to_debug(iv.to_s, source.instance_variable_get(iv), intern_value: true)
+              }
+            ]
+          }
         @packets << packet
         fiber_flow_stack << packet
         super
       end
 
       def end_dataloader_source(source)
+        end_ts = ts
         @packets << trace_packet(
+          timestamp: end_ts,
           type: TrackEvent::Type::TYPE_SLICE_END,
           track_uuid: fid,
-          extra_counter_track_uuids: [@objects_counter_id],
+          extra_counter_track_uuids: @counts_objects,
           extra_counter_values: [count_allocations],
         )
         fiber_flow_stack.pop
@@ -451,7 +513,7 @@ module GraphQL
           type: TrackEvent::Type::TYPE_SLICE_BEGIN,
           track_uuid: fid,
           category_iids: AUTHORIZED_CATEGORY_IIDS,
-          extra_counter_track_uuids: [@objects_counter_id],
+          extra_counter_track_uuids: @counts_objects,
           extra_counter_values: [count_allocations],
           name_iid: @auth_name_iids[type],
         )
@@ -461,14 +523,18 @@ module GraphQL
       end
 
       def end_authorized(type, obj, ctx, is_authorized)
+        end_ts = ts
         @packets << trace_packet(
+          timestamp: end_ts,
           type: TrackEvent::Type::TYPE_SLICE_END,
           track_uuid: fid,
-          extra_counter_track_uuids: [@objects_counter_id],
+          extra_counter_track_uuids: @counts_objects,
           extra_counter_values: [count_allocations],
         )
         beg_auth = fiber_flow_stack.pop
-        beg_auth.track_event = dup_with(beg_auth.track_event, { debug_annotations: [payload_to_debug("authorized?", is_authorized)] })
+        if @create_debug_annotations
+          beg_auth.track_event = dup_with(beg_auth.track_event, { debug_annotations: [payload_to_debug("authorized?", is_authorized)] })
+        end
         super
       end
 
@@ -477,7 +543,7 @@ module GraphQL
           type: TrackEvent::Type::TYPE_SLICE_BEGIN,
           track_uuid: fid,
           category_iids: RESOLVE_TYPE_CATEGORY_IIDS,
-          extra_counter_track_uuids: [@objects_counter_id],
+          extra_counter_track_uuids: @counts_objects,
           extra_counter_values: [count_allocations],
           name_iid: @resolve_type_name_iids[type],
         )
@@ -487,14 +553,18 @@ module GraphQL
       end
 
       def end_resolve_type(type, value, context, resolved_type)
+        end_ts = ts
         @packets << trace_packet(
+          timestamp: end_ts,
           type: TrackEvent::Type::TYPE_SLICE_END,
           track_uuid: fid,
-          extra_counter_track_uuids: [@objects_counter_id],
+          extra_counter_track_uuids: @counts_objects,
           extra_counter_values: [count_allocations],
         )
         rt_begin = fiber_flow_stack.pop
-        rt_begin.track_event = dup_with(rt_begin.track_event, { debug_annotations: [payload_to_debug("resolved_type", resolved_type, intern_value: true)] })
+        if @create_debug_annotations
+          rt_begin.track_event = dup_with(rt_begin.track_event, { debug_annotations: [payload_to_debug("resolved_type", resolved_type, intern_value: true)] })
+        end
         super
       end
 
@@ -535,6 +605,22 @@ module GraphQL
         Fiber.current.object_id
       end
 
+      class ArgumentsFilter
+        # From Rails defaults
+        # https://github.com/rails/rails/blob/main/railties/lib/rails/generators/rails/app/templates/config/initializers/filter_parameter_logging.rb.tt#L6-L8
+        SENSITIVE_KEY = /passw|token|crypt|email|_key|salt|certificate|secret|ssn|cvv|cvc|otp/i
+        FILTERED = "[FILTERED]"
+
+        def filter_param(key, value)
+          if (key.is_a?(String) && SENSITIVE_KEY.match?(key)) ||
+                  (key.is_a?(Symbol) && SENSITIVE_KEY.match?(key.name))
+            FILTERED
+          else
+            value
+          end
+        end
+      end
+
       def debug_annotation(iid, value_key, value)
         if iid
           DebugAnnotation.new(name_iid: iid, value_key => value)
@@ -546,7 +632,6 @@ module GraphQL
       def payload_to_debug(k, v, iid: nil, intern_value: false)
         if iid.nil?
           iid = @interned_da_name_ids[k]
-          k = nil
         end
         case v
         when String
@@ -578,15 +663,56 @@ module GraphQL
         when Symbol
           debug_annotation(iid, :string_value, v.inspect)
         when Array
-          debug_annotation(iid, :array_values, v.map { |v2| payload_to_debug(nil, v2, intern_value: intern_value) }.compact)
+          debug_annotation(iid, :array_values, v.each_with_index.map { |v2, idx| payload_to_debug((k ? "#{k}.#{idx}" : String(idx)), v2, intern_value: intern_value) }.compact)
         when Hash
-          debug_annotation(iid, :dict_entries, v.map { |k2, v2| payload_to_debug(k2, v2, intern_value: intern_value) }.compact)
+          debug_v = v.map { |k2, v2|
+            debug_k = case k2
+            when String
+              k2
+            when Symbol
+              k2.name
+            else
+              String(k2)
+            end
+            filtered_v2 = @arguments_filter.filter_param(debug_k, v2)
+            payload_to_debug(debug_k, filtered_v2, intern_value: intern_value)
+          }
+          debug_v.compact!
+          debug_annotation(iid, :dict_entries, debug_v)
+        when GraphQL::Schema::InputObject
+          payload_to_debug(k, v.to_h, iid: iid, intern_value: intern_value)
         else
-          debug_str = if defined?(ActiveRecord::Relation) && v.is_a?(ActiveRecord::Relation)
-            "#{v.class}, .to_sql=#{v.to_sql.inspect}"
-          else
-            v.inspect
+          class_name_iid = @interned_da_string_values[(v.class.name || "(anonymous)")]
+          da = [
+            debug_annotation(DA_DEBUG_INSPECT_CLASS_IID, :string_value_iid, class_name_iid),
+          ]
+          if k
+            k_str_value_iid = @interned_da_string_values[k]
+            da << debug_annotation(DA_DEBUG_INSPECT_FOR_IID, :string_value_iid, k_str_value_iid)
+          elsif iid
+            k = REVERSE_DEBUG_NAME_LOOKUP[iid] || @interned_da_name_ids.key(iid)
+            if k.nil?
+              da << debug_annotation(DA_DEBUG_INSPECT_FOR_IID, :string_value_iid, DA_STR_VAL_NIL_IID)
+            else
+              k_str_value_iid = @interned_da_string_values[k]
+              da << debug_annotation(DA_DEBUG_INSPECT_FOR_IID, :string_value_iid, k_str_value_iid)
+            end
           end
+
+          @packets << trace_packet(
+            type: TrackEvent::Type::TYPE_SLICE_BEGIN,
+            track_uuid: fid,
+            name_iid: DEBUG_INSPECT_EVENT_NAME_IID,
+            category_iids: DEBUG_INSPECT_CATEGORY_IIDS,
+            extra_counter_track_uuids: @counts_objects,
+            extra_counter_values: [count_allocations],
+            debug_annotations: da,
+          )
+          debug_str = @detailed_trace.inspect_object(v)
+          @packets << trace_packet(
+            type: TrackEvent::Type::TYPE_SLICE_END,
+            track_uuid: fid,
+          )
           if intern_value
             str_iid = @interned_da_string_values[debug_str]
             debug_annotation(iid, :string_value_iid, str_iid)
@@ -622,10 +748,14 @@ module GraphQL
         Fiber[:graphql_flow_stack] ||= []
       end
 
-      def trace_packet(event_attrs)
+      def trace_packet(timestamp: ts, **event_attrs)
+        if @create_debug_annotations && block_given?
+          event_attrs[:debug_annotations] = yield
+        end
+        track_event = TrackEvent.new(event_attrs)
         TracePacket.new(
-          timestamp: ts,
-          track_event: TrackEvent.new(event_attrs),
+          timestamp: timestamp,
+          track_event: track_event,
           trusted_packet_sequence_id: @sequence_id,
           sequence_flags: 2,
           interned_data: new_interned_data
@@ -690,9 +820,9 @@ module GraphQL
 
       def subscribe_to_active_support_notifications(pattern)
         @as_subscriber = ActiveSupport::Notifications.monotonic_subscribe(pattern) do |name, start, finish, id, payload|
-          metadata = payload.map { |k, v| payload_to_debug(k, v, intern_value: true) }
-          metadata.compact!
-          te = if metadata.empty?
+          metadata = @create_debug_annotations ? payload.map { |k, v| payload_to_debug(String(k), v, intern_value: true) } : nil
+          metadata&.compact!
+          te = if metadata.nil? || metadata.empty?
             TrackEvent.new(
               type: TrackEvent::Type::TYPE_SLICE_BEGIN,
               track_uuid: fid,
@@ -721,7 +851,7 @@ module GraphQL
               type: TrackEvent::Type::TYPE_SLICE_END,
               track_uuid: fid,
               name: name,
-              extra_counter_track_uuids: [@objects_counter_id],
+              extra_counter_track_uuids: @counts_objects,
               extra_counter_values: [count_allocations]
             ),
             trusted_packet_sequence_id: @sequence_id,

data/lib/graphql/tracing/sentry_trace.rb

@@ -41,7 +41,9 @@ module GraphQL
                 if query.selected_operation_name
                   span.set_data('graphql.operation.name', query.selected_operation_name)
                 end
-                span.set_data('graphql.operation.type', query.selected_operation.operation_type)
+                if query.selected_operation
+                  span.set_data('graphql.operation.type', query.selected_operation.operation_type)
+                end
               end
             end
 

data/lib/graphql/tracing/trace.rb

@@ -98,6 +98,12 @@ module GraphQL
         yield
       end
 
+      def objects(type, object, context)
+      end
+
+      def object_loaded(argument_definition, object, context)
+      end
+
       # A call to `.authorized?` is starting
       # @param type [Class<GraphQL::Schema::Object>]
       # @param object [Object]