graphql 1.9.0.pre4 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1e4a203b440499962202563a6c4c834e14881c5c
-  data.tar.gz: 76c0395eb02e5bea7652869c9c665df092cd54ac
+  metadata.gz: fb79bf185d3d89d53f50ad5f0ae1cc93e3480acb
+  data.tar.gz: 46c04d4e296ea2b3b520d6df50f82d76da5ec641
 SHA512:
-  metadata.gz: b689670d32855deefb65dacf51f1ea3e37123e5934b2eb8ca43070ad3ee562405f99ce3c420faee173fa77badde9c11089975238c0de1782a5692ebab1319808
-  data.tar.gz: 3b48af200dccfdd63783f980e8c808f52823c46bb711d1b7f2c63867ae819e1e458e0dc796034ab703d002bac33723a30816b1e2ad17d6536709523b8f07fd03
+  metadata.gz: 78e070c3df4abd9e2d649ba0e5f1e7fdcef9b0241572a30bf233d516fa28b7eee9afa0fd2d650db835556dff87f4eddb344aefce8825019569aa7e55ff28f780
+  data.tar.gz: eb138cb5d2274c815ea42ec2eff4371cf34023ad817e4009302cb6de6da7deea213ccfaa2169d86a6a8c2b684f9e4fc8bd0780060163a764960d22af1a48bb25

data/lib/graphql.rb

@@ -89,6 +89,7 @@ require "graphql/runtime_type_error"
 require "graphql/invalid_null_error"
 require "graphql/invalid_name_error"
 require "graphql/unresolved_type_error"
+require "graphql/integer_encoding_error"
 require "graphql/string_encoding_error"
 require "graphql/query"
 require "graphql/internal_representation"

data/lib/graphql/execution/execute.rb

@@ -281,20 +281,22 @@ module GraphQL
               )
             when GraphQL::TypeKinds::UNION, GraphQL::TypeKinds::INTERFACE
               query = field_ctx.query
-              resolved_type = field_type.resolve_type(value, field_ctx)
-              possible_types = query.possible_types(field_type)
-
-              if !possible_types.include?(resolved_type)
-                parent_type = field_ctx.irep_node.owner_type
-                type_error = GraphQL::UnresolvedTypeError.new(value, field_defn, parent_type, resolved_type, possible_types)
-                field_ctx.schema.type_error(type_error, field_ctx)
-                PROPAGATE_NULL
-              else
-                resolve_value(
-                  value,
-                  resolved_type,
-                  field_ctx,
-                )
+              resolved_type_or_lazy = field_type.resolve_type(value, field_ctx)
+              query.schema.after_lazy(resolved_type_or_lazy) do |resolved_type|
+                possible_types = query.possible_types(field_type)
+
+                if !possible_types.include?(resolved_type)
+                  parent_type = field_ctx.irep_node.owner_type
+                  type_error = GraphQL::UnresolvedTypeError.new(value, field_defn, parent_type, resolved_type, possible_types)
+                  field_ctx.schema.type_error(type_error, field_ctx)
+                  PROPAGATE_NULL
+                else
+                  resolve_value(
+                    value,
+                    resolved_type,
+                    field_ctx,
+                  )
+                end
               end
             else
               raise("Unknown type kind: #{field_type.kind}")

data/lib/graphql/execution/interpreter/runtime.rb

@@ -270,18 +270,20 @@ module GraphQL
             write_in_response(path, r)
             r
           when "UNION", "INTERFACE"
-            resolved_type = query.resolve_type(type, value)
-            possible_types = query.possible_types(type)
-
-            if !possible_types.include?(resolved_type)
-              parent_type = field.owner
-              type_error = GraphQL::UnresolvedTypeError.new(value, field, parent_type, resolved_type, possible_types)
-              schema.type_error(type_error, context)
-              write_in_response(path, nil)
-              nil
-            else
-              resolved_type = resolved_type.metadata[:type_class]
-              continue_field(path, value, field, resolved_type, ast_node, next_selections, is_non_null)
+            resolved_type_or_lazy = query.resolve_type(type, value)
+            after_lazy(resolved_type_or_lazy, path: path, field: field) do |resolved_type|
+              possible_types = query.possible_types(type)
+
+              if !possible_types.include?(resolved_type)
+                parent_type = field.owner
+                type_error = GraphQL::UnresolvedTypeError.new(value, field, parent_type, resolved_type, possible_types)
+                schema.type_error(type_error, context)
+                write_in_response(path, nil)
+                nil
+              else
+                resolved_type = resolved_type.metadata[:type_class]
+                continue_field(path, value, field, resolved_type, ast_node, next_selections, is_non_null)
+              end
             end
           when "OBJECT"
             object_proxy = begin

data/lib/graphql/integer_encoding_error.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+module GraphQL
+  class IntegerEncodingError < GraphQL::RuntimeTypeError
+    # The value which couldn't be encoded
+    attr_reader :integer_value
+
+    def initialize(value)
+      @integer_value = value
+      super('Integer out of bounds.')
+    end
+  end
+end

data/lib/graphql/schema.rb

@@ -509,17 +509,20 @@ module GraphQL
         yield(type, object, ctx)
       end
 
-      if type_result.respond_to?(:graphql_definition)
-        type_result = type_result.graphql_definition
-      end
-
       if type_result.nil?
         nil
-      elsif !type_result.is_a?(GraphQL::BaseType)
-        type_str = "#{type_result} (#{type_result.class.name})"
-        raise "resolve_type(#{object}) returned #{type_str}, but it should return a GraphQL type"
       else
-        type_result
+        after_lazy(type_result) do |resolved_type_result|
+          if resolved_type_result.respond_to?(:graphql_definition)
+            resolved_type_result = resolved_type_result.graphql_definition
+          end
+          if !resolved_type_result.is_a?(GraphQL::BaseType)
+            type_str = "#{resolved_type_result} (#{resolved_type_result.class.name})"
+            raise "resolve_type(#{object}) returned #{type_str}, but it should return a GraphQL type"
+          else
+            resolved_type_result
+          end
+        end
       end
     end
 

data/lib/graphql/schema/default_type_error.rb

@@ -6,7 +6,7 @@ module GraphQL
         case type_error
         when GraphQL::InvalidNullError
           ctx.errors << type_error
-        when GraphQL::UnresolvedTypeError, GraphQL::StringEncodingError
+        when GraphQL::UnresolvedTypeError, GraphQL::StringEncodingError, GraphQL::IntegerEncodingError
           raise type_error
         end
       end

data/lib/graphql/schema/member/instrumentation.rb

@@ -91,7 +91,7 @@ module GraphQL
                   # For lists with nil, we need another nil check here
                   nil
                 else
-                  concrete_type = case @inner_return_type
+                  concrete_type_or_lazy = case @inner_return_type
                   when GraphQL::UnionType, GraphQL::InterfaceType
                     ctx.query.resolve_type(@inner_return_type, inner_obj)
                   when GraphQL::ObjectType
@@ -100,12 +100,15 @@ module GraphQL
                     raise "unexpected proxying type #{@inner_return_type} for #{inner_obj} at #{ctx.owner_type}.#{ctx.field.name}"
                   end
 
-                  if concrete_type && (object_class = concrete_type.metadata[:type_class])
-                    # use the query-level context here, since it won't be field-specific anyways
-                    query_ctx = ctx.query.context
-                    object_class.authorized_new(inner_obj, query_ctx)
-                  else
-                    inner_obj
+                  # .resolve_type may have returned a lazy
+                  ctx.schema.after_lazy(concrete_type_or_lazy) do |concrete_type|
+                    if concrete_type && (object_class = concrete_type.metadata[:type_class])
+                      # use the query-level context here, since it won't be field-specific anyways
+                      query_ctx = ctx.query.context
+                      object_class.authorized_new(inner_obj, query_ctx)
+                    else
+                      inner_obj
+                    end
                   end
                 end
               end

data/lib/graphql/schema/resolver.rb

@@ -200,13 +200,13 @@ module GraphQL
         # See if any object can be found for this ID
         loaded_application_object = object_from_id(lookup_as_type, id, context)
         context.schema.after_lazy(loaded_application_object) do |application_object|
-          begin
-            if application_object.nil?
-              raise LoadApplicationObjectFailedError.new(argument: argument, id: id, object: application_object)
-            end
-            # Double-check that the located object is actually of this type
-            # (Don't want to allow arbitrary access to objects this way)
-            application_object_type = context.schema.resolve_type(lookup_as_type, application_object, context)
+          if application_object.nil?
+            raise LoadApplicationObjectFailedError.new(argument: argument, id: id, object: application_object)
+          end
+          # Double-check that the located object is actually of this type
+          # (Don't want to allow arbitrary access to objects this way)
+          resolved_application_object_type = context.schema.resolve_type(lookup_as_type, application_object, context)
+          context.schema.after_lazy(resolved_application_object_type) do |application_object_type|
             possible_object_types = context.schema.possible_types(lookup_as_type)
             if !possible_object_types.include?(application_object_type)
               raise LoadApplicationObjectFailedError.new(argument: argument, id: id, object: application_object)
@@ -230,11 +230,11 @@ module GraphQL
                 application_object
               end
             end
-          rescue LoadApplicationObjectFailedError => err
-            # pass it to a handler
-            load_application_object_failed(err)
           end
         end
+      rescue LoadApplicationObjectFailedError => err
+        # pass it to a handler
+        load_application_object_failed(err)
       end
 
       def load_application_object_failed(err)

data/lib/graphql/tracing.rb

@@ -27,7 +27,7 @@ module GraphQL
   #    tracer MyTracer # <= responds to .trace(key, data, &block)
   #  end
   #
-  # @example Adding a tracer to a query
+  # @example Adding a tracer to a single query
   #   MySchema.execute(query_str, context: { backtrace: true })
   #
   # Events:
@@ -45,6 +45,11 @@ module GraphQL
   # execute_field | `{ context: GraphQL::Query::Context::FieldResolutionContext?, field: GraphQL::Schema::Field?, path: Array<String, Integer>?}`
   # execute_field_lazy | `{ context: GraphQL::Query::Context::FieldResolutionContext?, field: GraphQL::Schema::Field?, path: Array<String, Integer>?}`
   #
+  # Note that `execute_field` and `execute_field_lazy` receive different data in different settings:
+  #
+  # - When using {GraphQL::Execution::Interpreter}, they receive `{field:, path:}`
+  # - Otherwise, they receive `{context: ...}`
+  #
   module Tracing
     # Objects may include traceable to gain a `.trace(...)` method.
     # The object must have a `@tracers` ivar of type `Array<<#trace(k, d, &b)>>`.

data/lib/graphql/types/float.rb

@@ -3,7 +3,7 @@
 module GraphQL
   module Types
     class Float < GraphQL::Schema::Scalar
-      description "Represents signed double-precision fractional values as specified by [IEEE 754](http://en.wikipedia.org/wiki/IEEE_floating_point)."
+      description "Represents signed double-precision fractional values as specified by [IEEE 754](https://en.wikipedia.org/wiki/IEEE_floating_point)."
 
       def self.coerce_input(value, _ctx)
         value.is_a?(Numeric) ? value.to_f : nil

data/lib/graphql/types/int.rb

@@ -5,12 +5,21 @@ module GraphQL
     class Int < GraphQL::Schema::Scalar
       description "Represents non-fractional signed whole numeric values. Int can represent values between -(2^31) and 2^31 - 1."
 
+      MIN = -(2**31)
+      MAX = (2**31) - 1
+
       def self.coerce_input(value, _ctx)
         value.is_a?(Numeric) ? value.to_i : nil
       end
 
-      def self.coerce_result(value, _ctx)
-        value.to_i
+      def self.coerce_result(value, ctx)
+        value = value.to_i
+        if value >= MIN && value <= MAX
+          value
+        else
+          err = GraphQL::IntegerEncodingError.new(value)
+          ctx.schema.type_error(err, ctx)
+        end
       end
 
       default_scalar true

data/lib/graphql/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module GraphQL
-  VERSION = "1.9.0.pre4"
+  VERSION = "1.9.0"
 end

data/readme.md

@@ -4,12 +4,12 @@
 [![Gem Version](https://badge.fury.io/rb/graphql.svg)](https://rubygems.org/gems/graphql)
 [![Code Climate](https://codeclimate.com/github/rmosolgo/graphql-ruby/badges/gpa.svg)](https://codeclimate.com/github/rmosolgo/graphql-ruby)
 [![Test Coverage](https://codeclimate.com/github/rmosolgo/graphql-ruby/badges/coverage.svg)](https://codeclimate.com/github/rmosolgo/graphql-ruby)
-[![built with love](https://cloud.githubusercontent.com/assets/2231765/6766607/d07992c6-cfc9-11e4-813f-d9240714dd50.png)](http://rmosolgo.github.io/react-badges/)
+[![built with love](https://cloud.githubusercontent.com/assets/2231765/6766607/d07992c6-cfc9-11e4-813f-d9240714dd50.png)](https://rmosolgo.github.io/react-badges/)
 
-A Ruby implementation of [GraphQL](http://graphql.org/).
+A Ruby implementation of [GraphQL](https://graphql.org/).
 
-- [Website](https://rmosolgo.github.io/graphql-ruby)
-- [API Documentation](http://www.rubydoc.info/gems/graphql)
+- [Website](https://graphql-ruby.org/)
+- [API Documentation](https://www.rubydoc.info/gems/graphql)
 - [Newsletter](https://tinyletter.com/graphql-ruby)
 
 ## Installation
@@ -33,11 +33,11 @@ $ rails generate graphql:install
 
 After this, you may need to run `bundle install` again, as by default graphiql-rails is added on installation.
 
-Or, see ["Getting Started"](https://rmosolgo.github.io/graphql-ruby/).
+Or, see ["Getting Started"](https://graphql-ruby.org/).
 
 ## Upgrade
 
-I also sell [GraphQL::Pro](http://graphql.pro) which provides several features on top of the GraphQL runtime, including [Pundit authorization](http://rmosolgo.github.io/graphql-ruby/authorization/pundit_integration), [CanCan authorization](http://rmosolgo.github.io/graphql-ruby/authorization/can_can_integration), [Pusher-based subscriptions](http://graphql-ruby.org/subscriptions/pusher_implementation) and [persisted queries](http://rmosolgo.github.io/graphql-ruby/operation_store/overview). Besides that, Pro customers get email support and an opportunity to support graphql-ruby's development!
+I also sell [GraphQL::Pro](https://graphql.pro) which provides several features on top of the GraphQL runtime, including [Pundit authorization](https://graphql-ruby.org/authorization/pundit_integration), [CanCan authorization](https://graphql-ruby.org/authorization/can_can_integration), [Pusher-based subscriptions](https://graphql-ruby.org/subscriptions/pusher_implementation) and [persisted queries](https://graphql-ruby.org/operation_store/overview). Besides that, Pro customers get email support and an opportunity to support graphql-ruby's development!
 
 ## Goals
 
@@ -49,4 +49,4 @@ I also sell [GraphQL::Pro](http://graphql.pro) which provides several features o
 
 - __Say hi & ask questions__ in the [#ruby channel on Slack](https://graphql-slack.herokuapp.com/) or [on Twitter](https://twitter.com/rmosolgo)!
 - __Report bugs__ by posting a description, full stack trace, and all relevant code in a  [GitHub issue](https://github.com/rmosolgo/graphql-ruby/issues).
-- __Start hacking__ with the [Development guide](http://graphql-ruby.org/development).
+- __Start hacking__ with the [Development guide](https://graphql-ruby.org/development).

data/spec/dummy/config/locales/en.yml

@@ -27,7 +27,7 @@
 #   'true': 'foo'
 #
 # To learn more, please read the Rails Internationalization guide
-# available at http://guides.rubyonrails.org/i18n.html.
+# available at https://guides.rubyonrails.org/i18n.html.
 
 en:
   hello: "Hello world"

data/spec/graphql/int_type_spec.rb

@@ -12,5 +12,24 @@ describe GraphQL::INT_TYPE do
       assert_nil GraphQL::INT_TYPE.coerce_isolated_input("55")
       assert_nil GraphQL::INT_TYPE.coerce_isolated_input(true)
     end
+
+    describe "handling boundaries" do
+      let(:context) { GraphQL::Query.new(Dummy::Schema, "{ __typename }").context }
+
+      it "accepts result values in bounds" do
+        assert_equal 0, GraphQL::INT_TYPE.coerce_result(0, context)
+        assert_equal (2**31) - 1, GraphQL::INT_TYPE.coerce_result((2**31) - 1, context)
+        assert_equal -(2**31), GraphQL::INT_TYPE.coerce_result(-(2**31), context)
+      end
+
+      it "replaces values, if configured to do so" do
+        assert_equal Dummy::Schema::MAGIC_INT_COERCE_VALUE, GraphQL::INT_TYPE.coerce_result(99**99, context)
+      end
+
+      it "raises on values out of bounds" do
+        assert_raises(GraphQL::IntegerEncodingError) { GraphQL::INT_TYPE.coerce_result(2**31, context) }
+        assert_raises(GraphQL::IntegerEncodingError) { GraphQL::INT_TYPE.coerce_result(-(2**31 + 1), context) }
+      end
+    end
   end
 end

data/spec/graphql/language/document_from_schema_definition_spec.rb

@@ -433,7 +433,7 @@ describe GraphQL::Language::DocumentFromSchemaDefinition do
         }
 
         # Represents signed double-precision fractional values as specified by [IEEE
-        # 754](http://en.wikipedia.org/wiki/IEEE_floating_point).
+        # 754](https://en.wikipedia.org/wiki/IEEE_floating_point).
         scalar Float
 
         # Represents a unique identifier that is Base64 obfuscated. It is often used to
@@ -698,7 +698,7 @@ describe GraphQL::Language::DocumentFromSchemaDefinition do
         }
 
         # Represents signed double-precision fractional values as specified by [IEEE
-        # 754](http://en.wikipedia.org/wiki/IEEE_floating_point).
+        # 754](https://en.wikipedia.org/wiki/IEEE_floating_point).
         scalar Float
 
         # Represents a unique identifier that is Base64 obfuscated. It is often used to

data/spec/support/dummy/schema.rb

@@ -473,6 +473,18 @@ module Dummy
     def self.resolve_type(type, obj, ctx)
       Schema.types[obj.class.name.split("::").last]
     end
+
+    # This is used to confirm that the hook is called:
+    MAGIC_INT_COERCE_VALUE = -1
+
+    def self.type_error(err, ctx)
+      if err.is_a?(GraphQL::IntegerEncodingError) && err.integer_value == 99**99
+        MAGIC_INT_COERCE_VALUE
+      else
+        super
+      end
+    end
+
     if TESTING_INTERPRETER
       use GraphQL::Execution::Interpreter
     end

data/spec/support/jazz.rb

@@ -320,10 +320,12 @@ module Jazz
     possible_types Musician, Ensemble
 
     def self.resolve_type(object, context)
-      if object.is_a?(Models::Ensemble)
-        Ensemble
-      else
-        Musician
+      GraphQL::Execution::Lazy.new do
+        if object.is_a?(Models::Ensemble)
+          Ensemble
+        else
+          Musician
+        end
       end
     end
   end
@@ -352,7 +354,7 @@ module Jazz
     def now_playing; Models.data["Ensemble"].first; end
 
     # For asserting that the object is initialized once:
-    field :object_id, Integer, null: false
+    field :object_id, String, null: false
     field :inspect_context, [String], null: false
     field :hashyEnsemble, Ensemble, null: false
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphql
 version: !ruby/object:Gem::Version
-  version: 1.9.0.pre4
+  version: 1.9.0
 platform: ruby
 authors:
 - Robert Mosolgo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-11 00:00:00.000000000 Z
+date: 2019-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: benchmark-ips
@@ -437,6 +437,7 @@ files:
 - lib/graphql/id_type.rb
 - lib/graphql/input_object_type.rb
 - lib/graphql/int_type.rb
+- lib/graphql/integer_encoding_error.rb
 - lib/graphql/interface_type.rb
 - lib/graphql/internal_representation.rb
 - lib/graphql/internal_representation/document.rb
@@ -986,7 +987,7 @@ files:
 - spec/support/skylight.rb
 - spec/support/star_wars/schema.rb
 - spec/support/static_validation_helpers.rb
-homepage: http://github.com/rmosolgo/graphql-ruby
+homepage: https://github.com/rmosolgo/graphql-ruby
 licenses:
 - MIT
 metadata: {}
@@ -1001,9 +1002,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.6.13