graphql 1.8.7 → 1.9.0

data/spec/graphql/schema/member/build_type_spec.rb

@@ -2,6 +2,52 @@
 require "spec_helper"
 
 describe GraphQL::Schema::Member::BuildType do
+  describe ".parse_type" do
+    it "resolves a string type from a string" do
+      assert_equal GraphQL::Types::String, GraphQL::Schema::Member::BuildType.parse_type("String", null: true)
+    end
+
+    it "resolves an integer type from a string" do
+      assert_equal GraphQL::Types::Int, GraphQL::Schema::Member::BuildType.parse_type("Integer", null: true)
+    end
+
+    it "resolves a float type from a string" do
+      assert_equal GraphQL::Types::Float, GraphQL::Schema::Member::BuildType.parse_type("Float", null: true)
+    end
+
+    it "resolves a boolean type from a string" do
+      assert_equal GraphQL::Types::Boolean, GraphQL::Schema::Member::BuildType.parse_type("Boolean", null: true)
+    end
+
+    it "resolves an interface type from a string" do
+      assert_equal Jazz::BaseInterface, GraphQL::Schema::Member::BuildType.parse_type("Jazz::BaseInterface", null: true)
+    end
+
+    it "resolves an object type from a class" do
+      assert_equal Jazz::BaseObject, GraphQL::Schema::Member::BuildType.parse_type(Jazz::BaseObject, null: true)
+    end
+
+    it "resolves an object type from a string" do
+      assert_equal Jazz::BaseObject, GraphQL::Schema::Member::BuildType.parse_type("Jazz::BaseObject", null: true)
+    end
+
+    it "resolves a nested object type from a string" do
+      assert_equal Jazz::Introspection::NestedType, GraphQL::Schema::Member::BuildType.parse_type("Jazz::Introspection::NestedType", null: true)
+    end
+
+    it "resolves a deeply nested object type from a string" do
+      assert_equal Jazz::Introspection::NestedType::DeeplyNestedType, GraphQL::Schema::Member::BuildType.parse_type("Jazz::Introspection::NestedType::DeeplyNestedType", null: true)
+    end
+
+    it "resolves a list type from an array of classes" do
+      assert_instance_of GraphQL::Schema::List, GraphQL::Schema::Member::BuildType.parse_type([Jazz::BaseObject], null: true)
+    end
+
+    it "resolves a list type from an array of strings" do
+      assert_instance_of GraphQL::Schema::List, GraphQL::Schema::Member::BuildType.parse_type(["Jazz::BaseObject"], null: true)
+    end
+  end
+
   describe ".to_type_name" do
     it "works with lists and non-nulls" do
       t = Class.new(GraphQL::Schema::Object) do

data/spec/graphql/schema/member/scoped_spec.rb

@@ -54,11 +54,11 @@ describe GraphQL::Schema::Member::Scoped do
       field :items, [Item], null: false
       field :unscoped_items, [Item], null: false,
         scope: false,
-        method: :items
+        resolver_method: :items
       field :french_items, [FrenchItem], null: false,
-        method: :items
+        resolver_method: :items
       field :items_connection, Item.connection_type, null: false,
-        method: :items
+        resolver_method: :items
 
       def items
         [
@@ -74,6 +74,9 @@ describe GraphQL::Schema::Member::Scoped do
     end
 
     query(Query)
+    if TESTING_INTERPRETER
+      use GraphQL::Execution::Interpreter
+    end
   end
 
   describe ".scope_items(items, ctx)" do
@@ -118,6 +121,19 @@ describe GraphQL::Schema::Member::Scoped do
       res = ScopeSchema.execute(query_str, context: {english: true})
       names = res["data"]["itemsConnection"]["edges"].map { |e| e["node"]["name"] }
       assert_equal ["Paperclip"], names
+
+      query_str = "
+      {
+        itemsConnection {
+          nodes {
+            name
+          }
+        }
+      }
+      "
+      res = ScopeSchema.execute(query_str, context: {english: true})
+      names = res["data"]["itemsConnection"]["nodes"].map { |e| e["name"] }
+      assert_equal ["Paperclip"], names
     end
 
     it "is called for abstract types" do

data/spec/graphql/schema/mutation_spec.rb

@@ -23,7 +23,7 @@ describe GraphQL::Schema::Mutation do
 
   describe "argument prepare" do
     it "calls methods on the mutation, uses `as:`" do
-      query_str = 'mutation { prepareInput(input: 4) }'
+      query_str = "mutation { prepareInput(input: 4) }"
       res = Jazz::Schema.execute(query_str)
       assert_equal 16, res["data"]["prepareInput"], "It's squared by the prepare method"
     end
@@ -63,7 +63,8 @@ describe GraphQL::Schema::Mutation do
 
       assert_equal(GraphQL::Schema::Object, GraphQL::Schema::Mutation.object_class)
       assert_equal(obj_class, mutation_class.object_class)
-      assert_equal(obj_class, mutation_subclass.object_class)    end
+      assert_equal(obj_class, mutation_subclass.object_class)
+    end
   end
 
   describe ".argument_class" do
@@ -101,7 +102,8 @@ describe GraphQL::Schema::Mutation do
       response = Jazz::Schema.execute(query_str)
       assert_equal "Trombone", response["data"]["addInstrument"]["instrument"]["name"]
       assert_equal "BRASS", response["data"]["addInstrument"]["instrument"]["family"]
-      assert_equal "GraphQL::Query::Context::ExecutionErrors", response["data"]["addInstrument"]["ee"]
+      errors_class = TESTING_INTERPRETER ? "GraphQL::Execution::Interpreter::ExecutionErrors" : "GraphQL::Query::Context::ExecutionErrors"
+      assert_equal errors_class, response["data"]["addInstrument"]["ee"]
       assert_equal 7, response["data"]["addInstrument"]["entries"].size
     end
   end

data/spec/graphql/schema/object_spec.rb

@@ -14,6 +14,12 @@ describe GraphQL::Schema::Object do
       assert object_class.respond_to?(:connection_type)
     end
 
+    describe "path" do
+      it "is the type name" do
+        assert_equal "Ensemble", object_class.path
+      end
+    end
+
     it "inherits fields and interfaces" do
       new_object_class = Class.new(object_class) do
         field :newField, String, null: true
@@ -230,7 +236,9 @@ describe GraphQL::Schema::Object do
     it "skips fields properly" do
       query_str = "{ find(id: \"MagicalSkipId\") { __typename } }"
       res = Jazz::Schema.execute(query_str)
-      assert_equal({"data" => nil }, res.to_h)
+      # TBH I think `{}` is probably righter than `nil`, I guess we'll see.
+      skip_value = TESTING_INTERPRETER ? {} : nil
+      assert_equal({"data" => skip_value }, res.to_h)
     end
   end
 end