graphql 1.8.0.pre11 → 1.8.0

data/spec/graphql/tracing/new_relic_tracing_spec.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+require "spec_helper"
+
+describe GraphQL::Tracing::NewRelicTracing do
+  module NewRelicTest
+    class Query < GraphQL::Schema::Object
+      field :int, Integer, null: false
+
+      def int
+        1
+      end
+    end
+
+    class SchemaWithoutTransactionName < GraphQL::Schema
+      query(Query)
+      use(GraphQL::Tracing::NewRelicTracing)
+    end
+
+    class SchemaWithTransactionName < GraphQL::Schema
+      query(Query)
+      use(GraphQL::Tracing::NewRelicTracing, set_transaction_name: true)
+    end
+  end
+
+  before do
+    NewRelic.clear_all
+  end
+
+  it "can leave the transaction name in place" do
+    NewRelicTest::SchemaWithoutTransactionName.execute "query X { int }"
+    assert_equal [], NewRelic::TRANSACTION_NAMES
+  end
+
+  it "can override the transaction name" do
+    NewRelicTest::SchemaWithTransactionName.execute "query X { int }"
+    assert_equal ["GraphQL/query.X"], NewRelic::TRANSACTION_NAMES
+  end
+
+  it "can override the transaction name per query" do
+    # Override with `false`
+    NewRelicTest::SchemaWithTransactionName.execute "{ int }", context: { set_new_relic_transaction_name: false }
+    assert_equal [], NewRelic::TRANSACTION_NAMES
+    # Override with `true`
+    NewRelicTest::SchemaWithoutTransactionName.execute "{ int }", context: { set_new_relic_transaction_name: true }
+    assert_equal ["GraphQL/query.anonymous"], NewRelic::TRANSACTION_NAMES
+  end
+end

data/spec/support/jazz.rb

@@ -133,7 +133,12 @@ module Jazz
   module GloballyIdentifiableType
     include BaseInterface
     description "A fetchable object in the system"
-    field :id, ID, "A unique identifier for this object", null: false
+    field(
+      name: :id,
+      type: ID,
+      null: false,
+      description: "A unique identifier for this object",
+    )
     upcased_field :upcased_id, ID, null: false, method: :id # upcase: true added by helper
 
     def id

data/spec/support/new_relic.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+# A stub for the NewRelic agent, so we can make assertions about how it is used
+if defined?(NewRelic)
+  raise "Expected NewRelic to be undefined, so that we could define a stub for it."
+end
+
+module NewRelic
+  TRANSACTION_NAMES = []
+  # Reset state between tests
+  def self.clear_all
+    TRANSACTION_NAMES.clear
+  end
+  module Agent
+    def self.set_transaction_name(name)
+      TRANSACTION_NAMES << name
+    end
+
+    module MethodTracerHelpers
+      def self.trace_execution_scoped(trace_name)
+        yield
+      end
+    end
+  end
+end

data/spec/support/star_trek/schema.rb

@@ -326,8 +326,8 @@ module StarTrek
 
   class MutationType < GraphQL::Schema::Object
     graphql_name "Mutation"
-    # The mutation object exposes a field:
-    field :introduceShip, field: IntroduceShipMutation.field
+    field :introduceShip, mutation: IntroduceShipMutation
+    # To hook up a Relay::Mutation
     field :introduceShipFunction, field: IntroduceShipFunctionMutation.field
   end
 

data/spec/support/star_wars/schema.rb

@@ -331,8 +331,7 @@ module StarWars
 
   class MutationType < GraphQL::Schema::Object
     graphql_name "Mutation"
-    # The mutation object exposes a field:
-    field :introduceShip, field: IntroduceShipMutation.field
+    field :introduceShip, mutation: IntroduceShipMutation
     field :introduceShipFunction, field: IntroduceShipFunctionMutation.field
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphql
 version: !ruby/object:Gem::Version
-  version: 1.8.0.pre11
+  version: 1.8.0
 platform: ruby
 authors:
 - Robert Mosolgo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-03 00:00:00.000000000 Z
+date: 2018-05-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: benchmark-ips
@@ -541,6 +541,7 @@ files:
 - lib/graphql/schema/printer.rb
 - lib/graphql/schema/relay_classic_mutation.rb
 - lib/graphql/schema/rescue_middleware.rb
+- lib/graphql/schema/resolver.rb
 - lib/graphql/schema/scalar.rb
 - lib/graphql/schema/timeout_middleware.rb
 - lib/graphql/schema/traversal.rb
@@ -1053,6 +1054,7 @@ files:
 - spec/graphql/schema/introspection_system_spec.rb
 - spec/graphql/schema/loader_spec.rb
 - spec/graphql/schema/member/accepts_definition_spec.rb
+- spec/graphql/schema/member/build_type_spec.rb
 - spec/graphql/schema/member/has_fields_spec.rb
 - spec/graphql/schema/member/type_system_helpers_spec.rb
 - spec/graphql/schema/middleware_chain_spec.rb
@@ -1061,6 +1063,7 @@ files:
 - spec/graphql/schema/printer_spec.rb
 - spec/graphql/schema/relay_classic_mutation_spec.rb
 - spec/graphql/schema/rescue_middleware_spec.rb
+- spec/graphql/schema/resolver_spec.rb
 - spec/graphql/schema/scalar_spec.rb
 - spec/graphql/schema/timeout_middleware_spec.rb
 - spec/graphql/schema/traversal_spec.rb
@@ -1101,6 +1104,7 @@ files:
 - spec/graphql/subscriptions/serialize_spec.rb
 - spec/graphql/subscriptions_spec.rb
 - spec/graphql/tracing/active_support_notifications_tracing_spec.rb
+- spec/graphql/tracing/new_relic_tracing_spec.rb
 - spec/graphql/tracing/platform_tracing_spec.rb
 - spec/graphql/tracing/scout_tracing_spec.rb
 - spec/graphql/tracing_spec.rb
@@ -1116,6 +1120,7 @@ files:
 - spec/support/lazy_helpers.rb
 - spec/support/magic_cards/schema.graphql
 - spec/support/minimum_input_object.rb
+- spec/support/new_relic.rb
 - spec/support/parser/filename_example.graphql
 - spec/support/parser/filename_example_error_1.graphql
 - spec/support/parser/filename_example_error_2.graphql
@@ -1139,9 +1144,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.6.13
@@ -1597,6 +1602,7 @@ test_files:
 - spec/graphql/schema/introspection_system_spec.rb
 - spec/graphql/schema/loader_spec.rb
 - spec/graphql/schema/member/accepts_definition_spec.rb
+- spec/graphql/schema/member/build_type_spec.rb
 - spec/graphql/schema/member/has_fields_spec.rb
 - spec/graphql/schema/member/type_system_helpers_spec.rb
 - spec/graphql/schema/middleware_chain_spec.rb
@@ -1605,6 +1611,7 @@ test_files:
 - spec/graphql/schema/printer_spec.rb
 - spec/graphql/schema/relay_classic_mutation_spec.rb
 - spec/graphql/schema/rescue_middleware_spec.rb
+- spec/graphql/schema/resolver_spec.rb
 - spec/graphql/schema/scalar_spec.rb
 - spec/graphql/schema/timeout_middleware_spec.rb
 - spec/graphql/schema/traversal_spec.rb
@@ -1645,6 +1652,7 @@ test_files:
 - spec/graphql/subscriptions/serialize_spec.rb
 - spec/graphql/subscriptions_spec.rb
 - spec/graphql/tracing/active_support_notifications_tracing_spec.rb
+- spec/graphql/tracing/new_relic_tracing_spec.rb
 - spec/graphql/tracing/platform_tracing_spec.rb
 - spec/graphql/tracing/scout_tracing_spec.rb
 - spec/graphql/tracing_spec.rb
@@ -1660,6 +1668,7 @@ test_files:
 - spec/support/lazy_helpers.rb
 - spec/support/magic_cards/schema.graphql
 - spec/support/minimum_input_object.rb
+- spec/support/new_relic.rb
 - spec/support/parser/filename_example.graphql
 - spec/support/parser/filename_example_error_1.graphql
 - spec/support/parser/filename_example_error_2.graphql