graphql 1.8.0.pre1 → 1.8.0.pre2

data/spec/dummy/log/test.log

@@ -808,3 +808,207 @@ Could not execute command from ({"command"=>"subscribe", "identifier"=>"{\"chann
      ^
 /Users/rmosolgo/code/graphql-ruby/spec/dummy/app/channels/graphql_channel.rb:103: syntax error, unexpected end-of-input, expecting keyword_end]: /Users/rmosolgo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activesupport-5.1.4/lib/active_support/dependencies.rb:292:in `require' | /Users/rmosolgo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activesupport-5.1.4/lib/active_support/dependencies.rb:292:in `block in require' | /Users/rmosolgo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activesupport-5.1.4/lib/active_support/dependencies.rb:258:in `load_dependency' | /Users/rmosolgo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activesupport-5.1.4/lib/active_support/dependencies.rb:292:in `require' | /Users/rmosolgo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/activesupport-5.1.4/lib/active_support/dependencies.rb:379:in `block in require_or_load'
 Finished "/cable/" [WebSocket] for 127.0.0.1 at 2017-11-13 21:58:53 -0500
+-----------------------------------------------------------
+ActionCableSubscriptionsTest: test_it_handles_subscriptions
+-----------------------------------------------------------
+Started GET "/" for 127.0.0.1 at 2017-11-16 21:25:41 -0500
+Processing by PagesController#show as HTML
+  Rendering pages/show.html within layouts/application
+  Rendered pages/show.html within layouts/application (1.1ms)
+Completed 200 OK in 169ms (Views: 167.8ms)
+Started GET "/assets/application-aca150c4b2db51d5326af18134f6281fbce7e823a372b0337cca65ff41b4a7ea.js" for 127.0.0.1 at 2017-11-16 21:25:41 -0500
+Started GET "/cable" for 127.0.0.1 at 2017-11-16 21:25:42 -0500
+Started GET "/cable/" [WebSocket] for 127.0.0.1 at 2017-11-16 21:25:42 -0500
+Successfully upgraded to WebSocket (REQUEST_METHOD: GET, HTTP_CONNECTION: Upgrade, HTTP_UPGRADE: websocket)
+GraphqlChannel is transmitting the subscription confirmation
+GraphqlChannel is transmitting the subscription confirmation
+GraphqlChannel#execute({"query"=>"subscription($id: ID!) { payload(id: $id) { value } }", "variables"=>{"id"=>"updates-1"}})
+GraphqlChannel transmitting {:result=>{"data"=>nil}, :more=>true}
+GraphqlChannel#execute({"query"=>"subscription($id: ID!) { payload(id: $id) { value } }", "variables"=>{"id"=>"updates-2"}})
+GraphqlChannel transmitting {:result=>{"data"=>nil}, :more=>true}
+GraphqlChannel is streaming from graphql-event::payload:id:updates-1
+GraphqlChannel is streaming from graphql-event::payload:id:updates-2
+GraphqlChannel is streaming from graphql-subscription:2d85fcfd-550d-45ce-9b98-71d4adc0dcc0
+GraphqlChannel is streaming from graphql-subscription:a225c15d-b0a3-4bdf-b535-e6e5e937cc25
+GraphqlChannel#make_trigger({"id"=>"updates-1", "value"=>1})
+Could not execute command from ({"command"=>"message", "identifier"=>"{\"channel\":\"GraphqlChannel\",\"id\":\"15fc7cbd4ad\"}", "data"=>"{\"id\":\"updates-1\",\"value\":1,\"action\":\"make_trigger\"}"}) [NoMethodError - undefined method `dump_value' for GraphqlChannel::CustomSerializer:Module]: /Users/rmosolgo/code/graphql-ruby/lib/graphql/subscriptions/serialize.rb:21:in `dump' | /Users/rmosolgo/code/graphql-ruby/spec/dummy/app/channels/graphql_channel.rb:36:in `dump' | /Users/rmosolgo/code/graphql-ruby/lib/graphql/subscriptions/action_cable_subscriptions.rb:78:in `execute_all' | /Users/rmosolgo/code/graphql-ruby/lib/graphql/subscriptions.rb:52:in `trigger' | /Users/rmosolgo/code/graphql-ruby/spec/dummy/app/channels/graphql_channel.rb:83:in `make_trigger'
+GraphqlChannel#make_trigger({"id"=>"updates-1", "value"=>2})
+Could not execute command from ({"command"=>"message", "identifier"=>"{\"channel\":\"GraphqlChannel\",\"id\":\"15fc7cbd4ad\"}", "data"=>"{\"id\":\"updates-1\",\"value\":2,\"action\":\"make_trigger\"}"}) [NoMethodError - undefined method `dump_value' for GraphqlChannel::CustomSerializer:Module]: /Users/rmosolgo/code/graphql-ruby/lib/graphql/subscriptions/serialize.rb:21:in `dump' | /Users/rmosolgo/code/graphql-ruby/spec/dummy/app/channels/graphql_channel.rb:36:in `dump' | /Users/rmosolgo/code/graphql-ruby/lib/graphql/subscriptions/action_cable_subscriptions.rb:78:in `execute_all' | /Users/rmosolgo/code/graphql-ruby/lib/graphql/subscriptions.rb:52:in `trigger' | /Users/rmosolgo/code/graphql-ruby/spec/dummy/app/channels/graphql_channel.rb:83:in `make_trigger'
+GraphqlChannel#make_trigger({"id"=>"updates-1", "value"=>3})
+Could not execute command from ({"command"=>"message", "identifier"=>"{\"channel\":\"GraphqlChannel\",\"id\":\"15fc7cbd4ad\"}", "data"=>"{\"id\":\"updates-1\",\"value\":3,\"action\":\"make_trigger\"}"}) [NoMethodError - undefined method `dump_value' for GraphqlChannel::CustomSerializer:Module]: /Users/rmosolgo/code/graphql-ruby/lib/graphql/subscriptions/serialize.rb:21:in `dump' | /Users/rmosolgo/code/graphql-ruby/spec/dummy/app/channels/graphql_channel.rb:36:in `dump' | /Users/rmosolgo/code/graphql-ruby/lib/graphql/subscriptions/action_cable_subscriptions.rb:78:in `execute_all' | /Users/rmosolgo/code/graphql-ruby/lib/graphql/subscriptions.rb:52:in `trigger' | /Users/rmosolgo/code/graphql-ruby/spec/dummy/app/channels/graphql_channel.rb:83:in `make_trigger'
+Finished "/cable/" [WebSocket] for 127.0.0.1 at 2017-11-16 21:25:45 -0500
+GraphqlChannel stopped streaming from graphql-subscription:2d85fcfd-550d-45ce-9b98-71d4adc0dcc0
+GraphqlChannel stopped streaming from graphql-event::payload:id:updates-1
+GraphqlChannel stopped streaming from graphql-subscription:a225c15d-b0a3-4bdf-b535-e6e5e937cc25
+GraphqlChannel stopped streaming from graphql-event::payload:id:updates-2
+-----------------------------------------------------------
+ActionCableSubscriptionsTest: test_it_handles_subscriptions
+-----------------------------------------------------------
+Started GET "/" for 127.0.0.1 at 2017-11-16 21:31:11 -0500
+Processing by PagesController#show as HTML
+  Rendering pages/show.html within layouts/application
+  Rendered pages/show.html within layouts/application (0.7ms)
+Completed 200 OK in 138ms (Views: 136.5ms)
+Started GET "/assets/application-aca150c4b2db51d5326af18134f6281fbce7e823a372b0337cca65ff41b4a7ea.js" for 127.0.0.1 at 2017-11-16 21:31:11 -0500
+Started GET "/cable" for 127.0.0.1 at 2017-11-16 21:31:11 -0500
+Started GET "/cable/" [WebSocket] for 127.0.0.1 at 2017-11-16 21:31:11 -0500
+Successfully upgraded to WebSocket (REQUEST_METHOD: GET, HTTP_CONNECTION: Upgrade, HTTP_UPGRADE: websocket)
+GraphqlChannel is transmitting the subscription confirmation
+GraphqlChannel is transmitting the subscription confirmation
+GraphqlChannel#execute({"query"=>"subscription($id: ID!) { payload(id: $id) { value } }", "variables"=>{"id"=>"updates-1"}})
+GraphqlChannel transmitting {:result=>{"data"=>nil}, :more=>true}
+GraphqlChannel#execute({"query"=>"subscription($id: ID!) { payload(id: $id) { value } }", "variables"=>{"id"=>"updates-2"}})
+GraphqlChannel transmitting {:result=>{"data"=>nil}, :more=>true}
+GraphqlChannel is streaming from graphql-subscription:17acca37-2b4d-448c-b9bb-51ce54d11284
+GraphqlChannel is streaming from graphql-event::payload:id:updates-1
+GraphqlChannel is streaming from graphql-event::payload:id:updates-2
+GraphqlChannel is streaming from graphql-subscription:606ac42b-b06b-4d48-9f1e-0a82a7c313b0
+GraphqlChannel#make_trigger({"id"=>"updates-1", "value"=>1})
+[ActionCable] Broadcasting to graphql-event::payload:id:updates-1: "{\"__gid__\":\"Z2lkOi8vZHVtbXkvR3JhcGhxbENoYW5uZWw6OkV4YW1wbGVQYXlsb2FkLzE\"}"
+[ActionCable] Broadcasting to graphql-subscription:17acca37-2b4d-448c-b9bb-51ce54d11284: {:result=>{"data"=>{"payload"=>{"value"=>1}}}, :more=>true}
+GraphqlChannel transmitting {"result"=>{"data"=>{"payload"=>{"value"=>1}}}, "more"=>true} (via streamed from graphql-subscription:17acca37-2b4d-448c-b9bb-51ce54d11284)
+GraphqlChannel#make_trigger({"id"=>"updates-1", "value"=>2})
+[ActionCable] Broadcasting to graphql-event::payload:id:updates-1: "{\"__gid__\":\"Z2lkOi8vZHVtbXkvR3JhcGhxbENoYW5uZWw6OkV4YW1wbGVQYXlsb2FkLzI\"}"
+[ActionCable] Broadcasting to graphql-subscription:17acca37-2b4d-448c-b9bb-51ce54d11284: {:result=>{"data"=>{"payload"=>{"value"=>2}}}, :more=>true}
+GraphqlChannel transmitting {"result"=>{"data"=>{"payload"=>{"value"=>2}}}, "more"=>true} (via streamed from graphql-subscription:17acca37-2b4d-448c-b9bb-51ce54d11284)
+GraphqlChannel#make_trigger({"id"=>"updates-1", "value"=>3})
+[ActionCable] Broadcasting to graphql-event::payload:id:updates-1: "{\"__gid__\":\"Z2lkOi8vZHVtbXkvR3JhcGhxbENoYW5uZWw6OkV4YW1wbGVQYXlsb2FkLzM\"}"
+[ActionCable] Broadcasting to graphql-subscription:17acca37-2b4d-448c-b9bb-51ce54d11284: {:result=>{"data"=>{"payload"=>{"value"=>3}}}, :more=>true}
+GraphqlChannel transmitting {"result"=>{"data"=>{"payload"=>{"value"=>3}}}, "more"=>true} (via streamed from graphql-subscription:17acca37-2b4d-448c-b9bb-51ce54d11284)
+GraphqlChannel#make_trigger({"id"=>"updates-2", "value"=>1})
+[ActionCable] Broadcasting to graphql-event::payload:id:updates-2: "{\"__gid__\":\"Z2lkOi8vZHVtbXkvR3JhcGhxbENoYW5uZWw6OkV4YW1wbGVQYXlsb2FkLzE\"}"
+[ActionCable] Broadcasting to graphql-subscription:606ac42b-b06b-4d48-9f1e-0a82a7c313b0: {:result=>{"data"=>{"payload"=>{"value"=>1}}}, :more=>true}
+GraphqlChannel transmitting {"result"=>{"data"=>{"payload"=>{"value"=>1}}}, "more"=>true} (via streamed from graphql-subscription:606ac42b-b06b-4d48-9f1e-0a82a7c313b0)
+GraphqlChannel#make_trigger({"id"=>"updates-2", "value"=>2})
+[ActionCable] Broadcasting to graphql-event::payload:id:updates-2: "{\"__gid__\":\"Z2lkOi8vZHVtbXkvR3JhcGhxbENoYW5uZWw6OkV4YW1wbGVQYXlsb2FkLzI\"}"
+[ActionCable] Broadcasting to graphql-subscription:606ac42b-b06b-4d48-9f1e-0a82a7c313b0: {:result=>{"data"=>{"payload"=>{"value"=>2}}}, :more=>true}
+GraphqlChannel transmitting {"result"=>{"data"=>{"payload"=>{"value"=>2}}}, "more"=>true} (via streamed from graphql-subscription:606ac42b-b06b-4d48-9f1e-0a82a7c313b0)
+Unsubscribing from channel: {"channel":"GraphqlChannel","id":"15fc7d184bc"}
+GraphqlChannel stopped streaming from graphql-subscription:17acca37-2b4d-448c-b9bb-51ce54d11284
+GraphqlChannel stopped streaming from graphql-event::payload:id:updates-1
+Could not execute command from ({"command"=>"message", "identifier"=>"{\"channel\":\"GraphqlChannel\",\"id\":\"15fc7d184bc\"}", "data"=>"{\"id\":\"updates-1\",\"value\":4,\"action\":\"make_trigger\"}"}) [RuntimeError - Unable to find subscription with identifier: {"channel":"GraphqlChannel","id":"15fc7d184bc"}]: /Users/rmosolgo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actioncable-5.1.4/lib/action_cable/connection/subscriptions.rb:76:in `find' | /Users/rmosolgo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actioncable-5.1.4/lib/action_cable/connection/subscriptions.rb:53:in `perform_action' | /Users/rmosolgo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actioncable-5.1.4/lib/action_cable/connection/subscriptions.rb:17:in `execute_command' | /Users/rmosolgo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actioncable-5.1.4/lib/action_cable/connection/base.rb:85:in `dispatch_websocket_message' | /Users/rmosolgo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actioncable-5.1.4/lib/action_cable/server/worker.rb:58:in `block in invoke'
+GraphqlChannel#make_trigger({"id"=>"updates-2", "value"=>3})
+[ActionCable] Broadcasting to graphql-event::payload:id:updates-2: "{\"__gid__\":\"Z2lkOi8vZHVtbXkvR3JhcGhxbENoYW5uZWw6OkV4YW1wbGVQYXlsb2FkLzM\"}"
+[ActionCable] Broadcasting to graphql-subscription:606ac42b-b06b-4d48-9f1e-0a82a7c313b0: {:result=>{"data"=>{"payload"=>{"value"=>3}}}, :more=>true}
+GraphqlChannel transmitting {"result"=>{"data"=>{"payload"=>{"value"=>3}}}, "more"=>true} (via streamed from graphql-subscription:606ac42b-b06b-4d48-9f1e-0a82a7c313b0)
+GraphqlChannel#make_trigger({"id"=>"updates-2", "value"=>4})
+[ActionCable] Broadcasting to graphql-event::payload:id:updates-2: "4x"
+[ActionCable] Broadcasting to graphql-subscription:606ac42b-b06b-4d48-9f1e-0a82a7c313b0: {:result=>{"data"=>{"payload"=>{"value"=>400}}}, :more=>true}
+GraphqlChannel transmitting {"result"=>{"data"=>{"payload"=>{"value"=>400}}}, "more"=>true} (via streamed from graphql-subscription:606ac42b-b06b-4d48-9f1e-0a82a7c313b0)
+Finished "/cable/" [WebSocket] for 127.0.0.1 at 2017-11-16 21:31:15 -0500
+GraphqlChannel stopped streaming from graphql-subscription:606ac42b-b06b-4d48-9f1e-0a82a7c313b0
+GraphqlChannel stopped streaming from graphql-event::payload:id:updates-2
+-----------------------------------------------------------
+ActionCableSubscriptionsTest: test_it_handles_subscriptions
+-----------------------------------------------------------
+Started GET "/" for 127.0.0.1 at 2017-11-16 21:31:35 -0500
+Processing by PagesController#show as HTML
+  Rendering pages/show.html within layouts/application
+  Rendered pages/show.html within layouts/application (2.2ms)
+Completed 200 OK in 195ms (Views: 194.0ms)
+Started GET "/assets/application-aca150c4b2db51d5326af18134f6281fbce7e823a372b0337cca65ff41b4a7ea.js" for 127.0.0.1 at 2017-11-16 21:31:35 -0500
+Started GET "/cable" for 127.0.0.1 at 2017-11-16 21:31:35 -0500
+Started GET "/cable/" [WebSocket] for 127.0.0.1 at 2017-11-16 21:31:35 -0500
+Successfully upgraded to WebSocket (REQUEST_METHOD: GET, HTTP_CONNECTION: Upgrade, HTTP_UPGRADE: websocket)
+GraphqlChannel is transmitting the subscription confirmation
+GraphqlChannel is transmitting the subscription confirmation
+GraphqlChannel#execute({"query"=>"subscription($id: ID!) { payload(id: $id) { value } }", "variables"=>{"id"=>"updates-2"}})
+GraphqlChannel transmitting {:result=>{"data"=>nil}, :more=>true}
+GraphqlChannel#execute({"query"=>"subscription($id: ID!) { payload(id: $id) { value } }", "variables"=>{"id"=>"updates-1"}})
+GraphqlChannel transmitting {:result=>{"data"=>nil}, :more=>true}
+GraphqlChannel is streaming from graphql-subscription:deb86012-88c0-4449-872c-f71c390a3c11
+GraphqlChannel is streaming from graphql-event::payload:id:updates-2
+GraphqlChannel is streaming from graphql-subscription:ded77eba-1a76-4246-83f2-bd4637b11de0
+GraphqlChannel is streaming from graphql-event::payload:id:updates-1
+GraphqlChannel#make_trigger({"id"=>"updates-1", "value"=>1})
+[ActionCable] Broadcasting to graphql-event::payload:id:updates-1: "{\"__gid__\":\"Z2lkOi8vZHVtbXkvR3JhcGhxbENoYW5uZWw6OkV4YW1wbGVQYXlsb2FkLzE\"}"
+[ActionCable] Broadcasting to graphql-subscription:ded77eba-1a76-4246-83f2-bd4637b11de0: {:result=>{"data"=>{"payload"=>{"value"=>1}}}, :more=>true}
+GraphqlChannel transmitting {"result"=>{"data"=>{"payload"=>{"value"=>1}}}, "more"=>true} (via streamed from graphql-subscription:ded77eba-1a76-4246-83f2-bd4637b11de0)
+GraphqlChannel#make_trigger({"id"=>"updates-1", "value"=>2})
+[ActionCable] Broadcasting to graphql-event::payload:id:updates-1: "{\"__gid__\":\"Z2lkOi8vZHVtbXkvR3JhcGhxbENoYW5uZWw6OkV4YW1wbGVQYXlsb2FkLzI\"}"
+[ActionCable] Broadcasting to graphql-subscription:ded77eba-1a76-4246-83f2-bd4637b11de0: {:result=>{"data"=>{"payload"=>{"value"=>2}}}, :more=>true}
+GraphqlChannel transmitting {"result"=>{"data"=>{"payload"=>{"value"=>2}}}, "more"=>true} (via streamed from graphql-subscription:ded77eba-1a76-4246-83f2-bd4637b11de0)
+GraphqlChannel#make_trigger({"id"=>"updates-1", "value"=>3})
+[ActionCable] Broadcasting to graphql-event::payload:id:updates-1: "{\"__gid__\":\"Z2lkOi8vZHVtbXkvR3JhcGhxbENoYW5uZWw6OkV4YW1wbGVQYXlsb2FkLzM\"}"
+[ActionCable] Broadcasting to graphql-subscription:ded77eba-1a76-4246-83f2-bd4637b11de0: {:result=>{"data"=>{"payload"=>{"value"=>3}}}, :more=>true}
+GraphqlChannel transmitting {"result"=>{"data"=>{"payload"=>{"value"=>3}}}, "more"=>true} (via streamed from graphql-subscription:ded77eba-1a76-4246-83f2-bd4637b11de0)
+GraphqlChannel#make_trigger({"id"=>"updates-2", "value"=>1})
+[ActionCable] Broadcasting to graphql-event::payload:id:updates-2: "{\"__gid__\":\"Z2lkOi8vZHVtbXkvR3JhcGhxbENoYW5uZWw6OkV4YW1wbGVQYXlsb2FkLzE\"}"
+[ActionCable] Broadcasting to graphql-subscription:deb86012-88c0-4449-872c-f71c390a3c11: {:result=>{"data"=>{"payload"=>{"value"=>1}}}, :more=>true}
+GraphqlChannel transmitting {"result"=>{"data"=>{"payload"=>{"value"=>1}}}, "more"=>true} (via streamed from graphql-subscription:deb86012-88c0-4449-872c-f71c390a3c11)
+GraphqlChannel#make_trigger({"id"=>"updates-2", "value"=>2})
+[ActionCable] Broadcasting to graphql-event::payload:id:updates-2: "{\"__gid__\":\"Z2lkOi8vZHVtbXkvR3JhcGhxbENoYW5uZWw6OkV4YW1wbGVQYXlsb2FkLzI\"}"
+[ActionCable] Broadcasting to graphql-subscription:deb86012-88c0-4449-872c-f71c390a3c11: {:result=>{"data"=>{"payload"=>{"value"=>2}}}, :more=>true}
+GraphqlChannel transmitting {"result"=>{"data"=>{"payload"=>{"value"=>2}}}, "more"=>true} (via streamed from graphql-subscription:deb86012-88c0-4449-872c-f71c390a3c11)
+Unsubscribing from channel: {"channel":"GraphqlChannel","id":"15fc7d19ae3"}
+GraphqlChannel stopped streaming from graphql-subscription:ded77eba-1a76-4246-83f2-bd4637b11de0
+GraphqlChannel stopped streaming from graphql-event::payload:id:updates-1
+Could not execute command from ({"command"=>"message", "identifier"=>"{\"channel\":\"GraphqlChannel\",\"id\":\"15fc7d19ae3\"}", "data"=>"{\"id\":\"updates-1\",\"value\":4,\"action\":\"make_trigger\"}"}) [RuntimeError - Unable to find subscription with identifier: {"channel":"GraphqlChannel","id":"15fc7d19ae3"}]: /Users/rmosolgo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actioncable-5.1.4/lib/action_cable/connection/subscriptions.rb:76:in `find' | /Users/rmosolgo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actioncable-5.1.4/lib/action_cable/connection/subscriptions.rb:53:in `perform_action' | /Users/rmosolgo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actioncable-5.1.4/lib/action_cable/connection/subscriptions.rb:17:in `execute_command' | /Users/rmosolgo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actioncable-5.1.4/lib/action_cable/connection/base.rb:85:in `dispatch_websocket_message' | /Users/rmosolgo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actioncable-5.1.4/lib/action_cable/server/worker.rb:58:in `block in invoke'
+GraphqlChannel#make_trigger({"id"=>"updates-2", "value"=>3})
+[ActionCable] Broadcasting to graphql-event::payload:id:updates-2: "{\"__gid__\":\"Z2lkOi8vZHVtbXkvR3JhcGhxbENoYW5uZWw6OkV4YW1wbGVQYXlsb2FkLzM\"}"
+[ActionCable] Broadcasting to graphql-subscription:deb86012-88c0-4449-872c-f71c390a3c11: {:result=>{"data"=>{"payload"=>{"value"=>3}}}, :more=>true}
+GraphqlChannel transmitting {"result"=>{"data"=>{"payload"=>{"value"=>3}}}, "more"=>true} (via streamed from graphql-subscription:deb86012-88c0-4449-872c-f71c390a3c11)
+GraphqlChannel#make_trigger({"id"=>"updates-2", "value"=>4})
+[ActionCable] Broadcasting to graphql-event::payload:id:updates-2: "4x"
+[ActionCable] Broadcasting to graphql-subscription:deb86012-88c0-4449-872c-f71c390a3c11: {:result=>{"data"=>{"payload"=>{"value"=>400}}}, :more=>true}
+GraphqlChannel transmitting {"result"=>{"data"=>{"payload"=>{"value"=>400}}}, "more"=>true} (via streamed from graphql-subscription:deb86012-88c0-4449-872c-f71c390a3c11)
+Finished "/cable/" [WebSocket] for 127.0.0.1 at 2017-11-16 21:31:41 -0500
+GraphqlChannel stopped streaming from graphql-subscription:deb86012-88c0-4449-872c-f71c390a3c11
+GraphqlChannel stopped streaming from graphql-event::payload:id:updates-2
+-----------------------------------------------------------
+ActionCableSubscriptionsTest: test_it_handles_subscriptions
+-----------------------------------------------------------
+Started GET "/" for 127.0.0.1 at 2017-11-16 21:31:55 -0500
+Processing by PagesController#show as HTML
+  Rendering pages/show.html within layouts/application
+  Rendered pages/show.html within layouts/application (1.0ms)
+Completed 200 OK in 111ms (Views: 110.0ms)
+Started GET "/assets/application-aca150c4b2db51d5326af18134f6281fbce7e823a372b0337cca65ff41b4a7ea.js" for 127.0.0.1 at 2017-11-16 21:31:55 -0500
+Started GET "/cable" for 127.0.0.1 at 2017-11-16 21:31:56 -0500
+Started GET "/cable/" [WebSocket] for 127.0.0.1 at 2017-11-16 21:31:56 -0500
+Successfully upgraded to WebSocket (REQUEST_METHOD: GET, HTTP_CONNECTION: Upgrade, HTTP_UPGRADE: websocket)
+GraphqlChannel is transmitting the subscription confirmation
+GraphqlChannel is transmitting the subscription confirmation
+GraphqlChannel#execute({"query"=>"subscription($id: ID!) { payload(id: $id) { value } }", "variables"=>{"id"=>"updates-2"}})
+GraphqlChannel transmitting {:result=>{"data"=>nil}, :more=>true}
+GraphqlChannel is streaming from graphql-event::payload:id:updates-2
+GraphqlChannel#execute({"query"=>"subscription($id: ID!) { payload(id: $id) { value } }", "variables"=>{"id"=>"updates-1"}})
+GraphqlChannel is streaming from graphql-subscription:4aa99f83-32cb-4a2f-a337-ebfa958ad4f9
+GraphqlChannel transmitting {:result=>{"data"=>nil}, :more=>true}
+GraphqlChannel is streaming from graphql-subscription:359ce997-f8e7-4431-bd71-74af6276e37e
+GraphqlChannel is streaming from graphql-event::payload:id:updates-1
+GraphqlChannel#make_trigger({"id"=>"updates-1", "value"=>1})
+[ActionCable] Broadcasting to graphql-event::payload:id:updates-1: "{\"__gid__\":\"Z2lkOi8vZHVtbXkvR3JhcGhxbENoYW5uZWw6OkV4YW1wbGVQYXlsb2FkLzE\"}"
+[ActionCable] Broadcasting to graphql-subscription:359ce997-f8e7-4431-bd71-74af6276e37e: {:result=>{"data"=>{"payload"=>{"value"=>1}}}, :more=>true}
+GraphqlChannel transmitting {"result"=>{"data"=>{"payload"=>{"value"=>1}}}, "more"=>true} (via streamed from graphql-subscription:359ce997-f8e7-4431-bd71-74af6276e37e)
+GraphqlChannel#make_trigger({"id"=>"updates-1", "value"=>2})
+[ActionCable] Broadcasting to graphql-event::payload:id:updates-1: "{\"__gid__\":\"Z2lkOi8vZHVtbXkvR3JhcGhxbENoYW5uZWw6OkV4YW1wbGVQYXlsb2FkLzI\"}"
+[ActionCable] Broadcasting to graphql-subscription:359ce997-f8e7-4431-bd71-74af6276e37e: {:result=>{"data"=>{"payload"=>{"value"=>2}}}, :more=>true}
+GraphqlChannel transmitting {"result"=>{"data"=>{"payload"=>{"value"=>2}}}, "more"=>true} (via streamed from graphql-subscription:359ce997-f8e7-4431-bd71-74af6276e37e)
+GraphqlChannel#make_trigger({"id"=>"updates-1", "value"=>3})
+[ActionCable] Broadcasting to graphql-event::payload:id:updates-1: "{\"__gid__\":\"Z2lkOi8vZHVtbXkvR3JhcGhxbENoYW5uZWw6OkV4YW1wbGVQYXlsb2FkLzM\"}"
+[ActionCable] Broadcasting to graphql-subscription:359ce997-f8e7-4431-bd71-74af6276e37e: {:result=>{"data"=>{"payload"=>{"value"=>3}}}, :more=>true}
+GraphqlChannel transmitting {"result"=>{"data"=>{"payload"=>{"value"=>3}}}, "more"=>true} (via streamed from graphql-subscription:359ce997-f8e7-4431-bd71-74af6276e37e)
+GraphqlChannel#make_trigger({"id"=>"updates-2", "value"=>1})
+[ActionCable] Broadcasting to graphql-event::payload:id:updates-2: "{\"__gid__\":\"Z2lkOi8vZHVtbXkvR3JhcGhxbENoYW5uZWw6OkV4YW1wbGVQYXlsb2FkLzE\"}"
+[ActionCable] Broadcasting to graphql-subscription:4aa99f83-32cb-4a2f-a337-ebfa958ad4f9: {:result=>{"data"=>{"payload"=>{"value"=>1}}}, :more=>true}
+GraphqlChannel transmitting {"result"=>{"data"=>{"payload"=>{"value"=>1}}}, "more"=>true} (via streamed from graphql-subscription:4aa99f83-32cb-4a2f-a337-ebfa958ad4f9)
+GraphqlChannel#make_trigger({"id"=>"updates-2", "value"=>2})
+[ActionCable] Broadcasting to graphql-event::payload:id:updates-2: "{\"__gid__\":\"Z2lkOi8vZHVtbXkvR3JhcGhxbENoYW5uZWw6OkV4YW1wbGVQYXlsb2FkLzI\"}"
+[ActionCable] Broadcasting to graphql-subscription:4aa99f83-32cb-4a2f-a337-ebfa958ad4f9: {:result=>{"data"=>{"payload"=>{"value"=>2}}}, :more=>true}
+GraphqlChannel transmitting {"result"=>{"data"=>{"payload"=>{"value"=>2}}}, "more"=>true} (via streamed from graphql-subscription:4aa99f83-32cb-4a2f-a337-ebfa958ad4f9)
+Unsubscribing from channel: {"channel":"GraphqlChannel","id":"15fc7d1abf4"}
+GraphqlChannel stopped streaming from graphql-subscription:359ce997-f8e7-4431-bd71-74af6276e37e
+GraphqlChannel stopped streaming from graphql-event::payload:id:updates-1
+Could not execute command from ({"command"=>"message", "identifier"=>"{\"channel\":\"GraphqlChannel\",\"id\":\"15fc7d1abf4\"}", "data"=>"{\"id\":\"updates-1\",\"value\":4,\"action\":\"make_trigger\"}"}) [RuntimeError - Unable to find subscription with identifier: {"channel":"GraphqlChannel","id":"15fc7d1abf4"}]: /Users/rmosolgo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actioncable-5.1.4/lib/action_cable/connection/subscriptions.rb:76:in `find' | /Users/rmosolgo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actioncable-5.1.4/lib/action_cable/connection/subscriptions.rb:53:in `perform_action' | /Users/rmosolgo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actioncable-5.1.4/lib/action_cable/connection/subscriptions.rb:17:in `execute_command' | /Users/rmosolgo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actioncable-5.1.4/lib/action_cable/connection/base.rb:85:in `dispatch_websocket_message' | /Users/rmosolgo/.rbenv/versions/2.4.1/lib/ruby/gems/2.4.0/gems/actioncable-5.1.4/lib/action_cable/server/worker.rb:58:in `block in invoke'
+GraphqlChannel#make_trigger({"id"=>"updates-2", "value"=>3})
+[ActionCable] Broadcasting to graphql-event::payload:id:updates-2: "{\"__gid__\":\"Z2lkOi8vZHVtbXkvR3JhcGhxbENoYW5uZWw6OkV4YW1wbGVQYXlsb2FkLzM\"}"
+[ActionCable] Broadcasting to graphql-subscription:4aa99f83-32cb-4a2f-a337-ebfa958ad4f9: {:result=>{"data"=>{"payload"=>{"value"=>3}}}, :more=>true}
+GraphqlChannel transmitting {"result"=>{"data"=>{"payload"=>{"value"=>3}}}, "more"=>true} (via streamed from graphql-subscription:4aa99f83-32cb-4a2f-a337-ebfa958ad4f9)
+GraphqlChannel#make_trigger({"id"=>"updates-2", "value"=>4})
+[ActionCable] Broadcasting to graphql-event::payload:id:updates-2: "4x"
+[ActionCable] Broadcasting to graphql-subscription:4aa99f83-32cb-4a2f-a337-ebfa958ad4f9: {:result=>{"data"=>{"payload"=>{"value"=>400}}}, :more=>true}
+GraphqlChannel transmitting {"result"=>{"data"=>{"payload"=>{"value"=>400}}}, "more"=>true} (via streamed from graphql-subscription:4aa99f83-32cb-4a2f-a337-ebfa958ad4f9)
+Finished "/cable/" [WebSocket] for 127.0.0.1 at 2017-11-16 21:31:59 -0500
+GraphqlChannel stopped streaming from graphql-subscription:4aa99f83-32cb-4a2f-a337-ebfa958ad4f9
+GraphqlChannel stopped streaming from graphql-event::payload:id:updates-2

data/spec/dummy/test/system/action_cable_subscription_test.rb

@@ -37,5 +37,9 @@ class ActionCableSubscriptionsTest < ApplicationSystemTestCase
     click_on("Trigger 2")
     assert_selector "#updates-2-3", text: "3"
     refute_selector "#updates-1-4"
+
+    # wacky behavior to make sure the custom serializer is used:
+    click_on("Trigger 2")
+    assert_selector "#updates-2-400", text: "400"
   end
 end

data/spec/generators/graphql/function_generator_spec.rb

@@ -30,4 +30,30 @@ RUBY
 
     assert_file "app/graphql/functions/find_record.rb", expected_content
   end
+
+  test "it generates a namespaced function by name" do
+    run_generator(["finders::find_record"])
+
+    expected_content = <<-RUBY
+class Functions::Finders::FindRecord < GraphQL::Function
+  # Define `initialize` to store field-level options, eg
+  #
+  #     field :myField, function: Functions::Finders::FindRecord.new(type: MyType)
+  #
+  # attr_reader :type
+  # def initialize(type:)
+  #   @type = type
+  # end
+
+  # add arguments by type:
+  # argument :id, !types.ID
+
+  # Resolve function:
+  def call(obj, args, ctx)
+  end
+end
+RUBY
+
+    assert_file "app/graphql/functions/finders/find_record.rb", expected_content
+  end
 end

data/spec/generators/graphql/loader_generator_spec.rb

@@ -28,4 +28,28 @@ RUBY
 
     assert_file "app/graphql/loaders/record_loader.rb", expected_content
   end
+
+  test "it generates a namespaced loader by name" do
+    run_generator(["active_record::record_loader"])
+
+    expected_content = <<-RUBY
+class Loaders::ActiveRecord::RecordLoader < GraphQL::Batch::Loader
+  # Define `initialize` to store grouping arguments, eg
+  #
+  #     Loaders::ActiveRecord::RecordLoader.for(group).load(value)
+  #
+  # def initialize()
+  # end
+
+  # `keys` contains each key from `.load(key)`.
+  # Find the corresponding values, then
+  # call `fulfill(key, value)` or `fulfill(key, nil)`
+  # for each key.
+  def perform(keys)
+  end
+end
+RUBY
+
+    assert_file "app/graphql/loaders/active_record/record_loader.rb", expected_content
+  end
 end

data/spec/graphql/analysis/max_query_complexity_spec.rb

@@ -37,7 +37,7 @@ describe GraphQL::Analysis::MaxQueryComplexity do
       Dummy::Schema.max_complexity = nil
     end
     it "doesn't error" do
-      assert_equal nil, result["errors"]
+      assert_nil result["errors"]
     end
   end
 
@@ -46,7 +46,7 @@ describe GraphQL::Analysis::MaxQueryComplexity do
       Dummy::Schema.max_complexity = 99
     end
     it "doesn't error" do
-      assert_equal nil, result["errors"]
+      assert_nil result["errors"]
     end
   end
 
@@ -68,7 +68,7 @@ describe GraphQL::Analysis::MaxQueryComplexity do
     let(:result) { Dummy::Schema.execute(query_string, max_complexity: 10) }
 
     it "doesn't error" do
-      assert_equal nil, result["errors"]
+      assert_nil result["errors"]
     end
   end
 

data/spec/graphql/analysis/max_query_depth_spec.rb

@@ -39,7 +39,7 @@ describe GraphQL::Analysis::MaxQueryDepth do
     let(:result) { Dummy::Schema.execute(query_string, max_depth: 100) }
 
     it "obeys that max_depth" do
-      assert_equal nil, result["errors"]
+      assert_nil result["errors"]
     end
   end
 
@@ -49,7 +49,7 @@ describe GraphQL::Analysis::MaxQueryDepth do
     end
 
     it "doesn't add an error" do
-      assert_equal nil, result["errors"]
+      assert_nil result["errors"]
     end
   end
 
@@ -59,7 +59,7 @@ describe GraphQL::Analysis::MaxQueryDepth do
     end
 
     it "doesn't add an error message" do
-      assert_equal nil, result["errors"]
+      assert_nil result["errors"]
     end
   end
 

data/spec/graphql/base_type_spec.rb

@@ -28,6 +28,18 @@ describe GraphQL::BaseType do
     assert_equal ["Cheese"], Dummy::CheeseType.metadata[:class_names]
   end
 
+  describe "name" do
+    it "fails with a helpful message" do
+      error = assert_raises RuntimeError do
+        class BaseType < GraphQL::Schema::Object
+          name "KerkShine"
+        end
+      end
+
+      assert_equal error.message, "The new name override method is `graphql_name`, not `name`. Usage: graphql_name \"KerkShine\""
+    end
+  end
+
   describe "forwards-compat with new api" do
     let(:type_defn) { Dummy::CheeseType }
     it "responds to new methods" do

data/spec/graphql/boolean_type_spec.rb

@@ -13,9 +13,9 @@ describe GraphQL::BOOLEAN_TYPE do
     end
 
     it "rejects other types" do
-      assert_equal nil, coerce_input("true")
-      assert_equal nil, coerce_input(5.5)
-      assert_equal nil, coerce_input(nil)
+      assert_nil coerce_input("true")
+      assert_nil coerce_input(5.5)
+      assert_nil coerce_input(nil)
     end
   end
 end

data/spec/graphql/execution/execute_spec.rb

@@ -120,7 +120,7 @@ describe GraphQL::Execution::Execute do
       }
       GRAPHQL
 
-      assert_equal nil, res["data"]
+      assert_nil res["data"]
       assert_equal "👻", res["errors"].first["message"]
     end
 

data/spec/graphql/execution/instrumentation_spec.rb

@@ -0,0 +1,165 @@
+# frozen_string_literal: true
+require "spec_helper"
+
+describe GraphQL::Schema do
+  describe "instrumentation teardown bug" do
+    # This instrumenter records that it ran,
+    # or raises an error if instructed to do so
+    class InstrumenterError < StandardError
+      attr_reader :key
+      def initialize(key)
+        @key = key
+        super()
+      end
+    end
+
+    class LogInstrumenter
+      def before_query(unit_of_work)
+        run_hook(unit_of_work, "begin")
+      end
+
+      def after_query(unit_of_work)
+        run_hook(unit_of_work, "end")
+      end
+
+      alias :before_multiplex :before_query
+      alias :after_multiplex :after_query
+
+      private
+
+      def run_hook(unit_of_work, event_name)
+        unit_of_work.context[log_key(event_name)] = true
+        if unit_of_work.context[raise_key(event_name)]
+          raise InstrumenterError.new(log_key(event_name))
+        end
+      end
+
+      def log_key(event_name)
+        context_key("did_#{event_name}")
+      end
+
+      def raise_key(event_name)
+        context_key("should_raise_#{event_name}")
+      end
+
+      def context_key(suffix)
+        prefix = self.class.name.sub("Instrumenter", "").downcase
+        :"#{prefix}_instrumenter_#{suffix}"
+      end
+    end
+
+    class FirstInstrumenter < LogInstrumenter; end
+    class SecondInstrumenter < LogInstrumenter; end
+
+    let(:query_type) {
+      GraphQL::ObjectType.define do
+        name "Query"
+        field :int, types.Int do
+          argument :value, types.Int
+          resolve ->(obj, args, ctx) { args.value }
+        end
+      end
+    }
+
+    let(:schema) {
+      spec = self
+      GraphQL::Schema.define do
+        query(spec.query_type)
+        instrument(:query, FirstInstrumenter.new)
+        instrument(:query, SecondInstrumenter.new)
+      end
+    }
+
+    describe "query instrumenters" do
+      it "before_query of the 2nd instrumenter does not run but after_query does" do
+        context = {second_instrumenter_should_raise_begin: true}
+        assert_raises InstrumenterError do
+          schema.execute(" { int(value: 2) } ", context: context)
+        end
+        assert context[:first_instrumenter_did_begin]
+        assert context[:first_instrumenter_did_end]
+        assert context[:second_instrumenter_did_begin]
+        refute context[:second_instrumenter_did_end]
+      end
+
+      it "runs after_query even if a previous after_query raised an error" do
+        context = {second_instrumenter_should_raise_end: true}
+        err = assert_raises InstrumenterError do
+          schema.execute(" { int(value: 2) } ", context: context)
+        end
+        # The error came from the second instrumenter:
+        assert_equal :second_instrumenter_did_end, err.key
+        # But the first instrumenter still got a chance to teardown
+        assert context[:first_instrumenter_did_begin]
+        assert context[:first_instrumenter_did_end]
+        assert context[:second_instrumenter_did_begin]
+        assert context[:second_instrumenter_did_end]
+      end
+    end
+
+    describe "within a multiplex" do
+      let(:multiplex_schema) {
+        schema.redefine {
+          instrument(:multiplex, FirstInstrumenter.new)
+          instrument(:multiplex, SecondInstrumenter.new)
+        }
+      }
+
+      it "only runs after_multiplex if before_multiplex finished" do
+        multiplex_ctx = {second_instrumenter_should_raise_begin: true}
+        query_1_ctx = {}
+        query_2_ctx = {}
+        assert_raises InstrumenterError do
+          multiplex_schema.multiplex(
+            [
+              {query: "{int(value: 1)}", context: query_1_ctx},
+              {query: "{int(value: 2)}", context: query_2_ctx},
+            ],
+            context: multiplex_ctx
+          )
+        end
+
+        assert multiplex_ctx[:first_instrumenter_did_begin]
+        assert multiplex_ctx[:first_instrumenter_did_end]
+        assert multiplex_ctx[:second_instrumenter_did_begin]
+        refute multiplex_ctx[:second_instrumenter_did_end]
+        # No query instrumentation was run at all
+        assert_equal 0, query_1_ctx.size
+        assert_equal 0, query_2_ctx.size
+      end
+
+      it "does full and partial query runs" do
+        multiplex_ctx = {}
+        query_1_ctx = {}
+        query_2_ctx = {second_instrumenter_should_raise_begin: true}
+        assert_raises InstrumenterError do
+          multiplex_schema.multiplex(
+            [
+              { query: " { int(value: 2) } ", context: query_1_ctx },
+              { query: " { int(value: 2) } ", context: query_2_ctx },
+            ],
+            context: multiplex_ctx
+          )
+        end
+
+        # multiplex got a full run
+        assert multiplex_ctx[:first_instrumenter_did_begin]
+        assert multiplex_ctx[:first_instrumenter_did_end]
+        assert multiplex_ctx[:second_instrumenter_did_begin]
+        assert multiplex_ctx[:second_instrumenter_did_end]
+
+        # query 1 got a full run
+        assert query_1_ctx[:first_instrumenter_did_begin]
+        assert query_1_ctx[:first_instrumenter_did_end]
+        assert query_1_ctx[:second_instrumenter_did_begin]
+        assert query_1_ctx[:second_instrumenter_did_end]
+
+        # query 2 got a partial run
+        assert query_2_ctx[:first_instrumenter_did_begin]
+        assert query_2_ctx[:first_instrumenter_did_end]
+        assert query_2_ctx[:second_instrumenter_did_begin]
+        refute query_2_ctx[:second_instrumenter_did_end]
+      end
+    end
+  end
+end