graphql 1.7.6 → 1.8.0

data/spec/graphql/input_object_type_spec.rb

@@ -218,6 +218,19 @@ describe GraphQL::InputObjectType do
           assert_equal(expected, actual)
         end
       end
+
+      describe 'with invalid name' do
+        it 'raises the correct error' do
+          assert_raises(GraphQL::InvalidNameError) do
+            InvalidInputTest = GraphQL::InputObjectType.define do
+              name "Some::Invalid Name"
+            end
+
+            # Force evaluation
+            InvalidInputTest.name
+          end
+        end
+      end
     end
   end
 
@@ -251,7 +264,7 @@ describe GraphQL::InputObjectType do
       assert_equal 'Test', result['a']
 
       assert result.key?('b')
-      assert_equal nil, result['b']
+      assert_nil result['b']
 
       assert_equal "Test", result['c']
     end
@@ -264,7 +277,7 @@ describe GraphQL::InputObjectType do
       assert_equal 1, result['b']
 
       assert result.key?('c')
-      assert_equal nil, result['c']
+      assert_nil result['c']
     end
 
     it "omitted arguments are not returned" do

data/spec/graphql/int_type_spec.rb

@@ -9,8 +9,8 @@ describe GraphQL::INT_TYPE do
     end
 
     it "rejects other types" do
-      assert_equal nil, GraphQL::INT_TYPE.coerce_isolated_input("55")
-      assert_equal nil, GraphQL::INT_TYPE.coerce_isolated_input(true)
+      assert_nil GraphQL::INT_TYPE.coerce_isolated_input("55")
+      assert_nil GraphQL::INT_TYPE.coerce_isolated_input(true)
     end
   end
 end

data/spec/graphql/interface_type_spec.rb

@@ -92,6 +92,18 @@ describe GraphQL::InterfaceType do
       assert_equal 3, interface.fields.size
       assert_equal 4, interface_2.fields.size
     end
+
+    it "copies orphan types without affecting the original" do
+      interface = GraphQL::InterfaceType.define do
+        name "AInterface"
+        orphan_types [Dummy::HoneyType]
+      end
+
+      interface_2 = interface.dup
+      interface_2.orphan_types << Dummy::CheeseType
+      assert_equal 1, interface.orphan_types.size
+      assert_equal 2, interface_2.orphan_types.size
+    end
   end
 
   describe "#resolve_type" do

data/spec/graphql/internal_representation/rewrite_spec.rb

@@ -110,7 +110,7 @@ describe GraphQL::InternalRepresentation::Rewrite do
 
     it "groups selections by object types which they apply to" do
       doc = rewrite_result.operation_definitions["getPlant"]
-      assert_equal nil, doc.definition
+      assert_nil doc.definition
 
       plant_scoped_selection = doc.scoped_children[schema.types["Query"]]["plant"]
       assert_equal ["Fruit", "Nut", "Plant"], plant_scoped_selection.scoped_children.keys.map(&:name).sort
@@ -132,7 +132,7 @@ describe GraphQL::InternalRepresentation::Rewrite do
 
     it "tracks parent nodes" do
       doc = rewrite_result.operation_definitions["getPlant"]
-      assert_equal nil, doc.parent
+      assert_nil doc.parent
 
       plant_selection = doc.typed_children[schema.types["Query"]]["plant"]
       assert_equal doc, plant_selection.parent

data/spec/graphql/introspection/schema_type_spec.rb

@@ -35,8 +35,10 @@ describe GraphQL::Introspection::SchemaType do
             {"name"=>"fromSource"},
             {"name"=>"maybeNull"},
             {"name"=>"milk"},
+            {"name"=>"multipleErrorsOnNonNullableField"},
             {"name"=>"root"},
             {"name"=>"searchDairy"},
+            {"name"=>"tracingScalar"},
             {"name"=>"valueWithExecutionError"},
           ]
         },

data/spec/graphql/language/block_string_spec.rb

@@ -0,0 +1,70 @@
+# frozen_string_literal: true
+require "spec_helper"
+
+describe GraphQL::Language::BlockString do
+  describe "trimming whitespace" do
+    def trim_whitespace(str)
+      GraphQL::Language::BlockString.trim_whitespace(str)
+    end
+
+    it "matches the examples in graphql-js" do
+      # these are taken from:
+      # https://github.com/graphql/graphql-js/blob/36ec0e9d34666362ff0e2b2b18edeb98e3c9abee/src/language/__tests__/blockStringValue-test.js#L12
+      # A set of [before, after] pairs:
+      examples = [
+        [
+          # Removes common whitespace:
+          "
+          Hello,
+            World!
+
+          Yours,
+            GraphQL.
+          ",
+          "Hello,\n  World!\n\nYours,\n  GraphQL."
+        ],
+        [
+          # Removes leading and trailing newlines:
+          "
+
+          Hello,
+            World!
+
+          Yours,
+            GraphQL.
+
+          ",
+          "Hello,\n  World!\n\nYours,\n  GraphQL."
+        ],
+        [
+          # Removes blank lines (with whitespace _and_ newlines:)
+          "\n    \n
+          Hello,
+            World!
+
+          Yours,
+            GraphQL.
+
+          \n     \n",
+          "Hello,\n  World!\n\nYours,\n  GraphQL."
+        ],
+        [
+          # Retains indentation from the first line
+          "    Hello,\n      World!\n\n    Yours,\n      GraphQL.",
+          "    Hello,\n  World!\n\nYours,\n  GraphQL.",
+        ],
+        [
+          # Doesn't alter trailing spaces
+          "\n    \n    Hello,     \n      World!   \n\n    Yours,     \n      GraphQL.  ",
+          "Hello,     \n  World!   \n\nYours,     \n  GraphQL.  ",
+
+        ],
+      ]
+
+      examples.each_with_index do |(before, after), idx|
+        transformed_str = trim_whitespace(before)
+        assert_equal(after, transformed_str, "Example ##{idx + 1}")
+      end
+    end
+  end
+end