graphql 1.4.5 → 1.5.3

data/spec/graphql/schema/loader_spec.rb

@@ -103,6 +103,7 @@ describe GraphQL::Schema::Loader do
         argument :id, !types.ID
         argument :varied, variant_input_type, default_value: { id: "123", int: 234, float: 2.3, enum: :foo, sub: [{ string: "str" }] }
         argument :variedWithNull, variant_input_type_with_nulls, default_value: { id: nil, int: nil, float: nil, enum: nil, sub: nil, bigint: nil, bool: nil }
+        argument :enum, choice_type, default_value: :foo
       end
 
       field :content do

data/spec/graphql/schema/printer_spec.rb

@@ -499,7 +499,7 @@ input Varied {
 }
 SCHEMA
 
-    only_filter = -> (member, ctx) {
+    only_filter = ->(member, ctx) {
       case member
       when GraphQL::ScalarType
         true
@@ -583,7 +583,7 @@ type Subscription {
 }
 SCHEMA
 
-    except_filter = -> (member, ctx) {
+    except_filter = ->(member, ctx) {
       ctx[:names].include?(member.name) || (member.respond_to?(:deprecation_reason) && member.deprecation_reason)
     }
 

data/spec/graphql/schema/validation_spec.rb

@@ -2,11 +2,22 @@
 require "spec_helper"
 
 describe GraphQL::Schema::Validation do
+  def integer_class_name
+    RUBY_VERSION >= "2.4.0" ? "Integer" : "Fixnum"
+  end
+
   def assert_error_includes(object, error_substring)
     validation_error = GraphQL::Schema::Validation.validate(object)
     assert_includes validation_error, error_substring
   end
 
+  def refute_error_includes(object, *error_substrings)
+    validation_error = GraphQL::Schema::Validation.validate(object)
+    error_substrings.each do |substr|
+      refute_includes(validation_error, substr)
+    end
+  end
+
   def assert_validation_warns(object, warning)
     assert_output("", warning + "\n") { GraphQL::Schema::Validation.validate(object) }
   end
@@ -102,18 +113,11 @@ describe GraphQL::Schema::Validation do
     end
 
     it "requires String-or-nil description" do
-      assert_error_includes wrongly_described_type, "must return String or NilClass, not Fixnum"
+      assert_error_includes wrongly_described_type, "must return String or NilClass, not #{integer_class_name}"
     end
   end
 
   describe "validating ObjectTypes" do
-    let(:invalid_interfaces_object) {
-      GraphQL::ObjectType.define do
-        name "InvalidInterfaces"
-        interfaces(55)
-      end
-    }
-
     let(:invalid_interface_member_object) {
       GraphQL::ObjectType.define do
         name "InvalidInterfaceMember"
@@ -129,13 +133,78 @@ describe GraphQL::Schema::Validation do
     }
 
     it "requires an Array for interfaces" do
-      assert_error_includes invalid_interfaces_object, "must be an Array of GraphQL::InterfaceType, not a Fixnum"
       assert_error_includes invalid_interface_member_object, "must contain GraphQL::InterfaceType, not Symbol"
     end
 
     it "validates the fields" do
       assert_error_includes invalid_field_object, "must return GraphQL::BaseType, not Symbol"
     end
+
+    it "requires interfaces to be implemented" do
+      iface_1 = GraphQL::InterfaceType.define do
+        name "Interface1"
+        field :field_1, types.String
+        field :field_2, types.Int
+      end
+
+      iface_2 = GraphQL::InterfaceType.define do
+        name "Interface2"
+        field :field_3, types.String do
+          argument :arg_1, types.Boolean
+        end
+        field :field_4, types.Int
+      end
+
+      iface_3 = GraphQL::InterfaceType.define do
+        name "Interface3"
+        field :field_5, types.String do
+          argument :arg_2, types.Float
+        end
+        field :field_6, types.Int do
+          argument :arg_3, types.Float
+        end
+        field :field_7, types.ID
+        field :field_8, !types[iface_2]
+        field :field_9, !types[iface_2]
+      end
+
+      obj_type = GraphQL::ObjectType.define do
+        name "Object1"
+        implements iface_1, inherit: true
+        implements iface_2, iface_3
+        field :field_2, types.Int do
+          # Acceptable extra optional argument:
+          argument :arg_0_extra, types.String
+          # Unacceptable extra required argument:
+          argument :arg_0_extra_2, !types.String
+        end
+        # Correct:
+        field :field_3, types.String do
+          argument :arg_1, types.Boolean
+        end
+        # Wrong return type:
+        field :field_4, types.Float
+        # Wrong argument type:
+        field :field_5, types.String do
+          argument :arg_2, types.Int
+        end
+        # Missing argument
+        field :field_6, types.Int
+        # Missing altogether:
+        # field :field_7
+        # Valid subtype:
+        field :field_8, !types[!iface_2]
+        # Invalid subtype:
+        field :field_9, types[iface_2]
+      end
+
+      assert_error_includes(obj_type, '"arg_0_extra_2" is not accepted by Interface1.field_2 but required by Object1.field_2')
+      assert_error_includes(obj_type, '"field_4" is required by Interface2 to return Int but Object1.field_4 returns Float')
+      assert_error_includes(obj_type, '"arg_2" is required by Interface3.field_5 to accept Float but Object1.field_5 accepts Int for "arg_2"')
+      assert_error_includes(obj_type, '"field_7" is required by Interface3 but not implemented by Object1')
+      assert_error_includes(obj_type, '"field_9" is required by Interface3 to return [Interface2]! but Object1.field_9 returns [Interface2]')
+      refute_error_includes(obj_type, "field_1", "field_3", "field_8")
+    end
   end
 
   describe "validating UnionTypes" do
@@ -163,7 +232,7 @@ describe GraphQL::Schema::Validation do
     }
 
     it "requires an array of ObjectTypes for possible_types" do
-      assert_error_includes non_array_union, "must be an Array of GraphQL::ObjectType, not a Fixnum"
+      assert_error_includes non_array_union, "must be an Array of GraphQL::ObjectType, not a #{integer_class_name}"
 
       assert_error_includes non_object_type_union, "must contain GraphQL::ObjectType, not GraphQL::InterfaceType"
     end
@@ -193,7 +262,7 @@ describe GraphQL::Schema::Validation do
     }
 
     it "requires {String => Argument} arguments" do
-      assert_error_includes invalid_arguments_input, "map String => GraphQL::Argument, not Fixnum => Symbol"
+      assert_error_includes invalid_arguments_input, "map String => GraphQL::Argument, not #{integer_class_name} => Symbol"
     end
 
     it "applies validation to its member Arguments" do

data/spec/graphql/schema/warden_spec.rb

@@ -107,7 +107,7 @@ module MaskHelpers
     query QueryType
     mutation MutationType
     subscription MutationType
-    resolve_type -> (obj, ctx) { PhonemeType }
+    resolve_type ->(obj, ctx) { PhonemeType }
   end
 
   module Data
@@ -208,7 +208,7 @@ describe GraphQL::Schema::Warden do
 
   describe "hiding fields" do
     let(:mask) {
-      -> (member, ctx) { member.metadata[:hidden_field] || member.metadata[:hidden_type] }
+      ->(member, ctx) { member.metadata[:hidden_field] || member.metadata[:hidden_type] }
     }
 
     it "causes validation errors" do
@@ -254,7 +254,7 @@ describe GraphQL::Schema::Warden do
 
   describe "hiding types" do
     let(:whitelist) {
-      -> (member, ctx) { !member.metadata[:hidden_type] }
+      ->(member, ctx) { !member.metadata[:hidden_type] }
     }
 
     it "hides types from introspection" do
@@ -340,7 +340,7 @@ describe GraphQL::Schema::Warden do
 
     describe "hiding an abstract type" do
       let(:mask) {
-        -> (member, ctx) { member.metadata[:hidden_abstract_type] }
+        ->(member, ctx) { member.metadata[:hidden_abstract_type] }
       }
 
       it "isn't present in a type's interfaces" do
@@ -362,7 +362,7 @@ describe GraphQL::Schema::Warden do
 
   describe "hiding arguments" do
     let(:mask) {
-      -> (member, ctx) { member.metadata[:hidden_argument] || member.metadata[:hidden_input_type] }
+      ->(member, ctx) { member.metadata[:hidden_argument] || member.metadata[:hidden_input_type] }
     }
 
     it "isn't present in introspection" do
@@ -398,7 +398,7 @@ describe GraphQL::Schema::Warden do
 
   describe "hidding input type arguments" do
     let(:mask) {
-      -> (member, ctx) { member.metadata[:hidden_input_field] }
+      ->(member, ctx) { member.metadata[:hidden_input_field] }
     }
 
     it "isn't present in introspection" do
@@ -447,7 +447,7 @@ describe GraphQL::Schema::Warden do
 
   describe "hidding input types" do
     let(:mask) {
-      -> (member, ctx) { member.metadata[:hidden_input_object_type] }
+      ->(member, ctx) { member.metadata[:hidden_input_object_type] }
     }
 
     it "isn't present in introspection" do
@@ -492,7 +492,7 @@ describe GraphQL::Schema::Warden do
 
   describe "hiding enum values" do
     let(:mask) {
-      -> (member, ctx) { member.metadata[:hidden_enum_value] }
+      ->(member, ctx) { member.metadata[:hidden_enum_value] }
     }
 
     it "isn't present in introspection" do
@@ -570,7 +570,7 @@ describe GraphQL::Schema::Warden do
 
   describe "default_mask" do
     let(:default_mask) {
-      -> (member, ctx) { member.metadata[:hidden_enum_value] }
+      ->(member, ctx) { member.metadata[:hidden_enum_value] }
     }
     let(:schema) {
       MaskHelpers::Schema.redefine(default_mask: default_mask)
@@ -584,7 +584,7 @@ describe GraphQL::Schema::Warden do
     }
 
     it "is additive with query filters" do
-      query_except = -> (member, ctx) { member.metadata[:hidden_input_object_type] }
+      query_except = ->(member, ctx) { member.metadata[:hidden_input_object_type] }
       res = schema.execute(query_str, except: query_except)
       assert_equal nil, res["data"]["input"]
       enum_values = res["data"]["enum"]["enumValues"].map { |v| v["name"] }

data/spec/graphql/schema_spec.rb

@@ -236,7 +236,7 @@ type Query {
         name "Query"
         field :int, types.Int do
           argument :value, types.Int
-          resolve -> (obj, args, ctx) { args[:value] == 13 ? raise("13 is unlucky") : args[:value] }
+          resolve ->(obj, args, ctx) { args[:value] == 13 ? raise("13 is unlucky") : args[:value] }
         end
       end
     }
@@ -319,4 +319,21 @@ type Query {
       refute_equal schema_2.middleware, schema.middleware
     end
   end
+
+  describe "#validate" do
+    it "returns errors on the query string" do
+      errors = schema.validate("{ cheese(id: 1) { flavor flavor: id } }")
+      assert_equal 1, errors.length
+      assert_equal "Field 'flavor' has a field conflict: flavor or id?", errors.first.message
+
+      errors = schema.validate("{ cheese(id: 1) { flavor id } }")
+      assert_equal [], errors
+    end
+
+    it "accepts a list of custom rules" do
+      custom_rules = GraphQL::StaticValidation::ALL_RULES - [GraphQL::StaticValidation::FragmentsAreNamed]
+      errors = schema.validate("fragment on Cheese { id }", rules: custom_rules)
+      assert_equal([], errors)
+    end
+  end
 end

data/spec/graphql/static_validation/rules/argument_literals_are_compatible_spec.rb

@@ -67,6 +67,22 @@ describe GraphQL::StaticValidation::ArgumentLiteralsAreCompatible do
     assert_includes(errors, fragment_error)
   end
 
+  describe "using input objects for enums" do
+    let(:query_string) { <<-GRAPHQL
+      {
+        yakSource: searchDairy(product: [{source: {a: 1, b: 2}, fatContent: 1.1}]) { __typename }
+      }
+    GRAPHQL
+    }
+
+    it "adds an error" do
+      # TODO:
+      # It's annoying that this error cascades up, there should only be one:
+      assert_equal 2, errors.length
+    end
+  end
+
+
   describe "null value" do
     describe "nullable arg" do
       let(:schema) {

data/spec/graphql/static_validation/rules/fields_will_merge_spec.rb

@@ -231,7 +231,7 @@ describe GraphQL::StaticValidation::FieldsWillMerge do
     |}
 
     it "fails rule" do
-      assert_equal ["Field 'name' has a field conflict: nickname or name?"], error_messages
+      assert_equal ["Field 'name' has a field conflict: name or nickname?"], error_messages
     end
   end
 
@@ -317,8 +317,8 @@ describe GraphQL::StaticValidation::FieldsWillMerge do
 
     it "fails rule" do
       assert_equal [
+        "Field 'name' has a field conflict: name or nickname?",
         "Field 'x' has a field conflict: name or nickname?",
-        "Field 'name' has a field conflict: nickname or name?",
       ], error_messages
     end
   end
@@ -337,7 +337,17 @@ describe GraphQL::StaticValidation::FieldsWillMerge do
     |}
 
     it "fails rule" do
-      assert_equal ["Field 'x' has a field conflict: name or nickname?"], error_messages
+      expected_errors = [
+        {
+          "message"=>"Field 'x' has a field conflict: name or nickname?",
+          "locations"=>[
+            {"line"=>4, "column"=>11},
+            {"line"=>8, "column"=>11}
+          ],
+          "fields"=>[]
+        }
+      ]
+      assert_equal expected_errors, errors
     end
   end
 
@@ -388,6 +398,43 @@ describe GraphQL::StaticValidation::FieldsWillMerge do
     end
   end
 
+  describe "same aliases allowed on non-overlapping fields" do
+    let(:query_string) {%|
+      {
+        pet {
+          ... on Dog {
+            name
+          }
+          ... on Cat {
+            name: nickname
+          }
+        }
+      }
+    |}
+
+    it "passes rule" do
+      assert_equal [], errors
+    end
+  end
+
+  describe "allows different args where no conflict is possible" do
+    let(:query_string) {%|
+      {
+        pet {
+          ... on Dog {
+            name(surname: true)
+          }
+          ... on Cat {
+            name
+          }
+        }
+      }
+    |}
+
+    it "passes rule" do
+      assert_equal [], errors
+    end
+  end
   describe "return types must be unambiguous" do
     let(:schema) {
       GraphQL::Schema.from_definition(%|

data/spec/graphql/static_validation/rules/fragment_names_are_unique_spec.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+require "spec_helper"
+
+describe GraphQL::StaticValidation::FragmentNamesAreUnique do
+  include StaticValidationHelpers
+
+  let(:query_string) {"
+    query {
+      cheese(id: 1) {
+        ... frag1
+      }
+    }
+
+    fragment frag1 on Cheese { id }
+    fragment frag1 on Cheese { id }
+  "}
+
+  it "requires unique fragment names" do
+    assert_equal(1, errors.length)
+    fragment_def_error = {
+      "message"=>"Fragment name \"frag1\" must be unique",
+      "locations"=>[{"line"=>8, "column"=>5}, {"line"=>9, "column"=>5}],
+      "fields"=>[],
+    }
+    assert_includes(errors, fragment_def_error)
+  end
+end

data/spec/graphql/static_validation/rules/fragments_are_finite_spec.rb

@@ -61,4 +61,61 @@ describe GraphQL::StaticValidation::FragmentsAreFinite do
       assert_equal("Fragment frag2 was used, but not defined", errors.first["message"])
     end
   end
+
+  describe "a duplicate fragment name with a loop" do
+    let(:query_string) {%|
+      {
+        cheese(id: 1) { ... frag1 }
+      }
+      fragment frag1 on Cheese { id }
+      fragment frag1 on Cheese { ...frag1 }
+    |}
+
+    it "detects the loop" do
+      assert_equal 2, errors.length
+      assert_equal("Fragment frag1 contains an infinite loop", errors[0]["message"])
+      assert_equal("Fragment name \"frag1\" must be unique", errors[1]["message"])
+    end
+  end
+
+  describe "a duplicate operation name with a loop" do
+    let(:query_string) {%|
+      fragment frag1 on Cheese { ...frag1 }
+
+      query frag1 {
+        cheese(id: 1) {
+          ... frag1
+        }
+      }
+    |}
+
+    it "detects the loop" do
+      assert_equal 1, errors.length
+      assert_equal("Fragment frag1 contains an infinite loop", errors[0]["message"])
+    end
+  end
+
+  describe "several duplicate operation names with a loop" do
+    let(:query_string) {%|
+      query frag1 {
+        cheese(id: 1) {
+          id
+        }
+      }
+
+      fragment frag1 on Cheese { ...frag1 }
+
+      query frag1 {
+        cheese(id: 1) {
+          ... frag1
+        }
+      }
+    |}
+
+    it "detects the loop" do
+      assert_equal 2, errors.length
+      assert_equal("Fragment frag1 contains an infinite loop", errors[0]["message"])
+      assert_equal("Operation name \"frag1\" must be unique", errors[1]["message"])
+    end
+  end
 end