graphql 1.2.6 → 1.3.0

data/spec/graphql/execution/typecast_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Execution::Typecast do

data/spec/graphql/execution_error_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::ExecutionError do

data/spec/graphql/field_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Field do
@@ -164,5 +165,21 @@ describe GraphQL::Field do
       assert_equal 1, int_field.arguments.size
       assert_equal 2, int_field_2.arguments.size
     end
+
+    it "copies metadata, even out-of-bounds assignments" do
+      int_field = GraphQL::Field.define do
+        metadata(:a, 1)
+        argument :value, types.Int
+      end
+      int_field.metadata[:b] = 2
+
+      int_field_2 = int_field.redefine do
+        metadata(:c, 3)
+        argument :value_2, types.Int
+      end
+
+      assert_equal({a: 1, b: 2}, int_field.metadata)
+      assert_equal({a: 1, b: 2, c: 3}, int_field_2.metadata)
+    end
   end
 end

data/spec/graphql/float_type_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::FLOAT_TYPE do

data/spec/graphql/id_type_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::ID_TYPE do

data/spec/graphql/input_object_type_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::InputObjectType do
@@ -252,4 +253,13 @@ describe GraphQL::InputObjectType do
       end
     end
   end
+
+  describe "#dup" do
+    it "shallow-copies internal state" do
+      input_object_2 = input_object.dup
+      input_object_2.arguments["nonsense"] = GraphQL::Argument.define(name: "int", type: GraphQL::INT_TYPE)
+      assert_equal 4, input_object.arguments.size
+      assert_equal 5, input_object_2.arguments.size
+    end
+  end
 end

data/spec/graphql/int_type_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::INT_TYPE do

data/spec/graphql/interface_type_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::InterfaceType do
@@ -83,4 +84,13 @@ describe GraphQL::InterfaceType do
       end
     end
   end
+
+  describe "#dup" do
+    it "copies the fields without altering the original" do
+      interface_2 = interface.dup
+      interface_2.fields["extra"] = GraphQL::Field.define(name: "extra", type: GraphQL::BOOLEAN_TYPE)
+      assert_equal 3, interface.fields.size
+      assert_equal 4, interface_2.fields.size
+    end
+  end
 end

data/spec/graphql/internal_representation/rewrite_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::InternalRepresentation::Rewrite do

data/spec/graphql/introspection/directive_type_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Introspection::DirectiveType do

data/spec/graphql/introspection/input_value_type_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 

data/spec/graphql/introspection/introspection_query_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe "GraphQL::Introspection::INTROSPECTION_QUERY" do

data/spec/graphql/introspection/schema_type_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Introspection::SchemaType do

data/spec/graphql/introspection/type_type_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Introspection::TypeType do

data/spec/graphql/language/definition_slice_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Language::DefinitionSlice do

data/spec/graphql/language/equality_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Language::Nodes::AbstractNode do

data/spec/graphql/language/generation_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Language::Generation do

data/spec/graphql/language/lexer_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Language::Lexer do

data/spec/graphql/language/nodes_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Language::Nodes::AbstractNode do

data/spec/graphql/language/parser_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Language::Parser do

data/spec/graphql/language/visitor_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Language::Visitor do

data/spec/graphql/list_type_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::ListType do

data/spec/graphql/non_null_type_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::NonNullType do
@@ -27,5 +28,21 @@ describe GraphQL::NonNullType do
       assert_equal(nil, result["data"])
       assert_equal([{"message"=>"Cannot return null for non-nullable field DeepNonNull.nonNullInt"}], result["errors"])
     end
+
+    describe "when type_error is configured to raise an error" do
+      it "crashes query execution" do
+        raise_schema = DummySchema.redefine {
+          type_error ->(type_err, ctx) {
+            raise type_err
+          }
+        }
+        query_string = %|{ cow { name cantBeNullButIs } }|
+        err = assert_raises(GraphQL::InvalidNullError) { raise_schema.execute(query_string) }
+        assert_equal("Cannot return null for non-nullable field Cow.cantBeNullButIs", err.message)
+        assert_equal("Cow", err.parent_type.name)
+        assert_equal("cantBeNullButIs", err.field.name)
+        assert_equal(nil, err.value)
+      end
+    end
   end
 end

data/spec/graphql/object_type_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::ObjectType do
@@ -45,4 +46,22 @@ describe GraphQL::ObjectType do
       assert_equal(field_from_iface.property, nil)
     end
   end
+
+  describe "#dup" do
+    it "copies fields and interfaces without altering the original" do
+      type.interfaces # load the internal cache
+      type_2 = type.dup
+
+      # IRL, use `+=`, not this
+      # (this tests the internal cache)
+      type_2.interfaces << type
+
+      type_2.fields["nonsense"] = GraphQL::Field.define(name: "nonsense", type: type)
+
+      assert_equal 3, type.interfaces.size
+      assert_equal 4, type_2.interfaces.size
+      assert_equal 8, type.fields.size
+      assert_equal 9, type_2.fields.size
+    end
+  end
 end

data/spec/graphql/query/arguments_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Query::Arguments do

data/spec/graphql/query/context_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Query::Context do

data/spec/graphql/query/executor_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Query::Executor do

data/spec/graphql/query/serial_execution/value_resolution_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Query::SerialExecution::ValueResolution do

data/spec/graphql/query/variables_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Query::Variables do

data/spec/graphql/query_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Query do
@@ -122,6 +123,24 @@ describe GraphQL::Query do
         assert_equal(expected, result)
       end
     end
+
+    describe "after_query hooks" do
+      module Instrumenter
+        ERROR_LOG = []
+        def self.before_query(q); end;
+        def self.after_query(q); ERROR_LOG << q.result["errors"]; end;
+      end
+
+      let(:schema) {
+        DummySchema.redefine {
+          instrument(:query, Instrumenter)
+        }
+      }
+      it "can access #result" do
+        result
+        assert_equal [nil], Instrumenter::ERROR_LOG
+      end
+    end
   end
 
   it "fails to execute a query containing a type definition" do
@@ -377,4 +396,10 @@ describe GraphQL::Query do
       end
     end
   end
+
+  describe "#provided_variables" do
+    it "returns the originally-provided object" do
+      assert_equal({"cheeseId" => 2}, query.provided_variables)
+    end
+  end
 end

data/spec/graphql/relay/array_connection_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe GraphQL::Relay::ArrayConnection do

data/spec/graphql/relay/base_connection_spec.rb

@@ -1,9 +1,8 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe GraphQL::Relay::BaseConnection do
-
   describe ".connection_for_nodes" do
-
     it "resolves most specific connection type" do
       class SpecialArray < Array; end
       class SpecialArrayConnection < GraphQL::Relay::BaseConnection; end
@@ -11,9 +10,39 @@ describe GraphQL::Relay::BaseConnection do
 
       nodes = SpecialArray.new
 
-      GraphQL::Relay::BaseConnection.connection_for_nodes(nodes)
-        .must_equal SpecialArrayConnection
+      conn_class = GraphQL::Relay::BaseConnection.connection_for_nodes(nodes)
+      assert_equal conn_class, SpecialArrayConnection
+    end
+  end
+
+  describe "#encode / #decode" do
+    module ReverseEncoder
+      module_function
+      def encode(str, nonce: false); str.reverse; end
+      def decode(str, nonce: false); str.reverse; end
+    end
+
+    let(:schema) { OpenStruct.new(cursor_encoder: ReverseEncoder) }
+    let(:context) { OpenStruct.new(schema: schema) }
+
+    it "Uses the schema's encoder" do
+      conn = GraphQL::Relay::BaseConnection.new([], {}, context: context)
+
+      assert_equal "1/nosreP", conn.encode("Person/1")
+      assert_equal "Person/1", conn.decode("1/nosreP")
     end
 
+    it "defaults to base64" do
+      conn = GraphQL::Relay::BaseConnection.new([], {}, context: nil)
+
+      assert_equal "UGVyc29uLzE=", conn.encode("Person/1")
+      assert_equal "Person/1", conn.decode("UGVyc29uLzE=")
+    end
+
+    it "handles trimmed base64" do
+      conn = GraphQL::Relay::BaseConnection.new([], {}, context: nil)
+
+      assert_equal "Person/1", conn.decode("UGVyc29uLzE")
+    end
   end
 end

data/spec/graphql/relay/connection_field_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Relay::ConnectionField do

data/spec/graphql/relay/connection_type_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Relay::ConnectionType do

data/spec/graphql/relay/mutation_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe GraphQL::Relay::Mutation do
@@ -43,6 +44,11 @@ describe GraphQL::Relay::Mutation do
     assert_equal(expected, result)
   end
 
+  it "supports lazy resolution" do
+    result = star_wars_query(query_string, "clientMutationId" => "1234", "shipName" => "Slave II")
+    assert_equal "Slave II", result["data"]["introduceShip"]["shipEdge"]["node"]["name"]
+  end
+
   it "returns the result & clientMutationId" do
     result = star_wars_query(query_string, "clientMutationId" => "1234")
     expected = {"data" => {

data/spec/graphql/relay/node_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Relay::Node do

data/spec/graphql/relay/page_info_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Relay::PageInfo do

data/spec/graphql/relay/relation_connection_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 describe GraphQL::Relay::RelationConnection do

data/spec/graphql/scalar_type_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::ScalarType do

data/spec/graphql/schema/build_from_definition_spec.rb

@@ -1,9 +1,14 @@
+# frozen_string_literal: true
 require "spec_helper"
 
 describe GraphQL::Schema::BuildFromDefinition do
+  # Build a schema from `definition` and assert that it
+  # prints out the same string.
+  # Then return the built schema.
   def build_schema_and_compare_output(definition)
     built_schema = GraphQL::Schema.from_definition(definition)
     assert_equal definition, GraphQL::Schema::Printer.print_schema(built_schema)
+    built_schema
   end
 
   describe '.build' do
@@ -345,7 +350,10 @@ type Root {
 }
       SCHEMA
 
-      build_schema_and_compare_output(schema.chop)
+      built_schema = build_schema_and_compare_output(schema.chop)
+      custom_scalar = built_schema.types["CustomScalar"]
+      assert_equal true, custom_scalar.valid_input?("anything", PermissiveWarden)
+      assert_equal true, custom_scalar.valid_input?(12345, PermissiveWarden)
     end
 
     it 'supports input object' do