graphql 1.12.14 → 1.12.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 74f73ae15eae0c31b63558b5d038091006422534ebee13cafe25b0fe07d1349a
-  data.tar.gz: c6f454d12ae887420e98f4e0563d74d7bedfa350d6b6dcd66beedd43e9cd5f5a
+  metadata.gz: f858de6eaac686676c159e87ae2f200b6c69b9b6c1da8e7459595b49f4f44e7a
+  data.tar.gz: afd8686f7897896919bef91076285f0763e49076759036352bd212d41c1bb47f
 SHA512:
-  metadata.gz: 333b8424cc0c6cf3caccf68b27a66bd555311255a83fd336b8ccd569edf6ab4020bb3459b7ce1c0ab26542f003cd12e7c3d312d8ea45c6c2d52fe81a94471536
-  data.tar.gz: e31d1e33bd7da992d866749f53fe05e417ac27ee6488d0bd7d5cf0e7316e57c6bec6154f496e09eb87eb830b8540eb1ecebde1384f50d7deb41244fdc07dc5b9
+  metadata.gz: 6774f423bdf61cf07d842ca00f517068139a86da2d6e0d6b7e15e7970aaf5ce1b07e58d78c0a13a1ccf0a8db87c48d4061e151ca42bc21731e26958ef96ad922
+  data.tar.gz: 31ca7b94bacf8df5a8c27c0e3c2f831362970e49c65c8b0a284095c1bd392af26347cecc78e60dc91ff4581a9a3d55dc08204eb0230ed641f2907e009a4f7f3e

data/lib/graphql/analysis/ast/field_usage.rb

@@ -7,6 +7,7 @@ module GraphQL
           super
           @used_fields = Set.new
           @used_deprecated_fields = Set.new
+          @used_deprecated_arguments = Set.new
         end
 
         def on_leave_field(node, parent, visitor)
@@ -14,14 +15,36 @@ module GraphQL
           field = "#{visitor.parent_type_definition.graphql_name}.#{field_defn.graphql_name}"
           @used_fields << field
           @used_deprecated_fields << field if field_defn.deprecation_reason
+
+          extract_deprecated_arguments(visitor.query.arguments_for(node, visitor.field_definition).argument_values)
         end
 
         def result
           {
             used_fields: @used_fields.to_a,
-            used_deprecated_fields: @used_deprecated_fields.to_a
+            used_deprecated_fields: @used_deprecated_fields.to_a,
+            used_deprecated_arguments: @used_deprecated_arguments.to_a,
           }
         end
+
+        private
+
+        def extract_deprecated_arguments(argument_values)
+          argument_values.each_pair do |_argument_name, argument|
+            if argument.definition.deprecation_reason
+              @used_deprecated_arguments << argument.definition.path
+            end
+
+            if argument.definition.type.kind.input_object?
+              extract_deprecated_arguments(argument.value.arguments.argument_values)
+            elsif argument.definition.type.list?
+              argument
+                .value
+                .select { |value| value.respond_to?(:arguments) }
+                .each { |value| extract_deprecated_arguments(value.arguments.argument_values) }
+            end
+          end
+        end
       end
     end
   end

data/lib/graphql/subscriptions/action_cable_subscriptions.rb

@@ -95,6 +95,14 @@ module GraphQL
         @action_cable = action_cable
         @action_cable_coder = action_cable_coder
         @serializer = serializer
+        @serialize_with_context = case @serializer.method(:load).arity
+        when 1
+          false
+        when 2
+          true
+        else
+          raise ArgumentError, "#{@serializer} must repond to `.load` accepting one or two arguments"
+        end
         @transmit_ns = namespace
         super
       end
@@ -154,7 +162,7 @@ module GraphQL
               # so just run it once, then deliver the result to every subscriber
               first_event = events.first
               first_subscription_id = first_event.context.fetch(:subscription_id)
-              object ||= @serializer.load(message)
+              object ||= load_action_cable_message(message, first_event.context)
               result = execute_update(first_subscription_id, first_event, object)
               # Having calculated the result _once_, send the same payload to all subscribers
               events.each do |event|
@@ -167,6 +175,18 @@ module GraphQL
         end
       end
 
+      # This is called to turn an ActionCable-broadcasted string (JSON)
+      # into a query-ready application object.
+      # @param message [String] n ActionCable-broadcasted string (JSON)
+      # @param context [GraphQL::Query::Context] the context of the first event for a given subscription fingerprint
+      def load_action_cable_message(message, context)
+        if @serialize_with_context
+          @serializer.load(message, context)
+        else
+          @serializer.load(message)
+        end
+      end
+
       # Return the query from "storage" (in memory)
       def read_subscription(subscription_id)
         query = @subscriptions[subscription_id]

data/lib/graphql/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module GraphQL
-  VERSION = "1.12.14"
+  VERSION = "1.12.15"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphql
 version: !ruby/object:Gem::Version
-  version: 1.12.14
+  version: 1.12.15
 platform: ruby
 authors:
 - Robert Mosolgo
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-07-22 00:00:00.000000000 Z
+date: 2021-08-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: benchmark-ips
@@ -318,8 +318,6 @@ files:
 - lib/graphql/compatibility/query_parser_specification/parse_error_specification.rb
 - lib/graphql/compatibility/query_parser_specification/query_assertions.rb
 - lib/graphql/compatibility/schema_parser_specification.rb
-- lib/graphql/cop/nullability.rb
-- lib/graphql/cop/resolve_methods.rb
 - lib/graphql/dataloader.rb
 - lib/graphql/dataloader/null_dataloader.rb
 - lib/graphql/dataloader/request.rb

data/lib/graphql/cop/nullability.rb

@@ -1,28 +0,0 @@
-require "rubocop"
-
-module GraphQL
-  module Cop
-    class Nullability < RuboCop::Cop::Base
-      extend AutoCorrector
-
-      NEEDLESS_NULL_FALSE = <<-ERR
-`null: false` is the default, it can be removed.
-ERR
-
-      NEEDLESS_REQUIRED_TRUE = <<-ERR
-`required: true` is the default, it can be removed.
-ERR
-
-      def on_send(node)
-        recv, method_name, args = *node
-        if recv.nil?
-          if method_name == :field
-
-          elsif method_name == :argument
-
-          end
-        end
-      end
-    end
-  end
-end

data/lib/graphql/cop/resolve_methods.rb

@@ -1,28 +0,0 @@
-require "rubocop"
-
-module GraphQL
-  module Cop
-    class ResolveMethods < RuboCop::Cop::Base
-      extend AutoCorrector
-
-      NEEDLESS_NULL_FALSE = <<-ERR
-`null: false` is the default, it can be removed.
-ERR
-
-      NEEDLESS_REQUIRED_TRUE = <<-ERR
-`required: true` is the default, it can be removed.
-ERR
-
-      def on_send(node)
-        recv, method_name, args = *node
-        if recv.nil?
-          if method_name == :field
-
-          elsif method_name == :argument
-
-          end
-        end
-      end
-    end
-  end
-end