graphql 1.1.0 → 1.2.0

data/spec/graphql/static_validation/rules/variable_default_values_are_correctly_typed_spec.rb

@@ -43,4 +43,82 @@ describe GraphQL::StaticValidation::VariableDefaultValuesAreCorrectlyTyped do
     ]
     assert_equal(expected, errors)
   end
+
+  describe "null default values" do
+    describe "variables with valid default null values" do
+      let(:schema) {
+        GraphQL::Schema.from_definition(%|
+          type Query {
+            field(a: Int, b: String, c: ComplexInput): Int
+          }
+
+          input ComplexInput {
+            requiredField: Boolean!
+            intField: Int
+          }
+        |)
+      }
+
+      let(:query_string) {%|
+        query getCheese(
+          $a: Int = null,
+          $b: String = null,
+          $c: ComplexInput = { requiredField: true, intField: null }
+        ) {
+          field(a: $a, b: $b, c: $c)
+        }
+      |}
+
+      it "finds no errors" do
+        assert_equal [], errors
+      end
+    end
+
+    describe "variables with invalid default null values" do
+      let(:schema) {
+        GraphQL::Schema.from_definition(%|
+          type Query {
+            field(a: Int!, b: String!, c: ComplexInput): Int
+          }
+
+          input ComplexInput {
+            requiredField: Boolean!
+            intField: Int
+          }
+        |)
+      }
+
+      let(:query_string) {%|
+        query getCheese(
+          $a: Int! = null,
+          $b: String! = null,
+          $c: ComplexInput = { requiredField: null, intField: null }
+        ) {
+          field(a: $a, b: $b, c: $c)
+        }
+      |}
+
+      it "finds errors" do
+        expected = [
+          {
+            "message"=>"Non-null variable $a can't have a default value",
+            "locations"=>[{"line"=>3, "column"=>11}],
+            "fields"=>["query getCheese"]
+          },
+          {
+            "message"=>"Non-null variable $b can't have a default value",
+            "locations"=>[{"line"=>4, "column"=>11}],
+            "fields"=>["query getCheese"]
+          },
+          {
+            "message"=>"Default value for $c doesn't match type ComplexInput",
+            "locations"=>[{"line"=>5, "column"=>11}],
+            "fields"=>["query getCheese"]
+          }
+        ]
+
+        assert_equal expected, errors
+      end
+    end
+  end
 end

data/spec/support/dairy_app.rb

@@ -16,6 +16,7 @@ EdibleInterface = GraphQL::InterfaceType.define do
   description "Something you can eat, yum"
   field :fatContent, !types.Float, "Percentage which is fat"
   field :origin, !types.String, "Place the edible comes from"
+  field :selfAsEdible, EdibleInterface, resolve: ->(o, a, c) { o }
 end
 
 AnimalProductInterface = GraphQL::InterfaceType.define do
@@ -297,6 +298,14 @@ DairyAppQueryType = GraphQL::ObjectType.define do
     resolve ->(t, a, c) { raise(GraphQL::ExecutionError, "There was an execution error") }
   end
 
+  field :valueWithExecutionError do
+    type !GraphQL::INT_TYPE
+    resolve ->(t, a, c) {
+      c.add_error(GraphQL::ExecutionError.new("Could not fetch latest value"))
+      return 0
+    }
+  end
+
   # To test possibly-null fields
   field :maybeNull, MaybeNullType do
     resolve ->(t, a, c) { OpenStruct.new(cheese: nil) }

data/spec/support/minimum_input_object.rb

@@ -13,4 +13,8 @@ class MinimumInputObject
   def [](key)
     @values[key]
   end
+
+  def key?(key)
+    @values.key?(key)
+  end
 end

data/spec/support/star_wars_schema.rb

@@ -147,7 +147,7 @@ IntroduceShipMutation = GraphQL::Relay::Mutation.define do
   description "Add a ship to this faction"
 
   # Nested under `input` in the query:
-  input_field :shipName, !types.String
+  input_field :shipName, types.String
   input_field :factionId, !types.ID
 
   # Result may have access to these fields:

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphql
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Robert Mosolgo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-01 00:00:00.000000000 Z
+date: 2016-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: codeclimate-test-reporter
@@ -306,6 +306,7 @@ files:
 - lib/graphql/internal_representation.rb
 - lib/graphql/internal_representation/node.rb
 - lib/graphql/internal_representation/rewrite.rb
+- lib/graphql/internal_representation/selections.rb
 - lib/graphql/introspection.rb
 - lib/graphql/introspection/arguments_field.rb
 - lib/graphql/introspection/directive_location_enum.rb
@@ -348,7 +349,6 @@ files:
 - lib/graphql/query/input_validation_result.rb
 - lib/graphql/query/literal_input.rb
 - lib/graphql/query/serial_execution.rb
-- lib/graphql/query/serial_execution/execution_context.rb
 - lib/graphql/query/serial_execution/field_resolution.rb
 - lib/graphql/query/serial_execution/operation_resolution.rb
 - lib/graphql/query/serial_execution/selection_resolution.rb
@@ -432,6 +432,7 @@ files:
 - spec/graphql/compatibility/execution_specification_spec.rb
 - spec/graphql/compatibility/query_parser_specification_spec.rb
 - spec/graphql/compatibility/schema_parser_specification_spec.rb
+- spec/graphql/define/assign_argument_spec.rb
 - spec/graphql/define/instance_definable_spec.rb
 - spec/graphql/directive_spec.rb
 - spec/graphql/enum_type_spec.rb
@@ -462,7 +463,6 @@ files:
 - spec/graphql/query/arguments_spec.rb
 - spec/graphql/query/context_spec.rb
 - spec/graphql/query/executor_spec.rb
-- spec/graphql/query/serial_execution/execution_context_spec.rb
 - spec/graphql/query/serial_execution/value_resolution_spec.rb
 - spec/graphql/query/variables_spec.rb
 - spec/graphql/query_spec.rb
@@ -556,6 +556,7 @@ test_files:
 - spec/graphql/compatibility/execution_specification_spec.rb
 - spec/graphql/compatibility/query_parser_specification_spec.rb
 - spec/graphql/compatibility/schema_parser_specification_spec.rb
+- spec/graphql/define/assign_argument_spec.rb
 - spec/graphql/define/instance_definable_spec.rb
 - spec/graphql/directive_spec.rb
 - spec/graphql/enum_type_spec.rb
@@ -586,7 +587,6 @@ test_files:
 - spec/graphql/query/arguments_spec.rb
 - spec/graphql/query/context_spec.rb
 - spec/graphql/query/executor_spec.rb
-- spec/graphql/query/serial_execution/execution_context_spec.rb
 - spec/graphql/query/serial_execution/value_resolution_spec.rb
 - spec/graphql/query/variables_spec.rb
 - spec/graphql/query_spec.rb

data/lib/graphql/query/serial_execution/execution_context.rb

@@ -1,37 +0,0 @@
-module GraphQL
-  class Query
-    class SerialExecution
-      class ExecutionContext
-        attr_reader :query, :schema, :strategy
-
-        def initialize(query, strategy)
-          @query = query
-          @schema = query.schema
-          @strategy = strategy
-          @warden = query.warden
-        end
-
-        def get_type(type_name)
-          @warden.get_type(type_name)
-        end
-
-        def get_fragment(name)
-          @query.fragments[name]
-        end
-
-        def get_field(type, irep_node)
-          # fall back for dynamic fields (eg __typename)
-          irep_node.definitions[type] || @warden.get_field(type, irep_node.definition_name) || raise("No field found on #{type.name} for '#{irep_node.definition_name}' (#{irep_node.ast_node.name})")
-        end
-
-        def possible_types(type)
-          @warden.possible_types(type)
-        end
-
-        def add_error(err)
-          @query.context.errors << err
-        end
-      end
-    end
-  end
-end

data/spec/graphql/query/serial_execution/execution_context_spec.rb

@@ -1,54 +0,0 @@
-require "spec_helper"
-
-describe GraphQL::Query::SerialExecution::ExecutionContext do
-  let(:query_string) { %|
-    query getFlavor($cheeseId: Int!) {
-      brie: cheese(id: 1)   { ...cheeseFields, taste: flavor }
-    }
-    fragment cheeseFields on Cheese { flavor }
-  |}
-  let(:operation_name) { nil }
-  let(:query_variables) { {"cheeseId" => 2} }
-  let(:schema) { DummySchema }
-  let(:query) { GraphQL::Query.new(
-    schema,
-    query_string,
-    variables: query_variables,
-    operation_name: operation_name,
-  )}
-  let(:execution_context) {
-    GraphQL::Query::SerialExecution::ExecutionContext.new(query, nil)
-  }
-
-  describe "add_error" do
-    let(:err) { StandardError.new("test") }
-    let(:expected) { [err] }
-
-    it "adds an error on the query context" do
-      execution_context.add_error(err)
-      assert_equal(expected, query.context.errors)
-    end
-  end
-
-  describe "get_type" do
-    it "returns the respective type from the schema" do
-      type = execution_context.get_type("Dairy")
-      assert_equal(DairyType, type)
-    end
-  end
-
-  describe "get_field" do
-    it "returns the respective field from the schema" do
-      irep_node = OpenStruct.new(definition_name: "cheese", definitions: {DairyType => DairyType.fields["cheese"]})
-      field = execution_context.get_field(DairyType, irep_node)
-      assert_equal("cheese", field.name)
-    end
-  end
-
-  describe "get_fragment" do
-    it "returns a fragment on the query by name" do
-      fragment = execution_context.get_fragment("cheeseFields")
-      assert_equal("cheeseFields", fragment.name)
-    end
-  end
-end