graphql 0.19.4 → 1.0.0

data/lib/graphql/static_validation/type_stack.rb

@@ -57,7 +57,7 @@ module GraphQL
       module FragmentWithTypeStrategy
         def push(stack, node)
           object_type = if node.type
-            stack.schema.types.fetch(node.type, nil)
+            stack.schema.types.fetch(node.type.name, nil)
           else
             stack.object_types.last
           end
@@ -86,7 +86,7 @@ module GraphQL
         extend FragmentWithTypeStrategy
         module_function
         def push_path_member(stack, node)
-          stack.path.push("...#{node.type ? " on #{node.type}" : ""}")
+          stack.path.push("...#{node.type ? " on #{node.type.to_query_string}" : ""}")
         end
       end
 

data/lib/graphql/static_validation/validator.rb

@@ -33,7 +33,7 @@ module GraphQL
         context.visitor.visit
 
         {
-          errors: context.errors.map(&:to_h),
+          errors: context.errors,
           # If there were errors, the irep is garbage
           irep: context.errors.none? ? rewrite.operations : nil,
         }

data/lib/graphql/unresolved_type_error.rb

@@ -8,9 +8,4 @@ module GraphQL
       super(message)
     end
   end
-
-  class ObjectType
-    # @deprecated Use {GraphQL::UnresolvedTypeError} instead
-    UnresolvedTypeError = GraphQL::UnresolvedTypeError
-  end
 end

data/lib/graphql/version.rb

@@ -1,3 +1,3 @@
 module GraphQL
-  VERSION = "0.19.4"
+  VERSION = "1.0.0"
 end

data/readme.md

@@ -24,63 +24,9 @@ gem 'graphql'
 $ bundle install
 ```
 
-## Overview
+## Getting Started
 
-#### Declare types & build a schema
-
-```ruby
-# Declare a type...
-PostType = GraphQL::ObjectType.define do
-  name "Post"
-  description "A blog post"
-
-  field :id, !types.ID
-  field :title, !types.String
-  field :body, !types.String
-  field :comments, types[!CommentType]
-end
-
-# ...and a query root
-QueryType = GraphQL::ObjectType.define do
-  name "Query"
-  description "The query root of this schema"
-
-  field :post do
-    type PostType
-    argument :id, !types.ID
-    resolve ->(obj, args, ctx) { Post.find(args["id"]) }
-  end
-end
-
-# Then create your schema
-Schema = GraphQL::Schema.define do
-  query QueryType
-  max_depth 8
-end
-```
-
-#### Execute queries
-
-Execute GraphQL queries on a given schema, from a query string.
-
-```ruby
-result_hash = Schema.execute(query_string)
-# {
-#   "data" => {
-#     "post" => {
-#        "id" => 1,
-#        "title" => "GraphQL is nice"
-#     }
-#   }
-# }
-```
-
-#### Use with Relay
-
-If you're building a backend for [Relay](http://facebook.github.io/relay/), you'll need:
-
-- A JSON dump of the schema, which you can get by sending [`GraphQL::Introspection::INTROSPECTION_QUERY`](https://github.com/rmosolgo/graphql-ruby/blob/master/lib/graphql/introspection/introspection_query.rb)
-- Relay-specific helpers for GraphQL, see [`GraphQL::Relay`](http://www.rubydoc.info/github/rmosolgo/graphql-ruby/file/guides/relay.md)
+See "Getting Started" on the [website](https://rmosolgo.github.io/graphql-ruby/) or on [GitHub](https://github.com/rmosolgo/graphql-ruby/blob/master/guides/index.md)
 
 ## Goals
 
@@ -94,23 +40,7 @@ If you're building a backend for [Relay](http://facebook.github.io/relay/), you'
 - __Report bugs__ by posting a description, full stack trace, and all relevant code in a  [GitHub issue](https://github.com/rmosolgo/graphql-ruby/issues).
 - __Features & patches__ are welcome! Consider discussing it in an [issue](https://github.com/rmosolgo/graphql-ruby/issues) or in the [#ruby channel on Slack](https://graphql-slack.herokuapp.com/) to make sure we're on the same page.
 - __Run the tests__ with `rake test` or start up guard with `bundle exec guard`.
-- __Build the site__ with `rake site:serve`, then visit `localhost:4000`.
-
-## Related Projects
-
-### Code
-
-- `graphql-ruby` + Rails demo ([src](https://github.com/rmosolgo/graphql-ruby-demo) / [heroku](http://graphql-ruby-demo.herokuapp.com))
-- [`graphql-batch`](https://github.com/shopify/graphql-batch), a batched query execution strategy
-- [`graphql-libgraphqlparser`](https://github.com/rmosolgo/graphql-libgraphqlparser-ruby), bindings to [libgraphqlparser](https://github.com/graphql/libgraphqlparser), a C-level parser.
-
-### Blog Posts
-
--  Building a blog in GraphQL and Relay on Rails [Introduction](https://medium.com/@gauravtiwari/graphql-and-relay-on-rails-getting-started-955a49d251de), [Part 1]( https://medium.com/@gauravtiwari/graphql-and-relay-on-rails-creating-types-and-schema-b3f9b232ccfc), [Part 2](https://medium.com/@gauravtiwari/graphql-and-relay-on-rails-first-relay-powered-react-component-cb3f9ee95eca)
-- https://medium.com/@khor/relay-facebook-on-rails-8b4af2057152
-- https://blog.jacobwgillespie.com/from-rest-to-graphql-b4e95e94c26b#.4cjtklrwt
-- http://mgiroux.me/2015/getting-started-with-rails-graphql-relay/
-- http://mgiroux.me/2015/uploading-files-using-relay-with-rails/
+- __Build the site__ with `rake site:serve`, then visit `http://localhost:4000/graphql-ruby/`.
 
 ## To Do
 
@@ -141,10 +71,4 @@ If you're building a backend for [Relay](http://facebook.github.io/relay/), you'
   - Renaming fragments from local names to unique names
 - Support AST subclasses? This would be hard, I think classes are used as hash keys in many places.
 - Support object deep-copy (schema, type, field, argument)? To support multiple schemas based on the same types. ([discussion](https://github.com/rmosolgo/graphql-ruby/issues/269))
-- Improve the website
-  - Feature the logo in the header
-  - Split `readme.md` into `index.md` (a homepage with code samples) and a technical readme (how to install, link to homepage)
-  - Move "Related projects" to a guide
-  - Revisit guides, maybe split them into smaller, more specific pages
-  - Put guide titles into the `<title />`
 - Document encrypted & versioned cursors

data/spec/graphql/language/parser_spec.rb

@@ -25,7 +25,7 @@ describe GraphQL::Language::Parser do
           assert fragment.is_a?(GraphQL::Language::Nodes::FragmentDefinition)
           assert_equal nil, fragment.name
           assert_equal 1, fragment.selections.length
-          assert_equal "NestedType", fragment.type
+          assert_equal "NestedType", fragment.type.name
           assert_equal 1, fragment.directives.length
           assert_equal [2, 7], fragment.position
         end

data/spec/graphql/query/serial_execution/value_resolution_spec.rb

@@ -27,8 +27,6 @@ describe GraphQL::Query::SerialExecution::ValueResolution do
       name "OtherObject"
     end
 
-    OtherObject = Class.new
-
     query_root = GraphQL::ObjectType.define do
       name "Query"
       field :tomorrow, day_of_week_enum do
@@ -39,7 +37,7 @@ describe GraphQL::Query::SerialExecution::ValueResolution do
         resolve ->(obj, args, ctx) { Object.new }
       end
       field :resolvesToWrongTypeInterface, interface do
-        resolve ->(obj, args, ctx) { OtherObject.new }
+        resolve ->(obj, args, ctx) { :something }
       end
     end
 
@@ -47,7 +45,7 @@ describe GraphQL::Query::SerialExecution::ValueResolution do
       query(query_root)
       orphan_types [some_object]
       resolve_type ->(obj, ctx) do
-        if obj.is_a?(OtherObject)
+        if obj.is_a?(Symbol)
           other_object
         else
           nil
@@ -86,7 +84,7 @@ describe GraphQL::Query::SerialExecution::ValueResolution do
       |}
 
       it "raises an error" do
-        err = assert_raises(GraphQL::ObjectType::UnresolvedTypeError) { result }
+        err = assert_raises(GraphQL::UnresolvedTypeError) { result }
         expected_message = %|The value from "resolvesToNilInterface" on "Query" could not be resolved to "SomeInterface". (Received: nil, Expected: [SomeObject])|
         assert_equal expected_message, err.message
       end
@@ -100,7 +98,7 @@ describe GraphQL::Query::SerialExecution::ValueResolution do
       |}
 
       it "raises an error" do
-        err = assert_raises(GraphQL::ObjectType::UnresolvedTypeError) { result }
+        err = assert_raises(GraphQL::UnresolvedTypeError) { result }
         expected_message = %|The value from "resolvesToWrongTypeInterface" on "Query" could not be resolved to "SomeInterface". (Received: OtherObject, Expected: [SomeObject])|
         assert_equal expected_message, err.message
       end

data/spec/graphql/relay/base_connection_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+describe GraphQL::Relay::BaseConnection do
+
+  describe ".connection_for_nodes" do
+
+    it "resolves most specific connection type" do
+      class SpecialArray < Array; end
+      class SpecialArrayConnection < GraphQL::Relay::BaseConnection; end
+      GraphQL::Relay::BaseConnection.register_connection_implementation(SpecialArray, SpecialArrayConnection)
+
+      nodes = SpecialArray.new
+
+      GraphQL::Relay::BaseConnection.connection_for_nodes(nodes)
+        .must_equal SpecialArrayConnection
+    end
+
+  end
+end

data/spec/graphql/relay/mutation_spec.rb

@@ -72,7 +72,7 @@ describe GraphQL::Relay::Mutation do
       GraphQL::Relay::Mutation.define do
         name "CustomReturnTypeTest"
         return_type custom_type
-        resolve ->(input, ctx) {
+        resolve ->(obj, input, ctx) {
           OpenStruct.new(name: "Custom Return Type Test")
         }
       end

data/spec/graphql/relay/relation_connection_spec.rb

@@ -361,4 +361,11 @@ describe GraphQL::Relay::RelationConnection do
       assert_includes err.message, "item not found"
     end
   end
+
+  it "is chosen for a relation" do
+    relation = Base.where(faction_id: 1)
+    assert relation.is_a?(ActiveRecord::Relation)
+    connection = GraphQL::Relay::BaseConnection.connection_for_nodes(relation)
+    assert_equal GraphQL::Relay::RelationConnection, connection
+  end
 end

data/spec/graphql/schema/printer_spec.rb

@@ -83,7 +83,7 @@ describe GraphQL::Schema::Printer do
 
       field :post do
         type post_type
-        argument :id, !types.ID
+        argument :id, !types.ID, 'Post ID'
         argument :varied, variant_input_type, default_value: { id: "123", int: 234, float: 2.3, enum: :foo, sub: [{ string: "str" }] }
         resolve ->(obj, args, ctx) { Post.find(args["id"]) }
       end
@@ -440,7 +440,11 @@ type Post {
 
 # The query root of this schema
 type Query {
-  post(id: ID!, varied: Varied = {id: \"123\", int: 234, float: 2.3, enum: FOO, sub: [{string: \"str\"}]}): Post
+  post(
+    # Post ID
+    id: ID!
+    varied: Varied = {id: \"123\", int: 234, float: 2.3, enum: FOO, sub: [{string: \"str\"}]}
+  ): Post
 }
 
 # Test

data/spec/graphql/schema/timeout_middleware_spec.rb

@@ -166,7 +166,7 @@ describe GraphQL::Schema::TimeoutMiddleware do
   describe "with a custom block" do
     let(:timeout_middleware) {
       GraphQL::Schema::TimeoutMiddleware.new(max_seconds: max_seconds) do |err, query|
-        raise("Query timed out after 2s: #{query.class.name}")
+        raise("Query timed out after 2s: #{query.class.name} on #{query.context.ast_node.alias}")
       end
     }
     let(:query_string) {%|
@@ -180,7 +180,8 @@ describe GraphQL::Schema::TimeoutMiddleware do
     |}
 
     it "calls the block" do
-      assert_raises(RuntimeError) { result }
+      err = assert_raises(RuntimeError) { result }
+      assert_equal "Query timed out after 2s: GraphQL::Query on d", err.message
     end
   end
 end

data/spec/graphql/static_validation/validator_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe GraphQL::StaticValidation::Validator do
   let(:validator) { GraphQL::StaticValidation::Validator.new(schema: DummySchema) }
   let(:query) { GraphQL::Query.new(DummySchema, query_string) }
-  let(:errors) { validator.validate(query)[:errors] }
+  let(:errors) { validator.validate(query)[:errors].map(&:to_h) }
 
 
   describe "validation order" do

data/spec/spec_helper.rb

@@ -8,9 +8,7 @@ require "benchmark"
 require "minitest/autorun"
 require "minitest/focus"
 require "minitest/reporters"
-require "pry"
-require 'pry-stack_explorer'
-Minitest::Reporters.use! Minitest::Reporters::SpecReporter.new
+Minitest::Reporters.use! Minitest::Reporters::DefaultReporter.new(color: true)
 
 Minitest::Spec.make_my_diffs_pretty!
 

data/spec/support/static_validation_helpers.rb

@@ -14,7 +14,7 @@ module StaticValidationHelpers
     target_schema = schema
     validator = GraphQL::StaticValidation::Validator.new(schema: target_schema)
     query = GraphQL::Query.new(target_schema, query_string)
-    validator.validate(query)[:errors]
+    validator.validate(query)[:errors].map(&:to_h)
   end
 
   def error_messages

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphql
 version: !ruby/object:Gem::Version
-  version: 0.19.4
+  version: 1.0.0
 platform: ruby
 authors:
 - Robert Mosolgo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-18 00:00:00.000000000 Z
+date: 2016-10-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: codeclimate-test-reporter
@@ -24,34 +24,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.4'
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.10'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.10'
-- !ruby/object:Gem::Dependency
-  name: pry-stack_explorer
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
@@ -276,20 +248,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: html-proofer
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: A GraphQL server implementation for Ruby. Includes schema definition,
   query parsing, static validation, type definition, and query execution.
 email:
@@ -298,6 +256,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".yardopts"
 - MIT-LICENSE
 - lib/graphql.rb
 - lib/graphql/analysis.rb
@@ -497,6 +456,7 @@ files:
 - spec/graphql/query/variables_spec.rb
 - spec/graphql/query_spec.rb
 - spec/graphql/relay/array_connection_spec.rb
+- spec/graphql/relay/base_connection_spec.rb
 - spec/graphql/relay/connection_field_spec.rb
 - spec/graphql/relay/connection_type_spec.rb
 - spec/graphql/relay/mutation_spec.rb
@@ -615,6 +575,7 @@ test_files:
 - spec/graphql/query/variables_spec.rb
 - spec/graphql/query_spec.rb
 - spec/graphql/relay/array_connection_spec.rb
+- spec/graphql/relay/base_connection_spec.rb
 - spec/graphql/relay/connection_field_spec.rb
 - spec/graphql/relay/connection_type_spec.rb
 - spec/graphql/relay/mutation_spec.rb