graphql 0.19.0 → 0.19.1

data/spec/graphql/schema/loader_spec.rb

@@ -106,7 +106,12 @@ describe GraphQL::Schema::Loader do
       field :ping, field: ping_mutation.field
     end
 
-    GraphQL::Schema.define(query: query_root, mutation: mutation_root, orphan_types: [audio_type, video_type])
+    GraphQL::Schema.define(
+      query: query_root,
+      mutation: mutation_root,
+      orphan_types: [audio_type, video_type],
+      resolve_type: :pass,
+    )
   }
 
   let(:schema_json) {

data/spec/graphql/schema/printer_spec.rb

@@ -63,7 +63,7 @@ describe GraphQL::Schema::Printer do
       end
     end
 
-    GraphQL::Schema.define(query: query_root)
+    GraphQL::Schema.define(query: query_root, resolve_type: :pass)
   }
 
   describe ".print_introspection_schema" do

data/spec/graphql/schema_spec.rb

@@ -47,6 +47,25 @@ describe GraphQL::Schema do
         }
       end
     end
+
+    describe "when a schema is defined with abstract types, but no resolve type hook" do
+      it "raises not implemented" do
+        interface = GraphQL::InterfaceType.define do
+          name "SomeInterface"
+        end
+
+        query_type = GraphQL::ObjectType.define do
+          name "Query"
+          field :something, interface
+        end
+
+        assert_raises(NotImplementedError) {
+          GraphQL::Schema.define do
+            query(query_type)
+          end
+        }
+      end
+    end
   end
 
   describe "object_from_id" do
@@ -57,6 +76,27 @@ describe GraphQL::Schema do
         }
       end
     end
+
+    describe "when a schema is defined with a relay ID field, but no hook" do
+      it "raises not implemented" do
+        thing_type = GraphQL::ObjectType.define do
+          name "Thing"
+          global_id_field :id
+        end
+
+        query_type = GraphQL::ObjectType.define do
+          name "Query"
+          field :thing, thing_type
+        end
+
+        assert_raises(NotImplementedError) {
+          GraphQL::Schema.define do
+            query(query_type)
+            resolve_type -> (obj, ctx) { :whatever }
+          end
+        }
+      end
+    end
   end
 
   describe "id_from_object" do
@@ -67,5 +107,21 @@ describe GraphQL::Schema do
         }
       end
     end
+
+    describe "when a schema is defined with a node field, but no hook" do
+      it "raises not implemented" do
+        query_type = GraphQL::ObjectType.define do
+          name "Query"
+          field :node, GraphQL::Relay::Node.field
+        end
+
+        assert_raises(NotImplementedError) {
+          GraphQL::Schema.define do
+            query(query_type)
+            resolve_type -> (obj, ctx) { :whatever }
+          end
+        }
+      end
+    end
   end
 end

data/spec/graphql/static_validation/rules/mutation_root_exists_spec.rb

@@ -15,7 +15,7 @@ describe GraphQL::StaticValidation::MutationRootExists do
   |}
 
   let(:schema) {
-    query_root = GraphQL::Field.define do
+    query_root = GraphQL::ObjectType.define do
       name "Query"
       description "Query root of the system"
     end

data/spec/graphql/static_validation/rules/subscription_root_exists_spec.rb

@@ -10,7 +10,7 @@ describe GraphQL::StaticValidation::SubscriptionRootExists do
   |}
 
   let(:schema) {
-    query_root = GraphQL::Field.define do
+    query_root = GraphQL::ObjectType.define do
       name "Query"
       description "Query root of the system"
     end

data/spec/support/dairy_app.rb

@@ -9,11 +9,6 @@ LocalProductInterface = GraphQL::InterfaceType.define do
   name "LocalProduct"
   description "Something that comes from somewhere"
   field :origin, !types.String, "Place the thing comes from"
-  # This is a "bug" in the dummy app:
-  # it should actually check the incoming object to determine the type.
-  # But this is here so we can check _where_ misbehaving resolve_type
-  # functions wreak their havoc.
-  resolve_type -> (o, c) { MilkType }
 end
 
 EdibleInterface = GraphQL::InterfaceType.define do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphql
 version: !ruby/object:Gem::Version
-  version: 0.19.0
+  version: 0.19.1
 platform: ruby
 authors:
 - Robert Mosolgo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-30 00:00:00.000000000 Z
+date: 2016-10-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: codeclimate-test-reporter
@@ -435,6 +435,7 @@ files:
 - lib/graphql/string_type.rb
 - lib/graphql/type_kinds.rb
 - lib/graphql/union_type.rb
+- lib/graphql/unresolved_type_error.rb
 - lib/graphql/version.rb
 - readme.md
 - spec/graphql/analysis/analyze_query_spec.rb