graphql 0.18.14 → 0.18.15

data/spec/graphql/execution_error_spec.rb

@@ -18,6 +18,28 @@ describe GraphQL::ExecutionError do
         }
         flavor
       }
+      allDairy {
+        ... on Cheese {
+          flavor
+        }
+        ... on Milk {
+          source
+          executionError
+        }
+      }
+      dairy {
+        milks {
+          source
+          executionError
+          allDairy {
+            __typename
+            ... on Milk {
+              origin
+              executionError
+            }
+          }
+        }
+      }
       executionError
     }
 
@@ -38,20 +60,58 @@ describe GraphQL::ExecutionError do
             },
             "flavor" => "Brie",
             },
+            "allDairy" => [
+              { "flavor" => "Brie" },
+              { "flavor" => "Gouda" },
+              { "flavor" => "Manchego" },
+              { "source" => "COW", "executionError" => nil }
+            ],
+            "dairy" => {
+              "milks" => [
+                {
+                  "source" => "COW",
+                  "executionError" => nil,
+                  "allDairy" => [
+                    { "__typename" => "Cheese" },
+                    { "__typename" => "Cheese" },
+                    { "__typename" => "Cheese" },
+                    { "__typename" => "Milk", "origin" => "Antiquity", "executionError" => nil }
+                  ]
+                }
+              ]
+            },
             "executionError" => nil,
           },
           "errors"=>[
             {
               "message"=>"No cheeses are made from Yak milk!",
-              "locations"=>[{"line"=>5, "column"=>9}]
+              "locations"=>[{"line"=>5, "column"=>9}],
+              "path"=>["cheese", "error1"]
             },
             {
               "message"=>"No cheeses are made from Yak milk!",
-              "locations"=>[{"line"=>8, "column"=>9}]
+              "locations"=>[{"line"=>8, "column"=>9}],
+              "path"=>["cheese", "error2"]
+            },
+            {
+              "message"=>"There was an execution error",
+              "locations"=>[{"line"=>22, "column"=>11}],
+              "path"=>["allDairy", 3, "executionError"]
+            },
+            {
+              "message"=>"There was an execution error",
+              "locations"=>[{"line"=>28, "column"=>11}],
+              "path"=>["dairy", "milks", 0, "executionError"]
+            },
+            {
+              "message"=>"There was an execution error",
+              "locations"=>[{"line"=>33, "column"=>15}],
+              "path"=>["dairy", "milks", 0, "allDairy", 3, "executionError"]
             },
             {
               "message"=>"There was an execution error",
-              "locations"=>[{"line"=>16, "column"=>7}]
+              "locations"=>[{"line"=>38, "column"=>7}],
+              "path"=>["executionError"]
             },
           ]
         }

data/spec/graphql/introspection/type_type_spec.rb

@@ -41,6 +41,8 @@ describe GraphQL::Introspection::TypeType do
           {"name"=>"LocalProduct"},
         ],
         "fields"=>[
+          {"type"=>{"name"=>"List", "ofType"=>{"name"=>"DairyProduct"}}},
+          {"type"=>{"name"=>"String", "ofType"=>nil}},
           {"type"=>{"name"=>"Non-Null", "ofType"=>{"name"=>"Float"}}},
           {"type"=>{"name"=>"List", "ofType"=>{"name"=>"String"}}},
           {"type"=>{"name"=>"Non-Null", "ofType"=>{"name"=>"ID"}}},

data/spec/graphql/language/generation_spec.rb

@@ -10,7 +10,7 @@ describe GraphQL::Language::Generation do
         ...moreNestedFields @skip(if: $skipNested)
       }
       ... on OtherType @include(unless: false) {
-        field(arg: [{ key: "value", anotherKey: 0.9, anotherAnotherKey: WHATEVER }])
+        field(arg: [{key: "value", anotherKey: 0.9, anotherAnotherKey: WHATEVER}])
         anotherField
       }
       ... {
@@ -31,7 +31,7 @@ describe GraphQL::Language::Generation do
     describe "inputs" do
       let(:query_string) {%|
         query {
-          field(int: 3, float: 4.7e-24, bool: false, string: "☀︎🏆\\n escaped \\" unicode ¶ /", enum: ENUM_NAME, array: [7, 8, 9], object: { a: [1, 2, 3], b: { c: "4" } }, unicode_bom: "\xef\xbb\xbfquery")
+          field(int: 3, float: 4.7e-24, bool: false, string: "☀︎🏆\\n escaped \\" unicode ¶ /", enum: ENUM_NAME, array: [7, 8, 9], object: {a: [1, 2, 3], b: {c: "4"}}, unicode_bom: "\xef\xbb\xbfquery")
         }
       |}
 
@@ -41,15 +41,63 @@ describe GraphQL::Language::Generation do
     end
 
     describe "schema" do
-      let(:query_string) {%|
+      # From: https://github.com/graphql/graphql-js/blob/a725499b155285c2e33647a93393c82689b20b0f/src/language/__tests__/schema-kitchen-sink.graphql
+      let(:query_string) {<<-schema
         schema {
-          query: Query
+          query: QueryType
+          mutation: MutationType
         }
 
-        type Query {
-          field: String!
+        type Foo implements Bar {
+          one: Type
+          two(argument: InputType!): Type
+          three(argument: InputType, other: String): Int
+          four(argument: String = "string"): String
+          five(argument: [String] = ["string", "string"]): String
+          six(argument: InputType = {key: "value"}): Type
         }
-      |}
+
+        type AnnotatedObject @onObject(arg: "value") {
+          annotatedField(arg: Type = "default" @onArg): Type @onField
+        }
+
+        interface Bar {
+          one: Type
+          four(argument: String = "string"): String
+        }
+
+        interface AnnotatedInterface @onInterface {
+          annotatedField(arg: Type @onArg): Type @onField
+        }
+
+        union Feed = Story | Article | Advert
+
+        union AnnotatedUnion @onUnion = A | B
+
+        scalar CustomScalar
+
+        scalar AnnotatedScalar @onScalar
+
+        enum Site {
+          DESKTOP
+          MOBILE
+        }
+
+        enum AnnotatedEnum @onEnum {
+          ANNOTATED_VALUE @onEnumValue
+          OTHER_VALUE
+        }
+
+        input InputType {
+          key: String!
+          answer: Int = 42
+        }
+
+        input AnnotatedInput @onInputObjectType {
+          annotatedField: Type @onField
+        }
+      schema
+      }
 
       it "generate" do
         assert_equal query_string.gsub(/^        /, "").strip, document.to_query_string

data/spec/graphql/query/executor_spec.rb

@@ -143,7 +143,8 @@ describe GraphQL::Query::Executor do
           "errors" => [
             {
               "message" => "BOOM",
-              "locations" => [ { "line" => 1, "column" => 28 } ]
+              "locations" => [ { "line" => 1, "column" => 28 } ],
+              "path" => ["noMilk", "cow", "cantBeNullButRaisesExecutionError"]
             }
           ]
         }
@@ -167,7 +168,8 @@ describe GraphQL::Query::Executor do
           "errors"=>[
             {
               "message"=>"Error was handled!",
-              "locations" => [{"line"=>1, "column"=>17}]
+              "locations" => [{"line"=>1, "column"=>17}],
+              "path"=>["noMilk", "error"]
             }
           ]
         }

data/spec/graphql/schema/catchall_middleware_spec.rb

@@ -22,6 +22,7 @@ describe GraphQL::Schema::CatchallMiddleware do
           {
             "message"=>"Internal error",
             "locations"=>[{"line"=>1, "column"=>17}],
+            "path"=>["noMilk", "error"]
           },
         ]
       }

data/spec/graphql/schema/printer_spec.rb

@@ -176,7 +176,7 @@ type Post {
 }
 
 type Query {
-  post(id: ID!, varied: Varied = { id: \"123\", int: 234, float: 2.3, enum: FOO, sub: [{ string: \"str\" }] }): Post
+  post(id: ID!, varied: Varied = {id: \"123\", int: 234, float: 2.3, enum: FOO, sub: [{string: \"str\"}]}): Post
 }
 
 input Sub {

data/spec/graphql/schema/timeout_middleware_spec.rb

@@ -64,11 +64,13 @@ describe GraphQL::Schema::TimeoutMiddleware do
       expected_errors =  [
         {
           "message"=>"Timeout on Query.sleepFor",
-          "locations"=>[{"line"=>6, "column"=>9}]
+          "locations"=>[{"line"=>6, "column"=>9}],
+          "path"=>["d"]
         },
         {
           "message"=>"Timeout on Query.sleepFor",
-          "locations"=>[{"line"=>7, "column"=>9}]
+          "locations"=>[{"line"=>7, "column"=>9}],
+          "path"=>["e"]
         },
       ]
       assert_equal expected_data, result["data"]
@@ -116,11 +118,13 @@ describe GraphQL::Schema::TimeoutMiddleware do
       expected_errors = [
         {
           "message"=>"Timeout on NestedSleep.seconds",
-          "locations"=>[{"line"=>10, "column"=>15}]
+          "locations"=>[{"line"=>10, "column"=>15}],
+          "path"=>["a", "b", "c", "d", "seconds"]
         },
         {
           "message"=>"Timeout on NestedSleep.nestedSleep",
-          "locations"=>[{"line"=>11, "column"=>15}]
+          "locations"=>[{"line"=>11, "column"=>15}],
+          "path"=>["a", "b", "c", "d", "e"]
         },
       ]
 
@@ -149,7 +153,8 @@ describe GraphQL::Schema::TimeoutMiddleware do
       expected_errors = [
         {
           "message"=>"Timeout on Query.sleepFor",
-          "locations"=>[{"line"=>6, "column"=>9}]
+          "locations"=>[{"line"=>6, "column"=>9}],
+          "path"=>["d"]
         },
       ]
 

data/spec/graphql/static_validation/rules/argument_literals_are_compatible_spec.rb

@@ -27,42 +27,42 @@ describe GraphQL::StaticValidation::ArgumentLiteralsAreCompatible do
     query_root_error = {
       "message"=>"Argument 'id' on Field 'cheese' has an invalid value. Expected type 'Int!'.",
       "locations"=>[{"line"=>3, "column"=>7}],
-      "path"=>["query getCheese", "cheese", "id"],
+      "fields"=>["query getCheese", "cheese", "id"],
     }
     assert_includes(errors, query_root_error)
 
     directive_error = {
       "message"=>"Argument 'if' on Directive 'skip' has an invalid value. Expected type 'Boolean!'.",
       "locations"=>[{"line"=>4, "column"=>30}],
-      "path"=>["query getCheese", "cheese", "source", "if"],
+      "fields"=>["query getCheese", "cheese", "source", "if"],
     }
     assert_includes(errors, directive_error)
 
     input_object_error = {
       "message"=>"Argument 'product' on Field 'badSource' has an invalid value. Expected type '[DairyProductInput]'.",
       "locations"=>[{"line"=>6, "column"=>7}],
-      "path"=>["query getCheese", "badSource", "product"],
+      "fields"=>["query getCheese", "badSource", "product"],
     }
     assert_includes(errors, input_object_error)
 
     input_object_field_error = {
       "message"=>"Argument 'source' on InputObject 'DairyProductInput' has an invalid value. Expected type 'DairyAnimal!'.",
       "locations"=>[{"line"=>6, "column"=>40}],
-      "path"=>["query getCheese", "badSource", "product", "source"],
+      "fields"=>["query getCheese", "badSource", "product", "source"],
     }
     assert_includes(errors, input_object_field_error)
 
     missing_required_field_error = {
       "message"=>"Argument 'product' on Field 'missingSource' has an invalid value. Expected type '[DairyProductInput]'.",
       "locations"=>[{"line"=>7, "column"=>7}],
-      "path"=>["query getCheese", "missingSource", "product"],
+      "fields"=>["query getCheese", "missingSource", "product"],
     }
     assert_includes(errors, missing_required_field_error)
 
     fragment_error = {
       "message"=>"Argument 'source' on Field 'similarCheese' has an invalid value. Expected type '[DairyAnimal!]!'.",
       "locations"=>[{"line"=>13, "column"=>7}],
-      "path"=>["fragment cheeseFields", "similarCheese", "source"],
+      "fields"=>["fragment cheeseFields", "similarCheese", "source"],
     }
     assert_includes(errors, fragment_error)
   end

data/spec/graphql/static_validation/rules/arguments_are_defined_spec.rb

@@ -24,28 +24,28 @@ describe GraphQL::StaticValidation::ArgumentsAreDefined do
     query_root_error = {
       "message"=>"Field 'cheese' doesn't accept argument 'silly'",
       "locations"=>[{"line"=>4, "column"=>7}],
-      "path"=>["query getCheese", "cheese", "silly"],
+      "fields"=>["query getCheese", "cheese", "silly"],
     }
     assert_includes(errors, query_root_error)
 
     input_obj_record = {
       "message"=>"InputObject 'DairyProductInput' doesn't accept argument 'wacky'",
       "locations"=>[{"line"=>5, "column"=>29}],
-      "path"=>["query getCheese", "searchDairy", "product", "wacky"],
+      "fields"=>["query getCheese", "searchDairy", "product", "wacky"],
     }
     assert_includes(errors, input_obj_record)
 
     fragment_error = {
       "message"=>"Field 'similarCheese' doesn't accept argument 'nonsense'",
       "locations"=>[{"line"=>9, "column"=>7}],
-      "path"=>["fragment cheeseFields", "similarCheese", "nonsense"],
+      "fields"=>["fragment cheeseFields", "similarCheese", "nonsense"],
     }
     assert_includes(errors, fragment_error)
 
     directive_error = {
       "message"=>"Directive 'skip' doesn't accept argument 'something'",
       "locations"=>[{"line"=>10, "column"=>10}],
-      "path"=>["fragment cheeseFields", "id", "something"],
+      "fields"=>["fragment cheeseFields", "id", "something"],
     }
     assert_includes(errors, directive_error)
   end

data/spec/graphql/static_validation/rules/directives_are_defined_spec.rb

@@ -23,11 +23,11 @@ describe GraphQL::StaticValidation::DirectivesAreDefined do
         {
           "message"=>"Directive @nonsense is not defined",
           "locations"=>[{"line"=>5, "column"=>16}],
-          "path"=>["query getCheese", "okCheese", "source"],
+          "fields"=>["query getCheese", "okCheese", "source"],
         }, {
           "message"=>"Directive @moreNonsense is not defined",
           "locations"=>[{"line"=>7, "column"=>18}],
-          "path"=>["query getCheese", "okCheese", "... on Cheese", "flavor"],
+          "fields"=>["query getCheese", "okCheese", "... on Cheese", "flavor"],
         }
       ]
       assert_equal(expected, errors)

data/spec/graphql/static_validation/rules/directives_are_in_valid_locations_spec.rb

@@ -27,12 +27,12 @@ describe GraphQL::StaticValidation::DirectivesAreInValidLocations do
         {
           "message"=> "'@skip' can't be applied to queries (allowed: fields, fragment spreads, inline fragments)",
           "locations"=>[{"line"=>2, "column"=>21}],
-          "path"=>["query getCheese"],
+          "fields"=>["query getCheese"],
         },
         {
           "message"=>"'@skip' can't be applied to fragment definitions (allowed: fields, fragment spreads, inline fragments)",
           "locations"=>[{"line"=>12, "column"=>33}],
-           "path"=>["fragment whatever"],
+           "fields"=>["fragment whatever"],
         },
       ]
       assert_equal(expected, errors)

data/spec/graphql/static_validation/rules/fields_are_defined_on_type_spec.rb

@@ -34,7 +34,7 @@ describe GraphQL::StaticValidation::FieldsAreDefinedOnType do
         {
           "message"=>"Field 'notDefinedField' doesn't exist on type 'Query'",
           "locations"=>[{"line"=>1, "column"=>18}],
-          "path"=>["query getStuff", "notDefinedField"],
+          "fields"=>["query getStuff", "notDefinedField"],
         }
       ]
       assert_equal(expected_errors, errors)
@@ -49,7 +49,7 @@ describe GraphQL::StaticValidation::FieldsAreDefinedOnType do
         {
           "message"=>"Field 'amountThatILikeIt' doesn't exist on type 'Edible'",
           "locations"=>[{"line"=>1, "column"=>35}],
-          "path"=>["query getStuff", "favoriteEdible", "amountThatILikeIt"],
+          "fields"=>["query getStuff", "favoriteEdible", "amountThatILikeIt"],
         }
       ]
       assert_equal(expected_errors, errors)
@@ -71,7 +71,7 @@ describe GraphQL::StaticValidation::FieldsAreDefinedOnType do
           "locations"=>[
             {"line"=>3, "column"=>7}
           ],
-          "path"=>["fragment dbFields", "source"],
+          "fields"=>["fragment dbFields", "source"],
         }
       ]
       assert_equal(expected_errors, errors)

data/spec/graphql/static_validation/rules/fields_have_appropriate_selections_spec.rb

@@ -19,14 +19,14 @@ describe GraphQL::StaticValidation::FieldsHaveAppropriateSelections do
     illegal_selection_error = {
       "message"=>"Selections can't be made on scalars (field 'id' returns Int but has selections [something, someFields])",
       "locations"=>[{"line"=>5, "column"=>47}],
-      "path"=>["query getCheese", "illegalSelectionCheese", "id"],
+      "fields"=>["query getCheese", "illegalSelectionCheese", "id"],
     }
     assert_includes(errors, illegal_selection_error, "finds illegal selections on scalarss")
 
     selection_required_error = {
       "message"=>"Objects must have selections (field 'cheese' returns Cheese but has no selections)",
       "locations"=>[{"line"=>4, "column"=>7}],
-      "path"=>["query getCheese", "missingFieldsCheese"],
+      "fields"=>["query getCheese", "missingFieldsCheese"],
     }
     assert_includes(errors, selection_required_error, "finds objects without selections")
   end

data/spec/graphql/static_validation/rules/fragment_spreads_are_possible_spec.rb

@@ -32,17 +32,17 @@ describe GraphQL::StaticValidation::FragmentSpreadsArePossible do
       {
         "message"=>"Fragment on Milk can't be spread inside Cheese",
         "locations"=>[{"line"=>6, "column"=>9}],
-        "path"=>["query getCheese", "cheese", "... on Milk"],
+        "fields"=>["query getCheese", "cheese", "... on Milk"],
       },
       {
         "message"=>"Fragment milkFields on Milk can't be spread inside Cheese",
         "locations"=>[{"line"=>4, "column"=>9}],
-        "path"=>["query getCheese", "cheese", "... milkFields"],
+        "fields"=>["query getCheese", "cheese", "... milkFields"],
       },
       {
         "message"=>"Fragment milkFields on Milk can't be spread inside Cheese",
         "locations"=>[{"line"=>18, "column"=>7}],
-        "path"=>["fragment cheeseFields", "... milkFields"],
+        "fields"=>["fragment cheeseFields", "... milkFields"],
       }
     ]
     assert_equal(expected, errors)