graphql 0.17.2 → 0.18.0

data/spec/graphql/static_validation/rules/directives_are_defined_spec.rb

@@ -22,10 +22,12 @@ describe GraphQL::StaticValidation::DirectivesAreDefined do
       expected = [
         {
           "message"=>"Directive @nonsense is not defined",
-          "locations"=>[{"line"=>5, "column"=>16}]
+          "locations"=>[{"line"=>5, "column"=>16}],
+          "path"=>["query getCheese", "okCheese", "source"],
         }, {
           "message"=>"Directive @moreNonsense is not defined",
-          "locations"=>[{"line"=>7, "column"=>18}]
+          "locations"=>[{"line"=>7, "column"=>18}],
+          "path"=>["query getCheese", "okCheese", "... on Cheese", "flavor"],
         }
       ]
       assert_equal(expected, errors)

data/spec/graphql/static_validation/rules/directives_are_in_valid_locations_spec.rb

@@ -26,11 +26,13 @@ describe GraphQL::StaticValidation::DirectivesAreInValidLocations do
       expected = [
         {
           "message"=> "'@skip' can't be applied to queries (allowed: fields, fragment spreads, inline fragments)",
-          "locations"=>[{"line"=>2, "column"=>21}]
+          "locations"=>[{"line"=>2, "column"=>21}],
+          "path"=>["query getCheese"],
         },
         {
           "message"=>"'@skip' can't be applied to fragment definitions (allowed: fields, fragment spreads, inline fragments)",
-          "locations"=>[{"line"=>12, "column"=>33}]
+          "locations"=>[{"line"=>12, "column"=>33}],
+           "path"=>["fragment whatever"],
         },
       ]
       assert_equal(expected, errors)

data/spec/graphql/static_validation/rules/fields_are_defined_on_type_spec.rb

@@ -31,7 +31,11 @@ describe GraphQL::StaticValidation::FieldsAreDefinedOnType do
 
     it "finds invalid fields" do
       expected_errors = [
-        {"message"=>"Field 'amountThatILikeIt' doesn't exist on type 'Edible'", "locations"=>[{"line"=>1, "column"=>18}]}
+        {
+          "message"=>"Field 'amountThatILikeIt' doesn't exist on type 'Edible'",
+          "locations"=>[{"line"=>1, "column"=>18}],
+          "path"=>["query getStuff", "favoriteEdible", "amountThatILikeIt"],
+        }
       ]
       assert_equal(expected_errors, errors)
     end
@@ -51,7 +55,8 @@ describe GraphQL::StaticValidation::FieldsAreDefinedOnType do
           "message"=>"Selections can't be made directly on unions (see selections on DairyProduct)",
           "locations"=>[
             {"line"=>3, "column"=>7}
-          ]
+          ],
+          "path"=>["fragment dbFields", "source"],
         }
       ]
       assert_equal(expected_errors, errors)

data/spec/graphql/static_validation/rules/fields_have_appropriate_selections_spec.rb

@@ -18,13 +18,15 @@ describe GraphQL::StaticValidation::FieldsHaveAppropriateSelections do
 
     illegal_selection_error = {
       "message"=>"Selections can't be made on scalars (field 'id' returns Int but has selections [something, someFields])",
-      "locations"=>[{"line"=>5, "column"=>47}]
+      "locations"=>[{"line"=>5, "column"=>47}],
+      "path"=>["query getCheese", "illegalSelectionCheese", "id"],
     }
     assert_includes(errors, illegal_selection_error, "finds illegal selections on scalarss")
 
     selection_required_error = {
       "message"=>"Objects must have selections (field 'cheese' returns Cheese but has no selections)",
-      "locations"=>[{"line"=>4, "column"=>7}]
+      "locations"=>[{"line"=>4, "column"=>7}],
+      "path"=>["query getCheese", "missingFieldsCheese"],
     }
     assert_includes(errors, selection_required_error, "finds objects without selections")
   end

data/spec/graphql/static_validation/rules/fragment_spreads_are_possible_spec.rb

@@ -31,15 +31,18 @@ describe GraphQL::StaticValidation::FragmentSpreadsArePossible do
     expected = [
       {
         "message"=>"Fragment on Milk can't be spread inside Cheese",
-        "locations"=>[{"line"=>6, "column"=>9}]
+        "locations"=>[{"line"=>6, "column"=>9}],
+        "path"=>["query getCheese", "cheese", "... on Milk"],
       },
       {
         "message"=>"Fragment milkFields on Milk can't be spread inside Cheese",
-        "locations"=>[{"line"=>4, "column"=>9}]
+        "locations"=>[{"line"=>4, "column"=>9}],
+        "path"=>["query getCheese", "cheese", "... milkFields"],
       },
       {
         "message"=>"Fragment milkFields on Milk can't be spread inside Cheese",
-        "locations"=>[{"line"=>18, "column"=>7}]
+        "locations"=>[{"line"=>18, "column"=>7}],
+        "path"=>["fragment cheeseFields", "... milkFields"],
       }
     ]
     assert_equal(expected, errors)

data/spec/graphql/static_validation/rules/fragment_types_exist_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe GraphQL::StaticValidation::FragmentTypesExist do
   let(:query_string) {"
     query getCheese {
-      cheeese(id: 1) {
+      cheese(id: 1) {
         ... on Cheese { source }
         ... on Nothing { whatever }
         ... somethingFields
@@ -27,12 +27,14 @@ describe GraphQL::StaticValidation::FragmentTypesExist do
     assert_equal(2, errors.length)
     inline_fragment_error =  {
       "message"=>"No such type Something, so it can't be a fragment condition",
-      "locations"=>[{"line"=>11, "column"=>5}]
+      "locations"=>[{"line"=>11, "column"=>5}],
+      "path"=>["fragment somethingFields"],
     }
     assert_includes(errors, inline_fragment_error, "on inline fragments")
     fragment_def_error = {
       "message"=>"No such type Nothing, so it can't be a fragment condition",
-      "locations"=>[{"line"=>5, "column"=>9}]
+      "locations"=>[{"line"=>5, "column"=>9}],
+      "path"=>["query getCheese", "cheese", "... on Nothing"],
     }
     assert_includes(errors, fragment_def_error, "on fragment definitions")
   end

data/spec/graphql/static_validation/rules/fragments_are_finite_spec.rb

@@ -32,11 +32,13 @@ describe GraphQL::StaticValidation::FragmentsAreFinite do
     expected = [
       {
         "message"=>"Fragment sourceField contains an infinite loop",
-        "locations"=>[{"line"=>10, "column"=>5}]
+        "locations"=>[{"line"=>10, "column"=>5}],
+        "path"=>["fragment sourceField"],
       },
       {
         "message"=>"Fragment flavorField contains an infinite loop",
-        "locations"=>[{"line"=>15, "column"=>5}]
+        "locations"=>[{"line"=>15, "column"=>5}],
+        "path"=>["fragment flavorField"],
       }
     ]
     assert_equal(expected, errors)

data/spec/graphql/static_validation/rules/fragments_are_on_composite_types_spec.rb

@@ -33,15 +33,18 @@ describe GraphQL::StaticValidation::FragmentsAreOnCompositeTypes do
     expected = [
       {
         "message"=>"Invalid fragment on type Boolean (must be Union, Interface or Object)",
-        "locations"=>[{"line"=>6, "column"=>11}]
+        "locations"=>[{"line"=>6, "column"=>11}],
+        "path"=>["query getCheese", "cheese", "... on Cheese", "... on Boolean"],
       },
       {
         "message"=>"Invalid fragment on type DairyProductInput (must be Union, Interface or Object)",
         "locations"=>[{"line"=>14, "column"=>9}],
+        "path"=>["query getCheese", "cheese", "... on DairyProductInput"],
       },
       {
         "message"=>"Invalid fragment on type Int (must be Union, Interface or Object)",
-        "locations"=>[{"line"=>20, "column"=>5}]
+        "locations"=>[{"line"=>20, "column"=>5}],
+        "path"=>["fragment intFields"],
       },
     ]
     assert_equal(expected, errors)

data/spec/graphql/static_validation/rules/fragments_are_used_spec.rb

@@ -16,10 +16,18 @@ describe GraphQL::StaticValidation::FragmentsAreUsed do
   let(:errors) { validator.validate(query)[:errors] }
 
   it "adds errors for unused fragment definitions" do
-    assert_includes(errors, {"message"=>"Fragment unusedFields was defined, but not used", "locations"=>[{"line"=>8, "column"=>5}]})
+    assert_includes(errors, {
+      "message"=>"Fragment unusedFields was defined, but not used",
+      "locations"=>[{"line"=>8, "column"=>5}],
+      "path"=>[],
+    })
   end
 
   it "adds errors for undefined fragment spreads" do
-    assert_includes(errors, {"message"=>"Fragment undefinedFields was used, but not defined", "locations"=>[{"line"=>5, "column"=>7}]})
+    assert_includes(errors, {
+      "message"=>"Fragment undefinedFields was used, but not defined",
+      "locations"=>[{"line"=>5, "column"=>7}],
+      "path"=>["query getCheese", "... undefinedFields"]
+    })
   end
 end

data/spec/graphql/static_validation/rules/required_arguments_are_present_spec.rb

@@ -23,19 +23,22 @@ describe GraphQL::StaticValidation::RequiredArgumentsArePresent do
 
     query_root_error = {
       "message"=>"Field 'cheese' is missing required arguments: id",
-      "locations"=>[{"line"=>4, "column"=>7}]
+      "locations"=>[{"line"=>4, "column"=>7}],
+      "path"=>["query getCheese", "cheese"],
     }
     assert_includes(errors, query_root_error)
 
     fragment_error = {
       "message"=>"Field 'similarCheese' is missing required arguments: source",
-      "locations"=>[{"line"=>8, "column"=>7}]
+      "locations"=>[{"line"=>8, "column"=>7}],
+      "path"=>["fragment cheeseFields", "similarCheese"],
     }
     assert_includes(errors, fragment_error)
 
     directive_error = {
       "message"=>"Directive 'skip' is missing required arguments: if",
-      "locations"=>[{"line"=>10, "column"=>10}]
+      "locations"=>[{"line"=>10, "column"=>10}],
+      "path"=>["fragment cheeseFields", "id"],
     }
     assert_includes(errors, directive_error)
   end

data/spec/graphql/static_validation/rules/variable_default_values_are_correctly_typed_spec.rb

@@ -24,19 +24,23 @@ describe GraphQL::StaticValidation::VariableDefaultValuesAreCorrectlyTyped do
     expected = [
       {
         "message"=>"Default value for $badFloat doesn't match type Float",
-        "locations"=>[{"line"=>6, "column"=>7}]
+        "locations"=>[{"line"=>6, "column"=>7}],
+        "path"=>["query getCheese"],
       },
       {
         "message"=>"Default value for $badInt doesn't match type Int",
-        "locations"=>[{"line"=>7, "column"=>7}]
+        "locations"=>[{"line"=>7, "column"=>7}],
+        "path"=>["query getCheese"],
       },
       {
         "message"=>"Default value for $badInput doesn't match type DairyProductInput",
-        "locations"=>[{"line"=>9, "column"=>7}]
+        "locations"=>[{"line"=>9, "column"=>7}],
+        "path"=>["query getCheese"],
       },
       {
         "message"=>"Non-null variable $nonNull can't have a default value",
-        "locations"=>[{"line"=>10, "column"=>7}]
+        "locations"=>[{"line"=>10, "column"=>7}],
+        "path"=>["query getCheese"],
       }
     ]
     assert_equal(expected, errors)

data/spec/graphql/static_validation/rules/variable_usages_are_allowed_spec.rb

@@ -43,19 +43,23 @@ describe GraphQL::StaticValidation::VariableUsagesAreAllowed do
     expected = [
       {
         "message"=>"Nullability mismatch on variable $badInt and argument id (Int / Int!)",
-        "locations"=>[{"line"=>14, "column"=>28}]
+        "locations"=>[{"line"=>14, "column"=>28}],
+        "path"=>["query getCheese", "badCheese", "id"],
       },
       {
         "message"=>"Type mismatch on variable $badStr and argument id (String! / Int!)",
-        "locations"=>[{"line"=>15, "column"=>28}]
+        "locations"=>[{"line"=>15, "column"=>28}],
+        "path"=>["query getCheese", "badStrCheese", "id"],
       },
       {
         "message"=>"Nullability mismatch on variable $badAnimals and argument source ([DairyAnimal]! / [DairyAnimal!]!)",
-        "locations"=>[{"line"=>18, "column"=>30}]
+        "locations"=>[{"line"=>18, "column"=>30}],
+        "path"=>["query getCheese", "cheese", "other", "source"],
       },
       {
         "message"=>"List dimension mismatch on variable $deepAnimals and argument source ([[DairyAnimal!]!]! / [DairyAnimal!]!)",
-        "locations"=>[{"line"=>19, "column"=>32}]
+        "locations"=>[{"line"=>19, "column"=>32}],
+        "path"=>["query getCheese", "cheese", "tooDeep", "source"],
       }
     ]
     assert_equal(expected, errors)

data/spec/graphql/static_validation/rules/variables_are_input_types_spec.rb

@@ -21,15 +21,18 @@ describe GraphQL::StaticValidation::VariablesAreInputTypes do
     expected = [
       {
         "message"=>"AnimalProduct isn't a valid input type (on $interface)",
-        "locations"=>[{"line"=>5, "column"=>7}]
+        "locations"=>[{"line"=>5, "column"=>7}],
+        "path"=>["query getCheese"],
       },
       {
         "message"=>"Milk isn't a valid input type (on $object)",
-        "locations"=>[{"line"=>6, "column"=>7}]
+        "locations"=>[{"line"=>6, "column"=>7}],
+        "path"=>["query getCheese"],
       },
       {
         "message"=>"Cheese isn't a valid input type (on $objects)",
-        "locations"=>[{"line"=>7, "column"=>7}]
+        "locations"=>[{"line"=>7, "column"=>7}],
+        "path"=>["query getCheese"],
       }
     ]
     assert_equal(expected, errors)

data/spec/graphql/static_validation/rules/variables_are_used_and_defined_spec.rb

@@ -37,15 +37,18 @@ describe GraphQL::StaticValidation::VariablesAreUsedAndDefined do
     expected = [
       {
         "message"=>"Variable $notUsedVar is declared by getCheese but not used",
-        "locations"=>[{"line"=>2, "column"=>5}]
+        "locations"=>[{"line"=>2, "column"=>5}],
+        "path"=>["query getCheese"],
       },
       {
         "message"=>"Variable $undefinedVar is used by getCheese but not declared",
-        "locations"=>[{"line"=>11, "column"=>29}]
+        "locations"=>[{"line"=>11, "column"=>29}],
+        "path"=>["query getCheese", "cheese", "whatever", "undefined"],
       },
       {
         "message"=>"Variable $undefinedFragmentVar is used by innerCheeseFields but not declared",
-        "locations"=>[{"line"=>24, "column"=>26}]
+        "locations"=>[{"line"=>24, "column"=>26}],
+        "path"=>["fragment innerCheeseFields", "source", "notDefined"],
       },
     ]
     assert_equal(expected, errors)

data/spec/spec_helper.rb

@@ -1,5 +1,8 @@
 require "codeclimate-test-reporter"
 CodeClimate::TestReporter.start
+require "sqlite3"
+require "active_record"
+require "sequel"
 require "graphql"
 require "benchmark"
 require "minitest/autorun"
@@ -16,3 +19,7 @@ Minitest.backtrace_filter = Minitest::BacktraceFilter.new
 
 # # Load support files
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
+
+def query(string, variables={})
+  GraphQL::Query.new(StarWarsSchema, string, variables: variables).result
+end

data/spec/support/dairy_app.rb

@@ -38,7 +38,7 @@ CheeseType = GraphQL::ObjectType.define do
     "Animal which produced the milk for this cheese"
 
   # Or can define by block, `resolve ->` should override `property:`
-  field :similarCheese, CheeseType, "Cheeses like this one", property: :nonsense  do
+  field :similarCheese, CheeseType, "Cheeses like this one", property: :this_should_be_overriden  do
     argument :source, !types[!DairyAnimalEnum]
     resolve -> (t, a, c) {
       # get the strings out:
@@ -61,11 +61,12 @@ CheeseType = GraphQL::ObjectType.define do
     resolve -> (t, a, c) { raise("NotImplemented") }
   end
 
-  field :fatContent, property: :fat_content do
-    type(!GraphQL::FLOAT_TYPE)
-    description("Percentage which is milkfat")
-    deprecation_reason("Diet fashion has changed")
-  end
+  # Keywords can be used for definition methods
+  field :fatContent,
+    property: :fat_content,
+    type: !GraphQL::FLOAT_TYPE,
+    description: "Percentage which is milkfat",
+    deprecation_reason: "Diet fashion has changed"
 end
 
 MilkType = GraphQL::ObjectType.define do
@@ -216,7 +217,7 @@ FavoriteFieldDefn = GraphQL::Field.define do
   resolve -> (t, a, c) { MILKS[1] }
 end
 
-QueryType = GraphQL::ObjectType.define do
+DairyAppQueryType = GraphQL::ObjectType.define do
   name "Query"
   description "Query root of the system"
   field :root, types.String do
@@ -275,7 +276,7 @@ ReplaceValuesInputType = GraphQL::InputObjectType.define do
   input_field :values, !types[!types.Int]
 end
 
-MutationType = GraphQL::ObjectType.define do
+DairyAppMutationType = GraphQL::ObjectType.define do
   name "Mutation"
   description "The root for mutations in this schema"
   field :pushValue, !types[!types.Int] do
@@ -306,8 +307,8 @@ SubscriptionType = GraphQL::ObjectType.define do
 end
 
 DummySchema = GraphQL::Schema.new(
-  query: QueryType,
-  mutation: MutationType,
+  query: DairyAppQueryType,
+  mutation: DairyAppMutationType,
   subscription: SubscriptionType,
   max_depth: 5,
   types: [HoneyType],

data/spec/support/star_wars_data.rb

@@ -1,71 +1,78 @@
-luke = OpenStruct.new({
-  id: "1000",
-  name: "Luke Skywalker",
-  friends: ["1002", "1003", "2000", "2001"],
-  appearsIn: [4, 5, 6],
-  homePlanet: "Tatooine",
-})
 
-vader = OpenStruct.new({
-  id: "1001",
-  name: "Darth Vader",
-  friends: ["1004"],
-  appearsIn: [4, 5, 6],
-  homePlanet: "Tatooine",
-})
+names = [
+  'X-Wing',
+  'Y-Wing',
+  'A-Wing',
+  'Millenium Falcon',
+  'Home One',
+  'TIE Fighter',
+  'TIE Interceptor',
+  'Executor',
+]
 
-han = OpenStruct.new({
-  id: "1002",
-  name: "Han Solo",
-  friends: ["1000", "1003", "2001"],
-  appearsIn: [4, 5, 6],
-})
+# ActiveRecord::Base.logger = Logger.new(STDOUT)
+`rm -f ./_test_.db`
+# Set up "Bases" in ActiveRecord
+ActiveRecord::Base.establish_connection(adapter: "sqlite3", database: "./_test_.db")
 
-leia = OpenStruct.new({
-  id: "1003",
-  name: "Leia Organa",
-  friends: ["1000", "1002", "2000", "2001"],
-  appearsIn: [4, 5, 6],
-  homePlanet: "Alderaan",
-})
+ActiveRecord::Schema.define do
+  self.verbose = false
+  create_table :bases do |t|
+    t.column :name, :string
+    t.column :planet, :string
+    t.column :faction_id, :integer
+  end
+end
 
-tarkin = OpenStruct.new({
-  id: "1004",
-  name: "Wilhuff Tarkin",
-  friends: ["1001"],
-  appearsIn: [4],
-})
+class Base < ActiveRecord::Base
+end
 
-HUMAN_DATA = {
-  "1000" => luke,
-  "1001" => vader,
-  "1002" => han,
-  "1003" => leia,
-  "1004" => tarkin,
-}
+Base.create!(name: "Yavin", planet: "Yavin 4", faction_id: 1)
+Base.create!(name: "Echo Base", planet: "Hoth", faction_id: 1)
+Base.create!(name: "Secret Hideout", planet: "Dantooine", faction_id: 1)
+Base.create!(name: "Death Star", planet: nil, faction_id: 2)
+Base.create!(name: "Shield Generator", planet: "Endor", faction_id: 2)
+Base.create!(name: "Headquarters", planet: "Coruscant", faction_id: 2)
 
-threepio = OpenStruct.new({
-  id: "2000",
-  name: "C-3PO",
-  friends: ["1000", "1002", "1003", "2001"],
-  appearsIn: [4, 5, 6],
-  primaryFunction: "Protocol",
+# Also, set up Bases with Sequel
+DB = Sequel.sqlite("./_test_.db")
+class SequelBase < Sequel::Model(:bases)
+end
+
+rebels  = OpenStruct.new({
+  id: '1',
+  name: 'Alliance to Restore the Republic',
+  ships:  ['1', '2', '3', '4', '5'],
+  bases: Base.where(faction_id: 1),
+  basesClone: Base.where(faction_id: 1),
 })
 
-artoo = OpenStruct.new({
-  id: "2001",
-  name: "R2-D2",
-  friends: ["1000", "1002", "1003"],
-  appearsIn: [4, 5, 6],
-  primaryFunction: "Astromech",
+
+empire = OpenStruct.new({
+  id: '2',
+  name: 'Galactic Empire',
+  ships: ['6', '7', '8'],
+  bases: Base.where(faction_id: 2),
+  basesClone: Base.where(faction_id: 2),
 })
 
-DROID_DATA = {
-  "2000" => threepio,
-  "2001" => artoo,
+STAR_WARS_DATA = {
+  "Faction" => {
+    "1" => rebels,
+    "2" => empire,
+  },
+  "Ship" => names.each_with_index.reduce({}) do |memo, (name, idx)|
+    id = (idx + 1).to_s
+    memo[id] = OpenStruct.new(name: name, id: id)
+    memo
+  end,
+  "Base" => Hash.new { |h, k| h[k] = Base.find(k) }
 }
 
-# Get friends from IDs
-GET_FRIENDS = -> (obj, args, ctx) do
-  obj.friends.map { |id| HUMAN_DATA[id] || DROID_DATA[id]}
+def STAR_WARS_DATA.create_ship(name, faction_id)
+  new_id = (self["Ship"].keys.map(&:to_i).max + 1).to_s
+  new_ship = OpenStruct.new(id: new_id, name: name)
+  self["Ship"][new_id] = new_ship
+  self["Faction"][faction_id]["ships"] << new_id
+  new_ship
 end