graphql 0.1.0 → 0.2.0

data/spec/graph_ql/static_validation/fragment_types_exist_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+describe GraphQL::StaticValidation::FragmentTypesExist do
+  let(:document) { GraphQL.parse("
+    query getCheese {
+      cheeese(id: 1) {
+        ... on Cheese { source }
+        ... on Nothing { whatever }
+        ... somethingFields
+        ... cheeseFields
+      }
+    }
+
+    fragment somethingFields on Something {
+      something
+    }
+    fragment cheeseFields on Cheese {
+      fatContent
+    }
+  ")}
+
+  let(:validator) { GraphQL::StaticValidation::Validator.new(schema: DummySchema, validators: [GraphQL::StaticValidation::FragmentTypesExist]) }
+  let(:errors) { validator.validate(document) }
+
+  it 'finds non-existent types on fragments' do
+    assert_equal(2, errors.length)
+    inline_fragment_error =  {
+      "message"=>"No such type Something, so it can't be a fragment condition",
+      "locations"=>[{"line"=>11, "column"=>5}]
+    }
+    assert_includes(errors, inline_fragment_error, "on inline fragments")
+    fragment_def_error = {
+      "message"=>"No such type Nothing, so it can't be a fragment condition",
+      "locations"=>[{"line"=>5, "column"=>9}]
+    }
+    assert_includes(errors, fragment_def_error, "on fragment definitions")
+  end
+end

data/spec/graph_ql/static_validation/fragments_are_used_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+describe GraphQL::StaticValidation::FragmentsAreUsed do
+  let(:document) { GraphQL.parse("
+    query getCheese {
+      name,
+      ...cheeseFields
+      ...undefinedFields
+    }
+    fragment cheeseFields on Cheese { fatContent }
+    fragment unusedFields on Cheese { is, not, used }
+  ")}
+
+  let(:validator) { GraphQL::StaticValidation::Validator.new(schema: DummySchema, validators: [GraphQL::StaticValidation::FragmentsAreUsed]) }
+  let(:errors) { validator.validate(document) }
+
+  it 'adds errors for unused fragment definitions' do
+    assert_includes(errors, {"message"=>"Fragment unusedFields was defined, but not used", "locations"=>[{"line"=>8, "column"=>5}]})
+  end
+
+  it 'adds errors for undefined fragment spreads' do
+    assert_includes(errors, {"message"=>"Fragment undefinedFields was used, but not defined", "locations"=>[{"line"=>5, "column"=>7}]})
+  end
+end

data/spec/graph_ql/static_validation/required_arguments_are_present_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+describe GraphQL::StaticValidation::RequiredArgumentsArePresent do
+  let(:document) { GraphQL.parse("
+    query getCheese {
+      cheese(id: 1) { source }
+      cheese { source }
+    }
+
+    fragment cheeseFields on Cheese {
+      similarCheeses(id: 1)
+      flavor @include(if: true)
+      id @skip
+    }
+  ")}
+
+  let(:validator) { GraphQL::StaticValidation::Validator.new(schema: DummySchema, validators: [GraphQL::StaticValidation::RequiredArgumentsArePresent]) }
+  let(:errors) { validator.validate(document) }
+
+  it 'finds undefined arguments to fields and directives' do
+    assert_equal(3, errors.length)
+
+    query_root_error = {
+      "message"=>"Field 'cheese' is missing required arguments: id",
+      "locations"=>[{"line"=>4, "column"=>7}]
+    }
+    assert_includes(errors, query_root_error)
+
+    fragment_error = {
+      "message"=>"Field 'similarCheeses' is missing required arguments: source",
+      "locations"=>[{"line"=>8, "column"=>7}]
+    }
+    assert_includes(errors, fragment_error)
+
+    directive_error = {
+      "message"=>"Directive 'skip' is missing required arguments: if",
+      "locations"=>[{"line"=>10, "column"=>11}]
+    }
+    assert_includes(errors, directive_error)
+  end
+end

data/spec/graph_ql/static_validation/type_stack_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+class TypeCheckValidator
+  def self.checks
+    @checks ||= []
+  end
+
+  def validate(context)
+    self.class.checks.clear
+    context.visitor[GraphQL::Nodes::Field] << -> (node, parent) {
+      self.class.checks << context.object_types.map(&:name)
+    }
+  end
+end
+
+describe GraphQL::StaticValidation::TypeStack do
+  let(:query_string) {%|
+    query getCheese {
+      cheese(id: 1) { id, ... edibleFields }
+    }
+    fragment edibleFields on Edible { fatContent }
+  |}
+  let(:document) { GraphQL.parse(query_string) }
+  let(:validator) { GraphQL::StaticValidation::Validator.new(schema: DummySchema, validators: [TypeCheckValidator]) }
+
+  it 'stores up types' do
+    validator.validate(document)
+    expected = [
+      ["Query", "Cheese"],
+      ["Query", "Cheese", "Non-Null"],
+      ["Edible", "Non-Null"]
+    ]
+    assert_equal(expected, TypeCheckValidator.checks)
+  end
+end

data/spec/graph_ql/static_validation/validator_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+
+class SchemaErrorValidator
+  def validate(context)
+    context.errors << GraphQL::StaticValidation::Message.new("Something is wrong: #{context.schema}", line: 100, col: 4)
+  end
+end
+
+class DocumentErrorValidator
+  include
+  def validate(context)
+    context.errors << GraphQL::StaticValidation::Message.new("Something is wrong: #{context.document.name}", line: 1, col: 1)
+  end
+end
+
+describe GraphQL::StaticValidation::Validator do
+  let(:document)  { OpenStruct.new(name: "This is not a document", children: []) }
+  let(:validator) { GraphQL::StaticValidation::Validator.new(schema: "This is not a schema", validators: [SchemaErrorValidator, DocumentErrorValidator]) }
+
+  it 'uses validators' do
+    errors = validator.validate(document)
+    expected_errors = [
+      {"message" => "Something is wrong: This is not a schema", "locations" => [{"line" => 100, "column" => 4}]},
+      {"message" => "Something is wrong: This is not a document", "locations" => [{"line" => 1, "column" => 1}]}
+    ]
+    assert_equal(expected_errors, errors)
+  end
+end

data/spec/graph_ql/types/object_type_spec.rb

@@ -15,7 +15,7 @@ describe GraphQL::ObjectType do
   end
 
   it 'may have interfaces' do
-    assert_equal([Edible, AnimalProduct], type.interfaces)
+    assert_equal([EdibleInterface, AnimalProductInterface], type.interfaces)
   end
 
   it 'becomes non-null with !' do

data/spec/graph_ql/union_spec.rb

@@ -3,24 +3,11 @@ require 'spec_helper'
 describe GraphQL::Union do
   let(:type_1) { OpenStruct.new(kind: GraphQL::TypeKinds::OBJECT)}
   let(:type_2) { OpenStruct.new(kind: GraphQL::TypeKinds::OBJECT)}
-  let(:union) { GraphQL::Union.new("MyUnion", [type_1, type_2]) }
+  let(:union) { GraphQL::Union.new("MyUnion", "Some items", [type_1, type_2]) }
   it 'has a name' do
     assert_equal("MyUnion", union.name)
   end
 
-  it 'identifies members' do
-    assert(union.include?(type_1))
-    assert(!union.include?(:type_3))
-  end
-
-  it 'must be 2+ types' do
-    assert_raises(ArgumentError) { GraphQL::Union.new("Something", [type_1])}
-  end
-
-  it 'must be all object types' do
-    assert_raises(ArgumentError) { GraphQL::Union.new("Something", [type_1, type_2, union])}
-  end
-
   it 'infers type from an object' do
     assert_equal(CheeseType, DairyProductUnion.resolve_type(CHEESES[1]))
   end

data/spec/support/dummy_app.rb

@@ -1,18 +1,21 @@
 require_relative './dummy_data'
 
-Edible = GraphQL::Interface.new do
-  name "Edible"
-  description "Something you can eat, yum"
-  fields({
-    fatContent: field(type: !type.Float, desc: "Percentage which is fat"),
+EdibleInterface = GraphQL::Interface.new do |i, type, field|
+  i.name "Edible"
+  i.description "Something you can eat, yum"
+  i.fields({
+    fatContent: field.build(
+      type: !type.Float,
+      property: :non_existent_field_that_should_never_be_called,
+      desc: "Percentage which is fat"),
   })
 end
 
-AnimalProduct = GraphQL::Interface.new do
-  name "AnimalProduct"
-  description "Comes from an animal, no joke"
-  fields({
-    source: field(type: !type.String, desc: "Animal which produced this product"),
+AnimalProductInterface = GraphQL::Interface.new do |i, type, field|
+  i.name "AnimalProduct"
+  i.description "Comes from an animal, no joke"
+  i.fields({
+    source: field.build(type: !type.String, desc: "Animal which produced this product"),
   })
 end
 
@@ -25,52 +28,64 @@ DairyAnimalEnum = GraphQL::Enum.new do |e|
   e.value("YAK",    "Animal with long hair", deprecation_reason: "Out of fashion")
 end
 
-CheeseType = GraphQL::ObjectType.new do
-  name "Cheese"
-  description "Cultured dairy product"
-  interfaces [Edible, AnimalProduct]
-  self.fields = {
-    id:           field(type: !type.Int, desc: "Unique identifier"),
-    flavor:       field(type: !type.String, desc: "Kind of cheese"),
-    source:       field(type: !DairyAnimalEnum, desc: "Animal which produced the milk for this cheese"),
-    fatContent:   field(type: !type.Float, desc: "Percentage which is milkfat", deprecation_reason: "Diet fashion has changed"),
+CheeseType = GraphQL::ObjectType.new do |t, type, field, arg|
+  t.name "Cheese"
+  t.description "Cultured dairy product"
+  t.interfaces [EdibleInterface, AnimalProductInterface]
+  t.fields = {
+    id:           field.build(type: !type.Int, desc: "Unique identifier"),
+    flavor:       field.build(type: !type.String, desc: "Kind of cheese"),
+    source:       field.build(type: !DairyAnimalEnum, desc: "Animal which produced the milk for this cheese"),
+    similarCheeses: GraphQL::Field.new do |f|
+      f.description "Cheeses like this one"
+      f.type(t)
+      f.arguments({source: arg.build(type: !type[!DairyAnimalEnum])})
+      f.resolve -> (t, a, c) { CHEESES.values.find { |c| c.source == a["source"] } }
+    end,
+    fatContent:   field.build(type: !type.Float, desc: "Percentage which is milkfat", deprecation_reason: "Diet fashion has changed"),
   }
 end
 
-MilkType = GraphQL::ObjectType.new do
-  name 'Milk'
-  description "Dairy beverage"
-  interfaces [Edible, AnimalProduct]
-  self.fields = {
-    id:           field(type: !type.Int, desc: "Unique identifier"),
-    source:       field(type: DairyAnimalEnum, desc: "Animal which produced this milk"),
-    fatContent:   field(type: !type.Float, desc: "Percentage which is milkfat"),
-    flavors:      field(
+ MilkType = GraphQL::ObjectType.new do |t, type, field, arg|
+  t.name 'Milk'
+  t.description "Dairy beverage"
+  t.interfaces [EdibleInterface, AnimalProductInterface]
+  t.fields = {
+    id:           field.build(type: !type.Int, desc: "Unique identifier"),
+    source:       field.build(type: DairyAnimalEnum, desc: "Animal which produced this milk"),
+    fatContent:   field.build(type: !type.Float, desc: "Percentage which is milkfat"),
+    flavors:      field.build(
           type: type[type.String],
           desc: "Chocolate, Strawberry, etc",
-          args: {limit: {type: type.Int}}
+          args: {limit: arg.build({type: type.Int})}
         ),
   }
 end
 
-DairyProductUnion = GraphQL::Union.new("DairyProduct", [MilkType, CheeseType])
-
-DairyProductInputType = GraphQL::InputObjectType.new {
-  name "DairyProductInput"
-  description "Properties for finding a dairy product"
-  input_fields({
-    source:     arg({type: DairyAnimalEnum}),
-    fatContent: arg({type: type.Float}),
+DairyProductUnion = GraphQL::Union.new(
+  "DairyProduct",
+  "Kinds of food made from milk",
+  [MilkType, CheeseType]
+)
+
+DairyProductInputType = GraphQL::InputObjectType.new {|t, type, field, arg|
+  t.name "DairyProductInput"
+  t.description "Properties for finding a dairy product"
+  t.input_fields({
+    source:     arg.build({type: DairyAnimalEnum}),
+    fatContent: arg.build({type: type.Float}),
   })
 }
 
 
-class FetchField < GraphQL::AbstractField
-  attr_reader :type
+class FetchField
+  attr_reader :type, :arguments, :deprecation_reason
   attr_accessor :name
   def initialize(type:, data:)
     @type = type
     @data = data
+    @arguments = {"id" => GraphQL::InputValue.new(type: !GraphQL::INT_TYPE, name: "id")}
+    @deprecation_reason = nil
   end
 
   def description
@@ -82,9 +97,10 @@ class FetchField < GraphQL::AbstractField
   end
 end
 
-SourceField = GraphQL::Field.new do |f|
+SourceField = GraphQL::Field.new do |f, type, field, arg|
   f.type GraphQL::ListType.new(of_type: CheeseType)
   f.description "Cheese from source"
+  f.arguments(source: arg.build(type: !DairyAnimalEnum))
   f.resolve -> (target, arguments, context) {
     CHEESES.values.select{ |c| c.source == arguments["source"] }
   }
@@ -92,23 +108,23 @@ end
 
 FavoriteField = GraphQL::Field.new do |f|
   f.description "My favorite food"
-  f.type Edible
+  f.type EdibleInterface
   f.resolve -> (t, a, c) { MILKS[1] }
 end
 
 
-QueryType = GraphQL::ObjectType.new do
-  name "Query"
-  description "Query root of the system"
-  fields({
+QueryType = GraphQL::ObjectType.new do |t, types, field, arg|
+  t.name "Query"
+  t.description "Query root of the system"
+  t.fields({
     cheese: FetchField.new(type: CheeseType, data: CHEESES),
     fromSource: SourceField,
     favoriteEdible: FavoriteField,
     searchDairy: GraphQL::Field.new { |f|
       f.name "searchDairy"
       f.description "Find dairy products matching a description"
-      f.type DairyProductUnion
-      f.arguments({product: {type: DairyProductInputType}})
+      f.type !DairyProductUnion
+      f.arguments({product: arg.build({type: DairyProductInputType})})
       f.resolve -> (t, a, c) {
         products = CHEESES.values + MILKS.values
         source =  a["product"]["source"]
@@ -117,20 +133,25 @@ QueryType = GraphQL::ObjectType.new do
         end
         products.first
       }
-    }
+    },
+    error: GraphQL::Field.new { |f|
+      f.description "Raise an error"
+      f.type GraphQL::STRING_TYPE
+      f.resolve -> (t, a, c) { raise("This error was raised on purpose") }
+    },
   })
 end
 
 GLOBAL_VALUES = []
 
-MutationType = GraphQL::ObjectType.new do
-  name "Mutation"
-  description "The root for mutations in this schema"
-  fields({
+MutationType = GraphQL::ObjectType.new do |t, type, field, arg|
+  t.name "Mutation"
+  t.description "The root for mutations in this schema"
+  t.fields({
     pushValue: GraphQL::Field.new { |f|
       f.description("Push a value onto a global array :D")
       f.type(!type[!type.Int])
-      f.arguments(value: arg(type: !type.Int))
+      f.arguments(value: arg.build(type: !type.Int))
       f.resolve -> (o, args, ctx) {
         GLOBAL_VALUES << args["value"]
         GLOBAL_VALUES
@@ -138,4 +159,5 @@ MutationType = GraphQL::ObjectType.new do
     }
   })
 end
+
 DummySchema = GraphQL::Schema.new(query: QueryType, mutation: MutationType)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: graphql
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Robert Mosolgo
@@ -10,20 +10,6 @@ bindir: bin
 cert_chain: []
 date: 2015-03-06 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: activesupport
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '4'
 - !ruby/object:Gem::Dependency
   name: parslet
   requirement: !ruby/object:Gem::Requirement
@@ -177,9 +163,7 @@ files:
 - lib/graph_ql/directives/include_directive.rb
 - lib/graph_ql/directives/skip_directive.rb
 - lib/graph_ql/enum.rb
-- lib/graph_ql/fields/abstract_field.rb
-- lib/graph_ql/fields/access_field.rb
-- lib/graph_ql/fields/field.rb
+- lib/graph_ql/field.rb
 - lib/graph_ql/interface.rb
 - lib/graph_ql/introspection/arguments_field.rb
 - lib/graph_ql/introspection/directive_type.rb
@@ -189,11 +173,14 @@ files:
 - lib/graph_ql/introspection/fields_field.rb
 - lib/graph_ql/introspection/input_fields_field.rb
 - lib/graph_ql/introspection/input_value_type.rb
+- lib/graph_ql/introspection/interfaces_field.rb
 - lib/graph_ql/introspection/of_type_field.rb
 - lib/graph_ql/introspection/possible_types_field.rb
 - lib/graph_ql/introspection/schema_type.rb
 - lib/graph_ql/introspection/type_kind_enum.rb
 - lib/graph_ql/introspection/type_type.rb
+- lib/graph_ql/introspection/typename_field.rb
+- lib/graph_ql/parser.rb
 - lib/graph_ql/parser/nodes.rb
 - lib/graph_ql/parser/parser.rb
 - lib/graph_ql/parser/transform.rb
@@ -208,10 +195,31 @@ files:
 - lib/graph_ql/query/type_resolver.rb
 - lib/graph_ql/repl.rb
 - lib/graph_ql/schema.rb
+- lib/graph_ql/schema/each_item_validator.rb
+- lib/graph_ql/schema/field_validator.rb
+- lib/graph_ql/schema/implementation_validator.rb
+- lib/graph_ql/schema/schema_validator.rb
 - lib/graph_ql/schema/type_reducer.rb
+- lib/graph_ql/schema/type_validator.rb
+- lib/graph_ql/static_validation.rb
+- lib/graph_ql/static_validation/argument_literals_are_compatible.rb
+- lib/graph_ql/static_validation/arguments_are_defined.rb
+- lib/graph_ql/static_validation/arguments_validator.rb
+- lib/graph_ql/static_validation/directives_are_defined.rb
+- lib/graph_ql/static_validation/fields_are_defined_on_type.rb
+- lib/graph_ql/static_validation/fields_have_appropriate_selections.rb
+- lib/graph_ql/static_validation/fields_will_merge.rb
+- lib/graph_ql/static_validation/fragment_types_exist.rb
+- lib/graph_ql/static_validation/fragments_are_used.rb
+- lib/graph_ql/static_validation/literal_validator.rb
+- lib/graph_ql/static_validation/message.rb
+- lib/graph_ql/static_validation/required_arguments_are_present.rb
+- lib/graph_ql/static_validation/type_stack.rb
+- lib/graph_ql/static_validation/validator.rb
 - lib/graph_ql/type_kinds.rb
-- lib/graph_ql/types/abstract_type.rb
+- lib/graph_ql/types/argument_definer.rb
 - lib/graph_ql/types/boolean_type.rb
+- lib/graph_ql/types/field_definer.rb
 - lib/graph_ql/types/float_type.rb
 - lib/graph_ql/types/input_object_type.rb
 - lib/graph_ql/types/input_value.rb
@@ -224,10 +232,6 @@ files:
 - lib/graph_ql/types/string_type.rb
 - lib/graph_ql/types/type_definer.rb
 - lib/graph_ql/union.rb
-- lib/graph_ql/validations/fields_are_defined_on_type.rb
-- lib/graph_ql/validations/fields_will_merge.rb
-- lib/graph_ql/validations/fragments_are_used.rb
-- lib/graph_ql/validator.rb
 - lib/graph_ql/version.rb
 - lib/graphql.rb
 - readme.md
@@ -243,14 +247,23 @@ files:
 - spec/graph_ql/parser/visitor_spec.rb
 - spec/graph_ql/query/operation_resolver_spec.rb
 - spec/graph_ql/query_spec.rb
+- spec/graph_ql/schema/field_validator_spec.rb
 - spec/graph_ql/schema/type_reducer_spec.rb
+- spec/graph_ql/schema/type_validator_spec.rb
+- spec/graph_ql/static_validation/argument_literals_are_compatible_spec.rb
+- spec/graph_ql/static_validation/arguments_are_defined_spec.rb
+- spec/graph_ql/static_validation/directives_are_defined_spec.rb
+- spec/graph_ql/static_validation/fields_are_defined_on_type_spec.rb
+- spec/graph_ql/static_validation/fields_have_appropriate_selections_spec.rb
+- spec/graph_ql/static_validation/fields_will_merge_spec.rb
+- spec/graph_ql/static_validation/fragment_types_exist_spec.rb
+- spec/graph_ql/static_validation/fragments_are_used_spec.rb
+- spec/graph_ql/static_validation/required_arguments_are_present_spec.rb
+- spec/graph_ql/static_validation/type_stack_spec.rb
+- spec/graph_ql/static_validation/validator_spec.rb
 - spec/graph_ql/types/input_object_type_spec.rb
 - spec/graph_ql/types/object_type_spec.rb
 - spec/graph_ql/union_spec.rb
-- spec/graph_ql/validations/fields_are_defined_on_type_spec.rb
-- spec/graph_ql/validations/fields_will_merge_spec.rb
-- spec/graph_ql/validations/fragments_are_used_spec.rb
-- spec/graph_ql/validator_spec.rb
 - spec/spec_helper.rb
 - spec/support/dummy_app.rb
 - spec/support/dummy_data.rb
@@ -291,14 +304,23 @@ test_files:
 - spec/graph_ql/parser/visitor_spec.rb
 - spec/graph_ql/query/operation_resolver_spec.rb
 - spec/graph_ql/query_spec.rb
+- spec/graph_ql/schema/field_validator_spec.rb
 - spec/graph_ql/schema/type_reducer_spec.rb
+- spec/graph_ql/schema/type_validator_spec.rb
+- spec/graph_ql/static_validation/argument_literals_are_compatible_spec.rb
+- spec/graph_ql/static_validation/arguments_are_defined_spec.rb
+- spec/graph_ql/static_validation/directives_are_defined_spec.rb
+- spec/graph_ql/static_validation/fields_are_defined_on_type_spec.rb
+- spec/graph_ql/static_validation/fields_have_appropriate_selections_spec.rb
+- spec/graph_ql/static_validation/fields_will_merge_spec.rb
+- spec/graph_ql/static_validation/fragment_types_exist_spec.rb
+- spec/graph_ql/static_validation/fragments_are_used_spec.rb
+- spec/graph_ql/static_validation/required_arguments_are_present_spec.rb
+- spec/graph_ql/static_validation/type_stack_spec.rb
+- spec/graph_ql/static_validation/validator_spec.rb
 - spec/graph_ql/types/input_object_type_spec.rb
 - spec/graph_ql/types/object_type_spec.rb
 - spec/graph_ql/union_spec.rb
-- spec/graph_ql/validations/fields_are_defined_on_type_spec.rb
-- spec/graph_ql/validations/fields_will_merge_spec.rb
-- spec/graph_ql/validations/fragments_are_used_spec.rb
-- spec/graph_ql/validator_spec.rb
 - spec/spec_helper.rb
 - spec/support/dummy_app.rb
 - spec/support/dummy_data.rb