graphql-streaming 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2997980ed238638983e004e2291f16a5c5b4539c
-  data.tar.gz: 6f8e53cc1153a79f6560fc60a266b12f04e6d52e
+  metadata.gz: 8470b0d8e856800e46762341df29cc293dd3b90b
+  data.tar.gz: 7937410284b81b2ed5309fecf96c01565b8fc6b2
 SHA512:
-  metadata.gz: 4f020c2238d33f5fb86ef144b14630baad9ea458535eb40465a0b7839c08b5fa68962e4097fc0e70efef18f1e79d1effab0e31ef58852092d133f411acec6b30
-  data.tar.gz: 98bc9d602d0cd84fa266f1e844e8840abdff20ed133c58c8a2a71c2af16fdacf215beb01300f4a18cbf4e5333d45cf4a4469f9e9e589fce9ce8d3d08dac62a47
+  metadata.gz: 4b3c2d045fef16543b027093fb0b3457a9e5316b9c0ffd75fca8130a1edcf519349d3fcd8d8e8ecdf2fd73c53c007c3c72a08d04e3d717b3320e5bb18850d8de
+  data.tar.gz: 6fec853215152b4218adb7dc58056fb3fad25eff4e4065cd7a0314ca9f65d856e4a81c103b236255bf88690871766c189813d2dd1d9fbd9c425558e8eae392fe

data/README.md

@@ -90,7 +90,7 @@ class GraphqlChannel < ApplicationCable::Channel
 
   def fetch(data)
     query_string = data["query"]
-    variables = ensure_hash(data["variables"] || {})
+    variables = JSON.parse(data["variables"] || "{}")
     context = {
       # ...
     }
@@ -105,7 +105,7 @@ class GraphqlChannel < ApplicationCable::Channel
       merged_ctx = context.merge(stream_ctx)
       # don't forget to prevent stale data
       merged_ctx[:current_user].reload
-      GraphQL.execute(query_string, variables: variables, context: merged_ctx)
+      MySchema.execute(query_string, variables: variables, context: merged_ctx)
     end
   end
 end
@@ -191,7 +191,7 @@ SubscriptionType = GraphQL::ObjectType.define do
   end
 end
 
-MySchema = GraphQL::Schema.new(subscription: SubscriptionType ...)
+MySchema = GraphQL::Schema.define(subscription: SubscriptionType ...)
 ```
 
 #### Triggers
@@ -244,6 +244,7 @@ No further patches will be sent to the client.
 
 - What happens to subscriptions when you redeploy or ActionCable loses its connection? Need to handle reconnecting in some way.
 - Handle errors in subscriber block
+- For a streamed / defered query, we need a way to know when it's done
 - Tests for JS?
 - Other platforms (Pusher, HTTP/2)?
 - Request features from ActionCable

data/lib/graphql/streaming/action_cable_channel.rb

@@ -11,6 +11,7 @@ module GraphQL
 
       # Stop streams which were captured from stream_from
       def stop_specific_streams(streams_to_stop)
+        @_streams ||= []
         @_streams -= streams_to_stop
         streams_to_stop.each do |broadcasting, callback|
           pubsub.unsubscribe broadcasting, callback

data/lib/graphql/streaming/clients/graphql-streaming/graphql_channel.js

@@ -11,6 +11,17 @@ var GraphQLChannel = {
   },
 
   subscription: {
+    _backlog: [],
+
+    // Handle any queries set up before the channel was ready
+    connected: function() {
+      this._graphQLReady = true
+      var _this = this
+      this._backlog.forEach(function(req) {
+        _this.logOrPerform(req[0], req[1])
+      })
+    },
+
     // Called by server-sent events
     received: function(data) {
       GraphQLChannel.log("[GraphQLChannel received]", data)
@@ -36,7 +47,7 @@ var GraphQLChannel = {
       GraphQLChannel.registry.set(queryId, onResponse)
 
       GraphQLChannel.log("[GraphQLChannel sending]", queryString, variables, queryId)
-      this.perform("fetch", {
+      this.logOrPerform("fetch", {
         query: queryString,
         variables: JSON.stringify(variables),
         query_id: queryId,
@@ -55,8 +66,16 @@ var GraphQLChannel = {
     clear: function(queryId) {
       GraphQLChannel.log("[GraphQLChannel clearing]", queryId)
       GraphQLChannel.registry.unset(queryId)
-      this.perform("clear", {query_id: queryId})
-    }
+      this.logOrPerform("clear", {query_id: queryId})
+    },
+
+    logOrPerform(operation, params) {
+      if (this._graphQLReady) {
+        this.perform(operation, params)
+      } else {
+        this._backlog.push([operation, params])
+      }
+    },
   },
 
   // This registry keeps track of outstanding requests

data/lib/graphql/streaming/version.rb

@@ -1,5 +1,5 @@
 module GraphQL
   module Streaming
-    VERSION = "0.2.0"
+    VERSION = "0.3.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphql-streaming
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Robert Mosolgo
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-08-17 00:00:00.000000000 Z
+date: 2016-09-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: graphql