graphql-schema_comparator 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3a1db51082278388a76a88af6545645d72221ed3
-  data.tar.gz: d09f9a815fe13f64a1c89a3cd178a68d54eb033e
+  metadata.gz: bae47fd797c861e89911fafe37a7483acf01945e
+  data.tar.gz: 3a3ef6822c996be20aae3d0e3785ae8fa75549e1
 SHA512:
-  metadata.gz: 1b16777b072b7bbdb6a49bafcacd38885aa17adfc452b3b11055ac980451d2e70a74542b88c5716f2866c9860ca8ba942211a35fb565111df29d305878b87c57
-  data.tar.gz: 4ce22425d9c58150676a091f1df84a08f110e926af5dfd9838de62fdb7977421acf73b3c16d5db8fc23a1a337899963dd51d836a2fb00a3eec368b4359d049ec
+  metadata.gz: 6449c7c8044ebe1c5d586e9a6a99e308ab3b24bd8cee27996da25ff4b3c2793462d4865d8b9de491adec6e58ca2b2492fdc6bb273549831a4f0b9b4764516061
+  data.tar.gz: c3bc07672039aa72c0cb8de702ffa29357c3dd2778ae356cead4f02e242d83fd88f8bd2b9902bd831f8be7cfef8828f2130f1b1c6b9047b6ad84587098f976bc

data/.gitignore

@@ -1,4 +1,5 @@
 /.bundle/
+.ruby-version
 /.yardoc
 /Gemfile.lock
 /_yardoc/

data/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## 0.3.2 (Nov 14 2017)
+
+### New Features
+
+Added changes:
+
+  - `EnumValueDeprecated`
+  - `EnumValueDescriptionChanged`
+
+### Bug fixes
+
+Fix issue in Enum differ (https://github.com/xuorig/graphql-schema_comparator/issues/9)
+
 ## 0.3.1 (Nov 13 2017)
 
 ### Bug Fixes

data/lib/graphql/schema_comparator/changes.rb

@@ -296,15 +296,46 @@ module GraphQL
         end
       end
 
-      # TODO
       class EnumValueDescriptionChanged < AbstractChange
-        def initialize(*)
+        attr_reader :enum, :old_enum_value, :new_enum_value
+
+        def initialize(enum, old_enum_value, new_enum_value)
+          @enum = enum
+          @old_enum_value = old_enum_value
+          @new_enum_value = new_enum_value
+        end
+
+        def message
+          "Description for enum value `#{enum.name}.#{new_enum_value.name}` changed from " \
+            "`#{old_enum_value.description}` to `#{new_enum_value.description}`"
+        end
+
+        def breaking?
+          false
         end
       end
 
-      # TODO
       class EnumValueDeprecated < AbstractChange
-        def initialize(*)
+        attr_reader :enum, :old_enum_value, :new_enum_value
+
+        def initialize(enum, old_enum_value, new_enum_value)
+          @enum = enum
+          @old_enum_value = old_enum_value
+          @new_enum_value = new_enum_value
+        end
+
+        def message
+          if old_enum_value.deprecation_reason
+            "Enum value `#{enum.name}.#{new_enum_value.name}` deprecation reason changed " \
+              "from `#{old_enum_value.deprecation_reason}` to `#{new_enum_value.deprecation_reason}`"
+          else
+            "Enum value `#{enum.name}.#{new_enum_value.name}` was deprecated with reason" \
+              " `#{new_enum_value.deprecation_reason}`"
+          end
+        end
+
+        def breaking?
+          false
         end
       end
 

data/lib/graphql/schema_comparator/diff/enum.rb

@@ -2,29 +2,29 @@ module GraphQL
   module SchemaComparator
     module Diff
       class Enum
-        def initialize(old_type, new_type)
-          @old_type = old_type
-          @new_type = new_type
+        def initialize(old_enum, new_enum)
+          @old_enum = old_enum
+          @new_enum = new_enum
 
-          @old_values = old_type.values
-          @new_values = new_type.values
+          @old_values = old_enum.values
+          @new_values = new_enum.values
         end
 
         def diff
           changes = []
 
-          changes += removed_values.map { |value| Changes::EnumValueRemoved.new(old_type, value) }
-          changes += added_values.map { |value| Changes::EnumValueAdded.new(new_type, value) }
+          changes += removed_values.map { |value| Changes::EnumValueRemoved.new(old_enum, value) }
+          changes += added_values.map { |value| Changes::EnumValueAdded.new(new_enum, value) }
 
           each_common_value do |old_value, new_value|
             # TODO: Add Directive Stuff
 
             if old_value.description != new_value.description
-              changes += Changes::EnumValueDescriptionChanged.new(old_value, new_value)
+              changes << Changes::EnumValueDescriptionChanged.new(new_enum, old_value, new_value)
             end
 
             if old_value.deprecation_reason != new_value.deprecation_reason
-              changes += Changes::EnumValueDeprecated.new(old_value, new_value)
+              changes << Changes::EnumValueDeprecated.new(new_enum, old_value, new_value)
             end
           end
 
@@ -33,24 +33,24 @@ module GraphQL
 
         private
 
-        attr_reader :old_type, :new_type, :old_values, :new_values
+        attr_reader :old_enum, :new_enum, :old_values, :new_values
 
         def each_common_value(&block)
           intersection = old_values.keys & new_values.keys
           intersection.each do |common_value|
-            old_value = old_type.values[common_value]
-            new_value = new_type.values[common_value]
+            old_value = old_enum.values[common_value]
+            new_value = new_enum.values[common_value]
 
             block.call(old_value, new_value)
           end
         end
 
         def removed_values
-          (old_values.keys - new_values.keys).map { |removed| old_type.values[removed] }
+          (old_values.keys - new_values.keys).map { |removed| old_enum.values[removed] }
         end
 
         def added_values
-          (new_values.keys - old_values.keys).map { |added| new_type.values[added] }
+          (new_values.keys - old_values.keys).map { |added| new_enum.values[added] }
         end
       end
     end

data/lib/graphql/schema_comparator/version.rb

@@ -1,5 +1,5 @@
 module GraphQL
   module SchemaComparator
-    VERSION = "0.3.1"
+    VERSION = "0.3.2"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphql-schema_comparator
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Marc-Andre Giroux
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-13 00:00:00.000000000 Z
+date: 2017-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: graphql