graphql-fragment_cache 1.5.0 → 1.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fc02c6847d8e55983814bba96e0bd303893a1639648530048f0ccf6ab1527eab
-  data.tar.gz: 52530f6e108ed656077a02a78a44dd2cf498e4004b9d27897572f6f77aaec353
+  metadata.gz: ac4b97c7253e848ab4ff72052df5b1eb368aa5bd1537b561423cc1ae80419dbc
+  data.tar.gz: 2c6179d4c6fc56e1047f11f886ac05a4a9a5d701fab9222669635e8d82794a31
 SHA512:
-  metadata.gz: e5b95e2b3f68011a8cdc0fc23b3a5f117f0ce9c711efcfb504230f6a84fb8c6c53a156d6671f97c8ea52cad199de597954badb2e456d33303b80e6e2e2105bec
-  data.tar.gz: d7275ef053d1127a17476244bd7253cb98dab81df865195b7bae7241bcd6106564af13848dfeaf39676acb96e962be73fb7782274ae4ccce2190065234b5fbf9
+  metadata.gz: c70fa81b9330e80b4260f8d15beafc3d92cd9ea6b73257234ba518b13e96232a6734793d10a71363531166343aed413605a5d7deb7a11d5bd5c8fc9101ba0bbc
+  data.tar.gz: fbda61fba31e3d14a01d035cc087d212642066aa9548ef2e01d4b2ad1c22c1b651cc57548bc66d3127162979815413943c621917d1d392ccd52e028a9af7fa03

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## master
 
+## 1.5.1 (2021-03-10)
+
+- [PR#53](https://github.com/DmitryTsepelev/graphql-ruby-fragment_cache/pull/53) Use thread-safe query result for final_value ([@bbugh][])
+- [PR#51](https://github.com/DmitryTsepelev/graphql-ruby-fragment_cache/pull/51) Do not cache fragments without final value ([@DmitryTsepelev][])
+
 ## 1.5.0 (2021-02-20)
 
 - [PR#50](https://github.com/DmitryTsepelev/graphql-ruby-fragment_cache/pull/50) Add object_cache_key to CacheKeyBuilder ([@bbugh][])

data/lib/graphql/fragment_cache/cacher.rb

@@ -20,17 +20,21 @@ module GraphQL
         private
 
         def batched_persist(query)
-          query.context.fragments.group_by(&:options).each do |options, group|
+          select_valid_fragments(query).group_by(&:options).each do |options, group|
             hash = group.map { |fragment| [fragment.cache_key, fragment.value] }.to_h
             FragmentCache.cache_store.write_multi(hash, **options)
           end
         end
 
         def persist(query)
-          query.context.fragments.each do |fragment|
+          select_valid_fragments(query).each do |fragment|
             FragmentCache.cache_store.write(fragment.cache_key, fragment.value, **fragment.options)
           end
         end
+
+        def select_valid_fragments(query)
+          query.context.fragments.select(&:with_final_value?)
+        end
       end
     end
   end

data/lib/graphql/fragment_cache/fragment.rb

@@ -28,6 +28,10 @@ module GraphQL
         @cache_key ||= CacheKeyBuilder.call(path: path, query: context.query, **options)
       end
 
+      def with_final_value?
+        !final_value.nil?
+      end
+
       def value
         final_value.dig(*path)
       end
@@ -53,7 +57,7 @@ module GraphQL
       end
 
       def final_value
-        @final_value ||= interpreter_context[:runtime].final_value
+        @final_value ||= context.query.result["data"]
       end
     end
   end

data/lib/graphql/fragment_cache/version.rb

@@ -2,6 +2,6 @@
 
 module GraphQL
   module FragmentCache
-    VERSION = "1.5.0"
+    VERSION = "1.5.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphql-fragment_cache
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.5.1
 platform: ruby
 authors:
 - DmitryTsepelev
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-02-20 00:00:00.000000000 Z
+date: 2021-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: graphql
@@ -150,6 +150,20 @@ dependencies:
     - - '='
       - !ruby/object:Gem::Version
         version: 0.4.9
+- !ruby/object:Gem::Dependency
+  name: graphql-batch
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Fragment cache for graphql-ruby
 email:
 - dmitry.a.tsepelev@gmail.com