graphql-fragment_cache 1.18.1 → 1.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: da685d54588830a63cc96b79d9348f496c3d9e114b8bbd39353d89bbf734a2be
-  data.tar.gz: e97d85a3bb1b1ef33b50f9b784f14d5cf0662a220cb46b3e0195422775ca230a
+  metadata.gz: d4dd3472ddcbe18e4c306b81770b5a9fa2dbe306968d1e16f2d98e81630bfec8
+  data.tar.gz: 96c8cd920f0e46041c803527bbe3679841daa169aae82db6d627747eaf4632b9
 SHA512:
-  metadata.gz: 435e71e009c537926c19b2089815b8633a91f0f30caf49fbc45c71d227ff9923867a52c01ed9a0e0e8eff4c51bfa7887371af5ce51281c74bc0be7fcd9566f82
-  data.tar.gz: 87eadfeba581e7ad08a492ae9c82c6a40406def445b1284943dfa55c320426d7135401761561e3fd7ad1c7c99a987b0a52ec1fc6c5c3a229b8ce5ee5a77e3bc6
+  metadata.gz: c308ffcdfdb6fc7529ec3d094109cf7d21db8380b598435d6274e5b1f89a14110ece6fda565d9bc6429ae907066795597c8815f3e745c9a646033d246b2d1f2d
+  data.tar.gz: 806ef15a72ca9eec45e4cde2e35ba43ceb29194c9ed23d77aa776bd3721a77f4d1b04ae8dc3d189e285be12a3cacd5dd1415faba7f57c745c55cb505eca6322e

data/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 ## master
 
+## 1.19.0 (2023-11-03)
+
+- [PR#104](https://github.com/DmitryTsepelev/graphql-ruby-fragment_cache/pull/104) Support graphql-ruby 2.1.4 ([@DmitryTsepelev][])
+
+## 1.18.2 (2023-02-21)
+
+- [PR#100](https://github.com/DmitryTsepelev/graphql-ruby-fragment_cache/pull/100) Fix an error when `path_cache_key` is nil ([@rince][])
+
 ## 1.18.1 (2023-01-06)
 
 - [PR#96](https://github.com/DmitryTsepelev/graphql-ruby-fragment_cache/pull/96) Properly pass arguments to `write_multi` ([@DmitryTsepelev][])
@@ -172,3 +180,4 @@
 [@daukadolt]: https://github.com/daukadolt
 [@frostmark]: https://github.com/frostmark
 [@KTSCode]: https://github.com/KTSCode
+[@rince]: https://github.com/rince

data/README.md

@@ -469,7 +469,7 @@ def cached_author_inside_batch
 end
 ```
 
-2. Caching does not work for Union types, because of the `Lookahead` implementation: it requires the exact type to be passed to the `selection` method (you can find the [discussion](https://github.com/rmosolgo/graphql-ruby/pull/3007) here). This method is used for cache key building, and I haven't found a workaround yet ([PR in progress](https://github.com/DmitryTsepelev/graphql-ruby-fragment_cache/pull/30)). If you get `Failed to look ahead the field` error — please pass `query_cache_key` explicitly:
+2. Caching does not work for Union types, because of the `Lookahead` implementation: it requires the exact type to be passed to the `selection` method (you can find the [discussion](https://github.com/rmosolgo/graphql-ruby/pull/3007) here). This method is used for cache key building, and I haven't found a workaround yet ([PR in progress](https://github.com/DmitryTsepelev/graphql-ruby-fragment_cache/pull/30)). If you get `Failed to look ahead the field` error — please pass `path_cache_key` explicitly:
 
 ```ruby
 field :cached_avatar_url, String, null: false

data/lib/.rbnext/2.3/graphql/fragment_cache/cache_key_builder.rb

@@ -177,6 +177,8 @@ module GraphQL
       end
 
       def simple_path_cache_key
+        return if path_cache_key.nil?
+
         path_cache_key.split("(").first
       end
 

data/lib/.rbnext/2.7/graphql/fragment_cache/cache_key_builder.rb

@@ -177,6 +177,8 @@ module GraphQL
       end
 
       def simple_path_cache_key
+        return if path_cache_key.nil?
+
         path_cache_key.split("(").first
       end
 

data/lib/graphql/fragment_cache/cache_key_builder.rb

@@ -76,7 +76,7 @@ module GraphQL
               arguments = arguments.is_a?(::GraphQL::Execution::Interpreter::Arguments) ? arguments.keyword_arguments : arguments
               @ast_nodes.each do |ast_node|
                 ast_node.selections.each do |selection|
-                  if GraphQL::FragmentCache.graphql_ruby_after_2_0_13?
+                  if GraphQL::FragmentCache.graphql_ruby_after_2_0_13? && GraphQL::FragmentCache.graphql_ruby_before_2_1_4?
                     find_selected_nodes(selection, next_field_defn, arguments: arguments, matches: next_nodes)
                   else
                     find_selected_nodes(selection, next_field_name, next_field_defn, arguments: arguments, matches: next_nodes)
@@ -177,6 +177,8 @@ module GraphQL
       end
 
       def simple_path_cache_key
+        return if path_cache_key.nil?
+
         path_cache_key.split("(").first
       end
 

data/lib/graphql/fragment_cache/version.rb

@@ -2,6 +2,6 @@
 
 module GraphQL
   module FragmentCache
-    VERSION = "1.18.1"
+    VERSION = "1.19.0"
   end
 end

data/lib/graphql/fragment_cache.rb

@@ -65,6 +65,10 @@ module GraphQL
         check_graphql_version "> 2.0.13"
       end
 
+      def graphql_ruby_before_2_1_4?
+        check_graphql_version "< 2.1.4"
+      end
+
       private
 
       def check_graphql_version(predicate)
@@ -78,7 +82,6 @@ module GraphQL
               "GraphQL::Execution::Interpreter should be enabled for fragment caching"
           end
 
-          puts "schema_defn.analysis_engine #{schema_defn.analysis_engine}"
           unless schema_defn.analysis_engine == GraphQL::Analysis::AST
             raise StandardError,
               "GraphQL::Analysis::AST should be enabled for fragment caching"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphql-fragment_cache
 version: !ruby/object:Gem::Version
-  version: 1.18.1
+  version: 1.19.0
 platform: ruby
 authors:
 - DmitryTsepelev
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-01-05 00:00:00.000000000 Z
+date: 2023-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: graphql
@@ -235,7 +235,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.1
+rubygems_version: 3.4.6
 signing_key:
 specification_version: 4
 summary: Fragment cache for graphql-ruby