graphql-filters 1.0.0 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 69e8dec5946ab6eef47034012795f666d1714a4d67e5cee5ecaa105fd4a33e47
-  data.tar.gz: 52eaaf103d30162c293e6dd71df104455ae6adea20832f5acb1495379e084ab7
+  metadata.gz: 9344189bc4ae82f67f66db0a205d932500cdf8f318588e6129a64bd2374fbbac
+  data.tar.gz: d9e10df965526be218a0459234e7f79bb7626859d5f29af61ed1502559444ae5
 SHA512:
-  metadata.gz: cf5c8e6bd9fa9d30140affe06cb1f5e7cad8f04787a131d42419a28b4ed5a43cb13cd18179c7da3e07645e4cb043cc240f326d0066d8390ff3ca01f4be12c1f3
-  data.tar.gz: 8e0b3de41937ffd98350dec8409fd8757d20d46e4f8f917ffb24ceb0856fa0450736c838a91e3d6333bb152e1d99cd478862a95899a3145ad7c70e089a50b595
+  metadata.gz: f51fe336718070181df965eaab2c072cba21bd596d50c3faff28c342fdfe193996f8f3599d7a53c9940bedd8e327f5098d3abccc28b19c5e2ac8376b4d0aebca
+  data.tar.gz: 987109d5d12d53ebce9d9811f6d392a23bd23104443098ac56e9a19e428c2e725110845b120bd6d81e65a0b3cff104cbf7c25648af63a211fe4704beb7f0b573

data/CHANGELOG.md

@@ -1,12 +1,25 @@
 # Changelog
 
-[//]: # (
+<!--[//]: # (
 ## <Release number> <Date YYYY-MM-DD>
 ### Breaking changes
 ### Deprecations
 ### New features
 ### Bug fixes
-)
+)-->
+
+## 1.0.2 2023-07-24
+
+### Bug fixes
+
+- Fixed constant false conditions
+
+## 1.0.1 2023-03-15
+
+### Bug fixes
+
+- Fixed the priority of options declarations for fields
+- Fixed the override of `method_name` for the column name to use in the Active Record query
 
 ## 1.0.0 2023-03-06
 

data/README.md

@@ -9,7 +9,7 @@ This gem provides a module to include (or prepend, see below) in your resolvers
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'graphql-filters', '~> 0.1.0'
+gem 'graphql-filters', '~> 1.0'
 ```
 
 And then execute:
@@ -24,7 +24,7 @@ The easiest way to use GraphQL Filters is on top of [SearchObject](https://githu
 ```ruby
 class RoutesResolver < BaseResolver
   include SearchObject.module(:graphql)
-  
+
   scope { Route.all }
 
   type [RouteType], null: false
@@ -33,12 +33,12 @@ class RoutesResolver < BaseResolver
 end
 ```
 
-Otherwise, you have to explicitly define a `resolve` method and have it return an `ActiveRecord::Relation`; in this case youy need to prepend `GraphQL::Filters::Filterable` in the resolver, otherwise it won't have access to the starting scope:
+Otherwise, you have to explicitly define a `resolve` method and have it return an `ActiveRecord::Relation`; in this case you need to prepend `GraphQL::Filters::Filterable` in the resolver, otherwise it won't have access to the starting scope:
 
 ```ruby
 class RoutesResolver < BaseResolver
   type [RouteType], null: false
-  
+
   def resolve
     Route.all
   end
@@ -217,7 +217,7 @@ end
   Can be `true` or `false` (default: `true`). Controls whether or not the client can use this field in the filters. Passing `true` or `false` directly to `filter` is a shortcut:
 
 ```ruby
-field :name, String, null: false, filter: false 
+field :name, String, null: false, filter: false
 
 # is equivalent to
 
@@ -229,7 +229,7 @@ field :name, String, null: false, filter: {enabled: false}
   The name of the attribute that the field is tied to in the model. Defaults to the name of the resolver method for the field (which by default is the same as the name of the field itself).
 
 - `association_name`
-  
+
   The name of the Active Record association that the field is tied to in the model. Equivalent to `attribute_name`, has the same default.
 
 ## Plans for future development

data/lib/graphql/filters/dsl/graphql/schema/field.rb

@@ -43,21 +43,18 @@ monkey_patch = Module.new do
                 options
               end
 
-    applied_filter_options_defaults = filter_options_defaults.transform_values do |value|
+    filter_options.merge! options
+    filter_options.merge! kwargs
+  end
+
+  def filter_options
+    @filter_options ||= filter_options_defaults.transform_values do |value|
       if value.is_a? Proc
         value.call self
       else
         value
       end
     end
-
-    filter_options.reverse_merge! applied_filter_options_defaults
-    filter_options.reverse_merge! options
-    filter_options.reverse_merge! kwargs
-  end
-
-  def filter_options
-    @filter_options ||= {}
   end
 end
 

data/lib/graphql/filters/input_types/base_scalar_comparison_input_type.rb

@@ -19,7 +19,7 @@ module GraphQL
                          if value
                            scope.all
                          else
-                           scope.where false
+                           scope.none
                          end
                        }
                      }

data/lib/graphql/filters/input_types/fields_comparison_input_type.rb

@@ -21,7 +21,7 @@ module GraphQL
                        required: false,
                        prepare: lambda { |field_comparator, _context|
                          lambda { |scope|
-                           if scope.klass.attribute_names.include? filter_options[:attribute_name]
+                           if scope.klass.attribute_names.include? filter_options[:attribute_name].to_s
                              field_comparator.call scope, filter_options[:attribute_name]
                            else
                              field_comparator.call scope, filter_options[:association_name]

data/lib/graphql/filters/input_types/list_object_comparison_input_type.rb

@@ -17,7 +17,7 @@ module GraphQL
                          if value
                            scope.all
                          else
-                           scope.where false
+                           scope.none
                          end
                        }
                      }

data/lib/graphql/filters/input_types/object_comparison_input_type.rb

@@ -26,7 +26,7 @@ module GraphQL
                          if value
                            scope.all
                          else
-                           scope.where false
+                           scope.none
                          end
                        }
                      }

data/lib/graphql/filters/version.rb

@@ -1,5 +1,5 @@
 module GraphQL
   module Filters
-    VERSION = '1.0.0'
+    VERSION = '1.0.2'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: graphql-filters
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.2
 platform: ruby
 authors:
 - Moku S.r.l.
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-03-06 00:00:00.000000000 Z
+date: 2023-07-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -64,7 +64,6 @@ files:
 - ".rubocop.yml"
 - CHANGELOG.md
 - Gemfile
-- Gemfile.lock
 - LICENSE
 - README.md
 - Rakefile
@@ -103,7 +102,7 @@ licenses:
 metadata:
   homepage_uri: https://github.com/moku-io/graphql-filters
   source_code_uri: https://github.com/moku-io/graphql-filters
-  changelog_uri: https://github.com/moku-io/graphql-filters
+  changelog_uri: https://github.com/moku-io/graphql-filters/blob/master/CHANGELOG.md
 post_install_message:
 rdoc_options: []
 require_paths:
@@ -119,7 +118,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.3
+rubygems_version: 3.4.6
 signing_key:
 specification_version: 4
 summary: Provide a fully typed interface to filter lists in a GraphQL API.

data/Gemfile.lock

@@ -1,77 +0,0 @@
-PATH
-  remote: .
-  specs:
-    graphql-filters (1.0.0)
-      activerecord (~> 7.0.0)
-      activesupport (~> 7.0.0)
-      graphql (~> 2.0.0)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    activemodel (7.0.4.2)
-      activesupport (= 7.0.4.2)
-    activerecord (7.0.4.2)
-      activemodel (= 7.0.4.2)
-      activesupport (= 7.0.4.2)
-    activesupport (7.0.4.2)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 1.6, < 2)
-      minitest (>= 5.1)
-      tzinfo (~> 2.0)
-    ast (2.4.2)
-    concurrent-ruby (1.2.2)
-    diff-lcs (1.5.0)
-    graphql (2.0.17)
-    i18n (1.12.0)
-      concurrent-ruby (~> 1.0)
-    json (2.6.3)
-    minitest (5.18.0)
-    parallel (1.22.1)
-    parser (3.2.0.0)
-      ast (~> 2.4.1)
-    rainbow (3.1.1)
-    rake (13.0.6)
-    regexp_parser (2.6.2)
-    rexml (3.2.5)
-    rspec (3.12.0)
-      rspec-core (~> 3.12.0)
-      rspec-expectations (~> 3.12.0)
-      rspec-mocks (~> 3.12.0)
-    rspec-core (3.12.0)
-      rspec-support (~> 3.12.0)
-    rspec-expectations (3.12.2)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.12.0)
-    rspec-mocks (3.12.3)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.12.0)
-    rspec-support (3.12.0)
-    rubocop (1.44.1)
-      json (~> 2.3)
-      parallel (~> 1.10)
-      parser (>= 3.2.0.0)
-      rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.24.1, < 2.0)
-      ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.24.1)
-      parser (>= 3.1.1.0)
-    ruby-progressbar (1.11.0)
-    tzinfo (2.0.6)
-      concurrent-ruby (~> 1.0)
-    unicode-display_width (2.4.2)
-
-PLATFORMS
-  arm64-darwin-22
-
-DEPENDENCIES
-  graphql-filters!
-  rake (~> 13.0)
-  rspec (~> 3.0)
-  rubocop (~> 1.21)
-
-BUNDLED WITH
-   2.3.9