graphql-client 0.12.1 → 0.12.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 943d157f589058bdca038c48549ed4acb09d7ffb
-  data.tar.gz: 1f8e6364de03008e01506a6a3daf2ad22c74470c
+  metadata.gz: 00141a0b18656c8a3134bf9b441598ce97eeb1ae
+  data.tar.gz: 749d8bc7f60581177c4c7ea012b6d515180a87e3
 SHA512:
-  metadata.gz: a4d339911ca201b26f256c0253b709951d3353a48768d076c9d5bee48dc1deae7d7158e2ae56d5c7d18cd7531c912f406f82d9c62c777792b4f9e15af49fbf0e
-  data.tar.gz: 34919308f4a441702a8d2c40c888499ad9b1b4abb9f4572425f0e69ad62621e65d87b21b844426a7e81559daa650b513c4df989c8e19cb9d1aad18fa4f3c6f1c
+  metadata.gz: ea43f83a968fa438728cb3316f220a4bc58d206b56af5e2dbaee8709b9717ac6e744594e25e69db1bd1250409cdd8021d503e42f287b5dae97fdf70d51c6e37b
+  data.tar.gz: 3dbab0f1dfd017a1a97aaff1410cbc9971211cf0d507dd6a9b31f19ede515de638e387fc792d6e2f8a4c613624ee867789b3daec4bff5137b021e515b1f44f5c

data/lib/graphql/client/collocated_enforcement.rb

@@ -4,7 +4,7 @@ require "graphql/client/error"
 module GraphQL
   class Client
 
-    # Collcation will not be enforced if a stack trace includes any of these gems.
+    # Collocation will not be enforced if a stack trace includes any of these gems.
     WHITELISTED_GEM_NAMES = %w{pry byebug}
 
     # Raised when method is called from outside the expected file scope.

data/lib/graphql/client/errors.rb

@@ -31,7 +31,7 @@ module GraphQL
         errors
       end
 
-      # Internal: Initalize from collection of errors.
+      # Internal: Initialize from collection of errors.
       #
       # errors - Array of GraphQL Hash error objects
       # path   - Array of String|Integer fields to data
@@ -129,7 +129,7 @@ module GraphQL
       # message.
       def each
         return enum_for(:each) unless block_given?
-        messages.keys.each do |field|
+        messages.each_key do |field|
           messages[field].each { |error| yield field, error }
         end
       end

data/lib/graphql/client/erubi_enhancer.rb

@@ -5,7 +5,7 @@ module GraphQL
     # Public: Erubi enhancer that adds support for GraphQL static query sections.
     #
     #   <%graphql
-    #     query GetVerison {
+    #     query GetVersion {
     #       version
     #     }
     #   %>

data/lib/graphql/client/erubis.rb

@@ -13,7 +13,7 @@ module GraphQL
     # query sections.
     #
     #   <%graphql
-    #     query GetVerison {
+    #     query GetVersion {
     #       version
     #     }
     #   %>

data/lib/graphql/client/erubis_enhancer.rb

@@ -5,7 +5,7 @@ module GraphQL
     # Public: Erubis enhancer that adds support for GraphQL static query sections.
     #
     #   <%graphql
-    #     query GetVerison {
+    #     query GetVersion {
     #       version
     #     }
     #   %>

data/lib/graphql/client/hash_with_indifferent_access.rb

@@ -16,7 +16,7 @@ module GraphQL
         @hash = hash
         @aliases = {}
 
-        hash.keys.each do |key|
+        hash.each_key do |key|
           if key.is_a?(String)
             key_alias = ActiveSupport::Inflector.underscore(key)
             @aliases[key_alias] = key if key != key_alias
@@ -43,6 +43,10 @@ module GraphQL
       alias has_key? key?
       alias member? key?
 
+      def each_key(&block)
+        @hash.each_key { |key| yield convert_value(key) }
+      end
+
       private
 
       def convert_value(key)

data/lib/graphql/client/schema.rb

@@ -22,7 +22,7 @@ module GraphQL
           when GraphQL::ListType
             define_class(definition, irep_node, type.of_type).to_list_type
           else
-            const_get(type.name).define_class(definition, irep_node)
+            get_class(type.name).define_class(definition, irep_node)
           end
 
           irep_node.ast_node.directives.inject(type_klass) do |klass, directive|
@@ -33,6 +33,28 @@ module GraphQL
             end
           end
         end
+
+        def get_class(type_name)
+          const_get(normalize_type_name(type_name))
+        end
+
+        def set_class(type_name, klass)
+          class_name = normalize_type_name(type_name)
+
+          if constants.include?(class_name.to_sym)
+            raise ArgumentError,
+              "Can't define #{class_name} to represent type #{type_name} " \
+              "because it's already defined"
+          end
+
+          const_set(class_name, klass)
+        end
+
+        private
+
+        def normalize_type_name(type_name)
+          type_name =~ /\A[A-Z]/ ? type_name : type_name.camelize
+        end
       end
 
       def self.generate(schema)
@@ -48,7 +70,7 @@ module GraphQL
           next if name.start_with?("__")
           if klass = class_for(schema, type, cache)
             klass.schema_module = mod
-            mod.const_set(name, klass)
+            mod.set_class(name, klass)
           end
         end
 

data/lib/graphql/client/schema/interface_type.rb

@@ -22,7 +22,7 @@ module GraphQL
 
         def define_class(definition, irep_node)
           new(irep_node.typed_children.keys.map { |ctype|
-            schema_module.const_get(ctype.name).define_class(definition, irep_node)
+            schema_module.get_class(ctype.name).define_class(definition, irep_node)
           })
         end
       end

data/lib/graphql/client/schema/union_type.rb

@@ -22,7 +22,7 @@ module GraphQL
 
         def define_class(definition, irep_node)
           new(irep_node.typed_children.keys.map { |ctype|
-            schema_module.const_get(ctype.name).define_class(definition, irep_node)
+            schema_module.get_class(ctype.name).define_class(definition, irep_node)
           })
         end
       end

data/lib/rubocop/cop/graphql/heredoc.rb

@@ -19,11 +19,11 @@ module RuboCop
           return unless node.location.expression.source =~ /^<<(-|~)?GRAPHQL/
 
           node.each_child_node(:begin) do |begin_node|
-            add_offense(begin_node, :expression, "Do not interpolate variables into GraphQL queries, " \
+            add_offense(begin_node, location: :expression, message: "Do not interpolate variables into GraphQL queries, " \
               "used variables instead.")
           end
 
-          add_offense(node, :expression, "GraphQL heredocs should be quoted. <<-'GRAPHQL'")
+          add_offense(node, location: :expression, message: "GraphQL heredocs should be quoted. <<-'GRAPHQL'")
         end
 
         def autocorrect(node)

data/lib/rubocop/cop/graphql/overfetch.rb

@@ -44,7 +44,7 @@ module RuboCop
 
           fields.each do |field, count|
             next if count > 0
-            add_offense(nil, ranges[field], "GraphQL field '#{field}' query but was not used in template.")
+            add_offense(nil, location: ranges[field], message: "GraphQL field '#{field}' query but was not used in template.")
           end
         end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphql-client
 version: !ruby/object:Gem::Version
-  version: 0.12.1
+  version: 0.12.2
 platform: ruby
 authors:
 - GitHub
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-31 00:00:00.000000000 Z
+date: 2017-11-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -126,28 +126,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '0.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.47'
+        version: '0.49'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.47'
+        version: '0.49'
 description: A Ruby library for declaring, composing and executing GraphQL queries
 email: engineering@github.com
 executables: []
@@ -211,7 +211,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.6.12
 signing_key: 
 specification_version: 4
 summary: GraphQL Client