graphql-activerecord 0.10.0.pre.alpha1 → 0.10.0.pre.alpha2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 492bdd93511565f485130b3faa32d9af36eed176
-  data.tar.gz: bafa803ca1452a1f7ceefe66362cf4c063e06a49
+  metadata.gz: 1de65b95cb8f19cdca7643404e8dd55c072e2a3b
+  data.tar.gz: a21768845b286ae9f539725e2d7ab52002b6d3c0
 SHA512:
-  metadata.gz: 3e5652bd12e1b46d9bb1834aa8eebe149f5e484d79d29fa7d25297121e626f0962729199dc135e532d348344f4105ca35b3f2b6be5d5c3c02aaca938f0b37edf
-  data.tar.gz: ada3b96ec9bcdbfbdf0dee07ed79ccce4b603a7ac353a99f0b2acc65cec877f081d496e4e39a688f6d1e2a27bec5696424fd1ae6eb25efca36fefc1157c895a5
+  metadata.gz: 97aa43f8f65466f9b069786fbba22f7552f775c42693b3d148fdc931cd7d41606e729c4af73e75f4708a23ea4af7397b11ddf202bac57e9a501d96d787371cce
+  data.tar.gz: 9b541a012f17e0b7cb6dbba60110d64fcc5df04fd34eec2624d2ee7f6c91990bac411e42860b4211b62416581d5fbdf6aae5cb008b536fd7dd6712cc41870bd3

data/lib/graphql/models/reflection.rb

@@ -16,12 +16,20 @@ module GraphQL::Models
       # Determines if the attribute (or association) is required by examining presence validators
       # and the nullability of the column in the database
       def is_required(model_class, attr_or_assoc)
+        # Check for non-nullability on the column itself
         return true if model_class.columns_hash[attr_or_assoc.to_s]&.null == false
 
-        model_class.validators_on(attr_or_assoc)
+        # Check for a presence validator on the association
+        return true if model_class.validators_on(attr_or_assoc)
           .select { |v| v.is_a?(ActiveModel::Validations::PresenceValidator) }
           .reject { |v| v.options.include?(:if) || v.options.include?(:unless) }
           .any?
+
+        # If it's a belongs_to association, check for nullability on the foreign key
+        reflection = model_class.reflect_on_association(attr_or_assoc)
+        return true if reflection && reflection.macro == :belongs_to && is_required(model_class, reflection.foreign_key)
+
+        false
       end
 
       # Returns a struct that tells you the input and output GraphQL types for an attribute

data/lib/graphql/models/version.rb

@@ -1,5 +1,5 @@
 module GraphQL
   module Models
-    VERSION = "0.10.0-alpha1"
+    VERSION = "0.10.0-alpha2"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: graphql-activerecord
 version: !ruby/object:Gem::Version
-  version: 0.10.0.pre.alpha1
+  version: 0.10.0.pre.alpha2
 platform: ruby
 authors:
 - Ryan Foster