graphlient 0.8.0 → 0.9.0

data/spec/graphlient/query_spec.rb

@@ -1,105 +1,105 @@
-require 'spec_helper'
-
-describe Graphlient::Query do
-  describe '#initialize' do
-    context 'query' do
-      it 'returns expected query with block' do
-        query = Graphlient::Query.new do
-          query do
-            invoice do
-              line_items
-            end
-          end
-        end
-        expect(query.to_s).to eq "query{\n  invoice{\n    line_items\n    }\n  }"
-      end
-
-      it 'returns expected query with block and attributes' do
-        query = Graphlient::Query.new do
-          query do
-            invoice(id: 10) do
-              line_items
-            end
-          end
-        end
-        expect(query.to_s).to eq "query{\n  invoice(id: 10){\n    line_items\n    }\n  }"
-      end
-
-      it 'returns expected query with block and attributes' do
-        query = Graphlient::Query.new do
-          query do
-            invoice(id: 10) do
-              line_items(name: 'test')
-            end
-          end
-        end
-        expect(query.to_s).to eq "query{\n  invoice(id: 10){\n    line_items(name: \"test\")\n    }\n  }"
-      end
-
-      it 'returns expected query with block and local variables with proper type' do
-        int_arg = 10
-        float_arg = 10.3
-        str_arg = 'new name'
-        array_arg = ['str_item', 2]
-        query = Graphlient::Query.new do
-          query do
-            invoice(id: int_arg, threshold: float_arg, item_list: array_arg) do
-              line_items(name: str_arg)
-            end
-          end
-        end
-        expect(query.to_s).to eq "query{\n  invoice(id: 10, threshold: 10.3, item_list: [\"str_item\", 2]){\n    line_items(name: \"new name\")\n    }\n  }"
-      end
-
-      it 'returns proper query' do
-        query = Graphlient::Query.new do
-          query do
-            invoice(id: 10) do
-              line_items do
-                line_item_type
-              end
-            end
-          end
-        end
-        expect(query.to_s).to eq "query{\n  invoice(id: 10){\n    line_items{\n      line_item_type\n      }\n    }\n  }"
-      end
-
-      it 'returns proper query with query variables' do
-        query = Graphlient::Query.new do
-          query(invoice_id: :int, names: [:string!]) do
-            invoice(id: :invoice_id, name: :names) do
-              line_items do
-                line_item_type
-              end
-            end
-          end
-        end
-        expect(query.to_s).to eq "query($invoice_id: Int, $names: [String!]){\n  invoice(id: $invoice_id, name: $names){\n    line_items{\n      line_item_type\n      }\n    }\n  }"
-      end
-    end
-
-    context 'mutation' do
-      it 'returns proper mutation with arguments' do
-        mutation = Graphlient::Query.new do
-          mutation do
-            invoice(type: 'test', fee_in_cents: 20_000, total_cents: 50_000, line_items: %w[li1 li2]) do
-              id
-            end
-          end
-        end
-        expect(mutation.to_s).to eq "mutation{\n  invoice(type: \"test\", fee_in_cents: 20000, total_cents: 50000, line_items: [\"li1\", \"li2\"]){\n    id\n    }\n  }"
-      end
-    end
-
-    it 'returns proper mutation for relay style mutation' do
-      mutation = Graphlient::Query.new do
-        mutation do
-          invoice(input: { type: 'test', fee_in_cents: 20_000, total_cents: 50_000, line_items: %w[li1 li2] }) do
-            id
-          end
-        end
-      end
-      expect(mutation.to_s).to eq "mutation{\n  invoice(input: { type: \"test\", fee_in_cents: 20000, total_cents: 50000, line_items: [\"li1\", \"li2\"] }){\n    id\n    }\n  }"
-    end
-  end
-end
+require 'spec_helper'
+
+describe Graphlient::Query do
+  describe '#initialize' do
+    context 'query' do
+      it 'returns expected query with block' do
+        query = Graphlient::Query.new do
+          query do
+            invoice do
+              line_items
+            end
+          end
+        end
+        expect(query.to_s).to eq "query{\n  invoice{\n    line_items\n    }\n  }"
+      end
+
+      it 'returns expected query with block and attributes' do
+        query = Graphlient::Query.new do
+          query do
+            invoice(id: 10) do
+              line_items
+            end
+          end
+        end
+        expect(query.to_s).to eq "query{\n  invoice(id: 10){\n    line_items\n    }\n  }"
+      end
+
+      it 'returns expected query with block and attributes' do
+        query = Graphlient::Query.new do
+          query do
+            invoice(id: 10) do
+              line_items(name: 'test')
+            end
+          end
+        end
+        expect(query.to_s).to eq "query{\n  invoice(id: 10){\n    line_items(name: \"test\")\n    }\n  }"
+      end
+
+      it 'returns expected query with block and local variables with proper type' do
+        int_arg = 10
+        float_arg = 10.3
+        str_arg = 'new name'
+        array_arg = ['str_item', 2]
+        query = Graphlient::Query.new do
+          query do
+            invoice(id: int_arg, threshold: float_arg, item_list: array_arg) do
+              line_items(name: str_arg)
+            end
+          end
+        end
+        expect(query.to_s).to eq "query{\n  invoice(id: 10, threshold: 10.3, item_list: [\"str_item\", 2]){\n    line_items(name: \"new name\")\n    }\n  }"
+      end
+
+      it 'returns proper query' do
+        query = Graphlient::Query.new do
+          query do
+            invoice(id: 10) do
+              line_items do
+                line_item_type
+              end
+            end
+          end
+        end
+        expect(query.to_s).to eq "query{\n  invoice(id: 10){\n    line_items{\n      line_item_type\n      }\n    }\n  }"
+      end
+
+      it 'returns proper query with query variables' do
+        query = Graphlient::Query.new do
+          query(invoice_id: :int, names: [:string!]) do
+            invoice(id: :invoice_id, name: :names) do
+              line_items do
+                line_item_type
+              end
+            end
+          end
+        end
+        expect(query.to_s).to eq "query($invoice_id: Int, $names: [String!]){\n  invoice(id: $invoice_id, name: $names){\n    line_items{\n      line_item_type\n      }\n    }\n  }"
+      end
+    end
+
+    context 'mutation' do
+      it 'returns proper mutation with arguments' do
+        mutation = Graphlient::Query.new do
+          mutation do
+            invoice(type: 'test', fee_in_cents: 20_000, total_cents: 50_000, line_items: %w[li1 li2]) do
+              id
+            end
+          end
+        end
+        expect(mutation.to_s).to eq "mutation{\n  invoice(type: \"test\", fee_in_cents: 20000, total_cents: 50000, line_items: [\"li1\", \"li2\"]){\n    id\n    }\n  }"
+      end
+    end
+
+    it 'returns proper mutation for relay style mutation' do
+      mutation = Graphlient::Query.new do
+        mutation do
+          invoice(input: { type: 'test', fee_in_cents: 20_000, total_cents: 50_000, line_items: %w[li1 li2] }) do
+            id
+          end
+        end
+      end
+      expect(mutation.to_s).to eq "mutation{\n  invoice(input: { type: \"test\", fee_in_cents: 20000, total_cents: 50000, line_items: [\"li1\", \"li2\"] }){\n    id\n    }\n  }"
+    end
+  end
+end

data/spec/graphlient/schema_spec.rb

@@ -1,56 +1,56 @@
-require 'spec_helper'
-require 'tempfile'
-
-describe Graphlient::Schema do
-  let(:client) { Graphlient::Client.new(url) }
-  let(:url) { 'http://graph.biz/graphql' }
-  let(:schema) { client.schema }
-
-  describe '#dump!' do
-    let!(:introspection_query_request) do
-      stub_request(:post, url)
-        .with(body: /query IntrospectionQuery/)
-        .to_return(
-          body: DummySchema.execute(GraphQL::Introspection::INTROSPECTION_QUERY).to_json,
-          headers: { 'Content-Type' => 'application/json' }
-        )
-    end
-
-    context 'when schema path is not given' do
-      it 'raises error' do
-        expect { schema.dump! }.to raise_error(Graphlient::Schema::MissingConfigurationError)
-      end
-    end
-
-    context 'when schema path is given' do
-      let(:client) { Graphlient::Client.new(url, schema_path: @schema_path) }
-      let(:schema_path) { @schema_path }
-
-      around(:each) do |example|
-        Tempfile.open('graphql_schema.json') do |file|
-          @schema_path = file.path
-          example.run
-          @schema_path = nil
-        end
-      end
-
-      it 'makes introspection query' do
-        schema.dump!
-        expect(introspection_query_request).to have_been_made.once
-      end
-
-      it 'updates schema json file' do
-        expect { schema.dump! }.to(change { File.read(@schema_path) })
-      end
-
-      context 'with a schema file' do
-        before do
-          schema.dump!
-        end
-        it 'reads the schema' do
-          expect(client.schema).to be_a Graphlient::Schema
-        end
-      end
-    end
-  end
-end
+require 'spec_helper'
+require 'tempfile'
+
+describe Graphlient::Schema do
+  let(:client) { Graphlient::Client.new(url) }
+  let(:url) { 'http://graph.biz/graphql' }
+  let(:schema) { client.schema }
+
+  describe '#dump!' do
+    let!(:introspection_query_request) do
+      stub_request(:post, url)
+        .with(body: /query IntrospectionQuery/)
+        .to_return(
+          body: DummySchema.execute(GraphQL::Introspection::INTROSPECTION_QUERY).to_json,
+          headers: { 'Content-Type' => 'application/json' }
+        )
+    end
+
+    context 'when schema path is not given' do
+      it 'raises error' do
+        expect { schema.dump! }.to raise_error(Graphlient::Schema::MissingConfigurationError)
+      end
+    end
+
+    context 'when schema path is given' do
+      let(:client) { Graphlient::Client.new(url, schema_path: @schema_path) }
+      let(:schema_path) { @schema_path }
+
+      around(:each) do |example|
+        Tempfile.open('graphql_schema.json') do |file|
+          @schema_path = file.path
+          example.run
+          @schema_path = nil
+        end
+      end
+
+      it 'makes introspection query' do
+        schema.dump!
+        expect(introspection_query_request).to have_been_made.once
+      end
+
+      it 'updates schema json file' do
+        expect { schema.dump! }.to(change { File.read(@schema_path) })
+      end
+
+      context 'with a schema file' do
+        before do
+          schema.dump!
+        end
+        it 'reads the schema' do
+          expect(client.schema).to be_a Graphlient::Schema
+        end
+      end
+    end
+  end
+end

data/spec/graphlient/static_client_query_spec.rb

@@ -1,68 +1,75 @@
-require 'spec_helper'
-
-describe Graphlient::Client do
-  describe 'parse and execute' do
-    module Graphlient::Client::Spec
-      Client = Graphlient::Client.new(
-        'http://graph.biz/graphql',
-        headers: { 'Authorization' => 'Bearer 1231' },
-        allow_dynamic_queries: false
-      ) do |client|
-        client.http do |h|
-          h.connection do |c|
-            c.adapter Faraday::Adapter::Rack, Sinatra::Application
-          end
-        end
-      end
-
-      StringQuery = Client.parse <<~GRAPHQL
-        query($some_id: Int) {
-          invoice(id: $some_id) {
-            id
-            feeInCents
-          }
-        }
-      GRAPHQL
-
-      BlockQuery = Client.parse do
-        query(some_id: :int) do
-          invoice(id: :some_id) do
-            id
-            feeInCents
-          end
-        end
-      end
-    end
-
-    it 'defaults allow_dynamic_queries to false' do
-      expect(Graphlient::Client::Spec::Client.send(:client).allow_dynamic_queries).to be false
-    end
-
-    context 'with string-based queries' do
-      it 'parses a string query to an OperationDefinition' do
-        expect(Graphlient::Client::Spec::StringQuery.class).to be GraphQL::Client::OperationDefinition
-      end
-
-      it 'sets the OperationDefinition that came from a string to have a name' do
-        expect(Graphlient::Client::Spec::StringQuery.definition_name).to eql 'Graphlient__Client__Spec__StringQuery'
-      end
-    end
-
-    context 'with both string- and block-based queries' do
-      it 'gets identical results parsing equivalent string- and block-based queries' do
-        block_response = Graphlient::Client::Spec::Client.execute(Graphlient::Client::Spec::BlockQuery, some_id: 42)
-        string_response = Graphlient::Client::Spec::Client.execute(Graphlient::Client::Spec::StringQuery, some_id: 42)
-        expect(string_response.to_h).to eq block_response.to_h
-      end
-    end
-
-    context 'executing a query' do
-      it 'succeeds with expected feeInCents' do
-        response = Graphlient::Client::Spec::Client.execute(Graphlient::Client::Spec::BlockQuery, some_id: 42)
-        invoice = response.data.invoice
-        expect(invoice.id).to eq '42'
-        expect(invoice.fee_in_cents).to eq 20_000
-      end
-    end
-  end
-end
+require 'spec_helper'
+
+describe Graphlient::Client do
+  describe 'parse and execute' do
+    module Graphlient::Client::Spec
+      # schema_path avoids an HTTP schema fetch at file-load time.
+      # No Rack adapter needed here; parsing is local and execution is handled
+      # by the stub_request below.
+      Client = Graphlient::Client.new(
+        'http://graph.biz/graphql',
+        schema_path: 'spec/support/fixtures/invoice_api.json',
+        headers: { 'Authorization' => 'Bearer 1231' },
+        allow_dynamic_queries: false
+      )
+
+      StringQuery = Client.parse <<~GRAPHQL
+        query($some_id: Int) {
+          invoice(id: $some_id) {
+            id
+            feeInCents
+          }
+        }
+      GRAPHQL
+
+      BlockQuery = Client.parse do
+        query(some_id: :int) do
+          invoice(id: :some_id) do
+            id
+            feeInCents
+          end
+        end
+      end
+    end
+
+    # Route execution requests through the Sinatra dummy app via WebMock.
+    # to_rack works reliably across Ruby/gem versions; Faraday::Adapter::Rack
+    # can be intercepted before dispatch on some Ruby 3.x + WebMock combinations.
+    before do
+      stub_request(:post, 'http://graph.biz/graphql')
+        .with(headers: { 'Authorization' => 'Bearer 1231' })
+        .to_rack(Sinatra::Application)
+    end
+
+    it 'defaults allow_dynamic_queries to false' do
+      expect(Graphlient::Client::Spec::Client.send(:client).allow_dynamic_queries).to be false
+    end
+
+    context 'with string-based queries' do
+      it 'parses a string query to an OperationDefinition' do
+        expect(Graphlient::Client::Spec::StringQuery.class).to be GraphQL::Client::OperationDefinition
+      end
+
+      it 'sets the OperationDefinition that came from a string to have a name' do
+        expect(Graphlient::Client::Spec::StringQuery.definition_name).to eql 'Graphlient__Client__Spec__StringQuery'
+      end
+    end
+
+    context 'with both string- and block-based queries' do
+      it 'gets identical results parsing equivalent string- and block-based queries' do
+        block_response  = Graphlient::Client::Spec::Client.execute(Graphlient::Client::Spec::BlockQuery, some_id: 42)
+        string_response = Graphlient::Client::Spec::Client.execute(Graphlient::Client::Spec::StringQuery, some_id: 42)
+        expect(string_response.to_h).to eq block_response.to_h
+      end
+    end
+
+    context 'executing a query' do
+      it 'succeeds with expected feeInCents' do
+        response = Graphlient::Client::Spec::Client.execute(Graphlient::Client::Spec::BlockQuery, some_id: 42)
+        invoice  = response.data.invoice
+        expect(invoice.id).to eq '42'
+        expect(invoice.fee_in_cents).to eq 20_000
+      end
+    end
+  end
+end

data/spec/graphlient/webmock_client_query_spec.rb

@@ -1,41 +1,41 @@
-require 'spec_helper'
-
-describe 'App' do
-  let(:url) { 'http://graph.biz/graphql' }
-  let(:client) { Graphlient::Client.new(url, schema_path: 'spec/support/fixtures/invoice_api.json') }
-  let(:query) do
-    <<~GRAPHQL
-      query{
-        invoice(id: 42) {
-          id
-          feeInCents
-        }
-      }
-    GRAPHQL
-  end
-  let(:json_response) do
-    {
-      'data' => {
-        'invoice' => {
-          'id' => '42',
-          'feeInCents' => 2000
-        }
-      }
-    }.to_json
-  end
-
-  before do
-    stub_request(:post, url).to_return(
-      status: 200,
-      body: json_response,
-      headers: { 'Content-Type' => 'application/json' }
-    )
-  end
-
-  it 'returns invoice fees' do
-    response = client.query(query)
-    expect(response.data).to be_truthy
-    expect(response.data.invoice.id).to eq('42')
-    expect(response.data.invoice.fee_in_cents).to eq(2000)
-  end
-end
+require 'spec_helper'
+
+describe 'App' do
+  let(:url) { 'http://graph.biz/graphql' }
+  let(:client) { Graphlient::Client.new(url, schema_path: 'spec/support/fixtures/invoice_api.json') }
+  let(:query) do
+    <<~GRAPHQL
+      query{
+        invoice(id: 42) {
+          id
+          feeInCents
+        }
+      }
+    GRAPHQL
+  end
+  let(:json_response) do
+    {
+      'data' => {
+        'invoice' => {
+          'id' => '42',
+          'feeInCents' => 2000
+        }
+      }
+    }.to_json
+  end
+
+  before do
+    stub_request(:post, url).to_return(
+      status: 200,
+      body: json_response,
+      headers: { 'Content-Type' => 'application/json' }
+    )
+  end
+
+  it 'returns invoice fees' do
+    response = client.query(query)
+    expect(response.data).to be_truthy
+    expect(response.data.invoice.id).to eq('42')
+    expect(response.data.invoice.fee_in_cents).to eq(2000)
+  end
+end

data/spec/spec_helper.rb

@@ -1,14 +1,26 @@
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
-
-require 'rubygems'
-require 'rspec'
-require 'graphlient'
-require 'byebug' if RUBY_ENGINE != 'jruby'
-require 'rack/test'
-require 'webmock/rspec'
-require 'vcr'
-require 'faraday/rack'
-
-Dir[File.join(File.dirname(__FILE__), 'support', '**/*.rb')].each do |file|
-  require file
-end
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
+
+require 'rubygems'
+require 'rspec'
+
+# Standard-library gems unbundled from newer Ruby (3.4+) and needed by the test
+# dependencies below — required here so they're loaded before `graphlient` pulls
+# them in transitively:
+#   - ostruct:  graphql 1.13's compatibility specs reference OpenStruct
+#   - mutex_m:  activesupport 5.x depends on it
+require 'ostruct'
+require 'mutex_m'
+require 'graphlient'
+begin
+  require 'byebug' if RUBY_ENGINE != 'jruby'
+rescue LoadError
+  # byebug not available on all platforms (e.g. Windows x64-mingw-ucrt)
+end
+require 'rack/test'
+require 'webmock/rspec'
+require 'vcr'
+require 'faraday/rack'
+
+Dir[File.join(File.dirname(__FILE__), 'support', '**/*.rb')].each do |file|
+  require file
+end

data/spec/support/context/dummy_client.rb

@@ -1,26 +1,33 @@
-RSpec.shared_context 'Dummy Client', shared_context: :metadata do
-  include Rack::Test::Methods
-
-  def app
-    Sinatra::Application
-  end
-
-  let(:endpoint) { 'http://graph.biz/graphql' }
-
-  let(:headers) do
-    {
-      'Authorization' => 'Bearer 1231',
-      'Content-Type' => 'application/json'
-    }
-  end
-
-  let(:client) do
-    Graphlient::Client.new(endpoint, headers: headers) do |client|
-      client.http do |h|
-        h.connection do |c|
-          c.adapter Faraday::Adapter::Rack, app
-        end
-      end
-    end
-  end
-end
+RSpec.shared_context 'Dummy Client', shared_context: :metadata do
+  include Rack::Test::Methods
+
+  def app
+    Sinatra::Application
+  end
+
+  let(:endpoint) { 'http://graph.biz/graphql' }
+
+  let(:headers) do
+    {
+      'Authorization' => 'Bearer 1231',
+      'Content-Type' => 'application/json'
+    }
+  end
+
+  # Route all requests through the Sinatra dummy app via WebMock's to_rack adapter.
+  # This is more reliable than configuring Faraday::Adapter::Rack directly because
+  # WebMock intercepts Faraday requests before they reach the adapter layer on some
+  # Ruby/gem version combinations; to_rack routes at the WebMock level instead.
+  before do
+    stub_request(:post, endpoint)
+      .with(headers: { 'Authorization' => 'Bearer 1231' })
+      .to_rack(app)
+  end
+
+  # No schema_path: the to_rack stub above routes schema introspection to the
+  # Sinatra app as well, so graphql-client gets the full live schema including
+  # test-only fields (executionErrorInvoice, partialSuccess etc.).
+  let(:client) do
+    Graphlient::Client.new(endpoint, headers: headers)
+  end
+end