graphlient 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c049e978a0c48e45fe84d49470bc890ae3b6ea86b86aab8158322616c62968dd
-  data.tar.gz: c7307c2b5c6ac6ac2b55ee4d416bbfffee1e29ed0826916254077add10370ee9
+  metadata.gz: 2b777ec75d94d228faa748cadb28c1687b16a377892138a9fc8d1048773b8853
+  data.tar.gz: a3bc9f948ffa5c4fe6368282834b7cd4e7addc00b7d1c90ced575ce41e8a8b3a
 SHA512:
-  metadata.gz: 627d0d04d5ecea5e4c33ea0e59b15ac46fc458f76f179ac624d3519036865ad29267f629b1b3fda7592a50c846ea2cf06cc58a8f188a06caee44715268c18d07
-  data.tar.gz: 9742adef6879fbd08b00350674dced4b4886e476b45388d6d1a1afaaebba440153632e878649ff68beb223b158f365dd180b6db76e8463a13dbbeb4cdf8aa88d
+  metadata.gz: fc0080c0fab50ac5ecee6815fb24e6b216cba32558d010ebd3d9661581b55f3b3fca8b70e11f0e61f96eb471931645c12b3a3b8c2361909da31a15c650ab6bcb
+  data.tar.gz: feb39198706b8b9650da8f6f35f080744df668420d948f2b7d69d84dd3b812301542d5735d1a69f77d865706e5853703861fe440a1ab47ea2cfef3b91712f794

data/.github/workflows/ci.yml

@@ -0,0 +1,29 @@
+name: CI
+
+on: [push, pull_request]
+
+permissions:
+  contents: read
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        entry:
+          - { ruby: 2.7.2 }
+          - { ruby: 3.0.0 }
+          - { ruby: 3.1.2 }
+          - { ruby: "ruby-head", ignore: true }
+          - { ruby: "jruby-9.1.17", ignore: true }
+          - { ruby: "jruby-head", ignore: true }
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.entry.ruby }}
+        bundler-cache: true
+    - name: Run tests
+      continue-on-error: ${{ matrix.entry.ignore || false }}
+      run: bundle exec rspec spec/

data/.github/workflows/danger.yml

@@ -0,0 +1,20 @@
+name: Danger
+
+on: pull_request
+
+jobs:
+  danger:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v3
+      with:
+        fetch-depth: 0
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: 2.7.2
+        bundler-cache: true
+    - run: |
+        # the personal token is public, this is ok, base64 encode to avoid tripping Github
+        TOKEN=$(echo -n NWY1ZmM5MzEyMzNlYWY4OTZiOGU3MmI3MWQ3Mzk0MzgxMWE4OGVmYwo= | base64 --decode)
+        DANGER_GITHUB_API_TOKEN=$TOKEN bundle exec danger --verbose

data/.github/workflows/rubocop.yml

@@ -0,0 +1,19 @@
+name: Rubocop
+
+on: [push, pull_request]
+
+permissions:
+  contents: read
+
+jobs:
+  rubocop:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: 2.7.2
+        bundler-cache: true
+    - name: Run rubocop
+      run: bundle exec rubocop

data/CHANGELOG.md

@@ -1,74 +1,79 @@
-### 0.6.0 (Next)
-* Your contribution here.
+### 0.6.0 (2022/06/11)
 
-### 0.5.0 (12/28/2020)
+* [#87](https://github.com/ashkan18/graphlient/pull/87): Raised `ExecutionError` with partial error response - [@QQism](https://github.com/QQism).
+* [#90](https://github.com/ashkan18/graphlient/pull/90): Added support for Ruby 3.1 - [@QQism](https://github.com/QQism).
+* [#90](https://github.com/ashkan18/graphlient/pull/90): Dropped support for Ruby 2.5 - [@QQism](https://github.com/QQism).
+* [#91](https://github.com/ashkan18/graphlient/pull/91): Update GHA for `danger` with right permissions - [@QQism](https://github.com/QQism).
+* [#89](https://github.com/ashkan18/graphlient/pull/89): Replace Travis CI with Github Actions - [@QQism](https://github.com/QQism).
+
+### 0.5.0 (2020/12/28)
 
 * [#81](https://github.com/ashkan18/graphlient/pull/81): Make graphlient run on ruby 3.0 - [@Burgestrand](https://github.com/Burgestrand).
 * [#79](https://github.com/ashkan18/graphlient/pull/79): Added client testing docs - [@GabrielDzul](https://github.com/GabrielDzul).
 
-### 0.4.0 (5/22/2020)
+### 0.4.0 (2020/05/22)
 
 * [#72](https://github.com/ashkan18/graphlient/pull/72): Add http_options - [@neroleung](https://github.com/neroleung).
 * [#71](https://github.com/ashkan18/graphlient/issues/70): Add `Graphlient::Errors::TimeoutError` - [@BenDrozdoff](https://github.com/BenDrozdoff).
 * [#75](https://github.com/ashkan18/graphlient/pull/75): Support Faraday 1.x - [@jfhinchcliffe](https://github.com/jfhinchcliffe).
 * [#78](https://github.com/ashkan18/graphlient/pull/78): Add description of timeout values - [@sap1enza](https://github.com/sap1enza).
 
-### 0.3.7 (11/14/2019)
+### 0.3.7 (2019/11/14)
 
 * [#68](https://github.com/ashkan18/graphlient/pull/68): Add `Graphlient::Errors::ConnectionFailedError` - [@neroleung](https://github.com/neroleung).
 
-### 0.3.6 (07/23/2019)
+### 0.3.6 (2019/07/23)
 
 * [#63](https://github.com/ashkan18/graphlient/pull/63): Remove unused method for attribute with typo - [@ashkan18](https://github.com/ashkan18).
 * [#62](https://github.com/ashkan18/graphlient/pull/62): Fix typo preventing access to response object on error - [@jmondo](https://github.com/jmondo).
 
-### 0.3.4 (01/31/2019)
+### 0.3.4 (2019/01/31)
 
 * [#56](https://github.com/ashkan18/graphlient/pull/56): Remove safe navigation usage to retain support for Ruby 2.2 - [@avinoth](https://github.com/avinoth).
 * [#57](https://github.com/ashkan18/graphlient/pull/57): Add support for parsing queries from a String - [@ateamlunchbox](https://github.com/ateamlunchbox).
 
-### 0.3.3 (09/23/2018)
+### 0.3.3 (2018/09/23)
 
 * [#50](https://github.com/ashkan18/graphlient/pull/50): More detailed error responses - [@ashkan18](https://github.com/ashkan18).
 
-### 0.3.2 (07/03/2018)
+### 0.3.2 (2018/07/03)
 
 * [#46](https://github.com/ashkan18/graphlient/pull/46): Fix issue with gathering error details when trying `to_s` on `GraphQLError` - [@ashkan18](https://github.com/ashkan18).
 * [#45](https://github.com/ashkan18/graphlient/pull/45): Drop Support for Ruby 2.2 and Lock RuboCop - [@jonallured](https://github.com/jonallured).
 
-### 0.3.1 (04/17/2018)
+### 0.3.1 (2018/04/17)
 
 * [#43](https://github.com/ashkan18/graphlient/pull/43): Allow to load and dump schema to json - [@povilasjurcys](https://github.com/povilasjurcys).
 
-### 0.3.0 (02/22/2018)
+### 0.3.0 (2018/02/22)
 
 * [#38](https://github.com/ashkan18/graphlient/pull/38): Add support for Ruby 2.5 - [@yuki24](https://github.com/yuki24).
 * [#39](https://github.com/ashkan18/graphlient/pull/39): Add support for Ruby 2.2 - [@yuki24](https://github.com/yuki24).
 * [#40](https://github.com/ashkan18/graphlient/pull/40): Add experimental support for JRuby - [@yuki24](https://github.com/yuki24).
 
-### 0.2.0 (11/09/2017)
+### 0.2.0 (2017/11/09)
 
 * [#33](https://github.com/ashkan18/graphlient/pull/33): Added dsl for supporting parametrized queries/mutations - [@ashkan18](https://github.com/ashkan18).
 * [#34](https://github.com/ashkan18/graphlient/issues/34): Fix: don't convert variables to `String` - [@dblock](https://github.com/dblock).
 
-### 0.1.0 (10/27/2017)
+### 0.1.0 (2017/10/27)
 
 * [#31](https://github.com/ashkan18/graphlient/issues/31): Fix: catch execution errors that don't contain field names - [@dblock](https://github.com/dblock).
 
-### 0.0.9 (10/26/2017)
+### 0.0.9 (2017/10/26)
 
 * [#28](https://github.com/ashkan18/graphlient/pull/28): Raise errors in `execute`, not only `query` - [@dblock](https://github.com/dblock).
 * [#29](https://github.com/ashkan18/graphlient/pull/29): Added `Graphlient::Adapters::HTTP::HTTPAdapter` that replaces Faraday with `Net::HTTP` - [@dblock](https://github.com/dblock).
 
-### 0.0.8 (10/26/2017)
+### 0.0.8 (2017/10/26)
 
 * [#27](https://github.com/ashkan18/graphlient/pull/27): Always raise an exception unless a query has succeeded - [@dblock](https://github.com/dblock).
 
-### 0.0.7 (10/24/2017)
+### 0.0.7 (2017/10/24)
 
 * [#26](https://github.com/ashkan18/graphlient/pull/26): Support String queries - [@dblock](https://github.com/dblock).
 
-### 0.0.6 (10/20/2017)
+### 0.0.6 (2017/10/20)
 
 * [#14](https://github.com/ashkan18/graphlient/pull/14): Switch to `graphql-client` for network calls and schema validation - [@ashkan18](https://github.com/ashkan18).
 * [#17](https://github.com/ashkan18/graphlient/pull/17): Specialize server errors as `Graphlient::Errors::Server` - [@dblock](https://github.com/dblock).
@@ -79,16 +84,16 @@
 * [#20](https://github.com/ashkan18/graphlient/pull/20): Added support for parameterized queries and mutations - [@dblock](https://github.com/dblock).
 * [#25](https://github.com/ashkan18/graphlient/pull/25): Added `client.parse` and `client.execute` to parse and execute queries separately - [@dblock](https://github.com/dblock).
 
-### 0.0.5 (10/5/2017)
+### 0.0.5 (2017/10/05)
 
 * [#11](https://github.com/ashkan18/graphlient/pull/11): Fixed query argument types - [@ashkan18](https://github.com/ashkan18).
 
-### 0.0.4 (10/4/2017)
+### 0.0.4 (2017/10/04)
 
 * [#8](https://github.com/ashkan18/graphlient/pull/8): Handle HTTP errors and raise `Graphlient::Errors::HTTP` on failure - [@dblock](https://github.com/dblock).
 * [#5](https://github.com/ashkan18/graphlient/pull/5): Added RuboCop, Ruby-style linter, CHANGELOG, CONTRIBUTING and RELEASING - [@dblock](https://github.com/dblock).
 * [#4](https://github.com/ashkan18/graphlient/pull/4): Refactored Graphlient::Client to take a URL and options, moved extensions - [@dblock](https://github.com/dblock).
 
-### 0.0.3 (10/3/2017)
+### 0.0.3 (2017/10/03)
 
 * Initial public release - [@ashkan18](https://github.com/ashkan18).

data/README.md

@@ -1,7 +1,7 @@
 # Graphlient
 
 [![Gem Version](https://badge.fury.io/rb/graphlient.svg)](https://badge.fury.io/rb/graphlient)
-[![Build Status](https://travis-ci.org/ashkan18/graphlient.svg?branch=master)](https://travis-ci.org/ashkan18/graphlient)
+[![Build Status](https://github.com/ashkan18/graphlient/actions/workflows/ci.yml/badge.svg)](https://github.com/ashkan18/graphlient/actions/workflows/ci.yml)
 
 A friendlier Ruby client for consuming GraphQL-based APIs. Built on top of your usual [graphql-client](https://github.com/github/graphql-client), but with better defaults, more consistent error handling, and using the [faraday](https://github.com/lostisland/faraday) HTTP client.
 
@@ -435,4 +435,3 @@ end
 ## License
 
 MIT License, see [LICENSE](LICENSE)
-

data/lib/graphlient/client.rb

@@ -67,7 +67,7 @@ module Graphlient
     end
 
     def errors_in_result?(response)
-      response.data && response.data.errors && response.data.errors.any?
+      response.data && response.data.errors && response.data.errors.all.any?
     end
   end
 end

data/lib/graphlient/version.rb

@@ -1,3 +1,3 @@
 module Graphlient
-  VERSION = '0.5.0'.freeze
+  VERSION = '0.6.0'.freeze
 end

data/spec/graphlient/client_query_spec.rb

@@ -80,6 +80,29 @@ describe Graphlient::Client do
         GRAPHQL
       end
 
+      let(:execution_error_query) do
+        <<-GRAPHQL
+          query($id: Int) {
+            executionErrorInvoice(id: $id) {
+              id
+              feeInCents
+            }
+          }
+        GRAPHQL
+      end
+
+      let(:partial_success_query) do
+        <<-GRAPHQL
+          query {
+            someInvoices {
+              id
+              feeInCents
+              createdAt
+            }
+          }
+        GRAPHQL
+      end
+
       it '#execute' do
         response = client.execute(query, id: 42)
         invoice = response.data.invoice
@@ -97,10 +120,9 @@ describe Graphlient::Client do
 
       it 'fails on an execution error' do
         expect do
-          allow(OpenStruct).to receive(:new).and_raise StandardError, 'Unexpected error.'
-          client.execute(query, id: 42)
+          client.execute(execution_error_query, id: 42)
         end.to raise_error Graphlient::Errors::ExecutionError do |e|
-          expect(e.to_s).to eq 'invoice: Unexpected error.'
+          expect(e.to_s).to eq 'executionErrorInvoice: Execution Error'
         end
       end
 
@@ -119,6 +141,14 @@ describe Graphlient::Client do
           expect(e.response).to be_a GraphQL::Client::Response
         end
       end
+
+      it 'fails with a partial error response' do
+        expect do
+          client.execute(partial_success_query)
+        end.to raise_error Graphlient::Errors::ExecutionError do |e|
+          expect(e.response).to be_a GraphQL::Client::Response
+        end
+      end
     end
 
     context 'non-parameterized query' do

data/spec/support/mutations/create_invoice.rb

@@ -1,3 +1,4 @@
+require_relative '../types/invoice_type'
 class CreateInvoice < GraphQL::Schema::RelayClassicMutation
   null true
 

data/spec/support/queries/query.rb

@@ -10,6 +10,15 @@ class Query < GraphQL::Schema::Object
     argument :id, Integer, required: false
   end
 
+  field :execution_error_invoice, InvoiceType, null: false, extras: [:execution_errors] do
+    description 'Find invoice'
+    argument :id, Integer, required: false
+  end
+
+  field :some_invoices, [InvoiceType], null: true do
+    description 'List of invoices'
+  end
+
   def invoice(id: nil)
     return nil if id.nil?
     OpenStruct.new(
@@ -21,4 +30,18 @@ class Query < GraphQL::Schema::Object
   def not_null_invoice(*)
     nil
   end
+
+  def execution_error_invoice(id: nil, execution_errors:)
+    execution_errors.add(GraphQL::ExecutionError.new('Execution Error'))
+
+    invoice(id: id)
+  end
+
+  def some_invoices
+    [
+      OpenStruct.new(id: 0, fee_in_cents: 20_000),
+      OpenStruct.new(id: 1, fee_in_cents: 20_000),
+      OpenStruct.new(id: 2, fee_in_cents: 20_000)
+    ]
+  end
 end

data/spec/support/types/invoice_type.rb

@@ -4,4 +4,10 @@ class InvoiceType < GraphQL::Schema::Object
 
   field :id, ID, null: false
   field :fee_in_cents, Integer, null: true
+  field :created_at, String, null: true, extras: [:execution_errors]
+
+  def created_at(execution_errors:)
+    execution_errors.add(GraphQL::ExecutionError.new('This is a partial error'))
+    Time.now.iso8601
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphlient
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Ashkan Nasseri
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-12-28 00:00:00.000000000 Z
+date: 2022-06-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -58,11 +58,13 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
+- ".github/workflows/danger.yml"
+- ".github/workflows/rubocop.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
-- ".travis.yml"
 - CHANGELOG.md
 - CONTRIBUTING.md
 - Dangerfile
@@ -140,7 +142,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
-rubygems_version: 3.0.8
+rubygems_version: 3.1.3
 signing_key:
 specification_version: 4
 summary: A friendlier Ruby client for consuming GraphQL-based APIs.

data/.travis.yml

@@ -1,24 +0,0 @@
-language: ruby
-
-cache: bundler
-
-rvm:
-  - 2.5.0
-  - 2.7.2
-  - 3.0.0
-  - ruby-head
-  - jruby-9.1.16.0
-  - jruby-head
-
-before_install:
-  - gem update --system
-
-matrix:
-  include:
-    - rvm: 2.7.2
-      script:
-        - bundle exec danger
-  allow_failures:
-    - rvm: ruby-head
-    - rvm: jruby-9.1.16.0
-    - rvm: jruby-head