graphlient 0.3.3 → 0.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7ed6aeee8ae9bf6da765d8142a11387f17bfff3f
-  data.tar.gz: 084a33299652bb41bd08b83dd752a9703f0d7c58
+  metadata.gz: a6d0e92ac6d77cf9f1e57056c517074fb3ddf053
+  data.tar.gz: b9ecc89c535d2ef16ca945df3836a499038279ac
 SHA512:
-  metadata.gz: af15ee7373138bea76bf1d01beacdafa28ad50240974539c1fd33b3513a571253ce3df7b8739f4fbbd1ff3cbbe776af51c5c719c7ac68bc46e011d72cd97a3b1
-  data.tar.gz: 4711176bd83a7d24d13ee8bef46ab8eaf54473d03da06912a00a1c4bb544057285801765e753ea5225e073f3e9bbcaf8f1769c75efc203767525f6a120354c44
+  metadata.gz: 4295209e08e772f6d3e419d38df7f6eda09d02c47f84f97ec4b2f1ae13b7c716013a43715d336830f80bf7309d0d0a8eb67151d3162118c5a716dbef948abd49
+  data.tar.gz: 5cbb4cc4fae863e5bb91257d8299249709e06b3b6a0c8fcb9d29aa7f5db90219df977c11417338ac7af9778fbcb66dbaa673c1af438b62daf51f77744dd138d2

data/.rubocop.yml

@@ -4,6 +4,9 @@ Style/FrozenStringLiteralComment:
 Style/Documentation:
   Enabled: false
 
+Style/SafeNavigation:
+  Enabled: false
+
 Metrics/LineLength:
   Enabled: false
 

data/CHANGELOG.md

@@ -1,6 +1,14 @@
-### 0.3.3 (Next)
+### 0.3.5 (Next)
 
 * Your contribution here.
+
+### 0.3.4 (01/31/2019)
+
+* [#56](https://github.com/ashkan18/graphlient/pull/56): Remove safe navigation usage to retain support for Ruby 2.2 - [@avinoth](https://github.com/avinoth).
+* [#57](https://github.com/ashkan18/graphlient/pull/57): Add support for parsing queries from a String - [@ateamlunchbox](https://github.com/ateamlunchbox).
+
+### 0.3.3 (09/23/2018)
+
 * [#50](https://github.com/ashkan18/graphlient/pull/50): More detailed error responses - [@ashkan18](https://github.com/ashkan18).
 
 ### 0.3.2 (07/03/2018)

data/README.md

@@ -208,6 +208,23 @@ end
 client.execute query, ids: [42]
 ```
 
+Or pass in a string instead of a block:
+
+```ruby
+# parse a query, returns a GraphQL::Client::OperationDefinition
+query = client.parse <<~GRAPHQL
+  query($some_id: Int) {
+    invoice(id: $some_id) {
+      id
+      feeInCents
+    }
+  }
+GRAPHQL
+
+# execute a query, returns a GraphQL::Client::Response
+client.execute query, ids: [42]
+```
+
 ### Dynamic vs. Static Queries
 
 Graphlient uses [graphql-client](https://github.com/github/graphql-client), which [recommends](https://github.com/github/graphql-client/blob/master/guides/dynamic-query-error.md) building queries as static module members along with dynamic variables during execution. This can be accomplished with graphlient the same way.

data/RELEASING.md

@@ -21,6 +21,8 @@ Change next release in [CHANGELOG.md](CHANGELOG.md) to the new version.
 
 Remove the line with "Your contribution here.", since there will be no more contributions to this release.
 
+Update the version in `lib/graphlient/version.rb`.
+
 Commit your changes.
 
 ```

data/lib/graphlient/adapters/http/http_adapter.rb

@@ -9,7 +9,7 @@ module Graphlient
 
           request['Accept'] = 'application/json'
           request['Content-Type'] = 'application/json'
-          headers&.each { |name, value| request[name] = value }
+          headers && headers.each { |name, value| request[name] = value }
 
           body = {}
           body['query'] = document.to_query_string

data/lib/graphlient/client.rb

@@ -8,8 +8,8 @@ module Graphlient
       yield self if block_given?
     end
 
-    def parse(&block)
-      query_str = Graphlient::Query.new do
+    def parse(query_str = nil, &block)
+      query_str ||= Graphlient::Query.new do
         instance_eval(&block)
       end
       client.parse(query_str.to_s)
@@ -26,7 +26,7 @@ module Graphlient
       raise Graphlient::Errors::GraphQLError, rc if rc.errors.any?
       # see https://github.com/github/graphql-client/pull/132
       # see https://github.com/exAspArk/graphql-errors/issues/2
-      raise Graphlient::Errors::ExecutionError, rc if rc.data&.errors && rc.data.errors.any?
+      raise Graphlient::Errors::ExecutionError, rc if errors_in_result?(rc)
       rc
     rescue GraphQL::Client::Error => e
       raise Graphlient::Errors::ClientError, e.message
@@ -63,5 +63,9 @@ module Graphlient
         client.allow_dynamic_queries = @options.key?(:allow_dynamic_queries) ? options[:allow_dynamic_queries] : true
       end
     end
+
+    def errors_in_result?(response)
+      response.data && response.data.errors && response.data.errors.any?
+    end
   end
 end

data/lib/graphlient/version.rb

@@ -1,3 +1,3 @@
 module Graphlient
-  VERSION = '0.3.3'.freeze
+  VERSION = '0.3.5'.freeze
 end

data/spec/graphlient/static_client_query_spec.rb

@@ -15,7 +15,16 @@ describe Graphlient::Client do
         end
       end
 
-      Query = Client.parse do
+      StringQuery = Client.parse <<~GRAPHQL
+        query($some_id: Int) {
+          invoice(id: $some_id) {
+            id
+            feeInCents
+          }
+        }
+      GRAPHQL
+
+      BlockQuery = Client.parse do
         query(some_id: :int) do
           invoice(id: :some_id) do
             id
@@ -29,11 +38,31 @@ describe Graphlient::Client do
       expect(Graphlient::Client::Spec::Client.send(:client).allow_dynamic_queries).to be false
     end
 
-    it '#execute' do
-      response = Graphlient::Client::Spec::Client.execute(Graphlient::Client::Spec::Query, some_id: 42)
-      invoice = response.data.invoice
-      expect(invoice.id).to eq '42'
-      expect(invoice.fee_in_cents).to eq 20_000
+    context 'with string-based queries' do
+      it 'parses a string query to an OperationDefinition' do
+        expect(Graphlient::Client::Spec::StringQuery.class).to be GraphQL::Client::OperationDefinition
+      end
+
+      it 'sets the OperationDefinition that came from a string to have a name' do
+        expect(Graphlient::Client::Spec::StringQuery.definition_name).to eql 'Graphlient__Client__Spec__StringQuery'
+      end
+    end
+
+    context 'with both string- and block-based queries' do
+      it 'gets identical results parsing equivalent string- and block-based queries' do
+        block_response = Graphlient::Client::Spec::Client.execute(Graphlient::Client::Spec::BlockQuery, some_id: 42)
+        string_response = Graphlient::Client::Spec::Client.execute(Graphlient::Client::Spec::StringQuery, some_id: 42)
+        expect(string_response.to_h).to eq block_response.to_h
+      end
+    end
+
+    context 'executing a query' do
+      it 'succeeds with expected feeInCents' do
+        response = Graphlient::Client::Spec::Client.execute(Graphlient::Client::Spec::BlockQuery, some_id: 42)
+        invoice = response.data.invoice
+        expect(invoice.id).to eq '42'
+        expect(invoice.fee_in_cents).to eq 20_000
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphlient
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.3.5
 platform: ruby
 authors:
 - Ashkan Nasseri
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-23 00:00:00.000000000 Z
+date: 2019-01-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -136,7 +136,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: A friendlier Ruby client for consuming GraphQL-based APIs.