graphiti-activegraph 0.1.4 → 0.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 414cf4ca5fa4c6027a87a9af43c47041ffee42b746ab148b29ffc2dc452fcda9
-  data.tar.gz: 952da258c8b891c1165e26a13ac6c4c2a8377842a5c353d8a1d329d91b2f0c26
+  metadata.gz: f6f5689742540eacd7c8d5af6c94d69deca502eaf16b1e5d4c69c4e6bb34ad88
+  data.tar.gz: 8f0cdad94dc592a5496ac839abea4727422cd1b09a2dd5fe8df908a2a3422106
 SHA512:
-  metadata.gz: 50e809c41a2ccbdade72af95a4391102fb204ede9a0477149fa4810112c379d301f8807046d5a44362cc6a68c4b22c5932b2f1b45478b63a9f2e8afb1df66c16
-  data.tar.gz: 7bd4274635d96ccdd65fb2d041efb12a1df07042d8a207218af1d13c91c4e8beb067c2bffecc20c9f5e0ceeccc9cf965d14f30fa14e36eefbfc23a752947ab90
+  metadata.gz: 9bde7647cac6007c4378c427c494c3d67a3d838794189c82f347c89ce1a3916c18de66a39aee01f7b3fd1ec65130d956ef3733ce460084cc64731c4ff3127cfe
+  data.tar.gz: b563699ee2c31d298c10ac0fe70a63100f75b196c24fddc2abc44f0225f5087267ff6e8ff6fddd508ea6fbf06eded19a85b4f1decc2e5f9dc1c744c670d14fd4

data/.rspec

@@ -0,0 +1 @@
+--require spec_helper

data/.travis.yml

@@ -0,0 +1,10 @@
+---
+dist: xenial
+language: ruby
+jdk:
+  - openjdk11
+cache: bundler
+rvm:
+  - 2.7.1
+  - jruby-9.2.13.0
+script: 'bundle exec rspec'

data/CHANGELOG.md

@@ -0,0 +1,15 @@
+## Unreleased
+
+-
+
+## 0.1.8 (09-06-2021)
+
+Features:
+
+- Added support for polymorphic relationship.
+
+<!-- ### [version (DD-MM-YYYY)](diff_link) -->
+<!-- Breaking changes:-->
+<!-- Features:-->
+<!-- Fixes:-->
+<!-- Misc:-->

data/Gemfile

@@ -9,4 +9,5 @@ group :test do
   gem "appraisal"
   gem "guard"
   gem "guard-rspec"
+  gem "rspec"
 end

data/LICENSE.txt

@@ -0,0 +1,21 @@
+The MIT License (MIT)
+
+Copyright (c) 2020 Hardik Joshi
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.

data/graphiti-activegraph.gemspec

@@ -30,4 +30,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "activemodel", ">= 4.1"
   spec.add_development_dependency "graphiti_spec_helpers", "1.0.beta.4"
   spec.add_development_dependency "standard"
+  spec.add_development_dependency "rspec", "~> 3.9.0"
 end

data/lib/graphiti/active_graph/adapters/active_graph.rb

@@ -4,7 +4,9 @@ module Graphiti::ActiveGraph
       def self.sideloading_classes
         {
           has_many: Graphiti::ActiveGraph::Adapters::ActiveGraph::HasManySideload,
-          has_one: Graphiti::ActiveGraph::Adapters::ActiveGraph::HasOneSideload
+          has_one: Graphiti::ActiveGraph::Adapters::ActiveGraph::HasOneSideload,
+          polymorphic_belongs_to: Graphiti::ActiveGraph::Adapters::ActiveGraph::PolymorphicBelongsTo,
+          belongs_to: Graphiti::ActiveGraph::Adapters::ActiveGraph::HasOneSideload,
         }
       end
 
@@ -15,13 +17,17 @@ module Graphiti::ActiveGraph
       def assign_attributes(model_instance, attributes)
         model_instance.before_assign_resource_attr if model_instance.respond_to?(:before_assign_resource_attr)
 
-        attributes.each_pair do |k, v|
-          model_instance.send(:"#{k}=", v) if model_instance.respond_to?(:"#{k}=")
-        end
+        # currently there is no possible way to assign association on activegraph without triggering save
+        # https://github.com/neo4jrb/activegraph/issues/1445
+        # using "=" operator bypasses validations and callbacks in case of associations
+        # once above issue is fixed, we can change the below code to assign instead of update
+
+        model_instance.update(attributes)
       end
 
-      def paginate(scope, current_page, per_page)
-        scope.skip((current_page - 1) * per_page).limit(per_page)
+      def paginate(scope, current_page, per_page, offset)
+        offset ||= (current_page - 1) * per_page
+        scope.skip(offset).limit(per_page)
       end
 
       def transaction(_model_class)
@@ -43,7 +49,7 @@ module Graphiti::ActiveGraph
       end
 
       def save(model_instance)
-        model_instance.save
+        model_instance.save if model_instance.changed?
         model_instance
       end
 

data/lib/graphiti/active_graph/adapters/active_graph/polymorphic_belongs_to.rb

@@ -0,0 +1,15 @@
+class Graphiti::ActiveGraph::Adapters::ActiveGraph::PolymorphicBelongsTo < Graphiti::Sideload::PolymorphicBelongsTo
+  include Graphiti::ActiveGraph::Adapters::ActiveGraph::Sideload
+
+  def default_base_scope
+    resource_class.model.all
+  end
+
+  def infer_foreign_key
+    association_name.to_sym
+  end
+
+  def default_value_when_empty
+    nil
+  end
+end

data/lib/graphiti/active_graph/resource.rb

@@ -25,6 +25,9 @@ module Graphiti
         runner = ::Graphiti::Runner.new(self, params)
         runner.proxy(nil, raise_on_missing: false, preloaded: obj_arr)
       end
+
+      def guard_nil_id!(params)
+      end
     end
 
     module ResourceInstanceMethods

data/lib/graphiti/active_graph/resource_proxy.rb

@@ -57,7 +57,7 @@ module Graphiti::ActiveGraph
       original = Graphiti.context[:namespace]
       begin
         Graphiti.context[:namespace] = action
-        ::Graphiti::RequestValidator.new(@resource, @payload.params).validate!
+        ::Graphiti::RequestValidator.new(@resource, @payload.params, action).validate!
         validator = persist {
           @resource.persist_with_relationships \
             @payload.meta(action: action),

data/lib/graphiti/active_graph/runner.rb

@@ -6,7 +6,7 @@ module Graphiti::ActiveGraph
       @query = query
       @action = action
 
-      validator = ::Graphiti::RequestValidator.new(jsonapi_resource, params)
+      validator = ::Graphiti::RequestValidator.new(jsonapi_resource, params, action)
 
       validator.validate! unless params[:skip_render_val]
 

data/lib/graphiti/active_graph/sideload_resolve.rb

@@ -1,23 +1,6 @@
 module Graphiti::ActiveGraph
   module SideloadResolve
     def resolve_sideloads(parents)
-      @query.sideloads.each_pair do |name, q|
-        sideload = @resource.class.sideload(name)
-        next if sideload.nil? || sideload.shared_remote?
-
-        if sideload.assign_each_proc
-          Array.wrap(parents).each do |parent|
-            children = sideload.assign_each_proc.call(parent) || sideload.default_value_when_empty
-
-            # currently there is no possible way to assign association on activegraph without triggering save
-            # https://github.com/neo4jrb/activegraph/issues/1445
-            # as a workaround we are using instance variable here to store and retrive associations
-            # once above issue is fixed use that fix to assign the association here
-            # and also remove 1) this code and 2) SerializerRelationship#data_proc
-            parent.instance_variable_set("@graphiti_render_#{name}", { data: children })
-          end
-        end
-      end
     end
   end
 end

data/lib/graphiti/active_graph/util/serializer_relationship.rb

@@ -6,11 +6,10 @@ module Graphiti::ActiveGraph
         ->(_) {
           # use custom assigned sideload if it is specified via "assign_each_proc"
           # otherwise retrieve sideload using normal getter on parent object
-          custom_assigned_sideload = @object.instance_variable_get("@graphiti_render_#{sideload_ref.association_name}")
-          records = if custom_assigned_sideload.blank?
-                      @object.public_send(sideload_ref.association_name)
+          records = if custom_proc = sideload_ref.assign_each_proc
+                      custom_proc.call(@object)
                     else
-                      custom_assigned_sideload[:data]
+                      @object.public_send(sideload_ref.association_name)
                     end
 
           if records

data/lib/graphiti/active_graph/version.rb

@@ -1,5 +1,5 @@
 module Graphiti
   module ActiveGraph
-    VERSION = '0.1.4'
+    VERSION = '0.1.9'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphiti-activegraph
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.9
 platform: ruby
 authors:
 - Hardik Joshi
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-10-01 00:00:00.000000000 Z
+date: 2021-06-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: graphiti
@@ -164,7 +164,21 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.9.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.9.0
+description:
 email:
 - hardikjoshi1991@gmail.com
 executables: []
@@ -172,12 +186,17 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
+- ".travis.yml"
+- CHANGELOG.md
 - Gemfile
+- LICENSE.txt
 - graphiti-activegraph.gemspec
 - lib/graphiti-activegraph.rb
 - lib/graphiti/active_graph/adapters/active_graph.rb
 - lib/graphiti/active_graph/adapters/active_graph/has_many_sideload.rb
 - lib/graphiti/active_graph/adapters/active_graph/has_one_sideload.rb
+- lib/graphiti/active_graph/adapters/active_graph/polymorphic_belongs_to.rb
 - lib/graphiti/active_graph/adapters/active_graph/sideload.rb
 - lib/graphiti/active_graph/deserializer.rb
 - lib/graphiti/active_graph/query.rb
@@ -196,7 +215,7 @@ homepage: https://github.com/mrhardikjoshi/graphiti-activegraph
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -211,9 +230,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
-signing_key: 
+rubygems_version: 3.2.3
+signing_key:
 specification_version: 4
 summary: Easily build jsonapi.org-compatible APIs for GraphDB
 test_files: []