grape_fast_jsonapi 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1b2ef04c9a3d2b69160a93779d60466a90a93fed1bf1109e1e32c91e8632bad8
-  data.tar.gz: 1ba50c7bdf05a933b7c736f2a4f36e55f5bc3d4742bb2d552260760eb63dffe2
+  metadata.gz: c949823976af65fb4896c7a49333309978436c22324d79f296d6fb02fc4734db
+  data.tar.gz: 6381b94d235e84227841b123ae7b70a9b819d244473bd62180c59738997eca5c
 SHA512:
-  metadata.gz: d5175b87b19aca5fd04a5532d901ff03f41c06f1792de26f15b0c452f5e8a3357a0237a3ad6c835bb19da20cb3b09133e08b093e3680837307e3fa23d57b1317
-  data.tar.gz: 148a701839831d1b6b384b93ceddcfe07799eef6b233ec7e8df449711e94a2b4cf673cc859ab8760a96f4d20d85b4ff3c16d487c63489fac589eac3e88485c8e
+  metadata.gz: 61dc166df0aa1a94506aaa609016a805810bbf8d3589c1457764324cd418d75cc4cad8891235d056e22a8ea2d751efcb528ad236a7c7b93c764d5b17a1594331
+  data.tar.gz: 9f812886c303cc04a96a6b3e4380da40805e7614a3cfd36324823c52831e47dc3a3aaa6423302d01cf2e6ea3b1543b2990eda387edad8eb79d26f4b0cd349fbc

data/CHANGELOG.md

@@ -1,9 +1,13 @@
 ## Changelog
 
-### v0.2.4 (Next)
+### v0.2.5 (Next)
 
 * Your contribution here.
 
+### v0.2.4 (December 16, 2019)
+
+* [#15](https://github.com/EmCousin/grape_fast_jsonapi/pull/15) - Handle serializers which don't have any attributes - [@vesan](https://github.com/vesan)
+
 ### v0.2.3 (December 12, 2019)
 
 * Reverted v0.2.2 and bumped `loofah` using `dependabot`
@@ -19,7 +23,7 @@
 ### v0.2.0 (February 8, 2019)
 
 * [#5](https://github.com/EmCousin/grape_fast_jsonapi/pull/5): Provide custom Grape Swagger parser for fast_jsonapi object serializers, as well as unit test coverage - [@EmCousin](https://github.com/EmCousin)
-* [#6](https://github.com/EmCousin/grape_fast_jsonapi/pull/6) - Fix to make the parser compatible with latest version of fast_jsonapi (1.5 at date) - @rromanchuk](https://github.com/rromanchuk).
+* [#6](https://github.com/EmCousin/grape_fast_jsonapi/pull/6) - Fix to make the parser compatible with latest version of fast_jsonapi (1.5 at date) - [@rromanchuk](https://github.com/rromanchuk).
 
 ### v0.1.0
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    grape_fast_jsonapi (0.2.3)
+    grape_fast_jsonapi (0.2.4)
       fast_jsonapi (>= 1.5)
       grape
 

data/README.md

@@ -56,8 +56,11 @@ When using Grape with Swagger via [grape-swagger](https://github.com/ruby-grape/
 
 ```ruby
 # FastJsonapi serializer example
+
+# app/serializers/base_serializer.rb
+class BaseSerializer; end
 # app/serializers/user_serializer.rb
-class UserSerializer
+class UserSerializer < BaseSerializer
   include FastJsonapi::ObjectSerializer
 
   set_type :user
@@ -67,12 +70,13 @@ class UserSerializer
 end
 
 # config/initializers/grape_swagger.rb
-GrapeSwagger.model_parsers.register(GrapeSwagger::FastJsonapi::Parser, UserSerializer)
+GrapeSwagger.model_parsers.register(GrapeSwagger::FastJsonapi::Parser, BaseSerializer)
 
 # Your grape API endpoint
-desc 'Get current user',
-  success: { code: 200, model: UserSerializer, message: 'The current user' }
+desc 'Get current user' do
+  success code: 200, model: UserSerializer, message: 'The current user'
 # [...]
+end
 ```
 
 Note that you **need** the `grape-swagger` gem for this to work, otherwise it will throw an error.

data/lib/grape_fast_jsonapi/parser.rb

@@ -83,7 +83,7 @@ module GrapeSwagger
 
       def map_model_attributes
         attributes = {}
-        model.attributes_to_serialize.each do |attribute, _|
+        (model.attributes_to_serialize || []).each do |attribute, _|
           attributes[attribute] = :string
         end
         attributes
@@ -175,4 +175,4 @@ module GrapeSwagger
       end
     end
   end
-end
+end

data/lib/grape_fast_jsonapi/version.rb

@@ -2,6 +2,6 @@
 
 module Grape
   module FastJsonapi
-    VERSION = '0.2.3'.freeze
+    VERSION = '0.2.4'.freeze
   end
 end

data/spec/lib/grape_fast_jsonapi/parser_spec.rb

@@ -126,6 +126,53 @@ describe GrapeSwagger::FastJsonapi::Parser do
           })
         end
       end
+      context 'when the serializer doesn\'t have any attributes' do
+        let(:model) { AnotherBlogPostSerializer } # no attributes
+
+        it 'return a hash defining the schema with empty attributes' do
+          expect(subject).to eq({
+            data: {
+              type: :object,
+              properties: {
+                id: { type: :integer },
+                type: { type: :string },
+                attributes: {
+                  type: :object,
+                  properties: {}
+                },
+                relationships: {
+                  type: :object,
+                  properties: {
+                    user: {
+                      properties: {
+                        data: {
+                          properties: {
+                            id: { type: :integer },
+                            type: { type: :string }
+                          },
+                          type: :object,
+                        }
+                      },
+                      type: :object,
+                    }
+                  }
+                }
+              },
+              example: {
+                id: 1,
+                type: :blog_post,
+                attributes: {
+                },
+                relationships: {
+                  user: {
+                    data: { id: 1, type: :user }
+                  }
+                }
+              }
+            }
+          })
+        end
+      end
     end
   end
-end
+end

data/spec/lib/grape_fast_jsonapi/version_spec.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 describe Grape::FastJsonapi::VERSION do
-  it { is_expected.to eq '0.2.3' }
+  it { is_expected.to eq '0.2.4' }
 end

data/spec/support/serializers/another_blog_post_serializer.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+class AnotherBlogPostSerializer
+  include FastJsonapi::ObjectSerializer
+
+  set_type :blog_post
+
+  belongs_to :user
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: grape_fast_jsonapi
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Emmanuel Cousin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-12 00:00:00.000000000 Z
+date: 2019-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: grape
@@ -94,6 +94,7 @@ files:
 - spec/spec_helper.rb
 - spec/support/models/blog_post.rb
 - spec/support/models/user.rb
+- spec/support/serializers/another_blog_post_serializer.rb
 - spec/support/serializers/another_user_serializer.rb
 - spec/support/serializers/blog_post_serializer.rb
 - spec/support/serializers/user_serializer.rb
@@ -127,6 +128,7 @@ test_files:
 - spec/spec_helper.rb
 - spec/support/models/blog_post.rb
 - spec/support/models/user.rb
+- spec/support/serializers/another_blog_post_serializer.rb
 - spec/support/serializers/another_user_serializer.rb
 - spec/support/serializers/blog_post_serializer.rb
 - spec/support/serializers/user_serializer.rb