grape 1.8.0 → 2.1.0

data/spec/grape/validations/validators/except_values_spec.rb

@@ -1,192 +0,0 @@
-# frozen_string_literal: true
-
-describe Grape::Validations::Validators::ExceptValuesValidator do
-  module ValidationsSpec
-    class ExceptValuesModel
-      DEFAULT_EXCEPTS = %w[invalid-type1 invalid-type2 invalid-type3].freeze
-      class << self
-        attr_accessor :excepts
-
-        def excepts
-          @excepts ||= []
-          [DEFAULT_EXCEPTS + @excepts].flatten.uniq
-        end
-      end
-    end
-
-    TEST_CASES = {
-      req_except: {
-        requires: { except_values: ExceptValuesModel.excepts },
-        tests: [
-          { value: 'invalid-type1', rc: 400, body: { error: 'type has a value not allowed' }.to_json },
-          { value: 'invalid-type3', rc: 400, body: { error: 'type has a value not allowed' }.to_json },
-          { value: 'valid-type', rc: 200, body: { type: 'valid-type' }.to_json }
-        ]
-      },
-      req_except_hash: {
-        requires: { except_values: { value: ExceptValuesModel.excepts } },
-        tests: [
-          { value: 'invalid-type1', rc: 400, body: { error: 'type has a value not allowed' }.to_json },
-          { value: 'invalid-type3', rc: 400, body: { error: 'type has a value not allowed' }.to_json },
-          { value: 'valid-type', rc: 200, body: { type: 'valid-type' }.to_json }
-        ]
-      },
-      req_except_custom_message: {
-        requires: { except_values: { value: ExceptValuesModel.excepts, message: 'is not allowed' } },
-        tests: [
-          { value: 'invalid-type1', rc: 400, body: { error: 'type is not allowed' }.to_json },
-          { value: 'invalid-type3', rc: 400, body: { error: 'type is not allowed' }.to_json },
-          { value: 'valid-type', rc: 200, body: { type: 'valid-type' }.to_json }
-        ]
-      },
-      req_except_no_value: {
-        requires: { except_values: { message: 'is not allowed' } },
-        tests: [
-          { value: 'invalid-type1', rc: 200, body: { type: 'invalid-type1' }.to_json }
-        ]
-      },
-      req_except_empty: {
-        requires: { except_values: [] },
-        tests: [
-          { value: 'invalid-type1', rc: 200, body: { type: 'invalid-type1' }.to_json }
-        ]
-      },
-      req_except_lambda: {
-        requires: { except_values: -> { ExceptValuesModel.excepts } },
-        add_excepts: ['invalid-type4'],
-        tests: [
-          { value: 'invalid-type1', rc: 400, body: { error: 'type has a value not allowed' }.to_json },
-          { value: 'invalid-type4', rc: 400, body: { error: 'type has a value not allowed' }.to_json },
-          { value: 'valid-type', rc: 200, body: { type: 'valid-type' }.to_json }
-        ]
-      },
-      req_except_lambda_custom_message: {
-        requires: { except_values: { value: -> { ExceptValuesModel.excepts }, message: 'is not allowed' } },
-        add_excepts: ['invalid-type4'],
-        tests: [
-          { value: 'invalid-type1', rc: 400, body: { error: 'type is not allowed' }.to_json },
-          { value: 'invalid-type4', rc: 400, body: { error: 'type is not allowed' }.to_json },
-          { value: 'valid-type', rc: 200, body: { type: 'valid-type' }.to_json }
-        ]
-      },
-      opt_except_default: {
-        optional: { except_values: ExceptValuesModel.excepts, default: 'valid-type2' },
-        tests: [
-          { value: 'invalid-type1', rc: 400, body: { error: 'type has a value not allowed' }.to_json },
-          { value: 'invalid-type3', rc: 400, body: { error: 'type has a value not allowed' }.to_json },
-          { value: 'valid-type', rc: 200, body: { type: 'valid-type' }.to_json },
-          { rc: 200, body: { type: 'valid-type2' }.to_json }
-        ]
-      },
-      opt_except_lambda_default: {
-        optional: { except_values: -> { ExceptValuesModel.excepts }, default: 'valid-type2' },
-        tests: [
-          { value: 'invalid-type1', rc: 400, body: { error: 'type has a value not allowed' }.to_json },
-          { value: 'invalid-type3', rc: 400, body: { error: 'type has a value not allowed' }.to_json },
-          { value: 'valid-type', rc: 200, body: { type: 'valid-type' }.to_json },
-          { rc: 200, body: { type: 'valid-type2' }.to_json }
-        ]
-      },
-      req_except_type_coerce: {
-        requires: { type: Integer, except_values: [10, 11] },
-        tests: [
-          { value: 'invalid-type1', rc: 400, body: { error: 'type is invalid' }.to_json },
-          { value: 11, rc: 400, body: { error: 'type has a value not allowed' }.to_json },
-          { value: '11', rc: 400, body: { error: 'type has a value not allowed' }.to_json },
-          { value: '3', rc: 200, body: { type: 3 }.to_json },
-          { value: 3, rc: 200, body: { type: 3 }.to_json }
-        ]
-      },
-      opt_except_type_coerce_default: {
-        optional: { type: Integer, except_values: [10, 11], default: 12 },
-        tests: [
-          { value: 'invalid-type1', rc: 400, body: { error: 'type is invalid' }.to_json },
-          { value: 10, rc: 400, body: { error: 'type has a value not allowed' }.to_json },
-          { value: '3', rc: 200, body: { type: 3 }.to_json },
-          { value: 3, rc: 200, body: { type: 3 }.to_json },
-          { rc: 200, body: { type: 12 }.to_json }
-        ]
-      },
-      opt_except_array_type_coerce_default: {
-        optional: { type: Array[Integer], except_values: [10, 11], default: 12 },
-        tests: [
-          { value: 'invalid-type1', rc: 400, body: { error: 'type is invalid' }.to_json },
-          { value: 10, rc: 400, body: { error: 'type is invalid' }.to_json },
-          { value: [10], rc: 400, body: { error: 'type has a value not allowed' }.to_json },
-          { value: ['3'], rc: 200, body: { type: [3] }.to_json },
-          { value: [3], rc: 200, body: { type: [3] }.to_json },
-          { rc: 200, body: { type: 12 }.to_json }
-        ]
-      },
-      req_except_range: {
-        optional: { type: Integer, except_values: 10..12 },
-        tests: [
-          { value: 11, rc: 400, body: { error: 'type has a value not allowed' }.to_json },
-          { value: 13, rc: 200, body: { type: 13 }.to_json }
-        ]
-      }
-    }.freeze
-
-    module ExceptValidatorSpec
-      class API < Grape::API
-        default_format :json
-
-        TEST_CASES.each_with_index do |(k, v), _i|
-          params do
-            requires :type, v[:requires] if v.key? :requires
-            optional :type, v[:optional] if v.key? :optional
-          end
-          get k do
-            { type: params[:type] }
-          end
-        end
-      end
-    end
-  end
-
-  it 'raises IncompatibleOptionValues on a default value in exclude' do
-    subject = Class.new(Grape::API)
-    expect do
-      subject.params do
-        optional :type, except_values: ValidationsSpec::ExceptValuesModel.excepts,
-                        default: ValidationsSpec::ExceptValuesModel.excepts.sample
-      end
-    end.to raise_error Grape::Exceptions::IncompatibleOptionValues
-  end
-
-  it 'raises IncompatibleOptionValues when a default array has excluded values' do
-    subject = Class.new(Grape::API)
-    expect do
-      subject.params do
-        optional :type, type: Array[Integer],
-                        except_values: 10..12,
-                        default: [8, 9, 10]
-      end
-    end.to raise_error Grape::Exceptions::IncompatibleOptionValues
-  end
-
-  it 'raises IncompatibleOptionValues when type is incompatible with values array' do
-    subject = Class.new(Grape::API)
-    expect do
-      subject.params { optional :type, except_values: %w[valid-type1 valid-type2 valid-type3], type: Symbol }
-    end.to raise_error Grape::Exceptions::IncompatibleOptionValues
-  end
-
-  def app
-    ValidationsSpec::ExceptValidatorSpec::API
-  end
-
-  ValidationsSpec::TEST_CASES.each_with_index do |(k, v), i|
-    v[:tests].each do |t|
-      it "#{i}: #{k} - #{t[:value]}" do
-        ValidationsSpec::ExceptValuesModel.excepts = v[:add_excepts] if v.key? :add_excepts
-        body = {}
-        body[:type] = t[:value] if t.key? :value
-        get k.to_s, **body
-        expect(last_response.status).to eq t[:rc]
-        expect(last_response.body).to eq t[:body]
-        ValidationsSpec::ExceptValuesModel.excepts = nil
-      end
-    end
-  end
-end

data/spec/grape/validations/validators/mutual_exclusion_spec.rb

@@ -1,214 +0,0 @@
-# frozen_string_literal: true
-
-describe Grape::Validations::Validators::MutualExclusionValidator do
-  let_it_be(:app) do
-    Class.new(Grape::API) do
-      rescue_from Grape::Exceptions::ValidationErrors do |e|
-        error!(e.errors.transform_keys! { |key| key.join(',') }, 400)
-      end
-
-      params do
-        optional :beer
-        optional :wine
-        optional :grapefruit
-        mutually_exclusive :beer, :wine, :grapefruit
-      end
-      post do
-      end
-
-      params do
-        optional :beer
-        optional :wine
-        optional :grapefruit
-        optional :other
-        mutually_exclusive :beer, :wine, :grapefruit
-      end
-      post 'mixed-params' do
-      end
-
-      params do
-        optional :beer
-        optional :wine
-        optional :grapefruit
-        mutually_exclusive :beer, :wine, :grapefruit, message: 'you should not mix beer and wine'
-      end
-      post '/custom-message' do
-      end
-
-      params do
-        requires :item, type: Hash do
-          optional :beer
-          optional :wine
-          optional :grapefruit
-          mutually_exclusive :beer, :wine, :grapefruit
-        end
-      end
-      post '/nested-hash' do
-      end
-
-      params do
-        optional :item, type: Hash do
-          optional :beer
-          optional :wine
-          optional :grapefruit
-          mutually_exclusive :beer, :wine, :grapefruit
-        end
-      end
-      post '/nested-optional-hash' do
-      end
-
-      params do
-        requires :items, type: Array do
-          optional :beer
-          optional :wine
-          optional :grapefruit
-          mutually_exclusive :beer, :wine, :grapefruit
-        end
-      end
-      post '/nested-array' do
-      end
-
-      params do
-        requires :items, type: Array do
-          requires :nested_items, type: Array do
-            optional :beer, :wine, :grapefruit, type: Grape::API::Boolean
-            mutually_exclusive :beer, :wine, :grapefruit
-          end
-        end
-      end
-      post '/deeply-nested-array' do
-      end
-    end
-  end
-
-  describe '#validate!' do
-    subject(:validate) { post path, params }
-
-    context 'when all mutually exclusive params are present' do
-      let(:path) { '/' }
-      let(:params) { { beer: true, wine: true, grapefruit: true } }
-
-      it 'returns a validation error' do
-        validate
-        expect(last_response.status).to eq 400
-        expect(JSON.parse(last_response.body)).to eq(
-          'beer,wine,grapefruit' => ['are mutually exclusive']
-        )
-      end
-
-      context 'mixed with other params' do
-        let(:path) { '/mixed-params' }
-        let(:params) { { beer: true, wine: true, grapefruit: true, other: true } }
-
-        it 'returns a validation error' do
-          validate
-          expect(last_response.status).to eq 400
-          expect(JSON.parse(last_response.body)).to eq(
-            'beer,wine,grapefruit' => ['are mutually exclusive']
-          )
-        end
-      end
-    end
-
-    context 'when a subset of mutually exclusive params are present' do
-      let(:path) { '/' }
-      let(:params) { { beer: true, grapefruit: true } }
-
-      it 'returns a validation error' do
-        validate
-        expect(last_response.status).to eq 400
-        expect(JSON.parse(last_response.body)).to eq(
-          'beer,grapefruit' => ['are mutually exclusive']
-        )
-      end
-    end
-
-    context 'when custom message is specified' do
-      let(:path) { '/custom-message' }
-      let(:params) { { beer: true, wine: true } }
-
-      it 'returns a validation error' do
-        validate
-        expect(last_response.status).to eq 400
-        expect(JSON.parse(last_response.body)).to eq(
-          'beer,wine' => ['you should not mix beer and wine']
-        )
-      end
-    end
-
-    context 'when no mutually exclusive params are present' do
-      let(:path) { '/' }
-      let(:params) { { beer: true, somethingelse: true } }
-
-      it 'does not return a validation error' do
-        validate
-        expect(last_response.status).to eq 201
-      end
-    end
-
-    context 'when mutually exclusive params are nested inside required hash' do
-      let(:path) { '/nested-hash' }
-      let(:params) { { item: { beer: true, wine: true } } }
-
-      it 'returns a validation error with full names of the params' do
-        validate
-        expect(last_response.status).to eq 400
-        expect(JSON.parse(last_response.body)).to eq(
-          'item[beer],item[wine]' => ['are mutually exclusive']
-        )
-      end
-    end
-
-    context 'when mutually exclusive params are nested inside optional hash' do
-      let(:path) { '/nested-optional-hash' }
-
-      context 'when params are passed' do
-        let(:params) { { item: { beer: true, wine: true } } }
-
-        it 'returns a validation error with full names of the params' do
-          validate
-          expect(last_response.status).to eq 400
-          expect(JSON.parse(last_response.body)).to eq(
-            'item[beer],item[wine]' => ['are mutually exclusive']
-          )
-        end
-      end
-
-      context 'when params are empty' do
-        let(:params) { {} }
-
-        it 'does not return a validation error' do
-          validate
-          expect(last_response.status).to eq 201
-        end
-      end
-    end
-
-    context 'when mutually exclusive params are nested inside array' do
-      let(:path) { '/nested-array' }
-      let(:params) { { items: [{ beer: true, wine: true }, { wine: true, grapefruit: true }] } }
-
-      it 'returns a validation error with full names of the params' do
-        validate
-        expect(last_response.status).to eq 400
-        expect(JSON.parse(last_response.body)).to eq(
-          'items[0][beer],items[0][wine]' => ['are mutually exclusive'],
-          'items[1][wine],items[1][grapefruit]' => ['are mutually exclusive']
-        )
-      end
-    end
-
-    context 'when mutually exclusive params are deeply nested' do
-      let(:path) { '/deeply-nested-array' }
-      let(:params) { { items: [{ nested_items: [{ beer: true, wine: true }] }] } }
-
-      it 'returns a validation error with full names of the params' do
-        validate
-        expect(last_response.status).to eq 400
-        expect(JSON.parse(last_response.body)).to eq(
-          'items[0][nested_items][0][beer],items[0][nested_items][0][wine]' => ['are mutually exclusive']
-        )
-      end
-    end
-  end
-end