grape 1.3.3 → 1.6.2

data/spec/grape/api_spec.rb

@@ -4,7 +4,10 @@ require 'spec_helper'
 require 'shared/versioning_examples'
 
 describe Grape::API do
-  subject { Class.new(Grape::API) }
+  subject do
+    puts described_class
+    Class.new(described_class)
+  end
 
   def app
     subject
@@ -18,7 +21,7 @@ describe Grape::API do
       end
 
       get 'awesome/sauce/'
-      expect(last_response.status).to eql 200
+      expect(last_response.status).to be 200
       expect(last_response.body).to eql 'Hello there.'
     end
 
@@ -32,7 +35,7 @@ describe Grape::API do
       expect(last_response.body).to eql 'Hello there.'
 
       get '/hello'
-      expect(last_response.status).to eql 404
+      expect(last_response.status).to be 404
     end
 
     it 'supports OPTIONS' do
@@ -42,7 +45,7 @@ describe Grape::API do
       end
 
       options 'awesome/sauce'
-      expect(last_response.status).to eql 204
+      expect(last_response.status).to be 204
       expect(last_response.body).to be_blank
     end
 
@@ -51,7 +54,7 @@ describe Grape::API do
       subject.get
 
       post 'awesome/sauce'
-      expect(last_response.status).to eql 405
+      expect(last_response.status).to be 405
     end
   end
 
@@ -71,7 +74,7 @@ describe Grape::API do
   end
 
   describe '.version using path' do
-    it_should_behave_like 'versioning' do
+    it_behaves_like 'versioning' do
       let(:macro_options) do
         {
           using: :path
@@ -81,7 +84,7 @@ describe Grape::API do
   end
 
   describe '.version using param' do
-    it_should_behave_like 'versioning' do
+    it_behaves_like 'versioning' do
       let(:macro_options) do
         {
           using: :param,
@@ -92,7 +95,7 @@ describe Grape::API do
   end
 
   describe '.version using header' do
-    it_should_behave_like 'versioning' do
+    it_behaves_like 'versioning' do
       let(:macro_options) do
         {
           using: :header,
@@ -120,7 +123,7 @@ describe Grape::API do
   end
 
   describe '.version using accept_version_header' do
-    it_should_behave_like 'versioning' do
+    it_behaves_like 'versioning' do
       let(:macro_options) do
         {
           using: :accept_version_header
@@ -389,7 +392,7 @@ describe Grape::API do
         end
       end
 
-      before(:each) do
+      before do
         allow_any_instance_of(ApiSpec::DummyFormatClass).to receive(:to_json).and_return('abc')
         allow_any_instance_of(ApiSpec::DummyFormatClass).to receive(:to_txt).and_return('def')
 
@@ -447,7 +450,7 @@ describe Grape::API do
     end
 
     %i[put post].each do |verb|
-      context verb do
+      context verb.to_s do
         ['string', :symbol, 1, -1.1, {}, [], true, false, nil].each do |object|
           it "allows a(n) #{object.class} json object in params" do
             subject.format :json
@@ -459,6 +462,7 @@ describe Grape::API do
             expect(last_response.body).to eql ::Grape::Json.dump(object)
             expect(last_request.params).to eql({})
           end
+
           it 'stores input in api.request.input' do
             subject.format :json
             subject.send(verb) do
@@ -468,6 +472,7 @@ describe Grape::API do
             expect(last_response.status).to eq(verb == :post ? 201 : 200)
             expect(last_response.body).to eql ::Grape::Json.dump(object).to_json
           end
+
           context 'chunked transfer encoding' do
             it 'stores input in api.request.input' do
               subject.format :json
@@ -562,7 +567,8 @@ describe Grape::API do
           send(other_verb, '/example')
           expected_rc = if other_verb == 'options' then 204
                         elsif other_verb == 'head' && verb == 'get' then 200
-                        else 405
+                        else
+                          405
                         end
           expect(last_response.status).to eql expected_rc
         end
@@ -575,7 +581,7 @@ describe Grape::API do
       end
 
       post '/example'
-      expect(last_response.status).to eql 201
+      expect(last_response.status).to be 201
       expect(last_response.body).to eql 'Created'
     end
 
@@ -585,7 +591,7 @@ describe Grape::API do
         'example'
       end
       put '/example'
-      expect(last_response.status).to eql 405
+      expect(last_response.status).to be 405
       expect(last_response.body).to eql '405 Not Allowed'
       expect(last_response.headers['X-Custom-Header']).to eql 'foo'
     end
@@ -593,15 +599,17 @@ describe Grape::API do
     it 'runs only the before filter on 405 bad method' do
       subject.namespace :example do
         before            { header 'X-Custom-Header', 'foo' }
+
         before_validation { raise 'before_validation filter should not run' }
         after_validation  { raise 'after_validation filter should not run' }
         after             { raise 'after filter should not run' }
+
         params { requires :only_for_get }
         get
       end
 
       post '/example'
-      expect(last_response.status).to eql 405
+      expect(last_response.status).to be 405
       expect(last_response.headers['X-Custom-Header']).to eql 'foo'
     end
 
@@ -610,29 +618,33 @@ describe Grape::API do
       subject.namespace :example do
         before do
           raise 'before filter ran twice' if already_run
+
           already_run = true
           header 'X-Custom-Header', 'foo'
         end
+
         get
       end
 
       post '/example'
-      expect(last_response.status).to eql 405
+      expect(last_response.status).to be 405
       expect(last_response.headers['X-Custom-Header']).to eql 'foo'
     end
 
     it 'runs all filters and body with a custom OPTIONS method' do
       subject.namespace :example do
         before            { header 'X-Custom-Header-1', 'foo' }
+
         before_validation { header 'X-Custom-Header-2', 'foo' }
         after_validation  { header 'X-Custom-Header-3', 'foo' }
         after             { header 'X-Custom-Header-4', 'foo' }
+
         options { 'yup' }
         get
       end
 
       options '/example'
-      expect(last_response.status).to eql 200
+      expect(last_response.status).to be 200
       expect(last_response.body).to eql 'yup'
       expect(last_response.headers['Allow']).to be_nil
       expect(last_response.headers['X-Custom-Header-1']).to eql 'foo'
@@ -649,13 +661,13 @@ describe Grape::API do
         end
 
         put '/example'
-        expect(last_response.status).to eql 405
-        expect(last_response.body).to eq <<-XML
-<?xml version="1.0" encoding="UTF-8"?>
-<error>
-  <message>405 Not Allowed</message>
-</error>
-XML
+        expect(last_response.status).to be 405
+        expect(last_response.body).to eq <<~XML
+          <?xml version="1.0" encoding="UTF-8"?>
+          <error>
+            <message>405 Not Allowed</message>
+          </error>
+        XML
       end
     end
 
@@ -669,7 +681,7 @@ XML
           'example'
         end
         put '/example'
-        expect(last_response.status).to eql 405
+        expect(last_response.status).to be 405
         expect(last_response.body).to eql '405 Not Allowed'
       end
     end
@@ -713,7 +725,7 @@ XML
       end
 
       it 'returns a 204' do
-        expect(last_response.status).to eql 204
+        expect(last_response.status).to be 204
       end
 
       it 'has an empty body' do
@@ -749,11 +761,53 @@ XML
       end
     end
 
+    describe 'when a resource routes by POST, GET, PATCH, PUT, and DELETE' do
+      before do
+        subject.namespace :example do
+          get do
+            'example'
+          end
+
+          patch do
+            'example'
+          end
+
+          post do
+            'example'
+          end
+
+          delete do
+            'example'
+          end
+
+          put do
+            'example'
+          end
+        end
+        options '/example'
+      end
+
+      describe 'it adds an OPTIONS route for namespaced endpoints that' do
+        it 'returns a 204' do
+          expect(last_response.status).to be 204
+        end
+
+        it 'has an empty body' do
+          expect(last_response.body).to be_blank
+        end
+
+        it 'has an Allow header' do
+          expect(last_response.headers['Allow']).to eql 'OPTIONS, GET, PATCH, POST, DELETE, PUT, HEAD'
+        end
+      end
+    end
+
     describe 'adds an OPTIONS route for namespaced endpoints that' do
       before do
         subject.before { header 'X-Custom-Header', 'foo' }
         subject.namespace :example do
           before { header 'X-Custom-Header-2', 'foo' }
+
           get :inner do
             'example/inner'
           end
@@ -762,7 +816,7 @@ XML
       end
 
       it 'returns a 204' do
-        expect(last_response.status).to eql 204
+        expect(last_response.status).to be 204
       end
 
       it 'has an empty body' do
@@ -800,7 +854,7 @@ XML
       end
 
       it 'returns a 405' do
-        expect(last_response.status).to eql 405
+        expect(last_response.status).to be 405
       end
 
       it 'contains error message in body' do
@@ -816,6 +870,74 @@ XML
       end
     end
 
+    describe 'when hook behaviour is controlled by attributes on the route' do
+      before do
+        subject.before do
+          error!('Access Denied', 401) unless route.options[:secret] == params[:secret]
+        end
+
+        subject.namespace 'example' do
+          before do
+            error!('Access Denied', 401) unless route.options[:namespace_secret] == params[:namespace_secret]
+          end
+
+          desc 'it gets with secret', secret: 'password'
+          get { status(params[:id] == '504' ? 200 : 404) }
+
+          desc 'it post with secret', secret: 'password', namespace_secret: 'namespace_password'
+          post {}
+        end
+      end
+
+      context 'when HTTP method is not defined' do
+        let(:response) { delete('/example') }
+
+        it 'responds with a 405 status' do
+          expect(response.status).to be 405
+        end
+      end
+
+      context 'when HTTP method is defined with attribute' do
+        let(:response) { post('/example?secret=incorrect_password') }
+
+        it 'responds with the defined error in the before hook' do
+          expect(response.status).to be 401
+        end
+      end
+
+      context 'when HTTP method is defined and the underlying before hook expectation is not met' do
+        let(:response) { post('/example?secret=password&namespace_secret=wrong_namespace_password') }
+
+        it 'ends up in the endpoint' do
+          expect(response.status).to be 401
+        end
+      end
+
+      context 'when HTTP method is defined and everything is like the before hooks expect' do
+        let(:response) { post('/example?secret=password&namespace_secret=namespace_password') }
+
+        it 'ends up in the endpoint' do
+          expect(response.status).to be 201
+        end
+      end
+
+      context 'when HEAD is called for the defined GET' do
+        let(:response) { head('/example?id=504') }
+
+        it 'responds with 401 because before expectations in before hooks are not met' do
+          expect(response.status).to be 401
+        end
+      end
+
+      context 'when HEAD is called for the defined GET' do
+        let(:response) { head('/example?id=504&secret=password') }
+
+        it 'responds with 200 because before hooks are not called' do
+          expect(response.status).to be 200
+        end
+      end
+    end
+
     context 'allows HEAD on a GET request that' do
       before do
         subject.get 'example' do
@@ -828,7 +950,7 @@ XML
       end
 
       it 'returns a 200' do
-        expect(last_response.status).to eql 200
+        expect(last_response.status).to be 200
       end
 
       it 'has an empty body' do
@@ -844,31 +966,33 @@ XML
         'example'
       end
       head '/example'
-      expect(last_response.status).to eql 400
+      expect(last_response.status).to be 400
     end
   end
 
   context 'do_not_route_head!' do
-    before :each do
+    before do
       subject.do_not_route_head!
       subject.get 'example' do
         'example'
       end
     end
+
     it 'options does not contain HEAD' do
       options '/example'
-      expect(last_response.status).to eql 204
+      expect(last_response.status).to be 204
       expect(last_response.body).to eql ''
       expect(last_response.headers['Allow']).to eql 'OPTIONS, GET'
     end
+
     it 'does not allow HEAD on a GET request' do
       head '/example'
-      expect(last_response.status).to eql 405
+      expect(last_response.status).to be 405
     end
   end
 
   context 'do_not_route_options!' do
-    before :each do
+    before do
       subject.do_not_route_options!
       subject.get 'example' do
         'example'
@@ -877,19 +1001,19 @@ XML
 
     it 'does not create an OPTIONS route' do
       options '/example'
-      expect(last_response.status).to eql 405
+      expect(last_response.status).to be 405
     end
 
     it 'does not include OPTIONS in Allow header' do
       options '/example'
-      expect(last_response.status).to eql 405
+      expect(last_response.status).to be 405
       expect(last_response.headers['Allow']).to eql 'GET, HEAD'
     end
   end
 
   describe '.compile!' do
     it 'requires the grape/eager_load file' do
-      expect(app).to receive(:require).with('grape/eager_load') { nil }
+      expect(app).to receive(:require).with('grape/eager_load').and_return(nil)
       app.compile!
     end
 
@@ -911,7 +1035,7 @@ XML
     context 'when the app was mounted' do
       it 'returns the first mounted instance' do
         mounted_app = app
-        Class.new(Grape::API) do
+        Class.new(described_class) do
           namespace 'new_namespace' do
             mount mounted_app
           end
@@ -939,6 +1063,7 @@ XML
       end
       subject.namespace :blah do
         before { @foo = 'foo' }
+
         get '/' do
           "blah - #{@foo}"
         end
@@ -980,7 +1105,7 @@ XML
         @var ||= 'default'
       end
 
-      expect(m).to receive(:do_something!).exactly(2).times
+      expect(m).to receive(:do_something!).twice
       get '/'
       expect(last_response.body).to eql 'default'
     end
@@ -996,21 +1121,23 @@ XML
       end
       subject.resource ':id' do
         before { a.do_something! }
+
         before_validation { b.do_something! }
         after_validation { c.do_something! }
         after { d.do_something! }
+
         get do
           'got it'
         end
       end
 
-      expect(a).to receive(:do_something!).exactly(1).times
-      expect(b).to receive(:do_something!).exactly(1).times
-      expect(c).to receive(:do_something!).exactly(1).times
-      expect(d).to receive(:do_something!).exactly(1).times
+      expect(a).to receive(:do_something!).once
+      expect(b).to receive(:do_something!).once
+      expect(c).to receive(:do_something!).once
+      expect(d).to receive(:do_something!).once
 
       get '/123'
-      expect(last_response.status).to eql 200
+      expect(last_response.status).to be 200
       expect(last_response.body).to eql 'got it'
     end
 
@@ -1025,21 +1152,23 @@ XML
       end
       subject.resource ':id' do
         before { a.do_something! }
+
         before_validation { b.do_something! }
         after_validation { c.do_something! }
         after { d.do_something! }
+
         get do
           'got it'
         end
       end
 
-      expect(a).to receive(:do_something!).exactly(1).times
-      expect(b).to receive(:do_something!).exactly(1).times
+      expect(a).to receive(:do_something!).once
+      expect(b).to receive(:do_something!).once
       expect(c).to receive(:do_something!).exactly(0).times
       expect(d).to receive(:do_something!).exactly(0).times
 
       get '/abc'
-      expect(last_response.status).to eql 400
+      expect(last_response.status).to be 400
       expect(last_response.body).to eql 'id is invalid'
     end
 
@@ -1055,21 +1184,23 @@ XML
       end
       subject.resource ':id' do
         before { a.here(i += 1) }
+
         before_validation { b.here(i += 1) }
         after_validation { c.here(i += 1) }
         after { d.here(i += 1) }
+
         get do
           'got it'
         end
       end
 
-      expect(a).to receive(:here).with(1).exactly(1).times
-      expect(b).to receive(:here).with(2).exactly(1).times
-      expect(c).to receive(:here).with(3).exactly(1).times
-      expect(d).to receive(:here).with(4).exactly(1).times
+      expect(a).to receive(:here).with(1).once
+      expect(b).to receive(:here).with(2).once
+      expect(c).to receive(:here).with(3).once
+      expect(d).to receive(:here).with(4).once
 
       get '/123'
-      expect(last_response.status).to eql 200
+      expect(last_response.status).to be 200
       expect(last_response.body).to eql 'got it'
     end
   end
@@ -1084,6 +1215,11 @@ XML
       expect(last_response.headers['Content-Type']).to eq('text/plain')
     end
 
+    it 'does not set Cache-Control' do
+      get '/foo'
+      expect(last_response.headers['Cache-Control']).to eq(nil)
+    end
+
     it 'sets content type for xml' do
       get '/foo.xml'
       expect(last_response.headers['Content-Type']).to eq('application/xml')
@@ -1155,7 +1291,7 @@ XML
       subject.format :json
       subject.get('/error') { error!('error in json', 500) }
       get '/error.json'
-      expect(last_response.status).to eql 500
+      expect(last_response.status).to be 500
       expect(last_response.headers['Content-Type']).to eql 'application/json'
     end
 
@@ -1163,7 +1299,7 @@ XML
       subject.format :xml
       subject.get('/error') { error!('error in xml', 500) }
       get '/error'
-      expect(last_response.status).to eql 500
+      expect(last_response.status).to be 500
       expect(last_response.headers['Content-Type']).to eql 'application/xml'
     end
 
@@ -1422,9 +1558,9 @@ XML
       end
       subject.get(:hello) { 'Hello, world.' }
       get '/hello'
-      expect(last_response.status).to eql 401
+      expect(last_response.status).to be 401
       get '/hello', {}, 'HTTP_AUTHORIZATION' => encode_basic_auth('allow', 'whatever')
-      expect(last_response.status).to eql 200
+      expect(last_response.status).to be 200
     end
 
     it 'is scopable' do
@@ -1438,9 +1574,9 @@ XML
       end
 
       get '/hello'
-      expect(last_response.status).to eql 200
+      expect(last_response.status).to be 200
       get '/admin/hello'
-      expect(last_response.status).to eql 401
+      expect(last_response.status).to be 401
     end
 
     it 'is callable via .auth as well' do
@@ -1450,9 +1586,9 @@ XML
 
       subject.get(:hello) { 'Hello, world.' }
       get '/hello'
-      expect(last_response.status).to eql 401
+      expect(last_response.status).to be 401
       get '/hello', {}, 'HTTP_AUTHORIZATION' => encode_basic_auth('allow', 'whatever')
-      expect(last_response.status).to eql 200
+      expect(last_response.status).to be 200
     end
 
     it 'has access to the current endpoint' do
@@ -1482,9 +1618,9 @@ XML
 
       subject.get(:hello) { 'Hello, world.' }
       get '/hello', {}, 'HTTP_AUTHORIZATION' => encode_basic_auth('allow', 'whatever')
-      expect(last_response.status).to eql 200
+      expect(last_response.status).to be 200
       get '/hello', {}, 'HTTP_AUTHORIZATION' => encode_basic_auth('disallow', 'whatever')
-      expect(last_response.status).to eql 401
+      expect(last_response.status).to be 401
     end
 
     it 'can set instance variables accessible to routes' do
@@ -1496,39 +1632,36 @@ XML
 
       subject.get(:hello) { @hello }
       get '/hello', {}, 'HTTP_AUTHORIZATION' => encode_basic_auth('allow', 'whatever')
-      expect(last_response.status).to eql 200
+      expect(last_response.status).to be 200
       expect(last_response.body).to eql 'Hello, world.'
     end
   end
 
   describe '.logger' do
-    subject do
-      Class.new(Grape::API) do
-        def self.io
-          @io ||= StringIO.new
-        end
-        logger ::Logger.new(io)
-      end
-    end
-
     it 'returns an instance of Logger class by default' do
       expect(subject.logger.class).to eql Logger
     end
 
-    it 'allows setting a custom logger' do
-      mylogger = Class.new
-      subject.logger mylogger
-      expect(mylogger).to receive(:info).exactly(1).times
-      subject.logger.info 'this will be logged'
+    context 'with a custom logger' do
+      subject do
+        Class.new(described_class) do
+          def self.io
+            @io ||= StringIO.new
+          end
+          logger ::Logger.new(io)
+        end
+      end
+
+      it 'exposes its interaface' do
+        message = 'this will be logged'
+        subject.logger.info message
+        expect(subject.io.string).to include(message)
+      end
     end
 
-    it 'defaults to a standard logger log format' do
-      t = Time.at(100)
-      allow(Time).to receive(:now).and_return(t)
-      message = "this will be logged\n"
-      message = "I, [#{Logger::Formatter.new.send(:format_datetime, t)}\##{Process.pid}]  INFO -- : #{message}" if !defined?(Rails) || Gem::Version.new(Rails::VERSION::STRING) >= Gem::Version.new('4.0')
-      expect(subject.io).to receive(:write).with(message)
-      subject.logger.info 'this will be logged'
+    it 'does not unnecessarily retain duplicate setup blocks' do
+      subject.logger
+      expect { subject.logger }.not_to change(subject.instance_variable_get(:@setup), :size)
     end
   end
 
@@ -1654,13 +1787,13 @@ XML
       end
 
       get '/new/abc'
-      expect(last_response.status).to eql 404
+      expect(last_response.status).to be 404
       get '/legacy/abc'
-      expect(last_response.status).to eql 200
+      expect(last_response.status).to be 200
       get '/legacy/def'
-      expect(last_response.status).to eql 404
+      expect(last_response.status).to be 404
       get '/new/def'
-      expect(last_response.status).to eql 200
+      expect(last_response.status).to be 200
     end
   end
 
@@ -1880,8 +2013,8 @@ XML
     end
 
     context 'with multiple apis' do
-      let(:a) { Class.new(Grape::API) }
-      let(:b) { Class.new(Grape::API) }
+      let(:a) { Class.new(described_class) }
+      let(:b) { Class.new(described_class) }
 
       before do
         a.helpers do
@@ -1915,7 +2048,7 @@ XML
         raise 'rain!'
       end
       get '/exception'
-      expect(last_response.status).to eql 500
+      expect(last_response.status).to be 500
       expect(last_response.body).to eq 'rain!'
     end
 
@@ -1927,7 +2060,7 @@ XML
         raise 'rain!'
       end
       get '/exception'
-      expect(last_response.status).to eql 500
+      expect(last_response.status).to be 500
       expect(last_response.body).to eq({ error: 'rain!' }.to_json)
     end
 
@@ -1937,7 +2070,7 @@ XML
       subject.get('/unrescued') { raise 'beefcake' }
 
       get '/rescued'
-      expect(last_response.status).to eql 500
+      expect(last_response.status).to be 500
 
       expect { get '/unrescued' }.to raise_error(RuntimeError, 'beefcake')
     end
@@ -1956,10 +2089,10 @@ XML
       subject.get('/standard_error') { raise StandardError }
 
       get '/child_of_standard_error'
-      expect(last_response.status).to eql 402
+      expect(last_response.status).to be 402
 
       get '/standard_error'
-      expect(last_response.status).to eql 401
+      expect(last_response.status).to be 401
     end
 
     context 'CustomError subclass of Grape::Exceptions::Base' do
@@ -2000,7 +2133,7 @@ XML
       subject.get('/formatter_exception') { 'Hello world' }
 
       get '/formatter_exception'
-      expect(last_response.status).to eql 500
+      expect(last_response.status).to be 500
       expect(last_response.body).to eq('Formatter Error')
     end
 
@@ -2010,7 +2143,7 @@ XML
 
       expect_any_instance_of(Grape::Middleware::Error).to receive(:default_rescue_handler).and_call_original
       get '/'
-      expect(last_response.status).to eql 500
+      expect(last_response.status).to be 500
       expect(last_response.body).to eql 'Invalid response'
     end
   end
@@ -2024,14 +2157,16 @@ XML
         raise 'rain!'
       end
       get '/exception'
-      expect(last_response.status).to eql 202
+      expect(last_response.status).to be 202
       expect(last_response.body).to eq('rescued from rain!')
     end
 
     context 'custom errors' do
       before do
         class ConnectionError < RuntimeError; end
+
         class DatabaseError < RuntimeError; end
+
         class CommunicationError < StandardError; end
       end
 
@@ -2043,9 +2178,10 @@ XML
           raise ConnectionError
         end
         get '/exception'
-        expect(last_response.status).to eql 500
+        expect(last_response.status).to be 500
         expect(last_response.body).to eq('rescued from ConnectionError')
       end
+
       it 'rescues a specific error' do
         subject.rescue_from ConnectionError do |e|
           rack_response("rescued from #{e.class.name}", 500)
@@ -2054,9 +2190,10 @@ XML
           raise ConnectionError
         end
         get '/exception'
-        expect(last_response.status).to eql 500
+        expect(last_response.status).to be 500
         expect(last_response.body).to eq('rescued from ConnectionError')
       end
+
       it 'rescues a subclass of an error by default' do
         subject.rescue_from RuntimeError do |e|
           rack_response("rescued from #{e.class.name}", 500)
@@ -2065,9 +2202,10 @@ XML
           raise ConnectionError
         end
         get '/exception'
-        expect(last_response.status).to eql 500
+        expect(last_response.status).to be 500
         expect(last_response.body).to eq('rescued from ConnectionError')
       end
+
       it 'rescues multiple specific errors' do
         subject.rescue_from ConnectionError do |e|
           rack_response("rescued from #{e.class.name}", 500)
@@ -2082,12 +2220,13 @@ XML
           raise DatabaseError
         end
         get '/connection'
-        expect(last_response.status).to eql 500
+        expect(last_response.status).to be 500
         expect(last_response.body).to eq('rescued from ConnectionError')
         get '/database'
-        expect(last_response.status).to eql 500
+        expect(last_response.status).to be 500
         expect(last_response.body).to eq('rescued from DatabaseError')
       end
+
       it 'does not rescue a different error' do
         subject.rescue_from RuntimeError do |e|
           rack_response("rescued from #{e.class.name}", 500)
@@ -2153,7 +2292,7 @@ XML
       subject.rescue_from :all, with: :not_exist_method
       subject.get('/rescue_method') { raise StandardError }
 
-      expect { get '/rescue_method' }.to raise_error(NoMethodError, 'undefined method `not_exist_method\'')
+      expect { get '/rescue_method' }.to raise_error(NoMethodError, /^undefined method `not_exist_method'/)
     end
 
     it 'correctly chooses exception handler if :all handler is specified' do
@@ -2187,6 +2326,7 @@ XML
       module ApiSpec
         module APIErrors
           class ParentError < StandardError; end
+
           class ChildError < ParentError; end
         end
       end
@@ -2207,9 +2347,9 @@ XML
       end
 
       get '/caught_child'
-      expect(last_response.status).to eql 500
+      expect(last_response.status).to be 500
       get '/caught_parent'
-      expect(last_response.status).to eql 500
+      expect(last_response.status).to be 500
       expect { get '/uncaught_parent' }.to raise_error(StandardError)
     end
 
@@ -2222,7 +2362,7 @@ XML
       end
 
       get '/caught_child'
-      expect(last_response.status).to eql 500
+      expect(last_response.status).to be 500
     end
 
     it 'does not rescue child errors if rescue_subclasses is false' do
@@ -2317,7 +2457,7 @@ XML
     end
 
     context 'class' do
-      before :each do
+      before do
         module ApiSpec
           class CustomErrorFormatter
             def self.call(message, _backtrace, _options, _env, _original_exception)
@@ -2326,6 +2466,7 @@ XML
           end
         end
       end
+
       it 'returns a custom error format' do
         subject.rescue_from :all, backtrace: true
         subject.error_formatter :txt, ApiSpec::CustomErrorFormatter
@@ -2339,7 +2480,7 @@ XML
 
     describe 'with' do
       context 'class' do
-        before :each do
+        before do
           module ApiSpec
             class CustomErrorFormatter
               def self.call(message, _backtrace, _option, _env, _original_exception)
@@ -2369,6 +2510,7 @@ XML
       get '/exception'
       expect(last_response.body).to eql '{"error":"rain!"}'
     end
+
     it 'rescues all errors and return :json with backtrace' do
       subject.rescue_from :all, backtrace: true
       subject.format :json
@@ -2380,6 +2522,7 @@ XML
       expect(json['error']).to eql 'rain!'
       expect(json['backtrace'].length).to be > 0
     end
+
     it 'rescues error! and return txt' do
       subject.format :txt
       subject.get '/error' do
@@ -2388,23 +2531,26 @@ XML
       get '/error'
       expect(last_response.body).to eql 'Access Denied'
     end
+
     context 'with json format' do
       before { subject.format :json }
 
+      after do
+        get '/error'
+        expect(last_response.body).to eql('{"error":"failure"}')
+      end
+
       it 'rescues error! called with a string and returns json' do
         subject.get('/error') { error!(:failure, 401) }
       end
+
       it 'rescues error! called with a symbol and returns json' do
         subject.get('/error') { error!(:failure, 401) }
       end
+
       it 'rescues error! called with a hash and returns json' do
         subject.get('/error') { error!({ error: :failure }, 401) }
       end
-
-      after do
-        get '/error'
-        expect(last_response.body).to eql('{"error":"failure"}')
-      end
     end
   end
 
@@ -2417,6 +2563,7 @@ XML
       get '/excel.xls'
       expect(last_response.content_type).to eq('application/vnd.ms-excel')
     end
+
     it 'allows to override content-type' do
       subject.get :content do
         content_type 'text/javascript'
@@ -2425,6 +2572,7 @@ XML
       get '/content'
       expect(last_response.content_type).to eq('text/javascript')
     end
+
     it 'removes existing content types' do
       subject.content_type :xls, 'application/vnd.ms-excel'
       subject.get :excel do
@@ -2442,24 +2590,27 @@ XML
 
   describe '.formatter' do
     context 'multiple formatters' do
-      before :each do
+      before do
         subject.formatter :json, ->(object, _env) { "{\"custom_formatter\":\"#{object[:some]}\"}" }
         subject.formatter :txt, ->(object, _env) { "custom_formatter: #{object[:some]}" }
         subject.get :simple do
           { some: 'hash' }
         end
       end
+
       it 'sets one formatter' do
         get '/simple.json'
         expect(last_response.body).to eql '{"custom_formatter":"hash"}'
       end
+
       it 'sets another formatter' do
         get '/simple.txt'
         expect(last_response.body).to eql 'custom_formatter: hash'
       end
     end
+
     context 'custom formatter' do
-      before :each do
+      before do
         subject.content_type :json, 'application/json'
         subject.content_type :custom, 'application/custom'
         subject.formatter :custom, ->(object, _env) { "{\"custom_formatter\":\"#{object[:some]}\"}" }
@@ -2467,15 +2618,18 @@ XML
           { some: 'hash' }
         end
       end
+
       it 'uses json' do
         get '/simple.json'
         expect(last_response.body).to eql '{"some":"hash"}'
       end
+
       it 'uses custom formatter' do
         get '/simple.custom', 'HTTP_ACCEPT' => 'application/custom'
         expect(last_response.body).to eql '{"custom_formatter":"hash"}'
       end
     end
+
     context 'custom formatter class' do
       module ApiSpec
         module CustomFormatter
@@ -2484,7 +2638,7 @@ XML
           end
         end
       end
-      before :each do
+      before do
         subject.content_type :json, 'application/json'
         subject.content_type :custom, 'application/custom'
         subject.formatter :custom, ApiSpec::CustomFormatter
@@ -2492,10 +2646,12 @@ XML
           { some: 'hash' }
         end
       end
+
       it 'uses json' do
         get '/simple.json'
         expect(last_response.body).to eql '{"some":"hash"}'
       end
+
       it 'uses custom formatter' do
         get '/simple.custom', 'HTTP_ACCEPT' => 'application/custom'
         expect(last_response.body).to eql '{"custom_formatter":"hash"}'
@@ -2513,8 +2669,9 @@ XML
       expect(last_response.status).to eq(201)
       expect(last_response.body).to eq('{"x":42}')
     end
+
     context 'lambda parser' do
-      before :each do
+      before do
         subject.content_type :txt, 'text/plain'
         subject.content_type :custom, 'text/custom'
         subject.parser :custom, ->(object, _env) { { object.to_sym => object.to_s.reverse } }
@@ -2522,6 +2679,7 @@ XML
           params[:simple]
         end
       end
+
       ['text/custom', 'text/custom; charset=UTF-8'].each do |content_type|
         it "uses parser for #{content_type}" do
           put '/simple', 'simple', 'CONTENT_TYPE' => content_type
@@ -2530,6 +2688,7 @@ XML
         end
       end
     end
+
     context 'custom parser class' do
       module ApiSpec
         module CustomParser
@@ -2538,7 +2697,7 @@ XML
           end
         end
       end
-      before :each do
+      before do
         subject.content_type :txt, 'text/plain'
         subject.content_type :custom, 'text/custom'
         subject.parser :custom, ApiSpec::CustomParser
@@ -2546,12 +2705,14 @@ XML
           params[:simple]
         end
       end
+
       it 'uses custom parser' do
         put '/simple', 'simple', 'CONTENT_TYPE' => 'text/custom'
         expect(last_response.status).to eq(200)
         expect(last_response.body).to eql 'elpmis'
       end
     end
+
     if Object.const_defined? :MultiXml
       context 'multi_xml' do
         it "doesn't parse yaml" do
@@ -2576,12 +2737,13 @@ XML
       end
     end
     context 'none parser class' do
-      before :each do
+      before do
         subject.parser :json, nil
         subject.put 'data' do
           "body: #{env['api.request.body']}"
         end
       end
+
       it 'does not parse data' do
         put '/data', 'not valid json', 'CONTENT_TYPE' => 'application/json'
         expect(last_response.status).to eq(200)
@@ -2591,10 +2753,11 @@ XML
   end
 
   describe '.default_format' do
-    before :each do
+    before do
       subject.format :json
       subject.default_format :json
     end
+
     it 'returns data in default format' do
       subject.get '/data' do
         { x: 42 }
@@ -2603,6 +2766,7 @@ XML
       expect(last_response.status).to eq(200)
       expect(last_response.body).to eq('{"x":42}')
     end
+
     it 'parses data in default format' do
       subject.post '/data' do
         { x: params[:x] }
@@ -2621,16 +2785,18 @@ XML
         raise 'rain!'
       end
       get '/exception'
-      expect(last_response.status).to eql 200
+      expect(last_response.status).to be 200
     end
+
     it 'has a default error status' do
       subject.rescue_from :all
       subject.get '/exception' do
         raise 'rain!'
       end
       get '/exception'
-      expect(last_response.status).to eql 500
+      expect(last_response.status).to be 500
     end
+
     it 'uses the default error status in error!' do
       subject.rescue_from :all
       subject.default_error_status 400
@@ -2638,7 +2804,7 @@ XML
         error! 'rain!'
       end
       get '/exception'
-      expect(last_response.status).to eql 400
+      expect(last_response.status).to be 400
     end
   end
 
@@ -2664,7 +2830,7 @@ XML
       end
 
       get '/exception'
-      expect(last_response.status).to eql 408
+      expect(last_response.status).to be 408
       expect(last_response.body).to eql({ code: 408, static: 'some static text' }.to_json)
     end
 
@@ -2675,7 +2841,7 @@ XML
       end
 
       get '/exception'
-      expect(last_response.status).to eql 408
+      expect(last_response.status).to be 408
       expect(last_response.body).to eql({ code: 408, static: 'some static text' }.to_json)
     end
   end
@@ -2686,12 +2852,14 @@ XML
         expect(subject.routes).to eq([])
       end
     end
+
     describe 'single method api structure' do
-      before(:each) do
+      before do
         subject.get :ping do
           'pong'
         end
       end
+
       it 'returns one route' do
         expect(subject.routes.size).to eq(1)
         route = subject.routes[0]
@@ -2700,8 +2868,9 @@ XML
         expect(route.request_method).to eq('GET')
       end
     end
+
     describe 'api structure with two versions and a namespace' do
-      before :each do
+      before do
         subject.version 'v1', using: :path
         subject.get 'version' do
           api.version
@@ -2717,30 +2886,37 @@ XML
           end
         end
       end
+
       it 'returns the latest version set' do
         expect(subject.version).to eq('v2')
       end
+
       it 'returns versions' do
         expect(subject.versions).to eq(%w[v1 v2])
       end
+
       it 'sets route paths' do
         expect(subject.routes.size).to be >= 2
         expect(subject.routes[0].path).to eq('/:version/version(.:format)')
         expect(subject.routes[1].path).to eq('/p/:version/n1/n2/version(.:format)')
       end
+
       it 'sets route versions' do
         expect(subject.routes[0].version).to eq('v1')
         expect(subject.routes[1].version).to eq('v2')
       end
+
       it 'sets a nested namespace' do
         expect(subject.routes[1].namespace).to eq('/n1/n2')
       end
+
       it 'sets prefix' do
         expect(subject.routes[1].prefix).to eq('p')
       end
     end
+
     describe 'api structure with additional parameters' do
-      before(:each) do
+      before do
         subject.params do
           requires :token, desc: 'a token'
           optional :limit, desc: 'the limit'
@@ -2749,14 +2925,17 @@ XML
           params[:string].split(params[:token], (params[:limit] || 0).to_i)
         end
       end
+
       it 'splits a string' do
         get '/split/a,b,c.json', token: ','
         expect(last_response.body).to eq('["a","b","c"]')
       end
+
       it 'splits a string with limit' do
         get '/split/a,b,c.json', token: ',', limit: '2'
         expect(last_response.body).to eq('["a","b,c"]')
       end
+
       it 'sets params' do
         expect(subject.routes.map do |route|
           { params: route.params }
@@ -2771,8 +2950,9 @@ XML
         ]
       end
     end
+
     describe 'api structure with multiple apis' do
-      before(:each) do
+      before do
         subject.params do
           requires :one, desc: 'a token'
           optional :two, desc: 'the limit'
@@ -2787,6 +2967,7 @@ XML
         subject.get 'two' do
         end
       end
+
       it 'sets params' do
         expect(subject.routes.map do |route|
           { params: route.params }
@@ -2806,8 +2987,9 @@ XML
         ]
       end
     end
+
     describe 'api structure with an api without params' do
-      before(:each) do
+      before do
         subject.params do
           requires :one, desc: 'a token'
           optional :two, desc: 'the limit'
@@ -2818,6 +3000,7 @@ XML
         subject.get 'two' do
         end
       end
+
       it 'sets params' do
         expect(subject.routes.map do |route|
           { params: route.params }
@@ -2834,17 +3017,20 @@ XML
         ]
       end
     end
+
     describe 'api with a custom route setting' do
-      before(:each) do
+      before do
         subject.route_setting :custom, key: 'value'
         subject.get 'one'
       end
+
       it 'exposed' do
         expect(subject.routes.count).to eq 1
         route = subject.routes.first
         expect(route.settings[:custom]).to eq(key: 'value')
       end
     end
+
     describe 'status' do
       it 'can be set to arbitrary Integer value' do
         subject.get '/foo' do
@@ -2853,6 +3039,7 @@ XML
         get '/foo'
         expect(last_response.status).to eq 210
       end
+
       it 'can be set with a status code symbol' do
         subject.get '/foo' do
           status :see_other
@@ -2867,10 +3054,12 @@ XML
     it 'empty array of routes' do
       expect(subject.routes).to eq([])
     end
+
     it 'empty array of routes' do
       subject.desc 'grape api'
       expect(subject.routes).to eq([])
     end
+
     it 'describes a method' do
       subject.desc 'first method'
       subject.get :first
@@ -2881,6 +3070,7 @@ XML
       expect(route.params).to eq({})
       expect(route.options).to be_a_kind_of(Hash)
     end
+
     it 'has params which does not include format and version as named captures' do
       subject.version :v1, using: :path
       subject.get :first
@@ -2888,6 +3078,7 @@ XML
       expect(param_keys).not_to include('format')
       expect(param_keys).not_to include('version')
     end
+
     it 'describes methods separately' do
       subject.desc 'first method'
       subject.get :first
@@ -2901,6 +3092,7 @@ XML
         { description: 'second method', params: {} }
       ]
     end
+
     it 'resets desc' do
       subject.desc 'first method'
       subject.get :first
@@ -2912,6 +3104,7 @@ XML
         { description: nil, params: {} }
       ]
     end
+
     it 'namespaces and describe arbitrary parameters' do
       subject.namespace 'ns' do
         desc 'ns second', foo: 'bar'
@@ -2923,6 +3116,7 @@ XML
         { description: 'ns second', foo: 'bar', params: {} }
       ]
     end
+
     it 'includes details' do
       subject.desc 'method', details: 'method details'
       subject.get 'method'
@@ -2932,6 +3126,7 @@ XML
         { description: 'method', details: 'method details', params: {} }
       ]
     end
+
     it 'describes a method with parameters' do
       subject.desc 'Reverses a string.', params: { 's' => { desc: 'string to reverse', type: 'string' } }
       subject.get 'reverse' do
@@ -2943,6 +3138,7 @@ XML
         { description: 'Reverses a string.', params: { 's' => { desc: 'string to reverse', type: 'string' } } }
       ]
     end
+
     it 'does not inherit param descriptions in consequent namespaces' do
       subject.desc 'global description'
       subject.params do
@@ -2973,6 +3169,7 @@ XML
           } }
       ]
     end
+
     it 'merges the parameters of the namespace with the parameters of the method' do
       subject.desc 'namespace'
       subject.params do
@@ -2997,6 +3194,7 @@ XML
           } }
       ]
     end
+
     it 'merges the parameters of nested namespaces' do
       subject.desc 'ns1'
       subject.params do
@@ -3029,6 +3227,7 @@ XML
           } }
       ]
     end
+
     it 'groups nested params and prevents overwriting of params with same name in different groups' do
       subject.desc 'method'
       subject.params do
@@ -3044,14 +3243,15 @@ XML
       subject.get 'method'
 
       expect(subject.routes.map(&:params)).to eq [{
-        'group1'         => { required: true, type: 'Array' },
+        'group1' => { required: true, type: 'Array' },
         'group1[param1]' => { required: false, desc: 'group1 param1 desc' },
         'group1[param2]' => { required: true, desc: 'group1 param2 desc' },
-        'group2'         => { required: true, type: 'Array' },
+        'group2' => { required: true, type: 'Array' },
         'group2[param1]' => { required: false, desc: 'group2 param1 desc' },
         'group2[param2]' => { required: true, desc: 'group2 param2 desc' }
       }]
     end
+
     it 'uses full name of parameters in nested groups' do
       subject.desc 'nesting'
       subject.params do
@@ -3072,6 +3272,7 @@ XML
           } }
       ]
     end
+
     it 'allows to set the type attribute on :group element' do
       subject.params do
         group :foo, type: Array do
@@ -3079,6 +3280,7 @@ XML
         end
       end
     end
+
     it 'parses parameters when no description is given' do
       subject.params do
         requires :one_param, desc: 'one param'
@@ -3090,6 +3292,7 @@ XML
         { description: nil, params: { 'one_param' => { required: true, desc: 'one param' } } }
       ]
     end
+
     it 'does not symbolize params' do
       subject.desc 'Reverses a string.', params: { 's' => { desc: 'string to reverse', type: 'string' } }
       subject.get 'reverse/:s' do
@@ -3148,7 +3351,7 @@ XML
         subject.version 'v1', using: :path
 
         subject.namespace :cool do
-          app = Class.new(Grape::API)
+          app = Class.new(Grape::API) # rubocop:disable RSpec/DescribedClass
           app.get('/awesome') do
             'yo'
           end
@@ -3164,12 +3367,12 @@ XML
         subject.version 'v1', using: :path
 
         subject.namespace :cool do
-          inner_app = Class.new(Grape::API)
+          inner_app = Class.new(Grape::API) # rubocop:disable RSpec/DescribedClass
           inner_app.get('/awesome') do
             'yo'
           end
 
-          app = Class.new(Grape::API)
+          app = Class.new(Grape::API) # rubocop:disable RSpec/DescribedClass
           app.mount inner_app
           mount app
         end
@@ -3184,7 +3387,7 @@ XML
             rack_response("rescued from #{e.message}", 202)
           end
 
-          app = Class.new(Grape::API)
+          app = Class.new(described_class)
 
           subject.namespace :mounted do
             app.rescue_from ArgumentError
@@ -3193,15 +3396,16 @@ XML
           end
 
           get '/mounted/fail'
-          expect(last_response.status).to eql 202
+          expect(last_response.status).to be 202
           expect(last_response.body).to eq('rescued from doh!')
         end
+
         it 'prefers rescues defined by mounted if they rescue similar error class' do
           subject.rescue_from StandardError do
             rack_response('outer rescue')
           end
 
-          app = Class.new(Grape::API)
+          app = Class.new(described_class)
 
           subject.namespace :mounted do
             rescue_from StandardError do
@@ -3214,12 +3418,13 @@ XML
           get '/mounted/fail'
           expect(last_response.body).to eq('inner rescue')
         end
+
         it 'prefers rescues defined by mounted even if outer is more specific' do
           subject.rescue_from ArgumentError do
             rack_response('outer rescue')
           end
 
-          app = Class.new(Grape::API)
+          app = Class.new(described_class)
 
           subject.namespace :mounted do
             rescue_from StandardError do
@@ -3232,12 +3437,13 @@ XML
           get '/mounted/fail'
           expect(last_response.body).to eq('inner rescue')
         end
+
         it 'prefers more specific rescues defined by mounted' do
           subject.rescue_from StandardError do
             rack_response('outer rescue')
           end
 
-          app = Class.new(Grape::API)
+          app = Class.new(described_class)
 
           subject.namespace :mounted do
             rescue_from ArgumentError do
@@ -3254,19 +3460,19 @@ XML
 
       it 'collects the routes of the mounted api' do
         subject.namespace :cool do
-          app = Class.new(Grape::API)
+          app = Class.new(Grape::API) # rubocop:disable RSpec/DescribedClass
           app.get('/awesome') {}
           app.post('/sauce') {}
           mount app
         end
         expect(subject.routes.size).to eq(2)
-        expect(subject.routes.first.path).to match(%r{\/cool\/awesome})
-        expect(subject.routes.last.path).to match(%r{\/cool\/sauce})
+        expect(subject.routes.first.path).to match(%r{/cool/awesome})
+        expect(subject.routes.last.path).to match(%r{/cool/sauce})
       end
 
       it 'mounts on a path' do
         subject.namespace :cool do
-          app = Class.new(Grape::API)
+          app = Class.new(Grape::API) # rubocop:disable RSpec/DescribedClass
           app.get '/awesome' do
             'sauce'
           end
@@ -3278,12 +3484,12 @@ XML
       end
 
       it 'mounts on a nested path' do
-        APP1 = Class.new(Grape::API)
-        APP2 = Class.new(Grape::API)
+        APP1 = Class.new(described_class)
+        APP2 = Class.new(described_class)
         APP2.get '/nice' do
           'play'
         end
-        # note that the reverse won't work, mount from outside-in
+        # NOTE: that the reverse won't work, mount from outside-in
         APP3 = subject
         APP3.mount APP1 => '/app1'
         APP1.mount APP2 => '/app2'
@@ -3295,7 +3501,7 @@ XML
       end
 
       it 'responds to options' do
-        app = Class.new(Grape::API)
+        app = Class.new(described_class)
         app.get '/colour' do
           'red'
         end
@@ -3309,21 +3515,21 @@ XML
         end
 
         get '/apples/colour'
-        expect(last_response.status).to eql 200
+        expect(last_response.status).to be 200
         expect(last_response.body).to eq('red')
         options '/apples/colour'
-        expect(last_response.status).to eql 204
+        expect(last_response.status).to be 204
         get '/apples/pears/colour'
-        expect(last_response.status).to eql 200
+        expect(last_response.status).to be 200
         expect(last_response.body).to eq('green')
         options '/apples/pears/colour'
-        expect(last_response.status).to eql 204
+        expect(last_response.status).to be 204
       end
 
       it 'responds to options with path versioning' do
         subject.version 'v1', using: :path
         subject.namespace :apples do
-          app = Class.new(Grape::API)
+          app = Class.new(Grape::API) # rubocop:disable RSpec/DescribedClass
           app.get('/colour') do
             'red'
           end
@@ -3331,14 +3537,14 @@ XML
         end
 
         get '/v1/apples/colour'
-        expect(last_response.status).to eql 200
+        expect(last_response.status).to be 200
         expect(last_response.body).to eq('red')
         options '/v1/apples/colour'
-        expect(last_response.status).to eql 204
+        expect(last_response.status).to be 204
       end
 
       it 'mounts a versioned API with nested resources' do
-        api = Class.new(Grape::API) do
+        api = Class.new(described_class) do
           version 'v1'
           resources :users do
             get :hello do
@@ -3353,7 +3559,7 @@ XML
       end
 
       it 'mounts a prefixed API with nested resources' do
-        api = Class.new(Grape::API) do
+        api = Class.new(described_class) do
           prefix 'api'
           resources :users do
             get :hello do
@@ -3368,7 +3574,7 @@ XML
       end
 
       it 'applies format to a mounted API with nested resources' do
-        api = Class.new(Grape::API) do
+        api = Class.new(described_class) do
           format :json
           resources :users do
             get do
@@ -3383,7 +3589,7 @@ XML
       end
 
       it 'applies auth to a mounted API with nested resources' do
-        api = Class.new(Grape::API) do
+        api = Class.new(described_class) do
           format :json
           http_basic do |username, password|
             username == 'username' && password == 'password'
@@ -3404,7 +3610,7 @@ XML
       end
 
       it 'mounts multiple versioned APIs with nested resources' do
-        api1 = Class.new(Grape::API) do
+        api1 = Class.new(described_class) do
           version 'one', using: :header, vendor: 'test'
           resources :users do
             get :hello do
@@ -3413,7 +3619,7 @@ XML
           end
         end
 
-        api2 = Class.new(Grape::API) do
+        api2 = Class.new(described_class) do
           version 'two', using: :header, vendor: 'test'
           resources :users do
             get :hello do
@@ -3432,7 +3638,7 @@ XML
       end
 
       it 'recognizes potential versions with mounted path' do
-        a = Class.new(Grape::API) do
+        a = Class.new(described_class) do
           version :v1, using: :path
 
           get '/hello' do
@@ -3440,7 +3646,7 @@ XML
           end
         end
 
-        b = Class.new(Grape::API) do
+        b = Class.new(described_class) do
           version :v1, using: :path
 
           get '/world' do
@@ -3460,11 +3666,11 @@ XML
 
       context 'when mounting class extends a subclass of Grape::API' do
         it 'mounts APIs with the same superclass' do
-          base_api = Class.new(Grape::API)
+          base_api = Class.new(described_class)
           a = Class.new(base_api)
           b = Class.new(base_api)
 
-          expect { a.mount b }.to_not raise_error
+          expect { a.mount b }.not_to raise_error
         end
       end
 
@@ -3474,6 +3680,7 @@ XML
             def self.included(base)
               base.extend(ClassMethods)
             end
+
             module ClassMethods
               def my_method
                 @test = true
@@ -3482,22 +3689,22 @@ XML
           end
         end
 
-        it 'should correctly include module in nested mount' do
+        it 'correctlies include module in nested mount' do
           module_to_include = included_module
-          v1 = Class.new(Grape::API) do
+          v1 = Class.new(described_class) do
             version :v1, using: :path
             include module_to_include
             my_method
           end
-          v2 = Class.new(Grape::API) do
+          v2 = Class.new(described_class) do
             version :v2, using: :path
           end
-          segment_base = Class.new(Grape::API) do
+          segment_base = Class.new(described_class) do
             mount v1
             mount v2
           end
 
-          Class.new(Grape::API) do
+          Class.new(described_class) do
             mount segment_base
           end
 
@@ -3532,7 +3739,7 @@ XML
   end
 
   describe '.endpoint' do
-    before(:each) do
+    before do
       subject.format :json
       subject.get '/endpoint/options' do
         {
@@ -3541,6 +3748,7 @@ XML
         }
       end
     end
+
     it 'path' do
       get '/endpoint/options'
       options = ::Grape::Json.load(last_response.body)
@@ -3552,7 +3760,7 @@ XML
 
   describe '.route' do
     context 'plain' do
-      before(:each) do
+      before do
         subject.get '/' do
           route.path
         end
@@ -3560,6 +3768,7 @@ XML
           route.path
         end
       end
+
       it 'provides access to route info' do
         get '/'
         expect(last_response.body).to eq('/(.:format)')
@@ -3567,8 +3776,9 @@ XML
         expect(last_response.body).to eq('/path(.:format)')
       end
     end
+
     context 'with desc' do
-      before(:each) do
+      before do
         subject.desc 'returns description'
         subject.get '/description' do
           route.description
@@ -3578,82 +3788,98 @@ XML
           route.params[params[:id]]
         end
       end
+
       it 'returns route description' do
         get '/description'
         expect(last_response.body).to eq('returns description')
       end
+
       it 'returns route parameters' do
         get '/params/x'
         expect(last_response.body).to eq('y')
       end
     end
   end
+
   describe '.format' do
     context ':txt' do
-      before(:each) do
+      before do
         subject.format :txt
         subject.content_type :json, 'application/json'
         subject.get '/meaning_of_life' do
           { meaning_of_life: 42 }
         end
       end
+
       it 'forces txt without an extension' do
         get '/meaning_of_life'
         expect(last_response.body).to eq({ meaning_of_life: 42 }.to_s)
       end
+
       it 'does not force txt with an extension' do
         get '/meaning_of_life.json'
         expect(last_response.body).to eq({ meaning_of_life: 42 }.to_json)
       end
+
       it 'forces txt from a non-accepting header' do
         get '/meaning_of_life', {}, 'HTTP_ACCEPT' => 'application/json'
         expect(last_response.body).to eq({ meaning_of_life: 42 }.to_s)
       end
     end
+
     context ':txt only' do
-      before(:each) do
+      before do
         subject.format :txt
         subject.get '/meaning_of_life' do
           { meaning_of_life: 42 }
         end
       end
+
       it 'forces txt without an extension' do
         get '/meaning_of_life'
         expect(last_response.body).to eq({ meaning_of_life: 42 }.to_s)
       end
+
       it 'accepts specified extension' do
         get '/meaning_of_life.txt'
         expect(last_response.body).to eq({ meaning_of_life: 42 }.to_s)
       end
+
       it 'does not accept extensions other than specified' do
         get '/meaning_of_life.json'
         expect(last_response.status).to eq(404)
       end
+
       it 'forces txt from a non-accepting header' do
         get '/meaning_of_life', {}, 'HTTP_ACCEPT' => 'application/json'
         expect(last_response.body).to eq({ meaning_of_life: 42 }.to_s)
       end
     end
+
     context ':json' do
-      before(:each) do
+      before do
         subject.format :json
         subject.content_type :txt, 'text/plain'
         subject.get '/meaning_of_life' do
           { meaning_of_life: 42 }
         end
       end
+
       it 'forces json without an extension' do
         get '/meaning_of_life'
         expect(last_response.body).to eq({ meaning_of_life: 42 }.to_json)
       end
+
       it 'does not force json with an extension' do
         get '/meaning_of_life.txt'
         expect(last_response.body).to eq({ meaning_of_life: 42 }.to_s)
       end
+
       it 'forces json from a non-accepting header' do
         get '/meaning_of_life', {}, 'HTTP_ACCEPT' => 'text/html'
         expect(last_response.body).to eq({ meaning_of_life: 42 }.to_json)
       end
+
       it 'can be overwritten with an explicit content type' do
         subject.get '/meaning_of_life_with_content_type' do
           content_type 'text/plain'
@@ -3662,6 +3888,7 @@ XML
         get '/meaning_of_life_with_content_type'
         expect(last_response.body).to eq({ meaning_of_life: 42 }.to_s)
       end
+
       it 'raised :error from middleware' do
         middleware = Class.new(Grape::Middleware::Base) do
           def before
@@ -3676,6 +3903,7 @@ XML
         expect(last_response.body).to eq({ error: 'Unauthorized' }.to_json)
       end
     end
+
     context ':serializable_hash' do
       class SerializableHashExample
         def serializable_hash
@@ -3683,9 +3911,10 @@ XML
         end
       end
 
-      before(:each) do
+      before do
         subject.format :serializable_hash
       end
+
       it 'instance' do
         subject.get '/example' do
           SerializableHashExample.new
@@ -3693,6 +3922,7 @@ XML
         get '/example'
         expect(last_response.body).to eq('{"abc":"def"}')
       end
+
       it 'root' do
         subject.get '/example' do
           { 'root' => SerializableHashExample.new }
@@ -3700,6 +3930,7 @@ XML
         get '/example'
         expect(last_response.body).to eq('{"root":{"abc":"def"}}')
       end
+
       it 'array' do
         subject.get '/examples' do
           [SerializableHashExample.new, SerializableHashExample.new]
@@ -3708,23 +3939,26 @@ XML
         expect(last_response.body).to eq('[{"abc":"def"},{"abc":"def"}]')
       end
     end
+
     context ':xml' do
-      before(:each) do
+      before do
         subject.format :xml
       end
+
       it 'string' do
         subject.get '/example' do
           'example'
         end
         get '/example'
         expect(last_response.status).to eq(500)
-        expect(last_response.body).to eq <<-XML
-<?xml version="1.0" encoding="UTF-8"?>
-<error>
-  <message>cannot convert String to xml</message>
-</error>
-XML
+        expect(last_response.body).to eq <<~XML
+          <?xml version="1.0" encoding="UTF-8"?>
+          <error>
+            <message>cannot convert String to xml</message>
+          </error>
+        XML
       end
+
       it 'hash' do
         subject.get '/example' do
           {
@@ -3734,28 +3968,30 @@ XML
         end
         get '/example'
         expect(last_response.status).to eq(200)
-        expect(last_response.body).to eq <<-XML
-<?xml version="1.0" encoding="UTF-8"?>
-<hash>
-  <example1>example1</example1>
-  <example2>example2</example2>
-</hash>
-XML
+        expect(last_response.body).to eq <<~XML
+          <?xml version="1.0" encoding="UTF-8"?>
+          <hash>
+            <example1>example1</example1>
+            <example2>example2</example2>
+          </hash>
+        XML
       end
+
       it 'array' do
         subject.get '/example' do
           %w[example1 example2]
         end
         get '/example'
         expect(last_response.status).to eq(200)
-        expect(last_response.body).to eq <<-XML
-<?xml version="1.0" encoding="UTF-8"?>
-<strings type="array">
-  <string>example1</string>
-  <string>example2</string>
-</strings>
-XML
+        expect(last_response.body).to eq <<~XML
+          <?xml version="1.0" encoding="UTF-8"?>
+          <strings type="array">
+            <string>example1</string>
+            <string>example2</string>
+          </strings>
+        XML
       end
+
       it 'raised :error from middleware' do
         middleware = Class.new(Grape::Middleware::Base) do
           def before
@@ -3767,12 +4003,12 @@ XML
         end
         get '/'
         expect(last_response.status).to eq(42)
-        expect(last_response.body).to eq <<-XML
-<?xml version="1.0" encoding="UTF-8"?>
-<error>
-  <message>Unauthorized</message>
-</error>
-XML
+        expect(last_response.body).to eq <<~XML
+          <?xml version="1.0" encoding="UTF-8"?>
+          <error>
+            <message>Unauthorized</message>
+          </error>
+        XML
       end
     end
   end
@@ -3817,12 +4053,12 @@ XML
 
   context 'catch-all' do
     before do
-      api1 = Class.new(Grape::API)
+      api1 = Class.new(described_class)
       api1.version 'v1', using: :path
       api1.get 'hello' do
         'v1'
       end
-      api2 = Class.new(Grape::API)
+      api2 = Class.new(described_class)
       api2.version 'v2', using: :path
       api2.get 'hello' do
         'v2'
@@ -3830,6 +4066,7 @@ XML
       subject.mount api1
       subject.mount api2
     end
+
     [true, false].each do |anchor|
       it "anchor=#{anchor}" do
         subject.route :any, '*path', anchor: anchor do
@@ -3862,6 +4099,7 @@ XML
         expect(last_response.status).to eq(404)
         expect(last_response.headers['X-Cascade']).to eq('pass')
       end
+
       it 'does not cascade' do
         subject.version 'v2', using: :path, cascade: false
         get '/v2/hello'
@@ -3869,6 +4107,7 @@ XML
         expect(last_response.headers.keys).not_to include 'X-Cascade'
       end
     end
+
     context 'via endpoint' do
       it 'cascades' do
         subject.cascade true
@@ -3876,6 +4115,7 @@ XML
         expect(last_response.status).to eq(404)
         expect(last_response.headers['X-Cascade']).to eq('pass')
       end
+
       it 'does not cascade' do
         subject.cascade false
         get '/hello'
@@ -3925,12 +4165,14 @@ XML
           body false
         end
       end
+
       it 'returns blank body' do
         get '/blank'
         expect(last_response.status).to eq(204)
         expect(last_response.body).to be_blank
       end
     end
+
     context 'plain text' do
       before do
         subject.get '/text' do
@@ -3939,6 +4181,7 @@ XML
           'ignored'
         end
       end
+
       it 'returns blank body' do
         get '/text'
         expect(last_response.status).to eq(200)
@@ -3948,7 +4191,7 @@ XML
   end
 
   describe 'normal class methods' do
-    subject(:grape_api) { Class.new(Grape::API) }
+    subject(:grape_api) { Class.new(described_class) }
 
     before do
       stub_const('MyAPI', grape_api)
@@ -3965,10 +4208,54 @@ XML
     end
   end
 
+  describe '.inherited' do
+    context 'overriding within class' do
+      let(:root_api) do
+        Class.new(described_class) do
+          @bar = 'Hello, world'
+
+          def self.inherited(child_api)
+            super
+            child_api.instance_variable_set(:@foo, @bar.dup)
+          end
+        end
+      end
+
+      let(:child_api) { Class.new(root_api) }
+
+      it 'allows overriding the hook' do
+        expect(child_api.instance_variable_get(:@foo)).to eq('Hello, world')
+      end
+    end
+
+    context 'overriding via composition' do
+      module Inherited
+        def inherited(api)
+          super
+          api.instance_variable_set(:@foo, @bar.dup)
+        end
+      end
+
+      let(:root_api) do
+        Class.new(described_class) do
+          @bar = 'Hello, world'
+          extend Inherited
+        end
+      end
+
+      let(:child_api) { Class.new(root_api) }
+
+      it 'allows overriding the hook' do
+        expect(child_api.instance_variable_get(:@foo)).to eq('Hello, world')
+      end
+    end
+  end
+
   describe 'const_missing' do
-    subject(:grape_api) { Class.new(Grape::API) }
+    subject(:grape_api) { Class.new(described_class) }
+
     let(:mounted) do
-      Class.new(Grape::API) do
+      Class.new(described_class) do
         get '/missing' do
           SomeRandomConstant
         end
@@ -3981,4 +4268,82 @@ XML
       expect { get '/const/missing' }.to raise_error(NameError).with_message(/SomeRandomConstant/)
     end
   end
+
+  describe 'custom route helpers on nested APIs' do
+    subject(:grape_api) do
+      Class.new(described_class) do
+        version 'v1', using: :path
+      end
+    end
+
+    let(:shared_api_module) do
+      Module.new do
+        # rubocop:disable Style/ExplicitBlockArgument because this causes
+        #   the underlying issue in this form
+        def uniqe_id_route
+          params do
+            use :unique_id
+          end
+          route_param(:id) do
+            yield
+          end
+        end
+        # rubocop:enable Style/ExplicitBlockArgument
+      end
+    end
+    let(:shared_api_definitions) do
+      Module.new do
+        extend ActiveSupport::Concern
+
+        included do
+          helpers do
+            params :unique_id do
+              requires :id, type: String,
+                            allow_blank: false,
+                            regexp: /\d+-\d+/
+            end
+          end
+        end
+      end
+    end
+    let(:orders_root) do
+      shared = shared_api_definitions
+      find = orders_find_endpoint
+      Class.new(described_class) do
+        include shared
+
+        namespace(:orders) do
+          mount find
+        end
+      end
+    end
+    let(:orders_find_endpoint) do
+      shared = shared_api_definitions
+      Class.new(described_class) do
+        include shared
+
+        uniqe_id_route do
+          desc 'Fetch a single order' do
+            detail 'While specifying the order id on the route'
+          end
+          get { params[:id] }
+        end
+      end
+    end
+
+    before do
+      Grape::API::Instance.extend(shared_api_module)
+      subject.mount orders_root
+    end
+
+    it 'returns an error when the id is bad' do
+      get '/v1/orders/abc'
+      expect(last_response.body).to be_eql('id is invalid')
+    end
+
+    it 'returns the given id when it is valid' do
+      get '/v1/orders/1-2'
+      expect(last_response.body).to be_eql('1-2')
+    end
+  end
 end