grape 1.3.0 → 1.5.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/CHANGELOG.md +119 -1
- data/LICENSE +1 -1
- data/README.md +123 -29
- data/UPGRADING.md +265 -39
- data/lib/grape/api/instance.rb +32 -31
- data/lib/grape/api.rb +5 -5
- data/lib/grape/content_types.rb +34 -0
- data/lib/grape/dsl/callbacks.rb +1 -1
- data/lib/grape/dsl/helpers.rb +2 -1
- data/lib/grape/dsl/inside_route.rb +77 -43
- data/lib/grape/dsl/parameters.rb +12 -8
- data/lib/grape/dsl/routing.rb +12 -11
- data/lib/grape/dsl/validations.rb +18 -1
- data/lib/grape/eager_load.rb +1 -1
- data/lib/grape/endpoint.rb +8 -6
- data/lib/grape/exceptions/base.rb +0 -4
- data/lib/grape/exceptions/validation.rb +1 -1
- data/lib/grape/exceptions/validation_errors.rb +12 -13
- data/lib/grape/http/headers.rb +26 -0
- data/lib/grape/middleware/auth/base.rb +3 -3
- data/lib/grape/middleware/base.rb +4 -5
- data/lib/grape/middleware/error.rb +11 -13
- data/lib/grape/middleware/formatter.rb +3 -3
- data/lib/grape/middleware/stack.rb +10 -2
- data/lib/grape/middleware/versioner/header.rb +4 -4
- data/lib/grape/middleware/versioner/parse_media_type_patch.rb +2 -1
- data/lib/grape/middleware/versioner/path.rb +1 -1
- data/lib/grape/namespace.rb +12 -2
- data/lib/grape/path.rb +13 -3
- data/lib/grape/request.rb +13 -8
- data/lib/grape/router/attribute_translator.rb +26 -5
- data/lib/grape/router/pattern.rb +17 -16
- data/lib/grape/router/route.rb +5 -24
- data/lib/grape/router.rb +26 -30
- data/lib/grape/{serve_file → serve_stream}/file_body.rb +1 -1
- data/lib/grape/{serve_file → serve_stream}/sendfile_response.rb +1 -1
- data/lib/grape/{serve_file/file_response.rb → serve_stream/stream_response.rb} +8 -8
- data/lib/grape/util/base_inheritable.rb +15 -8
- data/lib/grape/util/cache.rb +20 -0
- data/lib/grape/util/lazy_object.rb +43 -0
- data/lib/grape/util/lazy_value.rb +1 -0
- data/lib/grape/util/reverse_stackable_values.rb +2 -0
- data/lib/grape/util/stackable_values.rb +7 -20
- data/lib/grape/validations/attributes_iterator.rb +8 -0
- data/lib/grape/validations/multiple_attributes_iterator.rb +1 -1
- data/lib/grape/validations/params_scope.rb +10 -8
- data/lib/grape/validations/single_attribute_iterator.rb +1 -1
- data/lib/grape/validations/types/array_coercer.rb +14 -5
- data/lib/grape/validations/types/build_coercer.rb +5 -8
- data/lib/grape/validations/types/custom_type_coercer.rb +16 -2
- data/lib/grape/validations/types/dry_type_coercer.rb +36 -1
- data/lib/grape/validations/types/file.rb +15 -12
- data/lib/grape/validations/types/invalid_value.rb +24 -0
- data/lib/grape/validations/types/json.rb +40 -36
- data/lib/grape/validations/types/primitive_coercer.rb +15 -6
- data/lib/grape/validations/types/set_coercer.rb +6 -4
- data/lib/grape/validations/types/variant_collection_coercer.rb +1 -1
- data/lib/grape/validations/types.rb +7 -9
- data/lib/grape/validations/validator_factory.rb +1 -1
- data/lib/grape/validations/validators/as.rb +1 -1
- data/lib/grape/validations/validators/base.rb +8 -8
- data/lib/grape/validations/validators/coerce.rb +11 -15
- data/lib/grape/validations/validators/default.rb +3 -5
- data/lib/grape/validations/validators/exactly_one_of.rb +4 -2
- data/lib/grape/validations/validators/except_values.rb +1 -1
- data/lib/grape/validations/validators/multiple_params_base.rb +2 -1
- data/lib/grape/validations/validators/regexp.rb +1 -1
- data/lib/grape/validations/validators/values.rb +1 -1
- data/lib/grape/version.rb +1 -1
- data/lib/grape.rb +5 -5
- data/spec/grape/api/instance_spec.rb +50 -0
- data/spec/grape/api_remount_spec.rb +9 -4
- data/spec/grape/api_spec.rb +82 -6
- data/spec/grape/dsl/inside_route_spec.rb +182 -33
- data/spec/grape/endpoint/declared_spec.rb +601 -0
- data/spec/grape/endpoint_spec.rb +0 -521
- data/spec/grape/entity_spec.rb +7 -1
- data/spec/grape/exceptions/validation_errors_spec.rb +2 -2
- data/spec/grape/integration/rack_sendfile_spec.rb +12 -8
- data/spec/grape/middleware/auth/strategies_spec.rb +1 -1
- data/spec/grape/middleware/error_spec.rb +1 -1
- data/spec/grape/middleware/formatter_spec.rb +3 -3
- data/spec/grape/middleware/stack_spec.rb +10 -0
- data/spec/grape/path_spec.rb +4 -4
- data/spec/grape/request_spec.rb +1 -1
- data/spec/grape/validations/instance_behaivour_spec.rb +1 -1
- data/spec/grape/validations/multiple_attributes_iterator_spec.rb +13 -3
- data/spec/grape/validations/params_scope_spec.rb +26 -0
- data/spec/grape/validations/single_attribute_iterator_spec.rb +17 -6
- data/spec/grape/validations/types/array_coercer_spec.rb +35 -0
- data/spec/grape/validations/types/primitive_coercer_spec.rb +135 -0
- data/spec/grape/validations/types/set_coercer_spec.rb +34 -0
- data/spec/grape/validations/types_spec.rb +1 -1
- data/spec/grape/validations/validators/coerce_spec.rb +366 -86
- data/spec/grape/validations/validators/default_spec.rb +170 -0
- data/spec/grape/validations/validators/exactly_one_of_spec.rb +12 -12
- data/spec/grape/validations/validators/except_values_spec.rb +1 -0
- data/spec/grape/validations/validators/values_spec.rb +1 -1
- data/spec/grape/validations_spec.rb +298 -30
- data/spec/integration/eager_load/eager_load_spec.rb +15 -0
- data/spec/shared/versioning_examples.rb +20 -20
- data/spec/spec_helper.rb +3 -10
- data/spec/support/chunks.rb +14 -0
- data/spec/support/eager_load.rb +19 -0
- data/spec/support/versioned_helpers.rb +4 -6
- metadata +27 -10
- data/lib/grape/util/content_types.rb +0 -28
data/spec/grape/path_spec.rb
CHANGED
@@ -87,12 +87,12 @@ module Grape
|
|
87
87
|
describe '#namespace?' do
|
88
88
|
it 'is false when the namespace is nil' do
|
89
89
|
path = Path.new(anything, nil, anything)
|
90
|
-
expect(path.namespace?).to
|
90
|
+
expect(path.namespace?).to be_falsey
|
91
91
|
end
|
92
92
|
|
93
93
|
it 'is false when the namespace starts with whitespace' do
|
94
94
|
path = Path.new(anything, ' /foo', anything)
|
95
|
-
expect(path.namespace?).to
|
95
|
+
expect(path.namespace?).to be_falsey
|
96
96
|
end
|
97
97
|
|
98
98
|
it 'is false when the namespace is the root path' do
|
@@ -109,12 +109,12 @@ module Grape
|
|
109
109
|
describe '#path?' do
|
110
110
|
it 'is false when the path is nil' do
|
111
111
|
path = Path.new(nil, anything, anything)
|
112
|
-
expect(path.path?).to
|
112
|
+
expect(path.path?).to be_falsey
|
113
113
|
end
|
114
114
|
|
115
115
|
it 'is false when the path starts with whitespace' do
|
116
116
|
path = Path.new(' /foo', anything, anything)
|
117
|
-
expect(path.path?).to
|
117
|
+
expect(path.path?).to be_falsey
|
118
118
|
end
|
119
119
|
|
120
120
|
it 'is false when the path is the root path' do
|
data/spec/grape/request_spec.rb
CHANGED
@@ -75,7 +75,7 @@ module Grape
|
|
75
75
|
Grape.config.reset
|
76
76
|
end
|
77
77
|
|
78
|
-
subject(:request_params) { Grape::Request.new(env, opts).params }
|
78
|
+
subject(:request_params) { Grape::Request.new(env, **opts).params }
|
79
79
|
|
80
80
|
context 'when the API does not include a specific param builder' do
|
81
81
|
let(:opts) { {} }
|
@@ -6,7 +6,7 @@ describe 'Validator with instance variables' do
|
|
6
6
|
let(:validator_type) do
|
7
7
|
Class.new(Grape::Validations::Base) do
|
8
8
|
def validate_param!(_attr_name, _params)
|
9
|
-
if @instance_variable
|
9
|
+
if instance_variable_defined?(:@instance_variable) && @instance_variable
|
10
10
|
raise Grape::Exceptions::Validation.new(params: ['params'],
|
11
11
|
message: 'This should never happen')
|
12
12
|
end
|
@@ -13,8 +13,8 @@ describe Grape::Validations::MultipleAttributesIterator do
|
|
13
13
|
{ first: 'string', second: 'string' }
|
14
14
|
end
|
15
15
|
|
16
|
-
it 'yields the whole params hash without the list of attrs' do
|
17
|
-
expect { |b| iterator.each(&b) }.to yield_with_args(params)
|
16
|
+
it 'yields the whole params hash and the skipped flag without the list of attrs' do
|
17
|
+
expect { |b| iterator.each(&b) }.to yield_with_args(params, false)
|
18
18
|
end
|
19
19
|
end
|
20
20
|
|
@@ -24,7 +24,17 @@ describe Grape::Validations::MultipleAttributesIterator do
|
|
24
24
|
end
|
25
25
|
|
26
26
|
it 'yields each element of the array without the list of attrs' do
|
27
|
-
expect { |b| iterator.each(&b) }.to yield_successive_args(params[0], params[1])
|
27
|
+
expect { |b| iterator.each(&b) }.to yield_successive_args([params[0], false], [params[1], false])
|
28
|
+
end
|
29
|
+
end
|
30
|
+
|
31
|
+
context 'when params is empty optional placeholder' do
|
32
|
+
let(:params) do
|
33
|
+
[Grape::DSL::Parameters::EmptyOptionalValue, { first: 'string2', second: 'string2' }]
|
34
|
+
end
|
35
|
+
|
36
|
+
it 'yields each element of the array without the list of attrs' do
|
37
|
+
expect { |b| iterator.each(&b) }.to yield_successive_args([Grape::DSL::Parameters::EmptyOptionalValue, true], [params[1], false])
|
28
38
|
end
|
29
39
|
end
|
30
40
|
end
|
@@ -633,6 +633,32 @@ describe Grape::Validations::ParamsScope do
|
|
633
633
|
expect(last_response.status).to eq(200)
|
634
634
|
end
|
635
635
|
|
636
|
+
it 'detect unmet nested dependency' do
|
637
|
+
subject.params do
|
638
|
+
requires :a, type: String, allow_blank: false, values: %w[x y z]
|
639
|
+
given a: ->(val) { val == 'z' } do
|
640
|
+
requires :inner3, type: Array, allow_blank: false do
|
641
|
+
requires :bar, type: String, allow_blank: false
|
642
|
+
given bar: ->(val) { val == 'b' } do
|
643
|
+
requires :baz, type: Array do
|
644
|
+
optional :baz_category, type: String
|
645
|
+
end
|
646
|
+
end
|
647
|
+
given bar: ->(val) { val == 'c' } do
|
648
|
+
requires :baz, type: Array do
|
649
|
+
requires :baz_category, type: String
|
650
|
+
end
|
651
|
+
end
|
652
|
+
end
|
653
|
+
end
|
654
|
+
end
|
655
|
+
subject.get('/nested-dependency') { declared(params).to_json }
|
656
|
+
|
657
|
+
get '/nested-dependency', a: 'z', inner3: [{ bar: 'c', baz: [{ unrelated: 'nope' }] }]
|
658
|
+
expect(last_response.status).to eq(400)
|
659
|
+
expect(last_response.body).to eq 'inner3[0][baz][0][baz_category] is missing'
|
660
|
+
end
|
661
|
+
|
636
662
|
it 'includes the parameter within #declared(params)' do
|
637
663
|
get '/test', a: true, b: true
|
638
664
|
|
@@ -15,7 +15,7 @@ describe Grape::Validations::SingleAttributeIterator do
|
|
15
15
|
|
16
16
|
it 'yields params and every single attribute from the list' do
|
17
17
|
expect { |b| iterator.each(&b) }
|
18
|
-
.to yield_successive_args([params, :first, false], [params, :second, false])
|
18
|
+
.to yield_successive_args([params, :first, false, false], [params, :second, false, false])
|
19
19
|
end
|
20
20
|
end
|
21
21
|
|
@@ -26,8 +26,8 @@ describe Grape::Validations::SingleAttributeIterator do
|
|
26
26
|
|
27
27
|
it 'yields every single attribute from the list for each of the array elements' do
|
28
28
|
expect { |b| iterator.each(&b) }.to yield_successive_args(
|
29
|
-
[params[0], :first, false], [params[0], :second, false],
|
30
|
-
[params[1], :first, false], [params[1], :second, false]
|
29
|
+
[params[0], :first, false, false], [params[0], :second, false, false],
|
30
|
+
[params[1], :first, false, false], [params[1], :second, false, false]
|
31
31
|
)
|
32
32
|
end
|
33
33
|
|
@@ -36,9 +36,20 @@ describe Grape::Validations::SingleAttributeIterator do
|
|
36
36
|
|
37
37
|
it 'marks params with empty values' do
|
38
38
|
expect { |b| iterator.each(&b) }.to yield_successive_args(
|
39
|
-
[params[0], :first, true], [params[0], :second, true],
|
40
|
-
[params[1], :first, true], [params[1], :second, true],
|
41
|
-
[params[2], :first, false], [params[2], :second, false]
|
39
|
+
[params[0], :first, true, false], [params[0], :second, true, false],
|
40
|
+
[params[1], :first, true, false], [params[1], :second, true, false],
|
41
|
+
[params[2], :first, false, false], [params[2], :second, false, false]
|
42
|
+
)
|
43
|
+
end
|
44
|
+
end
|
45
|
+
|
46
|
+
context 'when missing optional value' do
|
47
|
+
let(:params) { [Grape::DSL::Parameters::EmptyOptionalValue, 10] }
|
48
|
+
|
49
|
+
it 'marks params with skipped values' do
|
50
|
+
expect { |b| iterator.each(&b) }.to yield_successive_args(
|
51
|
+
[params[0], :first, false, true], [params[0], :second, false, true],
|
52
|
+
[params[1], :first, false, false], [params[1], :second, false, false],
|
42
53
|
)
|
43
54
|
end
|
44
55
|
end
|
@@ -0,0 +1,35 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
require 'spec_helper'
|
4
|
+
|
5
|
+
describe Grape::Validations::Types::ArrayCoercer do
|
6
|
+
subject { described_class.new(type) }
|
7
|
+
|
8
|
+
describe '#call' do
|
9
|
+
context 'an array of primitives' do
|
10
|
+
let(:type) { Array[String] }
|
11
|
+
|
12
|
+
it 'coerces elements in the array' do
|
13
|
+
expect(subject.call([10, 20])).to eq(%w[10 20])
|
14
|
+
end
|
15
|
+
end
|
16
|
+
|
17
|
+
context 'an array of arrays' do
|
18
|
+
let(:type) { Array[Array[Integer]] }
|
19
|
+
|
20
|
+
it 'coerces elements in the nested array' do
|
21
|
+
expect(subject.call([%w[10 20]])).to eq([[10, 20]])
|
22
|
+
expect(subject.call([['10'], ['20']])).to eq([[10], [20]])
|
23
|
+
end
|
24
|
+
end
|
25
|
+
|
26
|
+
context 'an array of sets' do
|
27
|
+
let(:type) { Array[Set[Integer]] }
|
28
|
+
|
29
|
+
it 'coerces elements in the nested set' do
|
30
|
+
expect(subject.call([%w[10 20]])).to eq([Set[10, 20]])
|
31
|
+
expect(subject.call([['10'], ['20']])).to eq([Set[10], Set[20]])
|
32
|
+
end
|
33
|
+
end
|
34
|
+
end
|
35
|
+
end
|
@@ -0,0 +1,135 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
require 'spec_helper'
|
4
|
+
|
5
|
+
describe Grape::Validations::Types::PrimitiveCoercer do
|
6
|
+
let(:strict) { false }
|
7
|
+
|
8
|
+
subject { described_class.new(type, strict) }
|
9
|
+
|
10
|
+
describe '#call' do
|
11
|
+
context 'BigDecimal' do
|
12
|
+
let(:type) { BigDecimal }
|
13
|
+
|
14
|
+
it 'coerces to BigDecimal' do
|
15
|
+
expect(subject.call(5)).to eq(BigDecimal(5))
|
16
|
+
end
|
17
|
+
|
18
|
+
it 'coerces an empty string to nil' do
|
19
|
+
expect(subject.call('')).to be_nil
|
20
|
+
end
|
21
|
+
end
|
22
|
+
|
23
|
+
context 'Boolean' do
|
24
|
+
let(:type) { Grape::API::Boolean }
|
25
|
+
|
26
|
+
[true, 'true', 1].each do |val|
|
27
|
+
it "coerces '#{val}' to true" do
|
28
|
+
expect(subject.call(val)).to eq(true)
|
29
|
+
end
|
30
|
+
end
|
31
|
+
|
32
|
+
[false, 'false', 0].each do |val|
|
33
|
+
it "coerces '#{val}' to false" do
|
34
|
+
expect(subject.call(val)).to eq(false)
|
35
|
+
end
|
36
|
+
end
|
37
|
+
|
38
|
+
it 'returns an error when the given value cannot be coerced' do
|
39
|
+
expect(subject.call(123)).to be_instance_of(Grape::Validations::Types::InvalidValue)
|
40
|
+
end
|
41
|
+
|
42
|
+
it 'coerces an empty string to nil' do
|
43
|
+
expect(subject.call('')).to be_nil
|
44
|
+
end
|
45
|
+
end
|
46
|
+
|
47
|
+
context 'DateTime' do
|
48
|
+
let(:type) { DateTime }
|
49
|
+
|
50
|
+
it 'coerces an empty string to nil' do
|
51
|
+
expect(subject.call('')).to be_nil
|
52
|
+
end
|
53
|
+
end
|
54
|
+
|
55
|
+
context 'Float' do
|
56
|
+
let(:type) { Float }
|
57
|
+
|
58
|
+
it 'coerces an empty string to nil' do
|
59
|
+
expect(subject.call('')).to be_nil
|
60
|
+
end
|
61
|
+
end
|
62
|
+
|
63
|
+
context 'Integer' do
|
64
|
+
let(:type) { Integer }
|
65
|
+
|
66
|
+
it 'coerces an empty string to nil' do
|
67
|
+
expect(subject.call('')).to be_nil
|
68
|
+
end
|
69
|
+
end
|
70
|
+
|
71
|
+
context 'Numeric' do
|
72
|
+
let(:type) { Numeric }
|
73
|
+
|
74
|
+
it 'coerces an empty string to nil' do
|
75
|
+
expect(subject.call('')).to be_nil
|
76
|
+
end
|
77
|
+
end
|
78
|
+
|
79
|
+
context 'Time' do
|
80
|
+
let(:type) { Time }
|
81
|
+
|
82
|
+
it 'coerces an empty string to nil' do
|
83
|
+
expect(subject.call('')).to be_nil
|
84
|
+
end
|
85
|
+
end
|
86
|
+
|
87
|
+
context 'String' do
|
88
|
+
let(:type) { String }
|
89
|
+
|
90
|
+
it 'coerces to String' do
|
91
|
+
expect(subject.call(10)).to eq('10')
|
92
|
+
end
|
93
|
+
|
94
|
+
it 'does not coerce an empty string to nil' do
|
95
|
+
expect(subject.call('')).to eq('')
|
96
|
+
end
|
97
|
+
end
|
98
|
+
|
99
|
+
context 'Symbol' do
|
100
|
+
let(:type) { Symbol }
|
101
|
+
|
102
|
+
it 'coerces an empty string to nil' do
|
103
|
+
expect(subject.call('')).to be_nil
|
104
|
+
end
|
105
|
+
end
|
106
|
+
|
107
|
+
context 'the strict mode' do
|
108
|
+
let(:strict) { true }
|
109
|
+
|
110
|
+
context 'Boolean' do
|
111
|
+
let(:type) { Grape::API::Boolean }
|
112
|
+
|
113
|
+
it 'returns an error when the given value is not Boolean' do
|
114
|
+
expect(subject.call(1)).to be_instance_of(Grape::Validations::Types::InvalidValue)
|
115
|
+
end
|
116
|
+
|
117
|
+
it 'returns a value as it is when the given value is Boolean' do
|
118
|
+
expect(subject.call(true)).to eq(true)
|
119
|
+
end
|
120
|
+
end
|
121
|
+
|
122
|
+
context 'BigDecimal' do
|
123
|
+
let(:type) { BigDecimal }
|
124
|
+
|
125
|
+
it 'returns an error when the given value is not BigDecimal' do
|
126
|
+
expect(subject.call(1)).to be_instance_of(Grape::Validations::Types::InvalidValue)
|
127
|
+
end
|
128
|
+
|
129
|
+
it 'returns a value as it is when the given value is BigDecimal' do
|
130
|
+
expect(subject.call(BigDecimal(0))).to eq(BigDecimal(0))
|
131
|
+
end
|
132
|
+
end
|
133
|
+
end
|
134
|
+
end
|
135
|
+
end
|
@@ -0,0 +1,34 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
require 'spec_helper'
|
4
|
+
|
5
|
+
describe Grape::Validations::Types::SetCoercer do
|
6
|
+
subject { described_class.new(type) }
|
7
|
+
|
8
|
+
describe '#call' do
|
9
|
+
context 'a set of primitives' do
|
10
|
+
let(:type) { Set[String] }
|
11
|
+
|
12
|
+
it 'coerces elements to the set' do
|
13
|
+
expect(subject.call([10, 20])).to eq(Set['10', '20'])
|
14
|
+
end
|
15
|
+
end
|
16
|
+
|
17
|
+
context 'a set of sets' do
|
18
|
+
let(:type) { Set[Set[Integer]] }
|
19
|
+
|
20
|
+
it 'coerces elements in the nested set' do
|
21
|
+
expect(subject.call([%w[10 20]])).to eq(Set[Set[10, 20]])
|
22
|
+
expect(subject.call([['10'], ['20']])).to eq(Set[Set[10], Set[20]])
|
23
|
+
end
|
24
|
+
end
|
25
|
+
|
26
|
+
context 'a set of sets of arrays' do
|
27
|
+
let(:type) { Set[Set[Array[Integer]]] }
|
28
|
+
|
29
|
+
it 'coerces elements in the nested set' do
|
30
|
+
expect(subject.call([[['10'], ['20']]])).to eq(Set[Set[Array[10], Array[20]]])
|
31
|
+
end
|
32
|
+
end
|
33
|
+
end
|
34
|
+
end
|
@@ -17,7 +17,7 @@ describe Grape::Validations::Types do
|
|
17
17
|
[
|
18
18
|
Integer, Float, Numeric, BigDecimal,
|
19
19
|
Grape::API::Boolean, String, Symbol,
|
20
|
-
Date, DateTime, Time
|
20
|
+
Date, DateTime, Time
|
21
21
|
].each do |type|
|
22
22
|
it "recognizes #{type} as a primitive" do
|
23
23
|
expect(described_class.primitive?(type)).to be_truthy
|