grape-slack-bot 1.5.5 → 1.5.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8369c909fff6a3b4da241ee643cc4eb88aea44b4cf36b46d23894d98485b99b7
-  data.tar.gz: 6b20d7329e693eada51866d5a20fa57f964bbf24996ff59b073773751dd59843
+  metadata.gz: 953075c11d83ecf06161ba1ffdda403a08c673c87a598a5d924443a8bf7bb587
+  data.tar.gz: c99d95f100f8e067e19502c2d144454b9d8416534b2e8ef930d31136d1b13ec7
 SHA512:
-  metadata.gz: e6e153e24e4b69c9447ab1a91f989213b0786f05ce25fb9ef726b855fe93e847c03ae00496379aa67f24de67f2a4b96e9a49f4c29589898044f04cda73131d41
-  data.tar.gz: 00aa26edbe0a901e646905ce3ba7b154ca112fd33340a86592860ec9e766ac1ee37bc616d0eaf63bbc9785ca901f761f46f8e60e2da4c0ea8fee31a6a11aedda
+  metadata.gz: 3f184bf86ddce2dacaecce93f8377ef62b562b8ba5cf010993903bac8910af115b5659be794fb9e7961c2ab51d3f48f46622705a595d79aadff089a909c4fce2
+  data.tar.gz: 6e821e2e1aea7494d01ece594de33ba5264ed6ff9e3ab6937ad44a4fb65ddfda1ff44bd717358c3fc4c0ff5a6bf8368988085e277677086d8dffdc5417d6ed7a

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+# 1.5.7
+
+* Raise error if handler class not resolved
+* App home interaction example added
+* Callback logic and usage fixed
+* Views improvements
+
 # 1.5.0
 
 * Complete upgrade of callback storage logic

data/README.md

@@ -292,6 +292,30 @@ module MySlackBot::Game
 end
 ```
 
+App home interaction example:
+
+```ruby
+module MySlackBot
+  class AppHomeInteraction < SlackBot::Event
+    view MySlackBot::AppHomeView
+
+    def call
+      action_id = payload.dig("actions", 0, "action_id")
+      case action_id
+      when "add_game"
+        add_game
+      end
+    end
+
+    private
+
+    def add_game
+      open_modal :add_game_modal
+    end
+  end
+end
+```
+
 ## View example
 
 Modal view example:
@@ -452,6 +476,13 @@ module MySlackBot
   class AppHomeOpenedEvent < SlackBot::Event
     view MySlackBot::AppHomeView
     def call
+      # NOTE: we have to create callback here in order to handle interactions
+      self.callback = SlackBot::Callback.find_or_create(
+        id: "app_home_opened",
+        user: current_user,
+        class_name: VacationsBot::AppHomeInteraction.name
+      )
+
       publish_view :index_view
     end
   end

data/lib/slack_bot/callback.rb

@@ -107,7 +107,7 @@ module SlackBot
 
     def handler_class=(handler_class)
       new_class_name = handler_class&.name
-      raise "Callback handler class not found" if !config.find_handler_class(class_name)
+      config.find_handler_class(class_name)
 
       self.class_name = new_class_name
     end

data/lib/slack_bot/config.rb

@@ -72,7 +72,9 @@ module SlackBot
 
     def find_handler_class(class_name)
       @handler_classes ||= {}
-      @handler_classes[class_name.to_sym]
+      @handler_classes.fetch(class_name.to_sym)
+    rescue KeyError
+      raise SlackBot::Errors::HandlerClassNotFound.new(class_name, handler_classes: @handler_classes)
     end
   end
 

data/lib/slack_bot/errors.rb

@@ -21,6 +21,16 @@ module SlackBot
     class CallbackNotFound < SlackBot::Error
     end
 
+    class HandlerClassNotFound < SlackBot::Error
+      attr_reader :class_name, :handler_classes
+      def initialize(class_name, handler_classes:)
+        @class_name = class_name
+        @handler_classes = handler_classes
+
+        super("Handler class not found for #{class_name}")
+      end
+    end
+
     class SlackResponseError < SlackBot::Error
       attr_reader :error, :data, :payload
       def initialize(error, data: nil, payload: nil)

data/lib/slack_bot/grape_extension.rb

@@ -84,7 +84,7 @@ module SlackBot
         def handle_block_actions_view(view:, user:, params:)
           callback_id = view&.dig("callback_id")
 
-          callback = SlackBot::Callback.find(callback_id, config: config)
+          callback = SlackBot::Callback.find(callback_id, user: user, config: config)
           raise SlackBot::Errors::CallbackNotFound.new if callback.blank?
 
           SlackBot::DevConsole.log_check "SlackApi::Interactions##{__method__}: #{callback.id} #{callback.payload} #{callback.user_id} #{user&.id}"

data/lib/slack_bot/interaction.rb

@@ -47,14 +47,13 @@ module SlackBot
       channel_id: nil,
       config: nil
     )
-      callback = Callback.find(callback_id, config: config) if callback_id.present?
-      callback ||=
-        Callback.create(
-          class_name: class_name,
-          user: user,
-          channel_id: channel_id,
-          config: config
-        )
+      callback = Callback.find_or_create(
+        id: callback_id,
+        class_name: class_name,
+        user: user,
+        channel_id: channel_id,
+        config: config
+      )
 
       view = payload.merge({ type: "modal", callback_id: callback.id })
       response =

data/lib/slack_bot.rb

@@ -22,5 +22,5 @@ require 'slack_bot/pager'
 require 'slack_bot/grape_extension'
 
 module SlackBot
-  VERSION = '1.5.5'.freeze
+  VERSION = '1.5.7'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: grape-slack-bot
 version: !ruby/object:Gem::Version
-  version: 1.5.5
+  version: 1.5.7
 platform: ruby
 authors:
 - Andrei Makarov