grape-path-helpers 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 503d81ea130278857cad2fea515eb2a963646dd3
-  data.tar.gz: 44075f836d0668feabc2974d8b9db23fca363539
+  metadata.gz: b8b63fdab374d8ffb25a82346ca56937710b7473
+  data.tar.gz: a7b44b0fb974d4b43c03fd71c5777b5d84943e2f
 SHA512:
-  metadata.gz: f270fbcff1cfe587aa4690cd2d2f9216267483a81280c872e0bc3e99a7e6cb0ee2ca403c92ca6e0c826c8259b8b35d510a118a477fa4d07aaacc8a9bf456c1f5
-  data.tar.gz: 4cfa551b90b82960c58dc291645cb93f189e27b8316d9b269f8bcd8b8c41bb5f80aebe02773678f7ca5748bda89428206bfb31967c34129a4ebcba390c562d03
+  metadata.gz: 3091465e660ea2dd3d5f2aff19525ca3c2def1dbb3e37fea62e4ed7add36aa1938d46d42e3a9cadd1449a023ee78b516b2b76f73fa323c8370a56eefef402c3e
+  data.tar.gz: b2e5b4cd5294253c84fa58fe06cf1c43cfd0bd67aaac0b60d469e6c276ec1550d1e0feb2a3e7525648d52358f83e60ff13c40cc884357f0413838d3836a4c6b2

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 1.0.3
+
+* [Fix return value in method_missing? implementation](https://gitlab.com/gitlab-org/grape-path-helpers/merge_requests/7)
+* [Fix broken method_missing? implementation](https://gitlab.com/gitlab-org/grape-path-helpers/merge_requests/6)
+
 ## 1.0.2
 
 * [Rename rake task from `grape:route_helpers` to `grape:path_helpers`](https://gitlab.com/gitlab-org/grape-path-helpers/merge_requests/5)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    grape-path-helpers (1.0.0)
+    grape-path-helpers (1.0.2)
       activesupport (~> 4)
       grape (~> 1.0)
       rake (~> 12)

data/lib/grape-path-helpers/named_route_matcher.rb

@@ -4,7 +4,8 @@ module GrapePathHelpers
   # helper function name
   module NamedRouteMatcher
     def method_missing(method_id, *arguments)
-      super unless method_id.to_s =~ /_path$/
+      return super unless method_id.to_s =~ /_path$/
+
       segments = arguments.first || {}
 
       route = Grape::API.decorated_routes.detect do |r|
@@ -19,9 +20,11 @@ module GrapePathHelpers
     end
 
     def respond_to_missing?(method_name, _include_private = false)
-      Grape::API.decorated_routes.detect do |r|
-        route_match?(r, method_name, {})
+      Grape::API.decorated_routes.detect do |route|
+        return true if route.respond_to?(method_name)
       end
+
+      false
     end
 
     def route_match?(route, method_name, segments)

data/lib/grape-path-helpers/version.rb

@@ -1,4 +1,4 @@
 # Gem version
 module GrapePathHelpers
-  VERSION = '1.0.2'.freeze
+  VERSION = '1.0.3'.freeze
 end

data/spec/grape_path_helpers/named_route_matcher_spec.rb

@@ -26,6 +26,36 @@ describe GrapePathHelpers::NamedRouteMatcher do
     end
   end
 
+  let(:helper_class) do
+    fake_class = Class.new do
+      prepend GrapePathHelpers::NamedRouteMatcher
+
+      def method_missing(_method_id, *_args)
+        'whatever' || super
+      end
+
+      def respond_to_missing?(_method_name, _include_private = false)
+        super
+      end
+    end
+
+    fake_class.new
+  end
+
+  describe '#method_missing' do
+    it 'returns super method_missing if the method does not end with path' do
+      expect(Grape::API).not_to receive(:decorated_routes)
+
+      helper_class.test_method
+    end
+
+    it 'search for the route if the method ends with path' do
+      expect(Grape::API).to receive(:decorated_routes).and_call_original
+
+      helper_class.test_method_path
+    end
+  end
+
   describe '#route_match?' do
     context 'when route responds to a method name' do
       let(:route) { ping_route }
@@ -115,6 +145,32 @@ describe GrapePathHelpers::NamedRouteMatcher do
     end
   end
 
+  describe '#respond_to_missing?' do
+    context 'when method name with segments matches a Grape::Route path' do
+      let(:method_name) { :api_v1_cats_path }
+
+      it 'returns true' do
+        expect(respond_to_missing?(method_name)).to eq(true)
+      end
+    end
+
+    context 'when method name matches a Grape::Route path helper name' do
+      let(:method_name) { :api_v1_ping_path }
+
+      it 'returns true' do
+        expect(respond_to_missing?(method_name)).to eq(true)
+      end
+    end
+
+    context 'when method name does not match a Grape::Route path helper name' do
+      let(:method_name) { :some_other_path }
+
+      it 'returns false' do
+        expect(respond_to_missing?(method_name)).to eq(false)
+      end
+    end
+  end
+
   describe '#method_missing' do
     context 'when method name matches a Grape::Route path helper name' do
       it 'returns the path for that route object' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: grape-path-helpers
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Drew Blessing