grape-kaminari 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 39954bcb02e83af2783635756ce5d94942edbbd0550c3670e467ba39eb9f2b00
-  data.tar.gz: 6c15582e16ae68fa09d7e1fd9480188d96bd7be0cd4c48cdc376cdddc03ed06d
+  metadata.gz: d0ae809ad4c135dcf91437d3e66be5aeade55263df274f958da45e3518643121
+  data.tar.gz: 6444fd46138c8e330a9c74254f27d0512ea861df07eb90cde07f070a1e43a0e6
 SHA512:
-  metadata.gz: 107535d26da91163d588390787b298b41e886466c6904eb59edbea9cae52643f43c5f4d418976a347b6704cbfdd67f8b0013532c6dfacc98c3db4900058b37fe
-  data.tar.gz: dc4b45493fe12f1dfd454437d12714850d97445062296162ab177780ef1c5bf0bbd9bb1b3330fe87fb7a0318ac400d6c1491c9851fabf46f1532c6bb8c17a3e5
+  metadata.gz: 5633fb0d0acecfe2aa68eaff97e29aabddd087922b0ab17a439b26a6fd8ac3889f5f3c902dff54b1729bace30fe6c81c2972a1075785653ea0785b5326ad79e0
+  data.tar.gz: 25fbc7a3ad61bc457e237da7ccf9dfbced16c76b291cec006ed45ac9504fc9e208d3f5ac2e3f30f9f94396d7b157214f106aeec05bd8d121e1b6ee06e614025a

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    grape-kaminari (0.2.0)
+    grape-kaminari (0.2.1)
       grape (>= 1.0)
       kaminari-grape
 

data/lib/grape/kaminari/max_value_validator.rb

@@ -3,7 +3,7 @@ module Grape
     class MaxValueValidator < Grape::Validations::Base
       def validate_param!(attr_name, params)
         attr = params[attr_name]
-        return unless attr && @option && attr > @option
+        return unless attr.is_a?(Integer) && @option && attr > @option
 
         raise Grape::Exceptions::Validation.new(
           params: [@scope.full_name(attr_name)],

data/lib/grape/kaminari/version.rb

@@ -1,5 +1,5 @@
 module Grape
   module Kaminari
-    VERSION = '0.2.0'.freeze
+    VERSION = '0.2.1'.freeze
   end
 end

data/spec/kaminari_spec.rb

@@ -99,15 +99,21 @@ describe Grape::Kaminari do
 
     it 'succeeds when :per_page is within :max_value' do
       get('/', page: 1, per_page: 999)
-      expect(last_response.status).to eq 200
+      expect(last_response.status).to eq(200)
     end
 
     it 'ensures :per_page is within :max_value' do
       get('/', page: 1, per_page: 1_000)
-      expect(last_response.status).to eq 400
+      expect(last_response.status).to eq(400)
       expect(last_response.body).to match(/per_page must be less than or equal 999/)
     end
 
+    it 'ensures :per_page is numeric' do
+      get('/', page: 1, per_page: 'foo')
+      expect(last_response.status).to eq(400)
+      expect(last_response.body).to match(/per_page is invalid/)
+    end
+
     it 'defaults :offset to customized value' do
       expect(params['offset'][:default]).to eq(9)
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: grape-kaminari
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Tymon Tobolski