granite 0.9.2 → 0.9.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1b2674022b2612547cab05e27f9c832300b8f7fd6a1c43b26961733e12e9d4aa
-  data.tar.gz: 59247c53dadced6268e4d921dae1c2f4ba8522eecf11b0d544c639a784f79c60
+  metadata.gz: 3b29f40ab453a5dccfe51b587a3bb8ac106441393110a34853aa7d6319a52dc8
+  data.tar.gz: 7670225bab82074b188a5ec72222a3986da4da217f2268473f3881f5487fb3ed
 SHA512:
-  metadata.gz: ecf502f37360a2c10312ec06e28e6d3a6d8f279874ead21e9c51ce8496b0b4c60028c68bfcb1118d0e60f643524eaa2fd0382caa4df7ecfc140397bf812de896
-  data.tar.gz: 9b5052b9193ec8038d6184b33bf258ec63dc93157f7f0a4e66f58e6b687cb6fb75ef2068bf8344b41abcc43272ac1b46f8540b2d8a95db28be6dda41548dcaab
+  metadata.gz: 127fb08af9bb0a97162650884ed9f7b82793db3963fa236a35b9ed1c4cd859cf3a030743eac7bf25ac7845838b61da42bc588d3baad3aa5919e5a8ef495bdb14
+  data.tar.gz: 5a9f6d3bd77cad622f2216706b46e413ed8263b960cd34eb5726c7cc3dc236910aa707acfa2e77df732cd15120be7774ff87261b3854bac8f65e1782096440a0

data/config/rubocop-default.yml

@@ -0,0 +1,3 @@
+Lint/UselessAccessModifier:
+  ContextCreatingMethods:
+    - projector

data/lib/granite/action.rb

@@ -7,6 +7,7 @@ require 'granite/action/types'
 require 'granite/action/error'
 require 'granite/action/performing'
 require 'granite/action/performer'
+require 'granite/action/precondition'
 require 'granite/action/preconditions'
 require 'granite/action/policies'
 require 'granite/action/projectors'

data/lib/granite/action/performing.rb

@@ -92,8 +92,10 @@ module Granite
       private
 
       def perform_action(raise_errors: false, **options)
-        apply_association_changes!
-        result = run_callbacks(:execute_perform) { execute_perform!(options) }
+        result = run_callbacks(:execute_perform) do
+          apply_association_changes!
+          execute_perform!(options)
+        end
         @_action_performed = true
         result || true
       rescue *handled_exceptions => e

data/lib/granite/action/precondition.rb

@@ -0,0 +1,38 @@
+module Granite
+  class Action
+    class Precondition < BasicObject
+      UNDEFINED = ::Object.new.freeze
+
+      def self.description(text = UNDEFINED)
+        case text
+        when UNDEFINED
+          @description
+        else
+          @description = text
+        end
+      end
+
+      def initialize(context)
+        @context = context
+      end
+
+      def call(*)
+        fail NotImplementedError, "#call method must be implemented for #{self.class}"
+      end
+
+      def method_missing(method_name, *args, &blk)
+        super unless @context.respond_to?(method_name)
+
+        @context.__send__(method_name, *args, &blk)
+      end
+
+      def respond_to_missing?(method_name, _include_private = false)
+        @context.respond_to?(method_name)
+      end
+
+      private
+
+      attr_reader :context
+    end
+  end
+end

data/lib/granite/action/preconditions.rb

@@ -1,5 +1,6 @@
 require 'granite/action/preconditions/base_precondition'
 require 'granite/action/preconditions/embedded_precondition'
+require 'granite/action/preconditions/object_precondition'
 
 module Granite
   class Action
@@ -13,6 +14,10 @@ module Granite
       extend ActiveSupport::Concern
 
       class PreconditionsCollection
+        include Enumerable
+
+        delegate :each, to: :@preconditions
+
         def initialize(*preconditions)
           @preconditions = preconditions.flatten
         end
@@ -43,8 +48,10 @@ module Granite
           options = args.extract_options!
           if block
             add_precondition(BasePrecondition, options, &block)
+          elsif args.first.is_a?(Class)
+            add_precondition(ObjectPrecondition, *args, options)
           else
-            common_options = options.extract!(:if, :unless)
+            common_options = options.extract!(:if, :unless, :desc, :description)
             args.each do |type|
               precondition common_options.merge(type => {})
             end

data/lib/granite/action/preconditions/object_precondition.rb

@@ -0,0 +1,15 @@
+require 'granite/action/preconditions/base_precondition'
+
+module Granite
+  class Action
+    module Preconditions
+      class ObjectPrecondition < BasePrecondition
+        private
+
+        def _execute(context)
+          @args.first.new(context).call(**@options.except(:if, :unless))
+        end
+      end
+    end
+  end
+end

data/lib/granite/projector/controller_actions.rb

@@ -23,11 +23,11 @@ module Granite
             controller_class.__send__(:define_method, name, &block)
             class_eval <<-METHOD, __FILE__, __LINE__ + 1
               def #{name}_url(options = {})
-                action_url(:#{name}, options)
+                action_url(:#{name}, options.symbolize_keys)
               end
 
               def #{name}_path(options = {})
-                action_path(:#{name}, options)
+                action_path(:#{name}, options.symbolize_keys)
               end
             METHOD
           else

data/lib/granite/represents/attribute.rb

@@ -11,9 +11,7 @@ module Granite
       end
 
       def sync
-        return if reference.nil?
-
-        reference.public_send(writer, read)
+        reference.public_send(writer, read) if reference.respond_to?(writer)
       end
 
       def typecast(value)

data/lib/granite/version.rb

@@ -1,3 +1,3 @@
 module Granite
-  VERSION = '0.9.2'.freeze
+  VERSION = '0.9.7'.freeze
 end

data/lib/rubocop-granite.rb

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+require 'rubocop'
+
+require_relative 'rubocop/granite'
+require_relative 'rubocop/granite/inject'
+
+RuboCop::Granite::Inject.defaults!

data/lib/rubocop/granite.rb

@@ -0,0 +1,9 @@
+module RuboCop
+  module Granite
+    PROJECT_ROOT   = Pathname.new(__dir__).parent.parent.expand_path.freeze
+    CONFIG_DEFAULT = PROJECT_ROOT.join('config', 'rubocop-default.yml').freeze
+    CONFIG         = YAML.safe_load(CONFIG_DEFAULT.read).freeze
+
+    private_constant(:CONFIG_DEFAULT, :PROJECT_ROOT)
+  end
+end

data/lib/rubocop/granite/inject.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+# The original code is from https://github.com/rubocop-hq/rubocop-rspec/blob/master/lib/rubocop/rspec/inject.rb
+# See https://github.com/rubocop-hq/rubocop-rspec/blob/master/MIT-LICENSE.md
+module RuboCop
+  module Granite
+    # Because RuboCop doesn't yet support plugins, we have to monkey patch in a
+    # bit of our configuration.
+    module Inject
+      def self.defaults!
+        path = CONFIG_DEFAULT.to_s
+        hash = ConfigLoader.load_file(path)
+        config = Config.new(hash, path).tap(&:make_excludes_absolute)
+        puts "configuration from #{path}" if ConfigLoader.debug?
+        config = ConfigLoader.merge_with_default(config, path)
+        ConfigLoader.instance_variable_set(:@default_configuration, config)
+      end
+    end
+  end
+end

metadata

@@ -1,57 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: granite
 version: !ruby/object:Gem::Version
-  version: 0.9.2
+  version: 0.9.7
 platform: ruby
 authors:
 - Arkadiy Zabazhanov & friends
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-09 00:00:00.000000000 Z
+date: 2021-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.1'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.1'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: active_data
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.3
+        version: 1.1.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.1.3
+        version: 1.1.5
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.1'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.1'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: memoist
   requirement: !ruby/object:Gem::Requirement
@@ -70,16 +82,22 @@ dependencies:
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.1'
 - !ruby/object:Gem::Dependency
   name: capybara
   requirement: !ruby/object:Gem::Requirement
@@ -114,14 +132,14 @@ dependencies:
     requirements:
     - - "<"
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "<"
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '2'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
@@ -226,28 +244,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.52'
+        version: 0.78.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.78.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.4.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.52'
+        version: 2.4.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.22'
+        version: 1.37.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.22'
+        version: 1.37.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -270,6 +302,7 @@ extra_rdoc_files: []
 files:
 - LICENSE
 - app/controllers/granite/controller.rb
+- config/rubocop-default.yml
 - lib/generators/USAGE
 - lib/generators/granite/install_controller_generator.rb
 - lib/generators/granite_generator.rb
@@ -287,9 +320,11 @@ files:
 - lib/granite/action/policies/always_allow_strategy.rb
 - lib/granite/action/policies/any_strategy.rb
 - lib/granite/action/policies/required_performer_strategy.rb
+- lib/granite/action/precondition.rb
 - lib/granite/action/preconditions.rb
 - lib/granite/action/preconditions/base_precondition.rb
 - lib/granite/action/preconditions/embedded_precondition.rb
+- lib/granite/action/preconditions/object_precondition.rb
 - lib/granite/action/projectors.rb
 - lib/granite/action/subject.rb
 - lib/granite/action/transaction.rb
@@ -331,6 +366,9 @@ files:
 - lib/granite/translations.rb
 - lib/granite/typecasters.rb
 - lib/granite/version.rb
+- lib/rubocop-granite.rb
+- lib/rubocop/granite.rb
+- lib/rubocop/granite/inject.rb
 homepage: https://github.com/toptal/granite
 licenses:
 - MIT
@@ -350,8 +388,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.9
 signing_key: 
 specification_version: 4
 summary: Another business actions architecture for Rails apps