granite 0.9.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 5d965fa31280c0c7068dec41cd034c2242444690
-  data.tar.gz: 22680daf024cf9d8956715e40c75ce2d3ad4cf93
+SHA256:
+  metadata.gz: bbe5e30c9b3c74f9a703caf9d9a30c6ea0791aaad7b159f8f5e12dd58d1b62d3
+  data.tar.gz: 5c6751169deb310e651cdeace4ac9612419892f13ec7188b06eee4385bc5f4ba
 SHA512:
-  metadata.gz: 3c92b2d9fb29164aa10c6b390686cdfca6830861eccaa8c85b6986996ee768fe0e34a7b6219ff4d6ae9a384d4d2cfd514a2896b248c9f01eff2af9bf0eef361b
-  data.tar.gz: 0f5fed5af5c2d707a41e3de1d4d18695e464605e0cd31fbbe0526e23c982fc5a02f1ea5961a82367baf06119994006af76f343ae271129575f9f0fced2666d1f
+  metadata.gz: c7cf2f66caafc82d058cc9e89404828733fbe5f7798de7016bff4a002454f2275f730e936cd48861e5080d582989be13a411484ee0d12dfd3ed65e5f993aabb0
+  data.tar.gz: 32530f64d500262d218909f28ce3d27d1845baba024e853b4041a9780b33b87d05824cd0ba32cbde5c12d1f44978e3dc615f448be3c1a6dc3e02c70df3045c9d

data/lib/granite/action/performing.rb

@@ -75,6 +75,7 @@ module Granite
       # @raise [NotImplementedError] execute_perform! method was not defined yet
       def try_perform!(context: nil, **options)
         return unless satisfy_preconditions?
+
         transaction do
           validate!(context)
           perform_action!(**options)

data/lib/granite/action/policies.rb

@@ -85,6 +85,7 @@ module Granite
       #
       def authorize!
         fail Granite::Action::NotAllowedError, self unless allowed?
+
         self
       end
     end

data/lib/granite/action/preconditions/base_precondition.rb

@@ -11,6 +11,7 @@ module Granite
         def execute!(context)
           return if @options[:if] && !context.instance_exec(&@options[:if])
           return if @options[:unless] && context.instance_exec(&@options[:unless])
+
           _execute(context)
         end
 

data/lib/granite/action/preconditions/embedded_precondition.rb

@@ -33,6 +33,7 @@ module Granite
 
         def decline_action(context, action)
           return if action.satisfy_preconditions?
+
           action.errors[:base].each { |error| context.errors.add(:base, error) }
           action.failed_preconditions.each { |error| context.failed_preconditions << error }
         end

data/lib/granite/action/transaction_manager.rb

@@ -51,15 +51,17 @@ module Granite
         end
 
         def finish_root_transaction
-          trigger_after_commit_callbacks
-        ensure
+          callbacks = transactions_stack.callbacks
+
           self.transactions_stack = nil
+
+          trigger_after_commit_callbacks(callbacks)
         end
 
-        def trigger_after_commit_callbacks
+        def trigger_after_commit_callbacks(callbacks)
           collected_errors = []
 
-          transactions_stack.callbacks.reverse_each do |callback|
+          callbacks.reverse_each do |callback|
             begin
               callback.respond_to?(:run_callbacks) ? callback.run_callbacks(:commit) : callback.call
             rescue StandardError => e

data/lib/granite/represents/attribute.rb

@@ -12,6 +12,7 @@ module Granite
 
       def sync
         return if reference.nil?
+
         reference.public_send(writer, read)
       end
 
@@ -23,6 +24,7 @@ module Granite
 
       def type
         return reflection.options[:type] if reflection.options[:type].present?
+
         active_data_type || type_from_type_for_attribute || super
       end
 

data/lib/granite/rspec/satisfy_preconditions.rb

@@ -3,7 +3,7 @@
 # Checks if business action satisfies preconditions in current state.
 #
 # Modifiers:
-# * `with_message(message)` (and `with_messages([list, of, messages])`) --
+# * `with_message(message)` (and `with_messages(list, of, messages)`) --
 #   only for negated matchers, checks messages of preconditions not satisfied;
 # * `with_message_of_kind(:message_kind)` (and `with_messages_of_kinds(:list, :of, :messages)`) --
 #   only for negated matchers, checks messages of preconditions not satisfied;
@@ -17,6 +17,7 @@
 # # assuming subject is business action
 # it { is_expected.to satisfy_preconditions }
 # it { is_expected.not_to satisfy_preconditions.with_message('Tax form has not been signed') }
+# it { is_expected.not_to satisfy_preconditions.with_messages(/^Tax form has not been signed by/', 'Signature required') }
 # it { is_expected.not_to satisfy_preconditions.with_message_of_kind(:relevant_portfolio_items_needed) }
 # it { is_expected.not_to satisfy_preconditions.with_messages_of_kinds(:relevant_portfolio_items_needed, :relevant_education_needed) }
 # ```
@@ -26,8 +27,8 @@ RSpec::Matchers.define :satisfy_preconditions do
     @expected_messages = [message]
   end
 
-  chain(:with_messages) do |messages|
-    @expected_messages = messages
+  chain(:with_messages) do |*messages|
+    @expected_messages = messages.flatten
   end
 
   chain(:with_message_of_kind) do |kind|
@@ -44,6 +45,7 @@ RSpec::Matchers.define :satisfy_preconditions do
 
   match do |object|
     fail '"with_messages" method chain is not supported for positive matcher' if @expected_messages
+
     object.satisfy_preconditions?
   end
 
@@ -51,11 +53,12 @@ RSpec::Matchers.define :satisfy_preconditions do
     result = !object.satisfy_preconditions?
     if @expected_messages
       errors = object.errors[:base]
-      result &&= if @exactly
-                   errors.to_a.sort == @expected_messages.sort
-                 else
-                   (@expected_messages - errors).empty?
-                 end
+
+      result &&= @expected_messages.all? { |expected| errors.any? { |error| error.match? expected } }
+
+      if @exactly
+        result &&= errors.none? { |error| @expected_messages.none? { |expected| error.match? expected } }
+      end
     elsif @expected_kind_of_messages
       error_kinds = object.errors.details[:base].map(&:values).flatten
       result &&= (@expected_kind_of_messages - error_kinds).empty?

data/lib/granite/version.rb

@@ -1,3 +1,3 @@
 module Granite
-  VERSION = '0.9.0'.freeze
+  VERSION = '0.9.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: granite
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors:
 - Arkadiy Zabazhanov & friends
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-18 00:00:00.000000000 Z
+date: 2018-11-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -351,7 +351,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Another business actions architecture for Rails apps