granite-form 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 908865a58fa79739294c85bb506d878596a28782c02a9a2825ca1fb7fd128972
-  data.tar.gz: ff9b6cbed34774e3dedb0b33c28b75694b1575051adb989248ca5695254e9586
+  metadata.gz: 5519b4c103eaec0a823f7869c496af428a11d4bab6652822add9e826a64a86c0
+  data.tar.gz: ac3048e88443939c4bae29e5eac6d177ff58a782501f2ee03b57cc5c27697d9c
 SHA512:
-  metadata.gz: 92d055b121d30a9644521227782908a0b84ef0847c16ce60fafec47cb17c5c2988e8a071e199ed5506dd0783bba335b6a399a519c095867658e310680dd96f10
-  data.tar.gz: 4b4cf5f23530ad12408f498df6eed11e53438dd0a6f110ae04c10568934f041dbb64b946ee42352b7bfec83119a5827b652c8fddd62e745fa0f2835448674ce6
+  metadata.gz: a25adecefad4bd54870c96884c388ad4528ad03269b348422725a73bfe366204bfd530f58c8ac5ee92264891abcf34f824a4b4067620b9b118dba3e3e8da69d7
+  data.tar.gz: b48f66dedbe424b642337f76468ddfc0809589e8d6e13c448ebe80b5cfe804e4bbf87e7107b14b24634af477f5cf9add77596f8c425757a75683867e2fe1320e

data/.github/CODEOWNERS

@@ -1 +1 @@
-* @toptal/portals-experience-be
+* @toptal/devx

data/.github/workflows/ruby.yml

@@ -10,12 +10,10 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - { ruby: '2.4', rails: '5.0' }
-          - { ruby: '2.5', rails: '5.1' }
-          - { ruby: '2.6', rails: '5.2' }
           - { ruby: '2.7', rails: '6.0' }
           - { ruby: '3.0', rails: '6.1' }
           - { ruby: '3.1', rails: '7.0' }
+          - { ruby: '3.2', rails: '7.1' }
     runs-on: ubuntu-latest
     env:
       BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/rails.${{ matrix.rails }}.gemfile
@@ -35,7 +33,7 @@ jobs:
           # Maps tcp port 5432 on service container to the host
           - 5432:5432
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby }}
@@ -45,7 +43,7 @@ jobs:
   rubocop:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - uses: ruby/setup-ruby@v1
       with:
         ruby-version: '3.0'

data/Appraisals

@@ -1,4 +1,4 @@
-%w[5.0 5.1 5.2 6.0 6.1 7.0].each do |version|
+%w[6.0 6.1 7.0 7.1].each do |version|
   appraise "rails.#{version}" do
     gem 'activesupport', "~> #{version}.0"
     gem 'activemodel', "~> #{version}.0"

data/CHANGELOG.md

@@ -1,6 +1,14 @@
 # master
 
 ## Next
+
+## v0.5.0
+
+* Support for ruby 3.2 by @konalegi in https://github.com/toptal/granite-form/pull/22
+* Fix deprecated #to_s method by @mpiask in https://github.com/toptal/granite-form/pull/24
+* Support for Rails 7.1 by @ojab in https://github.com/toptal/granite-form/pull/25
+* [BREAKING] Drop support for Rails < 6.0 by @ojab in https://github.com/toptal/granite-form/pull/25
+
 ## v0.4.0
 
 * [BREAKING] Drop support for taking `model` as first argument in default/readonly/enum/normalize. This means that `default: -> (model) { model.other_field}` is no longer supported and should be replaced with `default: -> { other_field }`.

data/gemfiles/{rails.5.0.gemfile → rails.7.1.gemfile}

@@ -2,9 +2,9 @@
 
 source "https://rubygems.org"
 
-gem "activesupport", "~> 5.0.0"
-gem "activemodel", "~> 5.0.0"
-gem "activerecord", "~> 5.0.0"
+gem "activesupport", "~> 7.1.0"
+gem "activemodel", "~> 7.1.0"
+gem "activerecord", "~> 7.1.0"
 
 group :test do
   gem "guard"

data/granite-form.gemspec

@@ -14,8 +14,8 @@ Gem::Specification.new do |gem|
   gem.required_ruby_version = '>= 2.4.0'
   gem.version = Granite::Form::VERSION
 
-  gem.add_development_dependency 'actionpack', '>= 5.0'
-  gem.add_development_dependency 'activerecord', '>= 5.0'
+  gem.add_development_dependency 'actionpack', '>= 6.0'
+  gem.add_development_dependency 'activerecord', '>= 6.0'
   gem.add_development_dependency 'appraisal'
   gem.add_development_dependency 'bump'
   gem.add_development_dependency 'database_cleaner'
@@ -26,7 +26,7 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'rubocop', '0.52.1'
   gem.add_development_dependency 'uuidtools'
 
-  gem.add_runtime_dependency 'activemodel', '>= 5.0'
-  gem.add_runtime_dependency 'activesupport', '>= 5.0'
+  gem.add_runtime_dependency 'activemodel', '>= 6.0'
+  gem.add_runtime_dependency 'activesupport', '>= 6.0'
   gem.add_runtime_dependency 'tzinfo'
 end

data/lib/granite/form/model/attributes/base.rb

@@ -58,7 +58,7 @@ module Granite
           def inspect_attribute
             value = case read
             when Date, Time, DateTime
-              %("#{read.to_s(:db)}")
+              %("#{read.to_formatted_s(:db)}")
             else
               inspection = read.inspect
               inspection.size > 100 ? inspection.truncate(50) : inspection

data/lib/granite/form/version.rb

@@ -1,5 +1,5 @@
 module Granite
   module Form
-    VERSION = '0.4.0'.freeze
+    VERSION = '0.5.0'.freeze
   end
 end

data/spec/granite/form/model/attributes/base_spec.rb

@@ -103,4 +103,22 @@ describe Granite::Form::Model::Attributes::Base do
 
     it { is_expected.to have_attributes(type: String, reflection: subject.reflection, owner: model) }
   end
+
+  describe '#inspect_attribute' do
+    let(:field) { attribute(type: type) }
+    let(:object) { Object.new }
+
+    {
+      'hello' => 'field: "hello"',
+      123 => 'field: 123',
+      Date.new(2023, 6, 20) => 'field: "2023-06-20"',
+      DateTime.new(2023, 6, 20, 12, 30) => 'field: "2023-06-20 12:30:00"', # rubocop:disable Style/DateTime
+      Time.new(2023, 6, 20, 12, 30) => 'field: "2023-06-20 12:30:00"'
+    }.each do |input, expected_output|
+      context "attribute type is #{input.class}" do
+        let(:type) { input.class }
+        specify { expect(field.tap { |r| r.write(input) }.inspect_attribute).to eq(expected_output) }
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: granite-form
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Toptal Engineering
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-01-31 00:00:00.000000000 Z
+date: 2023-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
@@ -170,28 +170,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: tzinfo
   requirement: !ruby/object:Gem::Requirement
@@ -207,7 +207,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 description: Making object from any hash or hash array
-email: 
+email:
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -227,12 +227,10 @@ files:
 - README.md
 - Rakefile
 - docker-compose.yml
-- gemfiles/rails.5.0.gemfile
-- gemfiles/rails.5.1.gemfile
-- gemfiles/rails.5.2.gemfile
 - gemfiles/rails.6.0.gemfile
 - gemfiles/rails.6.1.gemfile
 - gemfiles/rails.7.0.gemfile
+- gemfiles/rails.7.1.gemfile
 - granite-form.gemspec
 - lib/granite/form.rb
 - lib/granite/form/active_record/associations.rb
@@ -380,7 +378,7 @@ files:
 homepage: https://github.com/toptal/granite-form
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -395,8 +393,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.26
-signing_key: 
+rubygems_version: 3.4.6
+signing_key:
 specification_version: 4
 summary: Working with hashes in AR style
 test_files:

data/gemfiles/rails.5.1.gemfile

@@ -1,14 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "activesupport", "~> 5.1.0"
-gem "activemodel", "~> 5.1.0"
-gem "activerecord", "~> 5.1.0"
-
-group :test do
-  gem "guard"
-  gem "guard-rspec"
-end
-
-gemspec path: "../"

data/gemfiles/rails.5.2.gemfile

@@ -1,14 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "activesupport", "~> 5.2.0"
-gem "activemodel", "~> 5.2.0"
-gem "activerecord", "~> 5.2.0"
-
-group :test do
-  gem "guard"
-  gem "guard-rspec"
-end
-
-gemspec path: "../"