granite-form 0.2.0 → 0.4.0

data/spec/granite/form/model/associations/references_many_spec.rb

@@ -4,7 +4,7 @@ describe Granite::Form::Model::Associations::ReferencesMany do
   before do
     stub_model(:dummy)
     stub_class(:author, ActiveRecord::Base) do
-      scope :name_starts_with_a, -> { where('name LIKE "a%"') }
+      scope :name_starts_with_a, -> { where('name ILIKE "a%"') }
 
       validates :name, presence: true
     end
@@ -33,330 +33,9 @@ describe Granite::Form::Model::Associations::ReferencesMany do
   end
 
   describe 'book#inspect' do
-    specify { expect(existing_book.inspect).to eq('#<Book authors: #<ReferencesMany [#<Author id: 1, name: "Rick">]>, title: "Genesis", author_ids: [1]>') }
-  end
-
-  describe '#build' do
-    specify { expect(association.build).to be_a Author }
-    specify { expect(association.build).not_to be_persisted }
-
-    specify do
-      expect { association.build(name: 'Morty') }
-        .to change { book.author_ids }
-        .from([]).to([nil])
-    end
-    specify do
-      expect { association.build(name: 'Morty') }
-        .to change { association.reader }.from([])
-        .to([an_instance_of(Author).and(have_attributes(name: 'Morty'))])
-    end
-
-    specify do
-      expect { existing_association.build(name: 'Morty') }
-        .to change { existing_book.author_ids }
-        .from([author.id]).to([author.id, nil])
-    end
-    specify do
-      expect { existing_association.build(name: 'Morty') }
-        .to change { existing_association.reader }.from([author])
-        .to([author, an_instance_of(Author).and(have_attributes(name: 'Morty'))])
-    end
-
-    context 'dirty' do
-      before do
-        Book.include Granite::Form::Model::Dirty
-      end
-
-      specify do
-        expect { existing_association.build(name: 'Morty') }
-          .to change { existing_book.changes }
-          .from({}).to('author_ids' => [[author.id], [author.id, nil]])
-      end
-    end
-  end
-
-  describe '#create' do
-    specify { expect(association.create).to be_a Author }
-    specify { expect(association.create).not_to be_persisted }
-
-    specify { expect(association.create(name: 'Morty')).to be_a Author }
-    specify { expect(association.create(name: 'Morty')).to be_persisted }
-
-    specify do
-      expect { association.create }
-        .to change { book.author_ids }
-        .from([]).to([nil])
-    end
-    specify do
-      expect { association.create }
-        .to change { association.target }
-        .from([]).to([an_instance_of(Author).and(be_new_record)])
-    end
-
-    specify do
-      expect { association.create(name: 'Morty') }
-        .to change { book.author_ids }
-        .from([]).to([be_a(Integer)])
-    end
-    specify do
-      expect { association.create(name: 'Morty') }
-        .to change { association.target }.from([])
-        .to([an_instance_of(Author)
-          .and(have_attributes(name: 'Morty'))
-          .and(be_persisted)])
-    end
-
-    specify do
-      expect { existing_association.create }
-        .to change { existing_book.author_ids }
-        .from([author.id]).to([author.id, nil])
-    end
-    specify do
-      expect { existing_association.create }
-        .to change { existing_association.reader }.from([author])
-        .to([author, an_instance_of(Author).and(be_new_record)])
-    end
-
-    specify do
-      expect { existing_association.create(name: 'Morty') }
-        .to change { existing_book.author_ids }
-        .from([author.id]).to([author.id, be_a(Integer)])
-    end
-    specify do
-      expect { existing_association.create(name: 'Morty') }
-        .to change { existing_association.reader }.from([author])
-        .to([author, an_instance_of(Author)
-          .and(have_attributes(name: 'Morty'))
-          .and(be_persisted)])
-    end
-
-    context 'dirty' do
-      before do
-        Book.include Granite::Form::Model::Dirty
-      end
-
-      specify do
-        expect { existing_association.create(name: 'Morty') }
-          .to change { existing_book.changes }
-          .from({}).to('author_ids' => [[author.id], [author.id, be_a(Integer)]])
-      end
-    end
-  end
-
-  describe '#create!' do
-    specify { expect { association.create! }.to raise_error ActiveRecord::RecordInvalid }
-
-    specify { expect(association.create!(name: 'Morty')).to be_a Author }
-    specify { expect(association.create!(name: 'Morty')).to be_persisted }
-
-    specify do
-      expect { muffle(ActiveRecord::RecordInvalid) { association.create! } }
-        .to change { book.author_ids }
-        .from([]).to([nil])
-    end
-    specify do
-      expect { muffle(ActiveRecord::RecordInvalid) { association.create! } }
-        .to change { association.target }
-        .from([]).to([an_instance_of(Author).and(be_new_record)])
-    end
-
-    specify do
-      expect { association.create!(name: 'Morty') }
-        .to change { book.author_ids }
-        .from([]).to([be_a(Integer)])
-    end
-    specify do
-      expect { association.create!(name: 'Morty') }
-        .to change { association.target }.from([])
-        .to([an_instance_of(Author)
-          .and(have_attributes(name: 'Morty'))
-          .and(be_persisted)])
-    end
-
-    specify do
-      expect { muffle(ActiveRecord::RecordInvalid) { existing_association.create! } }
-        .to change { existing_book.author_ids }
-        .from([author.id]).to([author.id, nil])
-    end
-    specify do
-      expect { muffle(ActiveRecord::RecordInvalid) { existing_association.create! } }
-        .to change { existing_association.reader }.from([author])
-        .to([author, an_instance_of(Author).and(be_new_record)])
-    end
-
-    specify do
-      expect { existing_association.create!(name: 'Morty') }
-        .to change { existing_book.author_ids }
-        .from([author.id]).to([author.id, be_a(Integer)])
-    end
-    specify do
-      expect { existing_association.create!(name: 'Morty') }
-        .to change { existing_association.reader }.from([author])
-        .to([author, an_instance_of(Author)
-          .and(have_attributes(name: 'Morty'))
-          .and(be_persisted)])
-    end
-  end
-
-  describe '#apply_changes' do
-    specify do
-      association.build
-      expect(association.apply_changes).to eq(false)
-    end
-    specify do
-      association.build
-      expect { association.apply_changes }
-        .not_to change { association.target.map(&:persisted?) }
-        .from([false])
-    end
-    specify do
-      association.build(name: 'Rick')
-      expect(association.apply_changes).to eq(true)
-    end
-    specify do
-      association.build(name: 'Rick')
-      expect { association.apply_changes }
-        .to change { association.target.map(&:persisted?) }
-        .from([false]).to([true])
-    end
-    specify do
-      association.build(name: 'Rick')
-      expect { association.apply_changes }
-        .to change { book.author_ids }
-        .from([nil]).to([be_a(Integer)])
-    end
-    specify do
-      existing_association.target.first.name = 'Morty'
-      expect { existing_association.apply_changes }
-        .not_to change { author.reload.name }
-    end
-    specify do
-      existing_association.target.first.mark_for_destruction
-      existing_association.build(name: 'Morty')
-      expect { existing_association.apply_changes }
-        .to change { existing_book.author_ids }
-        .from([author.id, nil]).to([author.id, be_a(Integer)])
-    end
-    specify do
-      existing_association.target.first.mark_for_destruction
-      existing_association.build(name: 'Morty')
-      expect { existing_association.apply_changes }
-        .to change { existing_association.target.map(&:persisted?) }
-        .from([true, false]).to([true, true])
-    end
-    specify do
-      existing_association.target.first.destroy!
-      existing_association.build(name: 'Morty')
-      expect { existing_association.apply_changes }
-        .to change { existing_book.author_ids }
-        .from([author.id, nil]).to([author.id, be_a(Integer)])
-    end
-    specify do
-      existing_association.target.first.destroy!
-      existing_association.build(name: 'Morty')
-      expect { existing_association.apply_changes }
-        .to change { existing_association.target.map(&:persisted?) }
-        .from([false, false]).to([false, true])
-    end
-
-    context ':autosave' do
-      before do
-        Book.references_many :authors, autosave: true
-      end
-
-      specify do
-        association.build
-        expect(association.apply_changes).to eq(false)
-      end
-      specify do
-        association.build
-        expect { association.apply_changes }
-          .not_to change { association.target.map(&:persisted?) }
-          .from([false])
-      end
-      specify do
-        association.build(name: 'Rick')
-        expect(association.apply_changes).to eq(true)
-      end
-      specify do
-        association.build(name: 'Rick')
-        expect { association.apply_changes }
-          .to change { association.target.map(&:persisted?) }
-          .from([false]).to([true])
-      end
-      specify do
-        association.build(name: 'Rick')
-        expect { association.apply_changes }
-          .to change { book.author_ids }
-          .from([nil]).to([be_a(Integer)])
-      end
-      specify do
-        existing_association.target.first.name = 'Morty'
-        expect { existing_association.apply_changes }
-          .to change { author.reload.name }
-          .from('Rick').to('Morty')
-      end
-      specify do
-        existing_association.target.first.mark_for_destruction
-        existing_association.build(name: 'Morty')
-        expect { existing_association.apply_changes }
-          .to change { existing_book.author_ids }
-          .from([author.id, nil]).to([author.id, be_a(Integer)])
-      end
-      specify do
-        existing_association.target.first.mark_for_destruction
-        existing_association.build(name: 'Morty')
-        expect { existing_association.apply_changes }
-          .to change { existing_association.target.map(&:persisted?) }
-          .from([true, false]).to([false, true])
-      end
-      specify do
-        existing_association.target.first.destroy!
-        existing_association.build(name: 'Morty')
-        expect { existing_association.apply_changes }
-          .to change { existing_book.author_ids }
-          .from([author.id, nil]).to([author.id, be_a(Integer)])
-      end
-      specify do
-        existing_association.target.first.destroy!
-        existing_association.build(name: 'Morty')
-        expect { existing_association.apply_changes }
-          .to change { existing_association.target.map(&:persisted?) }
-          .from([false, false]).to([false, true])
-      end
-    end
-  end
-
-  describe '#apply_changes!' do
-    specify do
-      association.build
-      expect { association.apply_changes! }
-        .to raise_error(Granite::Form::AssociationChangesNotApplied)
-    end
-    specify do
-      association.build
-      expect { muffle(Granite::Form::AssociationChangesNotApplied) { association.apply_changes! } }
-        .not_to change { association.target.map(&:persisted?) }
-        .from([false])
-    end
-
-    context ':autosave' do
-      before do
-        Book.references_many :authors, autosave: true
-      end
-
-      specify do
-        association.build
-        expect { association.apply_changes! }
-          .to raise_error(Granite::Form::AssociationChangesNotApplied)
-      end
-      specify do
-        association.build
-        expect { muffle(Granite::Form::AssociationChangesNotApplied) { association.apply_changes! } }
-          .not_to change { association.target.map(&:persisted?) }
-          .from([false])
-      end
-    end
+    specify { expect(existing_book.inspect).to eq(<<~STR.chomp) }
+      #<Book authors: #<ReferencesMany #{[author].inspect.truncate(50, omission: '...]')}>, title: "Genesis", author_ids: [#{author.id}]>
+    STR
   end
 
   describe '#scope' do
@@ -536,7 +215,7 @@ describe Granite::Form::Model::Associations::ReferencesMany do
     end
     specify do
       expect { association.concat(new_author1) }
-        .to change { book.read_attribute(:author_ids) }.from([]).to([1])
+        .to change { book.read_attribute(:author_ids) }.from([]).to([new_author1.id])
     end
 
     specify do

data/spec/granite/form/model/associations/references_one_spec.rb

@@ -29,281 +29,9 @@ describe Granite::Form::Model::Associations::ReferencesOne do
   end
 
   describe 'book#inspect' do
-    specify { expect(existing_book.inspect).to eq('#<Book author: #<ReferencesOne #<Author id: 1, name: "Johny">>, title: "My Life", author_id: 1>') }
-  end
-
-  describe '#build' do
-    specify { expect(association.build).to be_a Author }
-    specify { expect(association.build).not_to be_persisted }
-
-    specify do
-      expect { association.build(name: 'Morty') }
-        .not_to change { book.author_id }
-    end
-    specify do
-      expect { association.build(name: 'Morty') }
-        .to change { book.author }.from(nil)
-        .to(an_instance_of(Author).and(have_attributes(name: 'Morty')))
-    end
-
-    specify do
-      expect { existing_association.build(name: 'Morty') }
-        .to change { existing_book.author_id }
-        .from(author.id).to(nil)
-    end
-    specify do
-      expect { existing_association.build(name: 'Morty') }
-        .to change { existing_book.author }.from(author)
-        .to(an_instance_of(Author).and(have_attributes(name: 'Morty')))
-    end
-
-    context 'dirty' do
-      before do
-        Book.include Granite::Form::Model::Dirty
-      end
-
-      specify do
-        expect { existing_association.build(name: 'Morty') }
-          .to change { existing_book.changes }
-          .from({}).to('author_id' => [author.id, nil])
-      end
-    end
-  end
-
-  describe '#create' do
-    specify { expect(association.create).to be_a Author }
-    specify { expect(association.create).not_to be_persisted }
-
-    specify { expect(association.create(name: 'Fred')).to be_a Author }
-    specify { expect(association.create(name: 'Fred')).to be_persisted }
-
-    specify do
-      expect { association.create }
-        .not_to change { book.author_id }
-    end
-    specify do
-      expect { association.create(name: 'Fred') }
-        .to change { book.author_id }
-        .from(nil).to(be_a(Integer))
-    end
-
-    specify do
-      expect { existing_association.create }
-        .to change { existing_book.author_id }
-        .from(author.id).to(nil)
-    end
-    specify do
-      expect { existing_association.create(name: 'Fred') }
-        .to change { existing_book.author_id }
-        .from(author.id).to(be_a(Integer))
-    end
-
-    context 'dirty' do
-      before do
-        Book.include Granite::Form::Model::Dirty
-      end
-
-      specify do
-        expect { existing_association.create(name: 'Fred') }
-          .to change { existing_book.changes }
-          .from({}).to('author_id' => [author.id, be_a(Integer)])
-      end
-    end
-  end
-
-  describe '#create!' do
-    specify { expect { association.create! }.to raise_error ActiveRecord::RecordInvalid }
-    specify do
-      expect { muffle(ActiveRecord::RecordInvalid) { association.create! } }
-        .to change { association.target }
-        .from(nil).to(an_instance_of(Author))
-    end
-
-    specify { expect(association.create!(name: 'Fred')).to be_a Author }
-    specify { expect(association.create!(name: 'Fred')).to be_persisted }
-
-    specify do
-      expect { muffle(ActiveRecord::RecordInvalid) { association.create! } }
-        .not_to change { book.author_id }
-    end
-    specify do
-      expect { muffle(ActiveRecord::RecordInvalid) { association.create! } }
-        .to change { association.reader.try(:attributes).try(:slice, 'name') }
-        .from(nil).to('name' => nil)
-    end
-    specify do
-      expect { association.create(name: 'Fred') }
-        .to change { book.author_id }
-        .from(nil).to(be_a(Integer))
-    end
-
-    specify do
-      expect { muffle(ActiveRecord::RecordInvalid) { existing_association.create! } }
-        .to change { existing_book.author_id }
-        .from(author.id).to(nil)
-    end
-    specify do
-      expect { muffle(ActiveRecord::RecordInvalid) { existing_association.create! } }
-        .to change { existing_association.reader.try(:attributes).try(:slice, 'name') }
-        .from('name' => 'Johny').to('name' => nil)
-    end
-    specify do
-      expect { existing_association.create!(name: 'Fred') }
-        .to change { existing_book.author_id }
-        .from(author.id).to(be_a(Integer))
-    end
-  end
-
-  context do
-    shared_examples 'apply_changes' do |method|
-      specify do
-        association.build(name: 'Fred')
-        expect(association.send(method)).to eq(true)
-      end
-      specify do
-        association.build(name: 'Fred')
-        expect { association.send(method) }
-          .to change { association.target.persisted? }.to(true)
-      end
-      specify do
-        association.build(name: 'Fred')
-        expect { association.send(method) }
-          .to change { book.author_id }
-          .from(nil).to(be_a(Integer))
-      end
-      specify do
-        existing_association.target.name = 'Fred'
-        expect { existing_association.send(method) }
-          .not_to change { author.reload.name }
-      end
-      specify do
-        existing_association.target.mark_for_destruction
-        expect { existing_association.send(method) }
-          .not_to change { existing_association.target.destroyed? }
-      end
-      specify do
-        existing_association.target.mark_for_destruction
-        expect { existing_association.send(method) }
-          .not_to change { existing_book.author_id }
-      end
-      specify do
-        existing_association.target.destroy!
-        expect { existing_association.send(method) }
-          .not_to change { existing_association.target.destroyed? }
-      end
-      specify do
-        existing_association.target.destroy!
-        expect { existing_association.send(method) }
-          .not_to change { existing_book.author_id }
-      end
-
-      context ':autosave' do
-        before do
-          Book.references_one :author, autosave: true
-        end
-
-        specify do
-          association.build(name: 'Fred')
-          expect(association.send(method)).to eq(true)
-        end
-        specify do
-          association.build(name: 'Fred')
-          expect { association.send(method) }
-            .to change { association.target.persisted? }.to(true)
-        end
-        specify do
-          existing_association.target.name = 'Fred'
-          expect { existing_association.send(method) }
-            .to change { author.reload.name }.from('Johny').to('Fred')
-        end
-        specify do
-          existing_association.target.mark_for_destruction
-          expect { existing_association.send(method) }
-            .to change { existing_association.target.destroyed? }
-            .from(false).to(true)
-        end
-        specify do
-          existing_association.target.mark_for_destruction
-          expect { existing_association.send(method) }
-            .not_to change { existing_book.author_id }
-            .from(author.id)
-        end
-        specify do
-          existing_association.target.destroy!
-          expect { existing_association.send(method) }
-            .not_to change { existing_association.target.destroyed? }
-            .from(true)
-        end
-        specify do
-          existing_association.target.destroy!
-          expect { existing_association.send(method) }
-            .not_to change { existing_book.author_id }
-            .from(author.id)
-        end
-      end
-    end
-
-    describe '#apply_changes' do
-      include_examples 'apply_changes', :apply_changes
-
-      specify do
-        association.build
-        expect(association.apply_changes).to eq(false)
-      end
-      specify do
-        association.build
-        expect { association.apply_changes }
-          .not_to change { association.target.persisted? }.from(false)
-      end
-
-      context ':autosave' do
-        before do
-          Book.references_one :author, autosave: true
-        end
-
-        specify do
-          association.build
-          expect(association.apply_changes).to eq(false)
-        end
-        specify do
-          association.build
-          expect { association.apply_changes }
-            .not_to change { association.target.persisted? }.from(false)
-        end
-      end
-    end
-
-    describe '#apply_changes!' do
-      include_examples 'apply_changes', :apply_changes!
-
-      specify do
-        association.build
-        expect { association.apply_changes! }
-          .to raise_error(Granite::Form::AssociationChangesNotApplied)
-      end
-      specify do
-        association.build
-        expect { muffle(Granite::Form::AssociationChangesNotApplied) { association.apply_changes! } }
-          .not_to change { association.target.persisted? }.from(false)
-      end
-
-      context ':autosave' do
-        before do
-          Book.references_one :author, autosave: true
-        end
-
-        specify do
-          association.build
-          expect { association.apply_changes! }
-            .to raise_error(Granite::Form::AssociationChangesNotApplied)
-        end
-        specify do
-          association.build
-          expect { muffle(Granite::Form::AssociationChangesNotApplied) { association.apply_changes! } }
-            .not_to change { association.target.persisted? }.from(false)
-        end
-      end
-    end
+    specify { expect(existing_book.inspect).to eq(<<~STR.chomp) }
+      #<Book author: #<ReferencesOne #{author.inspect.truncate(50)}>, title: "My Life", author_id: #{author.id}>
+    STR
   end
 
   describe '#target' do
@@ -384,7 +112,7 @@ describe Granite::Form::Model::Associations::ReferencesOne do
     end
 
     context 'persisted owner' do
-      let(:new_author) { Author.create(name: 'Morty') }
+      let(:new_author) { Author.create!(name: 'Morty') }
 
       specify do
         expect { association.writer(stub_model(:dummy).new) }
@@ -399,7 +127,7 @@ describe Granite::Form::Model::Associations::ReferencesOne do
       end
       specify do
         expect { association.writer(new_author) }
-          .to change { association.reader.try(:attributes) }.from(nil).to('id' => 1, 'name' => 'Morty')
+          .to change { association.reader }.from(nil).to(new_author)
       end
       specify do
         expect { association.writer(new_author) }
@@ -432,8 +160,8 @@ describe Granite::Form::Model::Associations::ReferencesOne do
       end
       specify do
         expect { existing_association.writer(new_author) }
-          .to change { existing_association.reader.try(:attributes) }
-          .from('id' => 1, 'name' => 'Johny').to('id' => 2, 'name' => 'Morty')
+          .to change { existing_association.reader }
+          .from(author).to(new_author)
       end
       specify do
         expect { existing_association.writer(new_author) }

data/spec/granite/form/model/associations/reflections/embeds_any_spec.rb

@@ -7,7 +7,6 @@ describe Granite::Form::Model::Associations::Reflections::EmbedsAny do
 
     before do
       stub_model(:project) do
-        include Granite::Form::Model::Lifecycle
         attribute :title, String
       end
       stub_model(:user) do
@@ -20,7 +19,7 @@ describe Granite::Form::Model::Associations::Reflections::EmbedsAny do
 
     it { is_expected.to be_a(Granite::Form::Model) }
     it { is_expected.to be_a(Granite::Form::Model::Primary) }
-    it { is_expected.to be_a(Granite::Form::Model::Lifecycle) }
+    it { is_expected.to be_a(Granite::Form::Model::Persistence) }
     it { is_expected.to be_a(Granite::Form::Model::Associations) }
 
     context 'when Granite::Form.base_concern is defined' do