gpx_kml 0.1.0 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 13f65ff6210343e36ea2ac9d4dba526063b52acb79e53e0b9041396e5c7f60e8
-  data.tar.gz: 20812205cf5a53b658bf7a5d4ea4ec389c3d535bdb6ea0f27e0bd06b9865998e
+  metadata.gz: 4e4f90ca7411226710707068d7b42b5d5bb9502b7431c842ec28611854e56487
+  data.tar.gz: 9926bc276fa356b3af9697a88e5b10c84cb421e4ef786268c1121ffb8cc8a536
 SHA512:
-  metadata.gz: 35887d6a1c43fb454ec18d06e02c7dc9de8b0586eaff513d6f18540b52b19768d5c52332cc5d4c7f94085e404c0253ec66618421d7379eeb624db83340163e36
-  data.tar.gz: d6d731ba24b088f7f6c35f19a8668a6384c85cba46f486455182457d79dabffd1ac289aafd74bc2d2113ecefcc41b1d19a4a491d068fa5a8d00ba5e1e4f42cb0
+  metadata.gz: 58cc3fc0313d1e898ea57f4969e10618ebe6a0745b98933aa5e614ae18c49da3dae8c292613ec642b673a0f39fc3eb8bd9bdf72713a2d0072acc529567b8205f
+  data.tar.gz: 2b6e8dd1db1191146bcd25e467536bd5eb750a2739e3bc3912b2979339d05f4d15186b948d64b471f33727238e6efdfe2dded853f76c9203cfb9b61c6744a03b

data/.gitignore

@@ -7,6 +7,7 @@
 /spec/reports/
 /tmp/
 /.idea/
+/coverage/
 
 # rspec failure tracking
 .rspec_status

data/CHANGELOG.md

@@ -1,4 +1,19 @@
 ### V 0.1.x
+- v 0.1.4:
+  - fixed kml files generation
+  - fixed bug that swapped latitude and longitude in certain conversions from gpx to kml
+  - added code coverage for development env
+- v 0.1.3:
+  - changed usage & updated/fixed minor parts in documentation (README.md)
+  - added preconverted files and missing tests
+  - change in inputs for conversion functions: now they take in Gpx and Kml instances instead of file paths
+  - added new feature: now you can check whether a Gpx (or Kml) object imported an effective 'gpx' (or 'kml') file
+  - added new feature: now you can create Gpx and Kml objects from their respective files
+  - removed dependency factory_bot which ended up being unused
+- v 0.1.2:
+  - fixed version tests, AGAIN
+- v 0.1.1:
+  - fixed critical bug on output file, path was wrong
 - v 0.1.0: 
   - fixed changelog link in rubygems.org
   - removed .idea directory in the project

data/Gemfile.lock

@@ -1,29 +1,16 @@
 PATH
   remote: .
   specs:
-    gpx_kml (0.1.0)
+    gpx_kml (0.1.4)
       nokogiri (~> 1.12.0)
       rake (~> 12.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.1.4.1)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 1.6, < 2)
-      minitest (>= 5.1)
-      tzinfo (~> 2.0)
-      zeitwerk (~> 2.3)
-    concurrent-ruby (1.1.9)
-    diff-lcs (1.4.4)
-    factory_bot (6.2.0)
-      activesupport (>= 5.0.0)
-    i18n (1.8.10)
-      concurrent-ruby (~> 1.0)
-    mini_portile2 (2.6.1)
-    minitest (5.14.4)
-    nokogiri (1.12.5)
-      mini_portile2 (~> 2.6.1)
+    diff-lcs (1.5.0)
+    docile (1.4.0)
+    nokogiri (1.12.5-x86_64-linux)
       racc (~> 1.4)
     racc (1.6.0)
     rake (12.3.3)
@@ -33,24 +20,27 @@ GEM
       rspec-mocks (~> 3.10.0)
     rspec-core (3.10.1)
       rspec-support (~> 3.10.0)
-    rspec-expectations (3.10.1)
+    rspec-expectations (3.10.2)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
     rspec-mocks (3.10.2)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
-    rspec-support (3.10.2)
-    tzinfo (2.0.4)
-      concurrent-ruby (~> 1.0)
-    zeitwerk (2.4.2)
+    rspec-support (3.10.3)
+    simplecov (0.21.2)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+      simplecov_json_formatter (~> 0.1)
+    simplecov-html (0.12.3)
+    simplecov_json_formatter (0.1.3)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  factory_bot (~> 6.2)
   gpx_kml!
   rspec (~> 3.0)
+  simplecov (~> 0.21.0)
 
 BUNDLED WITH
-   2.1.4
+   2.2.22

data/LICENSE.md

@@ -0,0 +1,157 @@
+### GNU LESSER GENERAL PUBLIC LICENSE
+
+Version 3, 29 June 2007
+
+Copyright (C) 2007 Free Software Foundation, Inc.
+<https://fsf.org/>
+
+Everyone is permitted to copy and distribute verbatim copies of this
+license document, but changing it is not allowed.
+
+This version of the GNU Lesser General Public License incorporates the
+terms and conditions of version 3 of the GNU General Public License,
+supplemented by the additional permissions listed below.
+
+#### 0. Additional Definitions.
+
+As used herein, "this License" refers to version 3 of the GNU Lesser
+General Public License, and the "GNU GPL" refers to version 3 of the
+GNU General Public License.
+
+"The Library" refers to a covered work governed by this License, other
+than an Application or a Combined Work as defined below.
+
+An "Application" is any work that makes use of an interface provided
+by the Library, but which is not otherwise based on the Library.
+Defining a subclass of a class defined by the Library is deemed a mode
+of using an interface provided by the Library.
+
+A "Combined Work" is a work produced by combining or linking an
+Application with the Library. The particular version of the Library
+with which the Combined Work was made is also called the "Linked
+Version".
+
+The "Minimal Corresponding Source" for a Combined Work means the
+Corresponding Source for the Combined Work, excluding any source code
+for portions of the Combined Work that, considered in isolation, are
+based on the Application, and not on the Linked Version.
+
+The "Corresponding Application Code" for a Combined Work means the
+object code and/or source code for the Application, including any data
+and utility programs needed for reproducing the Combined Work from the
+Application, but excluding the System Libraries of the Combined Work.
+
+#### 1. Exception to Section 3 of the GNU GPL.
+
+You may convey a covered work under sections 3 and 4 of this License
+without being bound by section 3 of the GNU GPL.
+
+#### 2. Conveying Modified Versions.
+
+If you modify a copy of the Library, and, in your modifications, a
+facility refers to a function or data to be supplied by an Application
+that uses the facility (other than as an argument passed when the
+facility is invoked), then you may convey a copy of the modified
+version:
+
+-   a) under this License, provided that you make a good faith effort
+    to ensure that, in the event an Application does not supply the
+    function or data, the facility still operates, and performs
+    whatever part of its purpose remains meaningful, or
+-   b) under the GNU GPL, with none of the additional permissions of
+    this License applicable to that copy.
+
+#### 3. Object Code Incorporating Material from Library Header Files.
+
+The object code form of an Application may incorporate material from a
+header file that is part of the Library. You may convey such object
+code under terms of your choice, provided that, if the incorporated
+material is not limited to numerical parameters, data structure
+layouts and accessors, or small macros, inline functions and templates
+(ten or fewer lines in length), you do both of the following:
+
+-   a) Give prominent notice with each copy of the object code that
+    the Library is used in it and that the Library and its use are
+    covered by this License.
+-   b) Accompany the object code with a copy of the GNU GPL and this
+    license document.
+
+#### 4. Combined Works.
+
+You may convey a Combined Work under terms of your choice that, taken
+together, effectively do not restrict modification of the portions of
+the Library contained in the Combined Work and reverse engineering for
+debugging such modifications, if you also do each of the following:
+
+-   a) Give prominent notice with each copy of the Combined Work that
+    the Library is used in it and that the Library and its use are
+    covered by this License.
+-   b) Accompany the Combined Work with a copy of the GNU GPL and this
+    license document.
+-   c) For a Combined Work that displays copyright notices during
+    execution, include the copyright notice for the Library among
+    these notices, as well as a reference directing the user to the
+    copies of the GNU GPL and this license document.
+-   d) Do one of the following:
+    -   0) Convey the Minimal Corresponding Source under the terms of
+        this License, and the Corresponding Application Code in a form
+        suitable for, and under terms that permit, the user to
+        recombine or relink the Application with a modified version of
+        the Linked Version to produce a modified Combined Work, in the
+        manner specified by section 6 of the GNU GPL for conveying
+        Corresponding Source.
+    -   1) Use a suitable shared library mechanism for linking with
+        the Library. A suitable mechanism is one that (a) uses at run
+        time a copy of the Library already present on the user's
+        computer system, and (b) will operate properly with a modified
+        version of the Library that is interface-compatible with the
+        Linked Version.
+-   e) Provide Installation Information, but only if you would
+    otherwise be required to provide such information under section 6
+    of the GNU GPL, and only to the extent that such information is
+    necessary to install and execute a modified version of the
+    Combined Work produced by recombining or relinking the Application
+    with a modified version of the Linked Version. (If you use option
+    4d0, the Installation Information must accompany the Minimal
+    Corresponding Source and Corresponding Application Code. If you
+    use option 4d1, you must provide the Installation Information in
+    the manner specified by section 6 of the GNU GPL for conveying
+    Corresponding Source.)
+
+#### 5. Combined Libraries.
+
+You may place library facilities that are a work based on the Library
+side by side in a single library together with other library
+facilities that are not Applications and are not covered by this
+License, and convey such a combined library under terms of your
+choice, if you do both of the following:
+
+-   a) Accompany the combined library with a copy of the same work
+    based on the Library, uncombined with any other library
+    facilities, conveyed under the terms of this License.
+-   b) Give prominent notice with the combined library that part of it
+    is a work based on the Library, and explaining where to find the
+    accompanying uncombined form of the same work.
+
+#### 6. Revised Versions of the GNU Lesser General Public License.
+
+The Free Software Foundation may publish revised and/or new versions
+of the GNU Lesser General Public License from time to time. Such new
+versions will be similar in spirit to the present version, but may
+differ in detail to address new problems or concerns.
+
+Each version is given a distinguishing version number. If the Library
+as you received it specifies that a certain numbered version of the
+GNU Lesser General Public License "or any later version" applies to
+it, you have the option of following the terms and conditions either
+of that published version or of any later version published by the
+Free Software Foundation. If the Library as you received it does not
+specify a version number of the GNU Lesser General Public License, you
+may choose any version of the GNU Lesser General Public License ever
+published by the Free Software Foundation.
+
+If the Library as you received it specifies that a proxy can decide
+whether future versions of the GNU Lesser General Public License shall
+apply, that proxy's public statement of acceptance of any version is
+permanent authorization for you to choose that version for the
+Library.

data/README.md

@@ -1,14 +1,14 @@
 # GpxKml
 
-Welcome to your new gem! In this directory, you'll find the files you need to be able to package up your Ruby library into a gem. Put your Ruby code in the file `lib/gpx_kml`. To experiment with that code, run `bin/console` for an interactive prompt.
+[![License: LGPL v3](https://img.shields.io/badge/License-LGPL%20v3-blue.svg)](http://www.gnu.org/licenses/lgpl-3.0) [![Coverage: %](https://img.shields.io/badge/Code%20coverage-100%25-green.svg)](#coverage)
 
-TODO: Delete this and the text above, and describe your gem
+This gem adds the capability to convert GPS Exchange Format (GPX) files to Keyhole Markup Language (KML) files and viceversa
 
 ## Before using
 
 Please take note that this only converts essentials data for the gpx and kml files compatibility.
-However the gem doesn't just include the converter, it also transforms gpx files and kml files (only their track/route/point parts) into a Gpx/Kml file, which could be useful for a new fork or other uses.
-Just dig in deep, tests are present for everything you need, except the mere conversion.
+However the gem doesn't just include the converter, it also transforms gpx files and kml files (only their track/route/point parts) into a Gpx/Kml instance, which could be useful for new forks or other uses.
+Just dig in deep, tests are present for everything you need.
 
 ## Installation
 
@@ -28,12 +28,26 @@ Or install it yourself as:
 
 ## Usage
 
-To use it just ```require 'gpx_kml'``` in the script you need the converter and use either one of the following two functions:
+To use it just ```require 'gpx_kml'``` in the script you need the converter and perform the following actions:
+<br>
+Create an instance of the file you want to convert as follows:
+- ```gpx = GPXKML::GpxKml.new_gpx('file_path')``` for a gpx file
+- ```kml = GPXKML::GpxKml.new_kml('file_path')``` for a kml file
+<br><br>
 
-- ```GPXKML::GpxKml.kml_to_gpx('file_path', 'destination_path')```
-- ```GPXKML::GpxKml.gpx_to_kml('file_path', 'destination_path')```
+Now: you may want to check if the file you imported is actually a gpx or a kml.<br>
+You can do that by usign the ```gpx?``` &  ```kml?``` functions on the instance you just created:
+- ```GPXKML::GpxKml.gpx?(gpx)```
+- ```GPXKML::GpxKml.kml?(kml)```
 
-Note: destination_path must be a directory
+Note: this step is optional since the conversions method below do the same thing inside of themselves, but this method could turn out to be useful.
+<br><br>
+Now you can actually convert the instance to create the new file needed.<br>
+The function will return the entire path to the file just created!
+- ```path_of_the_new_file = GPXKML::GpxKml.kml_to_gpx('gpx', 'destination_path')```
+- ```path_of_the_new_file = GPXKML::GpxKml.gpx_to_kml('kml', 'destination_path')```
+
+IMPORTANT : ```destination_path``` must be a directory
 
 ## Development
 
@@ -45,6 +59,9 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/Engim-eu/gpx_kml. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/[USERNAME]/gpx_kml/blob/master/CODE_OF_CONDUCT.md).
 
+## Coverage
+
+Coverage can be checked running `rake spec`. This command will generate the coverage files needed.
 
 ## Code of Conduct
 

data/gpx_kml.gemspec

@@ -7,8 +7,9 @@ Gem::Specification.new do |spec|
   spec.email         = ['info@engim.eu']
 
   spec.summary       = 'Gem to convert .gpx into .kml and back'
-  spec.description   = 'This gem adds the capability to convert GPS Exchange Format (GPX) to Keyhole Markup Language (KML) and viceversa'
+  spec.description   = 'This gem adds the capability to convert GPS Exchange Format (GPX) files to Keyhole Markup Language (KML) files and viceversa'
   spec.homepage      = 'https://www.github.com/engim-eu/gpx_kml'
+  spec.licenses      = ['LGNU']
   spec.required_ruby_version = Gem::Requirement.new('>= 2.5.0')
 
   spec.metadata['allowed_push_host'] = "https://rubygems.org"
@@ -33,6 +34,11 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'nokogiri', '~>1.12.0'
 
   # Gem testing
-  spec.add_development_dependency 'factory_bot', '~>6.2'
   spec.add_development_dependency 'rspec', '~>3.0'
+
+  # Test coverage
+  spec.add_development_dependency 'simplecov', '~>0.21.0'
+
+  # spec.add_development_dependency 'factory_bot', '~>6.2'
+  # factory_bot isn't really used
 end

data/lib/converter.rb

@@ -3,13 +3,11 @@
 module CONVERTER
   # Docu
   class Converter
-    def self.gpx_to_kml(gpx_path, output_path)
-      return unless File.directory?(output_path)
+    def self.gpx_to_kml(gpx, output_path)
+      return unless File.directory?(output_path) && gpx.is_a?(GPX::Gpx)
+      return nil unless gpx.gpx?
 
       output_path = output_path[0..-2] if output_path[-1].eql?('/')
-      gpx = GPXKML::Gpx.new(gpx_path)
-      return nil if gpx.nil? || !gpx.valid?
-
       kml = Nokogiri::XML::Builder.new do |xml|
         xml.kml('xmlns': 'http://www.opengis.net/kml/2.2', 'xmlns:gx': 'http://www.google.com/kml/ext/2.2',
                 'xmlns:atom': 'http://www.w3.org/Atom') do
@@ -33,20 +31,22 @@ module CONVERTER
           end
         end
       end
-      name = "#{output_path}/#{Time.now.strftime('%Y%m%d%H%M%S')}_#{gpx.file_name[0..-5]}.kml"
-      f = File.open("#{output_path}/#{name}", 'w')
+      name = if gpx.file_name.end_with?('.gpx') || gpx.file_name.end_with?('.xml')
+               "#{output_path}/#{Time.now.strftime('%Y%m%d%H%M%S')}_#{gpx.file_name[0..-5]}.kml"
+             else
+               "#{output_path}/#{Time.now.strftime('%Y%m%d%H%M%S')}_#{gpx.file_name}.kml"
+             end
+      f = File.open(name.to_s, 'w')
       f.write(kml.to_xml)
       f.close
       name
     end
 
-    def self.kml_to_gpx(kml_path, output_path)
-      return unless File.directory?(output_path)
+    def self.kml_to_gpx(kml, output_path)
+      return nil unless File.directory?(output_path) && kml.is_a?(KML::Kml)
+      return nil unless kml.kml?
 
       output_path = output_path[0..-2] if output_path[-1].eql?('/')
-      kml = GPXKML::Kml.new(kml_path)
-      return nil if kml.nil? || !kml.valid?
-
       gpx = Nokogiri::XML::Builder.new do |xml|
         xml.gpx('version': '1.1', 'creator': 'https://www.github.com/engim-eu/gpx_kml',
                 'xmlns': 'https://www.topografix.com/GPX/1/1', 'xmlns:xsi': 'http://www.w3.org/2001/XMLSchema-instance') do
@@ -58,31 +58,35 @@ module CONVERTER
           gpx_tracks(xml, kml)
         end
       end
-      name = "#{output_path}/#{Time.now.strftime('%Y%m%d%H%M%S')}_#{kml.file_name[0..-5]}.gpx"
-      f = File.open("#{output_path}/#{name}", 'w')
+      name = if kml.file_name.end_with?('.kml') || kml.file_name.end_with?('.xml')
+               "#{output_path}/#{Time.now.strftime('%Y%m%d%H%M%S')}_#{kml.file_name[0..-5]}.gpx"
+             else
+               "#{output_path}/#{Time.now.strftime('%Y%m%d%H%M%S')}_#{kml.file_name}.gpx"
+             end
+      f = File.open(name.to_s, 'w')
       f.write(gpx.to_xml)
       f.close
       name
     end
 
-    private
-
     def self.kml_routes(xml, gpx)
       if gpx.routes?
         gpx.routes.each do |r|
-          xml.LinearRing do
-            xml.extrude('0')
-            xml.tassellate('0')
-            xml.altitudeMode('clampToGroud')
-            s = ''
-            r.points.each do |p|
-              s = if p.elevation.nil? || p.elevation.empty?
-                    s + "#{p.latitude},#{p.longitude} "
-                  else
-                    s + "#{p.latitude},#{p.longitude},#{p.elevation} "
-                  end
+          xml.Placemark do
+            xml.LinearRing do
+              xml.extrude('0')
+              xml.tassellate('0')
+              xml.altitudeMode('clampToGroud')
+              s = ''
+              r.points.each do |p|
+                s = if p.elevation.nil? || p.elevation.empty?
+                      s + "#{p.longitude},#{p.latitude} "
+                    else
+                      s + "#{p.longitude},#{p.latitude},#{p.elevation} "
+                    end
+              end
+              xml.coordinates(s[0..-2])
             end
-            xml.coordinates(s[0..-2])
           end
         end
       end
@@ -91,27 +95,29 @@ module CONVERTER
     def self.kml_tracks(xml, gpx)
       if gpx.tracks?
         gpx.tracks.each do |t|
-          xml.LineString do
-            xml.extrude('0')
-            xml.tassellate('0')
-            xml.altitudeMode('clampToGroud')
-            s = ''
-            points = []
-            t.segments.each do |sg|
-              sg.points.each do |p|
-                points = points << p
+          xml.Placemark do
+            xml.LineString do
+              xml.extrude('0')
+              xml.tassellate('0')
+              xml.altitudeMode('clampToGroud')
+              s = ''
+              points = []
+              t.segments.each do |sg|
+                sg.points.each do |p|
+                  points = points << p
+                end
               end
-            end
-            points.each do |p|
-              next if p.nil?
+              points.each do |p|
+                next if p.nil?
 
-              s = if p.elevation.nil? || p.elevation.empty?
-                    s + "#{p.latitude},#{p.longitude} "
-                  else
-                    s + "#{p.latitude},#{p.longitude},#{p.elevation} "
-                  end
+                s = if p.elevation.nil? || p.elevation.empty?
+                      s + "#{p.longitude},#{p.latitude} "
+                    else
+                      s + "#{p.longitude},#{p.latitude},#{p.elevation} "
+                    end
+              end
+              xml.coordinates(s[0..-2])
             end
-            xml.coordinates(s[0..-2])
           end
         end
       end
@@ -124,9 +130,9 @@ module CONVERTER
             xml.extrude('0')
             xml.altitudeMode('clampToGroud')
             if p.elevation.nil? || p.elevation.empty?
-              xml.coordinates("#{p.latitude},#{p.longitude}")
+              xml.coordinates("#{p.longitude},#{p.latitude}")
             else
-              xml.coordinates("#{p.latitude},#{p.longitude},#{p.elevation}")
+              xml.coordinates("#{p.longitude},#{p.latitude},#{p.elevation}")
             end
           end
         end
@@ -138,8 +144,8 @@ module CONVERTER
         kml.points.each do |p|
           next if p.nil?
 
-          xml.wpt('lat': "#{p.latitude}", 'lon': "#{p.longitude}") do
-            xml.ele("#{p.elevation}") unless p.elevation.nil? || p.elevation.empty?
+          xml.wpt('lat': p.latitude.to_s, 'lon': p.longitude.to_s) do
+            xml.ele(p.elevation.to_s) unless p.elevation.nil? || p.elevation.empty?
             xml.name(p.name) unless p.name.nil? || p.name.empty?
             xml.desc("author = #{p.author}") unless p.author.nil? || p.author.empty?
             xml.link('href': p.link) unless p.link.nil? || p.link.empty?
@@ -160,8 +166,8 @@ module CONVERTER
             r.points.each do |p|
               next if p.nil?
 
-              xml.rtept('lat': "#{p.latitude}", 'lon': "#{p.longitude}") do
-                xml.ele("#{p.elevation}") unless p.elevation.nil? || p.elevation.empty?
+              xml.rtept('lat': p.latitude.to_s, 'lon': p.longitude.to_s) do
+                xml.ele(p.elevation.to_s) unless p.elevation.nil? || p.elevation.empty?
                 xml.desc("author = #{p.author}") unless p.author.nil? || p.author.empty?
                 xml.link('href': p.link) unless p.link.nil? || p.link.empty?
               end
@@ -184,8 +190,8 @@ module CONVERTER
               t.points.each do |p|
                 next if p.nil?
 
-                xml.trkpt('lat': "#{p.latitude}", 'lon': "#{p.longitude}") do
-                  xml.ele("#{p.elevation}") unless p.elevation.nil? || p.elevation.empty?
+                xml.trkpt('lat': p.latitude.to_s, 'lon': p.longitude.to_s) do
+                  xml.ele(p.elevation.to_s) unless p.elevation.nil? || p.elevation.empty?
                   xml.desc("author = #{p.author}") unless p.author.nil? || p.author.empty?
                   xml.link('href': p.link) unless p.link.nil? || p.link.empty?
                 end

data/lib/gpx_kml/gpx.rb

@@ -33,11 +33,13 @@ module GPX
     # access in readonly to the quantity of points/routes/tracks in the gpx
     attr_reader :points_length, :routes_length, :tracks_length
 
+    def gpx?
+      !@gpx.nil? && !@gpx.xpath('/xmlns:gpx').empty?
+    end
+
     # For a gpx file to be valid it must only have a waypoint, a route or a track
     def valid?
-      return nil if @gpx.nil?
-
-      !@gpx.xpath('/xmlns:gpx').empty? && (tracks? || routes? || points?)
+      gpx? && (tracks? || routes? || points?)
     end
 
     def routes?

data/lib/gpx_kml/kml/point.rb

@@ -16,8 +16,8 @@ module KML
 
       @father = father
       coord = coord.split(',')
-      @latitude = coord[0]
-      @longitude = coord[1]
+      @longitude = coord[0]
+      @latitude = coord[1]
       @elevation = coord[2] if coord.length == 3
       @node = node
       # Name is looked up in the ancestor of the node that compose this point

data/lib/gpx_kml/kml.rb

@@ -29,10 +29,12 @@ module KML
     # access data of the kml in readonly
     attr_reader :points, :routes, :tracks
 
-    def valid?
-      return nil if @kml.nil?
+    def kml?
+      !@kml.nil? && !@kml.xpath('/xmlns:kml').empty?
+    end
 
-      !@kml.xpath('/xmlns:kml').empty? && (tracks? || routes? || points?)
+    def valid?
+      kml? && (tracks? || routes? || points?)
     end
 
     def routes?

data/lib/gpx_kml/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module GPXKML
-  VERSION = '0.1.0'
+  VERSION = '0.1.4'
 end

data/lib/gpx_kml.rb

@@ -12,12 +12,28 @@ module GPXKML
   include CONVERTER
 
   class GpxKml
-    def self.gpx_to_kml(file_path, destination_path)
-      CONVERTER::Converter.gpx_to_kml(file_path, destination_path)
+    def self.gpx_to_kml(gpx, destination_path)
+      CONVERTER::Converter.gpx_to_kml(gpx, destination_path)
     end
 
-    def self.kml_to_gpx(file_path, destination_path)
-      CONVERTER::Converter.kml_to_gpx(file_path, destination_path)
+    def self.kml_to_gpx(kml, destination_path)
+      CONVERTER::Converter.kml_to_gpx(kml, destination_path)
+    end
+
+    def self.kml?(kml)
+      kml.is_a?(KML::Kml) && kml.kml?
+    end
+
+    def self.gpx?(gpx)
+      gpx.is_a?(GPX::Gpx) && gpx.gpx?
+    end
+
+    def self.new_kml(file_path)
+      KML::Kml.new(file_path)
+    end
+
+    def self.new_gpx(file_path)
+      GPX::Gpx.new(file_path)
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gpx_kml
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.4
 platform: ruby
 authors:
 - Angelo Terzi
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-10-28 00:00:00.000000000 Z
+date: 2022-01-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -39,35 +39,35 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 1.12.0
 - !ruby/object:Gem::Dependency
-  name: factory_bot
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.2'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.2'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 0.21.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
-description: This gem adds the capability to convert GPS Exchange Format (GPX) to
-  Keyhole Markup Language (KML) and viceversa
+        version: 0.21.0
+description: This gem adds the capability to convert GPS Exchange Format (GPX) files
+  to Keyhole Markup Language (KML) files and viceversa
 email:
 - info@engim.eu
 executables: []
@@ -81,6 +81,7 @@ files:
 - CODE_OF_CONDUCT.md
 - Gemfile
 - Gemfile.lock
+- LICENSE.md
 - README.md
 - Rakefile
 - bin/console
@@ -104,7 +105,8 @@ files:
 - lib/gpx_kml/templates/wpt.gpx
 - lib/gpx_kml/version.rb
 homepage: https://www.github.com/engim-eu/gpx_kml
-licenses: []
+licenses:
+- LGNU
 metadata:
   allowed_push_host: https://rubygems.org
   homepage_uri: https://www.github.com/engim-eu/gpx_kml
@@ -125,7 +127,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.2.22
 signing_key: 
 specification_version: 4
 summary: Gem to convert .gpx into .kml and back