gpx 0.8.3 → 1.1.1

data/lib/gpx/gpx_file.rb

@@ -1,30 +1,11 @@
-#--
-# Copyright (c) 2006  Doug Fales
-#
-# Permission is hereby granted, free of charge, to any person obtaining
-# a copy of this software and associated documentation files (the
-# "Software"), to deal in the Software without restriction, including
-# without limitation the rights to use, copy, modify, merge, publish,
-# distribute, sublicense, and/or sell copies of the Software, and to
-# permit persons to whom the Software is furnished to do so, subject to
-# the following conditions:
-#
-# The above copyright notice and this permission notice shall be
-# included in all copies or substantial portions of the Software.
-#
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-#++
+# frozen_string_literal: true
+
 module GPX
   class GPXFile < Base
-    attr_accessor :tracks, :routes, :waypoints, :bounds, :lowest_point, :highest_point, :duration, :ns, :time, :name, :version, :creator, :description, :moving_duration
+    attr_accessor :tracks,
+                  :routes, :waypoints, :bounds, :lowest_point, :highest_point, :duration, :ns, :time, :name, :version, :creator, :description, :moving_duration
 
-    DEFAULT_CREATOR = "GPX RubyGem #{GPX::VERSION} -- http://dougfales.github.io/gpx/".freeze
+    DEFAULT_CREATOR = "GPX RubyGem #{GPX::VERSION} -- http://dougfales.github.io/gpx/"
 
     # This initializer can be used to create a new GPXFile from an existing
     # file or to create a new GPXFile instance with no data (so that you can
@@ -44,10 +25,14 @@ module GPX
     #         gpx_file = GPXFile.new(:tracks => [some_track])
     #
     def initialize(opts = {})
+      super()
       @duration = 0
       @attributes = {}
       @namespace_defs = []
-      if(opts[:gpx_file] or opts[:gpx_data])
+      @tracks = []
+      @time = nil
+
+      if opts[:gpx_file] || opts[:gpx_data]
         if opts[:gpx_file]
           gpx_file = opts[:gpx_file]
           gpx_file = File.open(gpx_file) unless gpx_file.is_a?(File)
@@ -59,41 +44,54 @@ module GPX
         gpx_element = @xml.at('gpx')
         @attributes = gpx_element.attributes
         @namespace_defs = gpx_element.namespace_definitions
-        #$stderr.puts gpx_element.attributes.sort.inspect
-        #$stderr.puts @xmlns.inspect
-        #$stderr.puts @xsi.inspect
         @version = gpx_element['version']
         reset_meta_data
-        bounds_element = (@xml.at("metadata/bounds") rescue nil)
+        bounds_element = (
+        begin
+          @xml.at('metadata/bounds')
+        rescue StandardError
+          nil
+        end)
         if bounds_element
-          @bounds.min_lat = get_bounds_attr_value(bounds_element, %w{ min_lat minlat minLat })
-          @bounds.min_lon = get_bounds_attr_value(bounds_element, %w{ min_lon minlon minLon})
-          @bounds.max_lat = get_bounds_attr_value(bounds_element, %w{ max_lat maxlat maxLat})
-          @bounds.max_lon = get_bounds_attr_value(bounds_element, %w{ max_lon maxlon maxLon})
+          @bounds.min_lat = get_bounds_attr_value(bounds_element, %w[min_lat minlat minLat])
+          @bounds.min_lon = get_bounds_attr_value(bounds_element, %w[min_lon minlon minLon])
+          @bounds.max_lat = get_bounds_attr_value(bounds_element, %w[max_lat maxlat maxLat])
+          @bounds.max_lon = get_bounds_attr_value(bounds_element, %w[max_lon maxlon maxLon])
         else
           get_bounds = true
         end
 
-        @time = Time.parse(@xml.at("metadata/time").inner_text) rescue nil
-        @name = @xml.at("metadata/name").inner_text rescue nil
-        @description = @xml.at('metadata/desc').inner_text rescue nil
-        @tracks = []
-        @xml.search("trk").each do |trk|
-          trk = Track.new(:element => trk, :gpx_file => self)
+        @time = begin
+          Time.parse(@xml.at('metadata/time').inner_text)
+        rescue StandardError
+          nil
+        end
+        @name = begin
+          @xml.at('metadata/name').inner_text
+        rescue StandardError
+          nil
+        end
+        @description = begin
+          @xml.at('metadata/desc').inner_text
+        rescue StandardError
+          nil
+        end
+        @xml.search('trk').each do |trk|
+          trk = Track.new(element: trk, gpx_file: self)
           update_meta_data(trk, get_bounds)
           @tracks << trk
         end
         @waypoints = []
-        @xml.search("wpt").each { |wpt| @waypoints << Waypoint.new(:element => wpt, :gpx_file => self) }
+        @xml.search('wpt').each { |wpt| @waypoints << Waypoint.new(element: wpt, gpx_file: self) }
         @routes = []
-        @xml.search("rte").each { |rte| @routes << Route.new(:element => rte, :gpx_file => self) }
-        @tracks.delete_if { |t| t.empty? }
+        @xml.search('rte').each { |rte| @routes << Route.new(element: rte, gpx_file: self) }
+        @tracks.delete_if(&:empty?)
 
         calculate_duration
       else
         reset_meta_data
-        opts.each { |attr_name, value| instance_variable_set("@#{attr_name.to_s}", value) }
-        unless(@tracks.nil? or @tracks.size.zero?)
+        opts.each { |attr_name, value| instance_variable_set("@#{attr_name}", value) }
+        unless @tracks.nil? || @tracks.empty?
           @tracks.each { |trk| update_meta_data(trk) }
           calculate_duration
         end
@@ -109,19 +107,24 @@ module GPX
         result = el[name]
         break unless result.nil?
       end
-      return (result.to_f rescue nil)
+      (
+      begin
+        result.to_f
+      rescue StandardError
+        nil
+      end)
     end
 
     # Returns the distance, in kilometers, meters, or miles, of all of the
     # tracks and segments contained in this GPXFile.
-    def distance(opts = { :units => 'kilometers' })
+    def distance(opts = { units: 'kilometers' })
       case opts[:units]
       when /kilometers/i
-        return @distance
+        @distance
       when /meters/i
-        return (@distance * 1000)
+        (@distance * 1000)
       when /miles/i
-        return (@distance * 0.62)
+        (@distance * 0.62)
       end
     end
 
@@ -129,14 +132,14 @@ module GPX
     # GPXFile.  The calculation is based on the total distance divided by the
     # sum of duration of all segments of all tracks
     # (not taking into accounting pause time).
-    def average_speed(opts = { :units => 'kilometers' })
+    def average_speed(opts = { units: 'kilometers' })
       case opts[:units]
       when /kilometers/i
-        return distance / (moving_duration/3600.0)
+        distance / (moving_duration / 3600.0)
       when /meters/i
-        return (distance * 1000) /  (moving_duration/3600.0)
+        (distance * 1000) / (moving_duration / 3600.0)
       when /miles/i
-        return (distance * 0.62) / (moving_duration/3600.0)
+        (distance * 0.62) / (moving_duration / 3600.0)
       end
     end
 
@@ -176,7 +179,7 @@ module GPX
           keep_tracks << trk
         end
       end
-      @tracks =  keep_tracks
+      @tracks = keep_tracks
       routes.each { |rte| rte.delete_area(area) }
       waypoints.each { |wpt| wpt.delete_area(area) }
     end
@@ -191,13 +194,15 @@ module GPX
       @moving_duration = 0.0
     end
 
+    # rubocop:disable Style/OptionalBooleanParameter
+
     # Updates the meta data for this GPX file.  Meta data includes the
     # bounds, the high and low points, and the distance.  This is useful when
     # you modify the GPX data (i.e. by adding or deleting points) and you
     # want the meta data to accurately reflect the new data.
     def update_meta_data(trk, get_bounds = true)
-      @lowest_point   = trk.lowest_point if(@lowest_point.nil? or (!trk.lowest_point.nil? and trk.lowest_point.elevation < @lowest_point.elevation))
-      @highest_point  = trk.highest_point if(@highest_point.nil? or (!trk.highest_point.nil? and trk.highest_point.elevation > @highest_point.elevation))
+      @lowest_point = trk.lowest_point if @lowest_point.nil? || (!trk.lowest_point.nil? && (trk.lowest_point.elevation < @lowest_point.elevation))
+      @highest_point = trk.highest_point if @highest_point.nil? || (!trk.highest_point.nil? && (trk.highest_point.elevation > @highest_point.elevation))
       @bounds.add(trk.bounds) if get_bounds
       @distance += trk.distance
       @moving_duration += trk.moving_duration
@@ -206,17 +211,18 @@ module GPX
     # Serialize the current GPXFile to a gpx file named <filename>.
     # If the file does not exist, it is created.  If it does exist, it is overwritten.
     def write(filename, update_time = true)
-      @time = Time.now if(@time.nil? or update_time)
+      @time = Time.now if @time.nil? || update_time
       @name ||= File.basename(filename)
       doc = generate_xml_doc
       File.open(filename, 'w+') { |f| f.write(doc.to_xml) }
     end
 
     def to_s(update_time = true)
-      @time = Time.now if(@time.nil? or update_time)
+      @time = Time.now if @time.nil? || update_time
       doc = generate_xml_doc
       doc.to_xml
     end
+    # rubocop:enable Style/OptionalBooleanParameter
 
     def inspect
       "<#{self.class.name}:...>"
@@ -231,117 +237,117 @@ module GPX
     end
 
     private
+
     def attributes_and_nsdefs_as_gpx_attributes
-      #$stderr.puts @namespace_defs.inspect
+      # $stderr.puts @namespace_defs.inspect
       gpx_header = {}
-      @attributes.each do |k,v|
-        k = v.namespace.prefix + ':' + k if v.namespace
+      @attributes.each do |k, v|
+        k = "#{v.namespace.prefix}:#{k}" if v.namespace
         gpx_header[k] = v.value
-      end 
+      end
 
       @namespace_defs.each do |nsd|
         tag = 'xmlns'
-        if nsd.prefix
-          tag += ':' + nsd.prefix
-        end
+        tag += ":#{nsd.prefix}" if nsd.prefix
         gpx_header[tag] = nsd.href
       end
-      return gpx_header
+      gpx_header
     end
- 
+
     def generate_xml_doc
       @version ||= '1.1'
-      version_dir = version.gsub('.','/')
+      version_dir = version.tr('.', '/')
 
       gpx_header = attributes_and_nsdefs_as_gpx_attributes
-      
-      gpx_header['version'] = @version.to_s if !gpx_header['version']
-      gpx_header['creator'] = DEFAULT_CREATOR if !gpx_header['creator']
-      gpx_header['xsi:schemaLocation'] = "http://www.topografix.com/GPX/#{version_dir} http://www.topografix.com/GPX/#{version_dir}/gpx.xsd" if !gpx_header['xsi:schemaLocation']
-      gpx_header['xmlns:xsi'] = "http://www.w3.org/2001/XMLSchema-instance" if !gpx_header['xsi'] and !gpx_header['xmlns:xsi']
-      
-      #$stderr.puts gpx_header.keys.inspect
-
-      doc = Nokogiri::XML::Builder.new do |xml|
-        xml.gpx(gpx_header) \
-        {
-            # version 1.0 of the schema doesn't support the metadata element, so push them straight to the root 'gpx' element
-            if (@version == '1.0') then
+
+      gpx_header['version'] = @version.to_s unless gpx_header['version']
+      gpx_header['creator'] = DEFAULT_CREATOR unless gpx_header['creator']
+      gpx_header['xsi:schemaLocation'] = "http://www.topografix.com/GPX/#{version_dir} http://www.topografix.com/GPX/#{version_dir}/gpx.xsd" unless gpx_header['xsi:schemaLocation']
+      gpx_header['xmlns:xsi'] = 'http://www.w3.org/2001/XMLSchema-instance' if !gpx_header['xsi'] && !gpx_header['xmlns:xsi']
+
+      # $stderr.puts gpx_header.keys.inspect
+
+      # rubocop:disable Metrics/BlockLength
+      Nokogiri::XML::Builder.new(encoding: 'UTF-8') do |xml|
+        xml.gpx(gpx_header) do
+          # version 1.0 of the schema doesn't support the metadata element, so push them straight to the root 'gpx' element
+          if @version == '1.0'
+            xml.name @name
+            xml.time @time.xmlschema
+            xml.bound(
+              minlat: bounds.min_lat,
+              minlon: bounds.min_lon,
+              maxlat: bounds.max_lat,
+              maxlon: bounds.max_lon
+            )
+          else
+            xml.metadata do
               xml.name @name
               xml.time @time.xmlschema
               xml.bound(
                 minlat: bounds.min_lat,
                 minlon: bounds.min_lon,
                 maxlat: bounds.max_lat,
-                maxlon: bounds.max_lon,
+                maxlon: bounds.max_lon
               )
-            else
-              xml.metadata {
-                xml.name @name
-                xml.time @time.xmlschema
-                xml.bound(
-                  minlat: bounds.min_lat,
-                  minlon: bounds.min_lon,
-                  maxlat: bounds.max_lat,
-                  maxlon: bounds.max_lon,
-                )
-              }
             end
+          end
+
+          tracks&.each do |t|
+            xml.trk do
+              xml.name t.name
 
-            tracks.each do |t|
-              xml.trk {
-                xml.name t.name
-
-                t.segments.each do |seg|
-                  xml.trkseg {
-                    seg.points.each do |p|
-                      xml.trkpt(lat: p.lat, lon: p.lon) {
-                        xml.time p.time.xmlschema unless p.time.nil?
-                        xml.ele p.elevation unless p.elevation.nil?
-                        xml << p.extensions.to_xml unless p.extensions.nil?
-                      }
+              t.segments.each do |seg|
+                xml.trkseg do
+                  seg.points.each do |p|
+                    xml.trkpt(lat: p.lat, lon: p.lon) do
+                      xml.time p.time.xmlschema unless p.time.nil?
+                      xml.ele p.elevation unless p.elevation.nil?
+                      xml << p.extensions.to_xml unless p.extensions.nil?
                     end
-                  }
+                  end
                 end
-              }
-            end unless tracks.nil?
-
-            waypoints.each do |w|
-              xml.wpt(lat: w.lat, lon: w.lon) {
-                xml.time w.time.xmlschema unless w.time.nil?
-                Waypoint::SUB_ELEMENTS.each do |sub_elem|
-                  xml.send(sub_elem, w.send(sub_elem)) if w.respond_to?(sub_elem) && !w.send(sub_elem).nil?
-                end
-              }
-            end unless waypoints.nil?
-
-            routes.each do |r|
-              xml.rte {
-                xml.name r.name
-
-                r.points.each do |p|
-                  xml.rtept(lat: p.lat, lon: p.lon) {
-                    xml.time p.time.xmlschema unless p.time.nil?
-                    xml.ele p.elevation unless p.elevation.nil?
-                  }
+              end
+            end
+          end
+
+          waypoints&.each do |w|
+            xml.wpt(lat: w.lat, lon: w.lon) do
+              xml.time w.time.xmlschema unless w.time.nil?
+              Waypoint::SUB_ELEMENTS.each do |sub_elem|
+                xml.send(sub_elem, w.send(sub_elem)) if w.respond_to?(sub_elem) && !w.send(sub_elem).nil?
+              end
+            end
+          end
+
+          routes&.each do |r|
+            xml.rte do
+              xml.name r.name
+
+              r.points.each do |p|
+                xml.rtept(lat: p.lat, lon: p.lon) do
+                  xml.time p.time.xmlschema unless p.time.nil?
+                  xml.ele p.elevation unless p.elevation.nil?
                 end
-              }
-            end unless routes.nil?
-          }
+              end
+            end
+          end
+        end
       end
-
-      return doc
+      # rubocop:enable Metrics/BlockLength
     end
 
     # Calculates and sets the duration attribute by subtracting the time on
     # the very first point from the time on the very last point.
     def calculate_duration
       @duration = 0
-      if(@tracks.nil? or @tracks.size.zero? or @tracks[0].segments.nil? or @tracks[0].segments.size.zero?)
+      if @tracks.nil? || @tracks.empty? || @tracks[0].segments.nil? || @tracks[0].segments.empty?
         return @duration
+
       end
+
       @duration = (@tracks[-1].segments[-1].points[-1].time - @tracks.first.segments.first.points.first.time)
-    rescue
+    rescue StandardError
       @duration = 0
     end
   end

data/lib/gpx/magellan_track_log.rb

@@ -1,30 +1,10 @@
-#--
-# Copyright (c) 2006  Doug Fales
-#
-# Permission is hereby granted, free of charge, to any person obtaining
-# a copy of this software and associated documentation files (the
-# "Software"), to deal in the Software without restriction, including
-# without limitation the rights to use, copy, modify, merge, publish,
-# distribute, sublicense, and/or sell copies of the Software, and to
-# permit persons to whom the Software is furnished to do so, subject to
-# the following conditions:
-#
-# The above copyright notice and this permission notice shall be
-# included in all copies or substantial portions of the Software.
-#
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-#++
+# frozen_string_literal: true
+
 module GPX
   # This class will parse the lat/lon and time data from a Magellan track log,
   # which is a NMEA formatted CSV list of points.
   class MagellanTrackLog
-    #PMGNTRK
+    # PMGNTRK
     # This message is to be used to transmit Track information (basically a list of previous position fixes)
     # which is often displayed on the plotter or map screen of the unit.  The first field in this message
     # is the Latitude, followed by N or S.  The next field is the Longitude followed by E or W.  The next
@@ -35,98 +15,86 @@ module GPX
     # of the fix.  Note that this field is (and its preceding comma) is only produced by the unit when the
     # command PMGNCMD,TRACK,2 is given.  It is not present when a simple command of PMGNCMD,TRACK is issued.
 
-    #NOTE: The Latitude and Longitude Fields are shown as having two decimal
+    # NOTE: The Latitude and Longitude Fields are shown as having two decimal
     # places. As many additional decimal places may be added as long as the total
     # length of the message does not exceed 82 bytes.
 
     # $PMGNTRK,llll.ll,a,yyyyy.yy,a,xxxxx,a,hhmmss.ss,A,c----c,ddmmyy*hh<CR><LF>
     require 'csv'
 
-    LAT       = 1
-    LAT_HEMI  = 2
-    LON       = 3
-    LON_HEMI  = 4
-    ELE       = 5
+    LAT = 1
+    LAT_HEMI = 2
+    LON = 3
+    LON_HEMI = 4
+    ELE = 5
     ELE_UNITS = 6
-    TIME      = 7
+    TIME = 7
     INVALID_FLAG = 8
-    DATE      = 10
+    DATE = 10
 
     FEET_TO_METERS = 0.3048
 
     class << self
-
       # Takes the name of a magellan file, converts the contents to GPX, and
       # writes the result to gpx_filename.
       def convert_to_gpx(magellan_filename, gpx_filename)
-
         segment = Segment.new
 
-        CSV.open(magellan_filename, "r").each do |row|
-          next if(row.size < 10 or row[INVALID_FLAG] == 'V')
+        CSV.open(magellan_filename, 'r').each do |row|
+          next if (row.size < 10) || (row[INVALID_FLAG] == 'V')
 
-          lat_deg  = row[LAT][0..1]
-          lat_min  = row[LAT][2...-1]
+          lat_deg = row[LAT][0..1]
+          lat_min = row[LAT][2...-1]
           lat_hemi = row[LAT_HEMI]
 
           lat = lat_deg.to_f + (lat_min.to_f / 60.0)
-          lat = (-lat) if(lat_hemi == 'S')
+          lat = -lat if lat_hemi == 'S'
 
-          lon_deg      = row[LON][0..2]
-          lon_min  = row[LON][3..-1]
+          lon_deg = row[LON][0..2]
+          lon_min = row[LON][3..]
           lon_hemi = row[LON_HEMI]
 
           lon = lon_deg.to_f + (lon_min.to_f / 60.0)
-          lon = (-lon) if(lon_hemi == 'W')
-
+          lon = -lon if lon_hemi == 'W'
 
           ele = row[ELE]
           ele_units = row[ELE_UNITS]
           ele = ele.to_f
-          if(ele_units == 'F')
-            ele *= FEET_TO_METERS
-          end
+          ele *= FEET_TO_METERS if ele_units == 'F'
 
-          hrs  = row[TIME][0..1].to_i
+          hrs = row[TIME][0..1].to_i
           mins = row[TIME][2..3].to_i
           secs = row[TIME][4..5].to_i
-          day  = row[DATE][0..1].to_i
-          mon  = row[DATE][2..3].to_i
-          yr   = 2000 + row[DATE][4..5].to_i
+          day = row[DATE][0..1].to_i
+          mon = row[DATE][2..3].to_i
+          yr = 2000 + row[DATE][4..5].to_i
 
           time = Time.gm(yr, mon, day, hrs, mins, secs)
 
-          #must create point
-          pt = TrackPoint.new(:lat => lat, :lon => lon, :time => time, :elevation => ele)
+          # must create point
+          pt = TrackPoint.new(lat: lat, lon: lon, time: time, elevation: ele)
           segment.append_point(pt)
-
         end
 
         trk = Track.new
         trk.append_segment(segment)
-        gpx_file = GPXFile.new(:tracks => [trk])
+        gpx_file = GPXFile.new(tracks: [trk])
         gpx_file.write(gpx_filename)
-
       end
 
       # Tests to see if the given file is a magellan NMEA track log.
-      def is_magellan_file?(filename)
+      def magellan_file?(filename)
         i = 0
-        File.open(filename, "r") do |f|
+        File.open(filename, 'r') do |f|
           f.each do |line|
-            i +=  1
-            if line =~ /^\$PMGNTRK/
-              return true
-            elsif line =~ /<\?xml/
-              return false
-            elsif(i > 10)
-              return false
-            end
+            i += 1
+            return true if line =~ /^\$PMGNTRK/
+            return false if line =~ /<\?xml/
+            return false if i > 10
           end
         end
-        return false
+        false
       end
     end
-
   end
 end

data/lib/gpx/point.rb

@@ -1,46 +1,35 @@
-#--
-# Copyright (c) 2006  Doug Fales
-#
-# Permission is hereby granted, free of charge, to any person obtaining
-# a copy of this software and associated documentation files (the
-# "Software"), to deal in the Software without restriction, including
-# without limitation the rights to use, copy, modify, merge, publish,
-# distribute, sublicense, and/or sell copies of the Software, and to
-# permit persons to whom the Software is furnished to do so, subject to
-# the following conditions:
-#
-# The above copyright notice and this permission notice shall be
-# included in all copies or substantial portions of the Software.
-#
-# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-#++
+# frozen_string_literal: true
+
 module GPX
   # The base class for all points.  Trackpoint and Waypoint both descend from this base class.
   class Point < Base
-    D_TO_R = Math::PI/180.0;
-    attr_accessor :lat, :lon, :time, :elevation, :gpx_file, :speed, :extensions
+    D_TO_R = Math::PI / 180.0
+    attr_accessor :time, :elevation, :gpx_file, :speed, :extensions
+    attr_reader :lat, :lon
 
     # When you need to manipulate individual points, you can create a Point
     # object with a latitude, a longitude, an elevation, and a time.  In
     # addition, you can pass an XML element to this initializer, and the
     # relevant info will be parsed out.
-    def initialize(opts = {:lat => 0.0, :lon => 0.0, :elevation => 0.0, :time => Time.now } )
+    def initialize(opts = { lat: 0.0, lon: 0.0, elevation: 0.0, time: Time.now })
+      super()
       @gpx_file = opts[:gpx_file]
-      if (opts[:element])
+      if opts[:element]
         elem = opts[:element]
-        @lat, @lon = elem["lat"].to_f, elem["lon"].to_f
-        @latr, @lonr = (D_TO_R * @lat), (D_TO_R * @lon)
-        #'-'? yyyy '-' mm '-' dd 'T' hh ':' mm ':' ss ('.' s+)? (zzzzzz)?
-        @time = (Time.xmlschema(elem.at("time").inner_text) rescue nil)
-        @elevation = elem.at("ele").inner_text.to_f unless elem.at("ele").nil?
-        @speed = elem.at("speed").inner_text.to_f unless elem.at("speed").nil?
-        @extensions = elem.at("extensions") unless elem.at("extensions").nil?
+        @lat = elem['lat'].to_f
+        @lon = elem['lon'].to_f
+        @latr = (D_TO_R * @lat)
+        @lonr = (D_TO_R * @lon)
+        # '-'? yyyy '-' mm '-' dd 'T' hh ':' mm ':' ss ('.' s+)? (zzzzzz)?
+        @time = (
+        begin
+          Time.xmlschema(elem.at('time').inner_text)
+        rescue StandardError
+          nil
+        end)
+        @elevation = elem.at('ele').inner_text.to_f unless elem.at('ele').nil?
+        @speed = elem.at('speed').inner_text.to_f unless elem.at('speed').nil?
+        @extensions = elem.at('extensions') unless elem.at('extensions').nil?
       else
         @lat = opts[:lat]
         @lon = opts[:lon]
@@ -49,10 +38,8 @@ module GPX
         @speed = opts[:speed]
         @extensions = opts[:extensions]
       end
-
     end
 
-
     # Returns the latitude and longitude (in that order), separated by the
     # given delimeter.  This is useful for passing a point into another API
     # (i.e. the Google Maps javascript API).