govuk_tech_docs 2.0.9 → 2.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f7709b58fc3cee254691d4c894c58ee3cb273a9f4ab1261ee14601017af55e90
-  data.tar.gz: 63caab96ff45ca3724abb714d309bcc9ef07dc4f9151c1fec6d850095eaf4ab3
+  metadata.gz: a5cb57539ae552c6d1e24f8975a0f86171c2f88b0ec8584fa409067b8dadfe46
+  data.tar.gz: ded8edc17245592306e4d9330c0feb974daa471d873d773e9f19f2b1c07b6bf3
 SHA512:
-  metadata.gz: 645fb6043c122b389a0c89f37f7df17b41a0e8d019e576f141a93b424622aab11eecfc123cad8d83593379bfbf1943ad104aa4bdc652f76954679f2366678087
-  data.tar.gz: 6c8f05e3b7f36e94e08d696ea50444e8459835f078714f094e2d70f0f1c1e8672e67dfe73563e2ad44f87fd1923f987211c3cecbd456f092dd0da3c6269a9fed
+  metadata.gz: b9250bfe4da754f495df7f2b4f3c1c2066f85db1e9a8d15cb7b9c646a031fce10541fe43ef68964f09d03c0a636fd79c4024224bc109d083fc2bec894ee1ab62
+  data.tar.gz: 01ccc6902089cc61a1cc8a820e2ac22b526a96011a2f0c77d6b8a381d4af44019741da0c9e014715c2637a0fee1d2d39ebf32fdbddc1e37ab39af7d537029b60

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## 2.0.10
+
+- [Pull request #160: Make sure IDs on collapsible navigation are unique](https://github.com/alphagov/tech-docs-gem/pull/160)
+
 ## 2.0.9
 
 ### Fixes

data/example/source/nested-page/another-nested-nested-page/index.html.md

@@ -0,0 +1,5 @@
+---
+title: Another nested nested page
+---
+
+# Another nested nested page

data/lib/assets/javascripts/_modules/collapsible-navigation.js

@@ -28,11 +28,16 @@
           continue
         }
         $topLevelItem.addClass('collapsible')
-        $listing.addClass('collapsible__body')
-          .attr('id', id)
-          .attr('aria-expanded', 'false')
+        var arrayOfIds = []
+        $listing.each(function (i) {
+          var uniqueId = id + '-' + i
+          arrayOfIds.push(uniqueId)
+          $(this).addClass('collapsible__body')
+            .attr('id', uniqueId)
+            .attr('aria-expanded', 'false')
+        })
         $heading.addClass('collapsible__heading')
-          .after('<button class="collapsible__toggle" aria-controls="' + id + '"><span class="collapsible__toggle-label">Expand ' + $heading.text() + '</span><span class="collapsible__toggle-icon" aria-hidden="true"></button>')
+          .after('<button class="collapsible__toggle" aria-controls="' + arrayOfIds.join(' ') + '"><span class="collapsible__toggle-label">Expand ' + $heading.text() + '</span><span class="collapsible__toggle-icon" aria-hidden="true"></button>')
         $topLevelItem.on('click', '.collapsible__toggle', function (e) {
           e.preventDefault()
           var $parent = $(this).parent()

data/lib/govuk_tech_docs/version.rb

@@ -1,3 +1,3 @@
 module GovukTechDocs
-  VERSION = "2.0.9".freeze
+  VERSION = "2.0.10".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: govuk_tech_docs
 version: !ruby/object:Gem::Version
-  version: 2.0.9
+  version: 2.0.10
 platform: ruby
 authors:
 - Government Digital Service
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-11-14 00:00:00.000000000 Z
+date: 2019-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -358,6 +358,7 @@ files:
 - example/source/hidden-page.html.md
 - example/source/index.html.md.erb
 - example/source/javascripts/application.js
+- example/source/nested-page/another-nested-nested-page/index.html.md
 - example/source/nested-page/another-nested-page/index.html.md
 - example/source/nested-page/index.html.md
 - example/source/not-expired-page.html.md