govuk_publishing_components 51.1.1 → 51.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7b340b1565779a9e7ae1a1c56063a386e1083cad425b65b5b77313233767bf48
-  data.tar.gz: ee7fd33d63fd4a00e2d8820637c859153d49047040df417453274eec0a81f048
+  metadata.gz: c50d14be7610561ed91341a0824caa29b9c767d839acb2c6f7c65b5f58514ac4
+  data.tar.gz: d8bd8854736387adecda29ca77c0f31af6b7e5f0d8123c30c4b9fa5223e2530e
 SHA512:
-  metadata.gz: 20d167ef2111b13c7e9c97b6e2171cd85c426a713269e32c5cdc5b51459b1c14782a3975f1481e29046656461aa74f819f198e9edfb73750afd3a9774339d960
-  data.tar.gz: 185782d6c5e7b10409bdd9a6dfc60c063bde552d9ecf2d3c8eede100a230feb189e1add437a927786dce35ad667a503b9f835153286a145fb5aea05358700ac8
+  metadata.gz: 8a3fd0fbac03888e39e3aecd3adcc1c69dd9c1f3b179f8eeb853c14cb3edbea20df8593a00126fc3d23fa3b550af45746f6b42679a145287abf31b92e20886a1
+  data.tar.gz: e26f92b617d944bee8ffaee93c200eef6bf1b8596c946092e5646f4862d9043a7c4ba26e9d784ce4f0445cda143ef57f27003c94275b2c2423e8117a743553de

data/app/assets/javascripts/govuk_publishing_components/components/feedback.js

@@ -69,40 +69,35 @@ window.GOVUK.Modules = window.GOVUK.Modules || {};
       }.bind(this), 1000)
     }.bind(this))
 
-    // much of the JS needed to support sending the form contents via this script is
-    // unsupported by IE, even IE11. This check causes IE to not intercept form submits
-    // and let them happen normally, which is handled already by the backend
-    if (typeof window.URLSearchParams === 'function') {
-      for (var f = 0; f < this.forms.length; f++) {
-        this.forms[f].addEventListener('submit', function (e) {
-          e.preventDefault()
-          var $form = e.target
-          var xhr = new XMLHttpRequest()
-          var url = $form.getAttribute('action')
-          var params = new FormData($form)
-          params = new URLSearchParams(params).toString()
-
-          this.done = function () {
-            if (xhr.status === 200) {
-              this.showFormSuccess(xhr.message)
-              this.revealInitialPrompt()
-              this.setInitialAriaAttributes()
-              this.activeForm.hidden = true
-              clearInterval(this.timerInterval)
-            } else {
-              this.showError(xhr)
-              this.enableSubmitFormButton($form)
-            }
-          }.bind(this)
-
-          xhr.addEventListener('loadend', this.done)
-          xhr.open('POST', url, true)
-          xhr.setRequestHeader('Content-type', 'application/x-www-form-urlencoded')
-
-          this.disableSubmitFormButton($form)
-          xhr.send(params)
-        }.bind(this))
-      }
+    for (var f = 0; f < this.forms.length; f++) {
+      this.forms[f].addEventListener('submit', function (e) {
+        e.preventDefault()
+        var $form = e.target
+        var xhr = new XMLHttpRequest()
+        var url = $form.getAttribute('action')
+        var params = new FormData($form)
+        params = new URLSearchParams(params).toString()
+
+        this.done = function () {
+          if (xhr.status === 200) {
+            this.showFormSuccess(xhr.message)
+            this.revealInitialPrompt()
+            this.setInitialAriaAttributes()
+            this.activeForm.hidden = true
+            clearInterval(this.timerInterval)
+          } else {
+            this.showError(xhr)
+            this.enableSubmitFormButton($form)
+          }
+        }.bind(this)
+
+        xhr.addEventListener('loadend', this.done)
+        xhr.open('POST', url, true)
+        xhr.setRequestHeader('Content-type', 'application/x-www-form-urlencoded')
+
+        this.disableSubmitFormButton($form)
+        xhr.send(params)
+      }.bind(this))
     }
   }
 

data/app/assets/javascripts/govuk_publishing_components/vendor/lux/lux-reporter.js

@@ -336,7 +336,7 @@
     return str;
   }
 
-  var VERSION = "4.0.29";
+  var VERSION = "4.0.30";
   /**
   * Returns the version of the script as a float to be stored in legacy systems that do not support
   * string versions.
@@ -622,6 +622,10 @@
   }
   var MAX_SELECTOR_LENGTH = 100;
   function getNodeSelector(node, selector) {
+    if (selector === void 0) { selector = ""; }
+    return _getNodeSelector(node, selector).slice(0, MAX_SELECTOR_LENGTH);
+  }
+  function _getNodeSelector(node, selector) {
     if (selector === void 0) { selector = ""; }
     try {
       if (selector &&
@@ -668,6 +672,7 @@
   var sessionAttributions = [];
   var largestEntry;
   var maximumSessionValue = 0;
+  var MAX_CLS_SOURCES = 50;
   function processEntry$2(entry) {
     if (!entry.hadRecentInput) {
       var firstEntry = sessionEntries[0];
@@ -717,7 +722,7 @@
         startTime: processTimeMetric(largestEntry.startTime),
       }
       : null,
-      sources: sessionAttributions.length ? sessionAttributions : null,
+      sources: sessionAttributions.length ? sessionAttributions.slice(0, MAX_CLS_SOURCES) : null,
     };
   }
 

data/app/assets/stylesheets/component_guide/application.scss

@@ -116,7 +116,7 @@ $gem-guide-border-width: 1px;
 }
 
 .component-guide-preview {
-  padding: ($govuk-gutter * 1.5) $govuk-gutter $govuk-gutter;
+  padding: $govuk-gutter;
   border: $gem-guide-border-width solid $govuk-border-colour;
   position: relative;
 

data/app/assets/stylesheets/govuk_publishing_components/_all_components.scss

@@ -38,6 +38,7 @@
 @import "components/fieldset";
 @import "components/file-upload";
 @import "components/glance-metric";
+@import "components/global-banner";
 @import "components/govspeak-html-publication";
 @import "components/govspeak";
 @import "components/heading";

data/app/assets/stylesheets/govuk_publishing_components/components/helpers/_markdown-typography.scss

@@ -31,12 +31,11 @@
 
   h2 {
     margin-top: $govuk-gutter;
-    margin-bottom: 0;
+    margin-bottom: govuk-spacing(4);
     @include govuk-font($size: 27, $weight: bold);
 
     @include govuk-media-query($from: desktop) {
       margin-top: $govuk-gutter * 1.5;
-      margin-bottom: 0;
     }
   }
 
@@ -77,6 +76,7 @@
   a {
     @include govuk-link-common;
     @include govuk-link-style-default;
+    @include govuk-text-break-word;
 
     &:focus {
       @include govuk-focused-text;

data/app/models/govuk_publishing_components/audit_comparer.rb

@@ -182,7 +182,7 @@ module GovukPublishingComponents
       warnings = []
 
       locations.each do |location|
-        next if location[:location] == "template" || location[:location] == "ruby"
+        next if %w[template ruby].include?(location[:location])
 
         location[:components].each do |component|
           raise_warning = asset_already_in_static(location[:location], component)
@@ -196,14 +196,14 @@ module GovukPublishingComponents
     def warn_about_missing_assets(components)
       warnings = []
 
-      code = components.select { |c| c[:location] == "template" || c[:location] == "ruby" }
+      code = components.select { |c| %w[template ruby].include?(c[:location]) }
       code = [
         {
           location: "code",
           components: code.map { |c| c[:components] }.flatten.uniq.sort,
         },
       ]
-      assets = components.select { |c| c[:location] == "stylesheet" || c[:location] == "javascript" }
+      assets = components.select { |c| %w[stylesheet javascript].include?(c[:location]) }
 
       warnings << find_missing_items(code, assets)
       warnings << find_missing_items(assets, code)

data/app/views/govuk_publishing_components/components/_title.html.erb

@@ -9,12 +9,11 @@
 
   inverse ||= false
   local_assigns[:margin_bottom] ||= 8
-
-  shared_helper = GovukPublishingComponents::Presenters::SharedHelper.new(local_assigns)
+  margin_bottom = [*0..9].include?(local_assigns[:margin_bottom]) ? "govuk-!-margin-bottom-#{local_assigns[:margin_bottom]}" : "govuk-!-margin-bottom-3"
 
   classes = %w[gem-c-title]
   classes << "gem-c-title--inverse" if inverse
-  classes << shared_helper.get_margin_bottom
+  classes << margin_bottom
 
   heading_classes = %w[gem-c-title__text]
   heading_classes << (average_title_length.present? ? 'govuk-heading-l' : 'govuk-heading-xl')

data/app/views/govuk_publishing_components/components/docs/add_another.yml

@@ -35,7 +35,7 @@ examples:
               <input class="gem-c-input govuk-input" id="person_0_name" name="person[0]name">
             </div>
           destroy_checkbox: >
-            <div class="govuk-checkboxes" data-module="govuk-checkboxes" data-govuk-checkboxes-init="">
+            <div class="govuk-checkboxes" data-module="govuk-checkboxes">
               <div class="govuk-checkboxes__item">
                 <input type="checkbox" name="person[0][_destroy]" id="person_0__destroy" class="govuk-checkboxes__input">
                 <label for="person_0__destroy" class="govuk-label govuk-checkboxes__label">Delete</label>

data/app/views/govuk_publishing_components/components/docs/feedback.yml

@@ -3,7 +3,7 @@ description: Invites user feedback on the current page.
 body: |
   This component is designed to sit at the bottom of pages on GOV.UK to allow users to submit feedback on that page.
 
-  This component uses JavaScript for expanding and collapsing and also for submitting form responses. This code is not compatible with Internet Explorer, so IE11 and down do not use JavaScript to submit the forms, instead falling back to a normal form submission.
+  This component uses JavaScript for expanding and collapsing and also for submitting form responses. Users without JavaScript will fall back to a normal form submission.
 uses_component_wrapper_helper: true
 accessibility_criteria: |
   The form must:

data/lib/govuk_publishing_components/presenters/checkboxes_helper.rb

@@ -34,7 +34,7 @@ module GovukPublishingComponents
         @is_page_heading = options[:is_page_heading]
         @description = options[:description] || nil
         @no_hint_text = options[:no_hint_text]
-        @hint_text = options[:hint_text] || "Select all that apply." unless @no_hint_text
+        @hint_text = options[:hint_text] || "Select all that apply" unless @no_hint_text
         @visually_hide_heading = options[:visually_hide_heading]
       end
 

data/lib/govuk_publishing_components/presenters/shared_helper.rb

@@ -7,17 +7,6 @@ module GovukPublishingComponents
         @options = local_assigns
         @margin_bottom = @options[:margin_bottom] || 3
         @heading_level = @options[:heading_level] || 2
-
-        if local_assigns.include?(:classes)
-          @classes = local_assigns[:classes].split(" ")
-          unless @classes.all? { |c| c.start_with?("js-") }
-            raise(ArgumentError, "Passed classes must be prefixed with `js-`")
-          end
-        end
-      end
-
-      def get_margin_bottom
-        [*0..9].include?(@margin_bottom) ? "govuk-!-margin-bottom-#{margin_bottom}" : "govuk-!-margin-bottom-3"
       end
 
       def get_heading_level

data/lib/govuk_publishing_components/version.rb

@@ -1,3 +1,3 @@
 module GovukPublishingComponents
-  VERSION = "51.1.1".freeze
+  VERSION = "51.2.1".freeze
 end