govuk_publishing_components 38.3.1 → 38.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 174edc8aff1507967b48ea3efcec2a79d56c22adbf64f5414d2d758603fb0ef5
-  data.tar.gz: 0ce85ca601099c9341c2e956fef04e5fb1dbea78ffdc298a997e287423d21c8e
+  metadata.gz: e7ea0b6a93379ec1e7cb8e5b7194c5cc16e237129cdbe224b9a099d79f4ca7ff
+  data.tar.gz: 567e2f625bd4b773a48f56c13c15d383f4fcdba5c44c9369ae327b8cf5772419
 SHA512:
-  metadata.gz: d47f8dd957ff9d95f2c118aa7d747e4c43ef7dbf95dc80636d6c2583e925235370ca0f246d1be53bb83bf8bf90633e46e859c79fadf303779a886567c76e1528
-  data.tar.gz: 9e38d46ac5722147f3f48ffecb1d5d08b3ae93ca4117c48792a3e8903561a84947e7c1d5e32d3d66ef1413519bf7c30e8bb8424b54d2af0b3d005c5cd93a6bca
+  metadata.gz: 4b0bd17834a7658027b98c43cf2b2514f4bdb3ee06974e21bd27932a81e4f4ce4a7785468623d92511026e8773ae9af78dccca88c3c1ba0ba88ee89ff06b81aa
+  data.tar.gz: 1544edbfac9e4d2f5723f220aadd5619b86ff3386dae982d6b53ee9d8e20ba264a52f54ee44a6194b9ae912d8f0684d2a20bd3f0ff33d8d0775ca09cae3b8d86

data/app/assets/javascripts/govuk_publishing_components/components/feedback.js

@@ -26,7 +26,7 @@ window.GOVUK.Modules = window.GOVUK.Modules || {};
   Feedback.prototype.init = function () {
     this.setInitialAriaAttributes()
     this.setHiddenValues()
-
+    this.setSurveyPath()
     this.prompt.hidden = false
     for (var k = 0; k < this.promptQuestions.length; k++) {
       this.promptQuestions[k].hidden = false
@@ -151,6 +151,21 @@ window.GOVUK.Modules = window.GOVUK.Modules || {};
     this.somethingIsWrongForm.appendChild(this.timerHoneyPot)
   }
 
+  // This getter is needed for spyOn in tests
+  Feedback.prototype.getPagePath = function () {
+    return window.location.pathname
+  }
+
+  Feedback.prototype.setSurveyPath = function () {
+    var surveyLink = this.$module.querySelector('#survey_explanation a')
+
+    if (surveyLink) {
+      var pathWithoutEmailPII = this.getPagePath().replace(/[^\s=?&]+(?:@|%40)[^\s=?&]+/, '[email]')
+      var encodedPath = encodeURI(pathWithoutEmailPII)
+      surveyLink.setAttribute('href', 'https://www.smartsurvey.co.uk/s/gov-uk-banner/?c=' + encodedPath)
+    }
+  }
+
   Feedback.prototype.updateAriaAttributes = function (linkClicked) {
     linkClicked.setAttribute('aria-expanded', true)
   }

data/app/assets/javascripts/govuk_publishing_components/modules.js

@@ -36,15 +36,20 @@
           var moduleName = camelCaseAndCapitalise(moduleNames[j])
           var started = element.getAttribute('data-' + moduleNames[j] + '-module-started')
           if (typeof GOVUK.Modules[moduleName] === 'function' && !started) {
-            // Vanilla JavaScript GOV.UK Modules and GOV.UK Frontend Modules
-            if (GOVUK.Modules[moduleName].prototype.init) {
-              try {
+            try {
+              if (GOVUK.Modules[moduleName].prototype.init) {
+                // Vanilla JavaScript GOV.UK Modules and GOV.UK Frontend V4 Modules
                 new GOVUK.Modules[moduleName](element).init()
-                element.setAttribute('data-' + moduleNames[j] + '-module-started', true)
-              } catch (e) {
-                // if there's a problem with the module, catch the error to allow other modules to start
-                console.error('Error starting ' + moduleName + ' component JS: ', e, window.location)
+              } else {
+                // GOV.UK Frontend V5 Modules - removed component init() methods and initialise in constructor
+                // https://github.com/alphagov/govuk-design-system-architecture/blob/main/decision-records/010-remove-init-method.md
+                /* eslint-disable no-new */
+                new GOVUK.Modules[moduleName](element)
               }
+              element.setAttribute('data-' + moduleNames[j] + '-module-started', true)
+            } catch (e) {
+              // if there's a problem with the module, catch the error to allow other modules to start
+              console.error('Error starting ' + moduleName + ' component JS: ', e, window.location)
             }
           }
         }

data/app/views/govuk_publishing_components/components/feedback/_survey_signup_form.html.erb

@@ -10,7 +10,7 @@
       <h3 class="gem-c-feedback__form-heading"><%= t("components.feedback.help_us_improve_govuk") %></h3>
       <p id="survey_explanation" class="gem-c-feedback__form-paragraph">
         <%= t("components.feedback.more_about_visit") %>
-        <a href="https://www.smartsurvey.co.uk/s/gov-uk-banner/?c=<%= path_without_pii %>" class="govuk-link">Please fill in this survey</a>.
+        <a href="https://www.smartsurvey.co.uk/s/gov-uk-banner/?c=no-js" class="govuk-link" target="_blank" rel="noopener noreferrer external">Please fill in this survey (opens in a new tab)</a>.
       </p>
       <button
         class="govuk-button govuk-button--secondary js-close-form"

data/lib/govuk_publishing_components/version.rb

@@ -1,3 +1,3 @@
 module GovukPublishingComponents
-  VERSION = "38.3.1".freeze
+  VERSION = "38.4.0".freeze
 end

data/node_modules/axe-core/README.md

@@ -103,9 +103,9 @@ or equivalently:
 
 This will create a new build for axe, called `axe.<lang>.js` and `axe.<lang>.min.js`. If you want to build all localized versions, simply pass in `--all-lang` instead. If you want to build multiple localized versions (but not all of them), you can pass in a comma-separated list of languages to the `--lang` flag, like `--lang=nl,ja`.
 
-To create a new translation for axe, start by running `grunt translate --lang=<langcode>`. This will create a json file fin the `./locales` directory, with the default English text in it for you to translate. Alternatively, you could copy `./locales/_template.json`. We welcome any localization for axe-core. For details on how to contribute, see the Contributing section below. For details on the message syntax, see [Check Message Template](/doc/check-message-template.md).
+To create a new translation for axe, start by running `grunt translate --lang=<langcode>`. This will create a json file in the `./locales` directory, with the default English text in it for you to translate. Alternatively, you could copy `./locales/_template.json`. We welcome any localization for axe-core. For details on how to contribute, see the Contributing section below. For details on the message syntax, see [Check Message Template](/doc/check-message-template.md).
 
-To update existing translation file, re-run `grunt translate --lang=<langcode>`. This will add new messages used in English and remove messages which were not used in English.
+To update an existing translation file, re-run `grunt translate --lang=<langcode>`. This will add new messages used in English and remove messages which were not used in English.
 
 Additionally, locale can be applied at runtime by passing a `locale` object to `axe.configure()`. The locale object must be of the same shape as existing locales in the `./locales` directory. For example: