govuk_publishing_components 24.9.3 → 24.10.3

data/app/views/govuk_publishing_components/components/_notice.html.erb

@@ -10,7 +10,7 @@
 
   shared_helper = GovukPublishingComponents::Presenters::SharedHelper.new(local_assigns)
 
-  css_classes = %w(gem-c-notice)
+  css_classes = %w[gem-c-notice]
   css_classes << (shared_helper.get_margin_bottom)
 
   aria_attributes = aria_live ? {label: 'Notice', live: 'polite'} : {label: 'Notice'}

data/app/views/govuk_publishing_components/components/_phase_banner.html.erb

@@ -4,10 +4,6 @@ phase ||= nil
 message ||= nil
 inverse ||= false
 
-unless phase.in?(%w[alpha beta])
-  raise ArgumentError, "The phase banner component expects a `phase` (`beta` or `alpha`), #{phase.inspect} given"
-end
-
 unless message.present?
   if phase == "beta"
     message = raw("This part of GOV.UK is being rebuilt &ndash; <a class=\"govuk-link\" href=\"/help/beta\">find out what beta means</a>")
@@ -23,7 +19,7 @@ container_css_classes << "gem-c-phase-banner--inverse" if inverse
 <%= tag.div class: container_css_classes do %>
   <%= tag.p class: "govuk-phase-banner__content" do %>
     <%= tag.strong app_name, class: "govuk-phase-banner__content__app-name" if app_name %>
-    <%= tag.strong phase, class: "govuk-tag govuk-phase-banner__content__tag" %>
+    <%= tag.strong phase, class: "govuk-tag govuk-phase-banner__content__tag" if phase %>
     <%= tag.span message, class: "govuk-phase-banner__text" if message %>
   <% end %>
 <% end %>

data/app/views/govuk_publishing_components/components/_previous_and_next_navigation.html.erb

@@ -2,7 +2,7 @@
 <nav
   class="gem-c-pagination"
   role="navigation"
-  aria-label="<%= t("govuk_component.previous_and_next_navigation.pagination", default: "Pagination") %>"
+  aria-label="<%= t("components.previous_and_next_navigation.pagination", default: "Pagination") %>"
 >
   <ul class="gem-c-pagination__list" data-module="gem-track-click">
     <% if local_assigns.include?(:previous_page) %>

data/app/views/govuk_publishing_components/components/_radio.html.erb

@@ -11,6 +11,9 @@
   small ||= false
   inline ||= false
   is_page_heading ||= false
+  heading_level = is_page_heading ? 'h1' : shared_helper.get_heading_level
+  heading_classes = %w(govuk-fieldset__heading)
+  heading_classes << "gem-c-radio__heading-text" if heading_level == 'h1'
 
   if ['s', 'm', 'l', 'xl'].include?(heading_size)
     size = heading_size
@@ -46,20 +49,12 @@
 %>
 <%= tag.div id: id, class: form_group_css_classes do %>
   <%= tag.fieldset class: "govuk-fieldset", "aria-describedby": aria do %>
-
     <% if heading.present? %>
-      <% if is_page_heading %>
-        <%= tag.legend class: legend_classes do %>
-          <%= tag.span(heading_caption, class: "govuk-caption-#{size}") if heading_caption.present? %>
-          <%= tag.h1 heading, class: "gem-c-radio__heading-text govuk-fieldset__heading" %>
-        <% end %>
-      <% else %>
-        <%= tag.legend class: legend_classes do %>
-          <%= content_tag(shared_helper.get_heading_level, heading, class: "govuk-fieldset__heading") %>
-        <% end %>
+      <%= tag.legend class: legend_classes do %>
+        <%= tag.span(heading_caption, class: "govuk-caption-#{size}") if heading_caption.present? %>
+        <%= content_tag(heading_level, heading, class: heading_classes) %>
       <% end %>
     <% end %>
-
     <% if description.present? %>
       <%= tag.div description, class: "govuk-body" %>
     <% end %>

data/app/views/govuk_publishing_components/components/_show_password.html.erb

@@ -9,6 +9,7 @@
   hint ||= nil
   error_message ||= nil
   error_items ||= nil
+  data ||= nil
 
   if !label
     raise ArgumentError, "This component requires a label"
@@ -37,6 +38,7 @@
         error_items: error_items,
         type: "password",
         autocomplete: autocomplete,
+        data: data,
       } %>
   <% end %>
 <% end %>

data/app/views/govuk_publishing_components/components/_step_by_step_nav.html.erb

@@ -22,10 +22,10 @@
     class="gem-c-step-nav js-hidden <% unless small %>gem-c-step-nav--large<% end %>"
     <%= "data-remember" if remember_last_step %>
     <%= "data-id=#{tracking_id}" if tracking_id %>
-    data-show-text="<%= t("govuk_component.step_by_step_nav.show", default: "show") %>"
-    data-hide-text="<%= t("govuk_component.step_by_step_nav.hide", default: "hide") %>"
-    data-show-all-text="<%= t("govuk_component.step_by_step_nav.show_all", default: "Show all steps") %>"
-    data-hide-all-text="<%= t("govuk_component.step_by_step_nav.hide_all", default: "Hide all steps") %>"
+    data-show-text="<%= t("components.step_by_step_nav.show", default: "show") %>"
+    data-hide-text="<%= t("components.step_by_step_nav.hide", default: "hide") %>"
+    data-show-all-text="<%= t("components.step_by_step_nav.show_all", default: "Show all steps") %>"
+    data-hide-all-text="<%= t("components.step_by_step_nav.hide_all", default: "Hide all steps") %>"
   >
     <ol class="gem-c-step-nav__steps">
       <% steps.each_with_index do |step, step_index| %>

data/app/views/govuk_publishing_components/components/_step_by_step_nav_related.html.erb

@@ -1,6 +1,6 @@
 <%
   links ||= []
-  pretitle ||= t("govuk_component.step_by_step_nav_related.part_of", default: "Part of")
+  pretitle ||= t("components.step_by_step_nav_related.part_of", default: "Part of")
   always_display_as_list ||= false
 %>
 <% if links.any? %>

data/app/views/govuk_publishing_components/components/_subscription_links.html.erb

@@ -23,7 +23,7 @@
 <% if sl_helper.component_data_is_valid? %>
   <%= tag.section class: css_classes, data: data do %>
     <% unless hide_heading %>
-      <h2 class="gem-c-subscription-links__hidden-header visuallyhidden"><%= t("govuk_component.subscription_links.subscriptions", default: "Subscriptions") %></h2>
+      <h2 class="gem-c-subscription-links__hidden-header visuallyhidden"><%= t("components.subscription_links.subscriptions", default: "Subscriptions") %></h2>
     <% end %>
     <ul
       class="gem-c-subscription-links__list<%= ' gem-c-subscription-links__list--small' if local_assigns[:small_form] == true %>"

data/app/views/govuk_publishing_components/components/_success_alert.html.erb

@@ -13,7 +13,7 @@
     module: "initial-focus",
   } do %>
   <div class="govuk-notification-banner__header">
-    <%= tag.h2 t("govuk_component.success_alert.success", default: "Success"), class: "govuk-notification-banner__title", id: title_id %>
+    <%= tag.h2 t("components.success_alert.success", default: "Success"), class: "govuk-notification-banner__title", id: title_id %>
   </div>
   <div class="govuk-notification-banner__content">
     <% if description.present? %>

data/app/views/govuk_publishing_components/components/docs/phase_banner.yml

@@ -1,6 +1,6 @@
-name: Phase (alpha & beta) banner
+name: Phase banner
 description: |
-  A banner that indicates content is in a alpha or beta phase, with an optional explanation
+  A banner that indicates content is in a certain phase (usually alpha or beta), with an optional explanation
 accessibility_criteria: |
   The label must:
 

data/app/views/govuk_publishing_components/components/docs/show_password.yml

@@ -79,3 +79,13 @@ examples:
       error_items:
       - text: Look I keep telling you
       - text: This isn't your password
+  with_data_attributes:
+    description: Data attributes can be passed to add to the input element. If the data attribute starts with `data-button-` this attribute will be applied to the show/hide button, instead of the input. Note that if JS is disabled, all attributes are added to the input.
+    data:
+      label:
+        text: Your password
+      data:
+        example_1: value
+        example_2: thing
+        button_example_1: wotsit
+        button_example_2: doodad

data/app/views/govuk_publishing_components/components/layout_header/_navigation_items.html.erb

@@ -7,7 +7,7 @@
     class="govuk-header__menu-button govuk-js-header-toggle gem-c-header__menu-button"
     type="button"
   >
-    Menu
+    <%= t("components.layout_header.menu") %>
   </button>
   <%= tag.nav class: "gem-c-header__nav", aria: { label: navigation_aria_label } do %>
     <ul id="navigation" class="govuk-header__navigation govuk-header__navigation--end">

data/app/views/govuk_publishing_components/components/metadata/_sentence.html.erb

@@ -13,8 +13,8 @@
        class="gem-c-metadata__definition-link"
        data-controls="toggle-<%= toggle_id %>"
        data-expanded="false"
-       data-toggled-text="<%= t("govuk_component.metadata.toggle_less", default: "Show fewer") %>">
-        <%= t("govuk_component.metadata.toggle_more", number: remaining.length, default: "+ #{remaining.length} more") %>
+       data-toggled-text="<%= t("components.metadata.toggle_less", default: "Show fewer") %>">
+        <%= t("components.metadata.toggle_more", number: remaining.length, default: "+ #{remaining.length} more") %>
     </a>
   </div>
   <span id="toggle-<%= toggle_id %>" class="gem-c-metadata__toggle-items js-hidden"><%= remaining.to_sentence.html_safe %></span>

data/app/views/govuk_publishing_components/components/related_navigation/_section.html.erb

@@ -54,8 +54,8 @@
           class="gem-c-related-navigation__toggle"
           data-controls="toggle_<%= section_title %>"
           data-expanded="false"
-          data-toggled-text="<%= t("govuk_component.metadata.toggle_less", default: "Show fewer") %>">
-          <%= t("govuk_component.metadata.toggle_more",
+          data-toggled-text="<%= t("components.metadata.toggle_less", default: "Show fewer") %>">
+          <%= t("components.metadata.toggle_more",
                 number: related_nav_helper.remaining_link_count(links),
                 default: "+ #{related_nav_helper.remaining_link_count(links)} more") %>
         </a>

data/config/locales/en.yml

@@ -44,8 +44,8 @@ en:
       contents: "Contents"
     feedback:
       is_this_page_useful: "Is this page useful?"
-      yes: "Yes"
-      no: "No"
+      "yes": "Yes"
+      "no": "No"
       maybe: "Maybe"
       is_useful: "this page is useful"
       is_not_useful: "this page is not useful"
@@ -65,8 +65,16 @@ en:
       show_button: "Show search"
       hide_button: "Hide search"
       top_level: "Top level"
-      nav_items_aria_label: "Show or hide Top Level Navigation"
       menu: "Menu"
+    metadata:
+      from: "From"
+      part_of: "Part of"
+      history: "History"
+      published: "Published"
+      last_updated: "Last updated"
+      see_all_updates: "See all updates"
+      toggle_less: "Show fewer"
+      toggle_more: "+ %{number} more"
     organisation_schema:
       all_content_search_description: "Find all content from %{organisation}"
     radio:

data/lib/govuk_publishing_components/presenters/breadcrumb_selector.rb

@@ -60,6 +60,11 @@ module GovukPublishingComponents
             step_by_step: false,
             breadcrumbs: navigation.breadcrumbs,
           }
+        elsif navigation.content_is_travel_advice?
+          {
+            step_by_step: false,
+            breadcrumbs: navigation.breadcrumbs,
+          }
         elsif navigation.content_has_a_topic?
           {
             step_by_step: false,

data/lib/govuk_publishing_components/presenters/contextual_navigation.rb

@@ -16,6 +16,10 @@ module GovukPublishingComponents
         content_item["document_type"] == "simple_smart_answer"
       end
 
+      def content_is_travel_advice?
+        content_item["document_type"] == "travel_advice"
+      end
+
       def html_publication_with_parent?
         (content_item["document_type"] == "html_publication") && parent_api_path
       end

data/lib/govuk_publishing_components/version.rb

@@ -1,3 +1,3 @@
 module GovukPublishingComponents
-  VERSION = "24.9.3".freeze
+  VERSION = "24.10.3".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: govuk_publishing_components
 version: !ruby/object:Gem::Version
-  version: 24.9.3
+  version: 24.10.3
 platform: ruby
 authors:
 - GOV.UK Dev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-04-22 00:00:00.000000000 Z
+date: 2021-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: govuk_app_config
@@ -164,6 +164,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2'
+- !ruby/object:Gem::Dependency
+  name: i18n-coverage
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: jasmine
   requirement: !ruby/object:Gem::Requirement
@@ -416,7 +430,6 @@ files:
 - app/assets/javascripts/component_guide/filter-components.js
 - app/assets/javascripts/component_guide/vendor/bind-polyfill.js
 - app/assets/javascripts/component_guide/vendor/matches-polyfill.min.js
-- app/assets/javascripts/component_guide/visual-regression.js
 - app/assets/javascripts/govuk_publishing_components/all_components.js
 - app/assets/javascripts/govuk_publishing_components/analytics.js
 - app/assets/javascripts/govuk_publishing_components/analytics/analytics.js
@@ -469,6 +482,7 @@ files:
 - app/assets/javascripts/govuk_publishing_components/lib/toggle-input-class-on-focus.js
 - app/assets/javascripts/govuk_publishing_components/lib/toggle.js
 - app/assets/javascripts/govuk_publishing_components/lib/track-click.js
+- app/assets/javascripts/govuk_publishing_components/lib/trigger-event.js
 - app/assets/javascripts/govuk_publishing_components/modules.js
 - app/assets/javascripts/govuk_publishing_components/vendor/html5shiv-printshiv.js
 - app/assets/javascripts/govuk_publishing_components/vendor/json2.js

data/app/assets/javascripts/component_guide/visual-regression.js

@@ -1,71 +0,0 @@
-(function (window, document) {
-  window.GOVUK = window.GOVUK || {}
-
-  window.GOVUK.VisualDiffTool = function (currentWindowLocation) {
-    var visualDiffSelector = 'visual-diff'
-    var existingIframe = document.getElementById(visualDiffSelector)
-    var windowLocation = currentWindowLocation || window.location
-
-    if (existingIframe) {
-      existingIframe.parentNode.removeChild(existingIframe)
-      document.body.style.filter = null
-    } else {
-      var iframe = document.createElement('iframe')
-      iframe.id = visualDiffSelector
-      iframe.setAttribute('scrolling', 'no')
-      _setElementStyles(iframe, {
-        width: '100%',
-        height: document.body.scrollHeight + 'px',
-        position: 'absolute',
-        top: '0',
-        'pointer-events': 'none',
-        border: '0'
-      })
-      iframe.style.setProperty('z-index', '999', 'important')
-
-      // For browsers that support it, do mix-blend-mode diff
-      if ('mix-blend-mode' in document.body.style) {
-        _setElementStyles(iframe, { 'mix-blend-mode': 'difference' })
-        document.body.style.filter = 'invert(100%)'
-      } else {
-        // Else do a simple overlay of the live page for comparison (IE and Edge)
-        _setElementStyles(iframe, { opacity: '0.7' })
-      }
-
-      iframe.src = _processComparisonURL(windowLocation)
-
-      if (iframe.src) {
-        document.body.appendChild(iframe)
-        console.log('comparing to ' + iframe.src)
-      }
-    }
-  }
-
-  var _processComparisonURL = function (url) {
-    var appName
-    var href = url.href
-    var host = url.host
-
-    if (href.includes('dev.gov.uk/component-guide')) {
-      appName = host.split('.')[0]
-      return _forceHTTPS(href.replace(host, appName + '.herokuapp.com'))
-    } else if (href.includes('dev.gov.uk')) {
-      return _forceHTTPS(href.replace(host, 'www.gov.uk'))
-    } else if (href.includes('-pr-')) {
-      appName = host.split('-pr')[0]
-      return _forceHTTPS(href.replace(host, appName + '.herokuapp.com'))
-    } else {
-      throw new Error('Visual Diff Tool: You need to run this tool against a page running on your local dev environment')
-    }
-  }
-
-  var _forceHTTPS = function (href) {
-    return href.replace('http://', 'https://')
-  }
-
-  var _setElementStyles = function (element, styles) {
-    for (var style in styles) {
-      element.style[style] = styles[style]
-    }
-  }
-})(window, document)