govuk_publishing_components 24.18.4 → 24.18.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 356af78d76ad3c161339e6c908f64e22aa8ce6da250fa1389ec2d5095d28c906
-  data.tar.gz: e820884ca39a8533a260ae07b824bee43d3d0616e4434f70e8d8a5212ec5f693
+  metadata.gz: c0dd119f435f1a28904b9dcdb3606a673ce104affaf5ae042da92d0a0baed59f
+  data.tar.gz: b8812490fbe415509399aafe027c44e73a1d6792462a1d36454ce8fc58c57790
 SHA512:
-  metadata.gz: 115b6017568f069bece6086533f4e24e03af451682b59323924e96fe5996dc6c9e6f7597226571adba3fcba0df5798f85d8cfbd55f3ecaeaa49ac570946876af
-  data.tar.gz: 10f2ba6089990b0703e6cc4bc37aa3fc9e689560d8dfa9c193bf60aac1bc8536693e5f67a1501fdd836a408ad41d2ea3f191a640271425a27148bd8e1df54baf
+  metadata.gz: aca12277c18d9a05932d9b88d86a7c7e009a6fccc27740dd938165c19518b882b7b073b133215302e07930540f15af881e33fca4ee43fa4cf5ce09e9f53456f2
+  data.tar.gz: e0a26bacdc1cc6bc26a8e9392cff1ed1173c4af095d02fce45fba908cd520ccf23f41cdf49c9b3d3c37dca77a03f2b331050f98eda781418c91379f2e9fd1683

data/app/assets/javascripts/govuk_publishing_components/analytics/scroll-tracker.js

@@ -206,6 +206,13 @@
       ['Percent', 80],
       ['Percent', 100]
     ],
+    '/guidance/brexit-guidance-for-businesses.cy': [
+      ['Percent', 20],
+      ['Percent', 40],
+      ['Percent', 60],
+      ['Percent', 80],
+      ['Percent', 100]
+    ],
     '/guidance/brexit-guidance-for-individuals-and-families': [
       ['Percent', 20],
       ['Percent', 40],
@@ -213,6 +220,13 @@
       ['Percent', 80],
       ['Percent', 100]
     ],
+    '/guidance/brexit-guidance-for-individuals-and-families.cy': [
+      ['Percent', 20],
+      ['Percent', 40],
+      ['Percent', 60],
+      ['Percent', 80],
+      ['Percent', 100]
+    ],
     '/guidance/import-and-export-goods-using-preference-agreements': [
       ['Percent', 20],
       ['Percent', 40],

data/app/assets/javascripts/govuk_publishing_components/components/details.js

@@ -7,24 +7,26 @@ window.GOVUK.Modules.GovukDetails = window.GOVUKFrontend;
 (function (Modules) {
   function GemDetails ($module) {
     this.$module = $module
-    this.customTrackLabel = this.$module.getAttribute('data-track-label')
+    this.$summary = this.$module.querySelector('.govuk-details__summary')
+
+    this.customTrackLabel = this.$summary.getAttribute('data-track-label')
     this.detailsClick = this.$module.querySelector('[data-details-track-click]')
   }
 
   GemDetails.prototype.init = function () {
     if (this.customTrackLabel) { // If a custom label has been provided, we can simply call the tracking module
       var trackDetails = new window.GOVUK.Modules.GemTrackClick()
-      trackDetails.start($(this.$module))
+      trackDetails.start($(this.$summary))
     } else if (this.detailsClick) { // If no custom label is set, we use the open/close status as the label
       this.detailsClick.addEventListener('click', function (event) {
-        this.trackDefault(this.$module)
+        this.trackDefault(this.$summary)
       }.bind(this))
     }
   }
 
   GemDetails.prototype.trackDefault = function (element) {
     if (window.GOVUK.analytics && window.GOVUK.analytics.trackEvent) {
-      var componentStatus = (element.getAttribute('open') == null) ? 'open' : 'closed'
+      var componentStatus = (this.$module.getAttribute('open') == null) ? 'open' : 'closed'
       var trackCategory = element.getAttribute('data-track-category')
       var trackAction = element.getAttribute('data-track-action')
       var trackOptions = element.getAttribute('data-track-options')

data/app/assets/stylesheets/govuk_publishing_components/components/_action-link.scss

@@ -151,11 +151,11 @@
 
   &:before {
     height: 30px;
-    width: 35px;
+    width: 30px;
     background-image: image-url("govuk_publishing_components/action-link-arrow--brexit.svg");
     background-repeat: no-repeat;
-    background-size: 25px auto;
-    background-position: 0 0;
+    background-size: 18px auto;
+    background-position: 0 2px;
   }
 
   @include govuk-media-query($until: tablet) {
@@ -166,7 +166,9 @@
     margin-bottom: govuk-spacing(2);
 
     &:before {
+      width: 35px;
       background-position: 0 4px;
+      background-size: 25px auto;
     }
   }
 }

data/app/views/govuk_publishing_components/components/_details.html.erb

@@ -6,15 +6,18 @@
   css_classes = %w(gem-c-details govuk-details)
   css_classes << (shared_helper.get_margin_bottom)
 
+  details_data_attributes = {}
+  details_data_attributes[:module] = 'govuk-details gem-details'
+
   data_attributes ||= {}
-  data_attributes[:module] = 'govuk-details gem-details'
+  data_attributes[:details_track_click] = ''
 %>
-<%= tag.details class: css_classes, data: data_attributes, open: open do %>
-  <summary class="govuk-details__summary" data-details-track-click>
+<%= tag.details class: css_classes, data: details_data_attributes, open: open do %>
+  <%= tag.summary class: "govuk-details__summary", data: data_attributes do %>
     <span class="govuk-details__summary-text">
       <%= title %>
     </span>
-  </summary>
+  <% end %>
   <div class="govuk-details__text">
     <%= yield %>
   </div>

data/app/views/govuk_publishing_components/components/docs/details.yml

@@ -22,7 +22,7 @@ examples:
       block: |
         We need to know your nationality so we can work out which elections you’re entitled to vote in. If you can’t provide your nationality, you’ll have to send copies of identity documents through the post.
   with_data_attributes:
-    description: Can be used for tracking. By default, `track-label` is set to the status ("open" or "closed") unless a track_label is passed into the component.
+    description: Can be used for tracking. Tracking is applied to the summary element when the details element is opened and closed. By default, `track-label` is set to the status ("open" or "closed") unless a track_label is passed into the component.
     data:
       title: Help with nationality
       data_attributes:

data/app/views/govuk_publishing_components/components/docs/layout_header.yml

@@ -105,7 +105,10 @@ examples:
   with_search_bar:
     data:
       search: true
-
+  with_custom_logo_link:
+    description: The header logo links to root by default. This option allows us to override that in certain instances.
+    data:
+      logo_link: "/account/home"
 accessibility_criteria: |
   The component must:
 

data/lib/govuk_publishing_components/version.rb

@@ -1,3 +1,3 @@
 module GovukPublishingComponents
-  VERSION = "24.18.4".freeze
+  VERSION = "24.18.5".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: govuk_publishing_components
 version: !ruby/object:Gem::Version
-  version: 24.18.4
+  version: 24.18.5
 platform: ruby
 authors:
 - GOV.UK Dev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-07-08 00:00:00.000000000 Z
+date: 2021-07-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: govuk_app_config