govuk_publishing_components 24.0.0 → 24.3.1

data/app/views/govuk_publishing_components/components/docs/inverse_header.yml

@@ -45,7 +45,7 @@ examples:
     data:
       padding_top: false
       block: |
-        <div class="gem-c-breadcrumbs " data-module="track-click">
+        <div class="gem-c-breadcrumbs " data-module="gem-track-click">
           <ol>
             <li class="">
                 <a data-track-category="breadcrumbClicked" data-track-action="1" data-track-label="/section" data-track-options="{&quot;dimension28&quot;:&quot;2&quot;,&quot;dimension29&quot;:&quot;Section&quot;}" class="gem-c-breadcrumbs--inverse" aria-current="false" href="/section">Section</a>

data/app/views/govuk_publishing_components/components/layout_header/_header_logo.html.erb

@@ -1,5 +1,5 @@
 <div class="govuk-header__logo gem-c-header__logo">
-  <a href="/" class="govuk-header__link govuk-header__link--homepage" data-module="track-click" data-track-category="homeLinkClicked" data-track-action="homeHeader">
+  <a href="/" class="govuk-header__link govuk-header__link--homepage" data-module="gem-track-click" data-track-category="homeLinkClicked" data-track-action="homeHeader">
     <span class="govuk-header__logotype">
       <svg aria-hidden="true" focusable="false" class="govuk-header__logotype-crown" xmlns="http://www.w3.org/2000/svg" viewbox="0 0 132 97" height="32" width="36">
         <path fill="currentColor" fill-rule="evenodd"

data/app/views/govuk_publishing_components/components/layout_header/_navigation_items.html.erb

@@ -1,3 +1,5 @@
+<% navigation_aria_label ||= "Top level" %>
+
 <% if navigation_items.any? %>
   <button role="button" class="govuk-header__menu-button gem-c-header__menu-button govuk-js-header-toggle" aria-controls="navigation" aria-label="Show or hide Top Level Navigation">Menu</button>
   <%= tag.nav class: "gem-c-header__nav", aria: { label: navigation_aria_label } do %>

data/app/views/govuk_publishing_components/components/related_navigation/_section.html.erb

@@ -16,7 +16,7 @@
     %>
   <% end %>
 
-  <ul class="gem-c-related-navigation__link-list" data-module="track-click">
+  <ul class="gem-c-related-navigation__link-list" data-module="gem-track-click">
     <% constructed_link_array = [] %>
 
     <% section_link_limit = related_nav_helper.calculate_section_link_limit(links) %>
@@ -26,7 +26,7 @@
         link_element = link_to(
           link[:text],
           link[:path],
-          class: related_nav_helper.section_css_class("gem-c-related-navigation__section-link", section_title, link, (index >= section_link_limit)),
+          class: related_nav_helper.section_css_class("gem-c-related-navigation__section-link", section_title, link: link, link_is_inline: (index >= section_link_limit)),
           rel: link[:rel],
           lang: shared_helper.t_locale_check(link[:locale]),
           data: {

data/lib/govuk_publishing_components/app_helpers/table_helper.rb

@@ -15,6 +15,7 @@ module GovukPublishingComponents
           yield(builder)
         end
       end
+
       class TableBuilder
         include ActionView::Helpers::UrlHelper
         include ActionView::Helpers::TagHelper
@@ -57,7 +58,7 @@ module GovukPublishingComponents
 
         def cell(str, opt = {})
           classes = %w[govuk-table__cell]
-          classes << "govuk-table__cell--" + opt[:format] if opt[:format]
+          classes << "govuk-table__cell--#{opt[:format]}" if opt[:format]
           classes << "govuk-table__cell--empty" unless str
           str ||= "Not set"
           tag.td str, class: classes

data/lib/govuk_publishing_components/presenters/machine_readable/faq_page_schema.rb

@@ -88,7 +88,7 @@ module GovukPublishingComponents
       end
 
       def section_url(anchor)
-        return page_url + "#" + anchor if anchor.present?
+        return "#{page_url}##{anchor}" if anchor.present?
 
         page_url
       end

data/lib/govuk_publishing_components/presenters/machine_readable/html_publication_schema.rb

@@ -1,12 +1,6 @@
 module GovukPublishingComponents
   module Presenters
     class HtmlPublicationSchema < FaqPageSchema
-      attr_reader :page
-
-      def initialize(page)
-        @page = page
-      end
-
       def structured_data
         return ArticleSchema.new(page).structured_data if less_than_two_headings_of_any_one_type?
 
@@ -55,7 +49,7 @@ module GovukPublishingComponents
       # {:a => :b, :b => :c}
       def pairs_hash(array)
         all_but_last = array[0..-2]
-        all_but_first = array[1..-1]
+        all_but_first = array[1..]
         pairs = [all_but_last, all_but_first].transpose
         Hash[pairs]
       end

data/lib/govuk_publishing_components/presenters/meta_tags.rb

@@ -20,8 +20,7 @@ module GovukPublishingComponents
         meta_tags = add_organisation_tags(meta_tags)
         meta_tags = add_political_tags(meta_tags)
         meta_tags = add_taxonomy_tags(meta_tags)
-        meta_tags = add_step_by_step_tags(meta_tags)
-        meta_tags
+        add_step_by_step_tags(meta_tags)
       end
 
     private

data/lib/govuk_publishing_components/presenters/related_navigation_helper.rb

@@ -58,14 +58,14 @@ module GovukPublishingComponents
           I18n.t(
             "components.related_#{@context}_navigation." + section_title,
             default: [
-              I18n.t("components.related_navigation." + section_title),
+              I18n.t("components.related_navigation.#{section_title}"),
               section_title.tr("_", " "),
             ],
           )
         end
       end
 
-      def section_css_class(css_class, section_title, link = {}, link_is_inline = false)
+      def section_css_class(css_class, section_title, link: {}, link_is_inline: false)
         css_classes = [css_class]
         css_classes << "#{css_class}--#{@context}" unless @context.nil?
         css_classes << "#{css_class}--inline" if link_is_inline

data/lib/govuk_publishing_components/version.rb

@@ -1,3 +1,3 @@
 module GovukPublishingComponents
-  VERSION = "24.0.0".freeze
+  VERSION = "24.3.1".freeze
 end

data/lib/tasks/govuk_publishing_components_tasks.rake

@@ -14,7 +14,7 @@ namespace :component do
 
     if components_missing_docs.any?
       error = "You have components which are missing documentation. These components will not be displayed in the component guide:\n"
-      components_missing_docs.each { |component| error += "\t" + component + "\n" }
+      components_missing_docs.each { |component| error += "\t#{component}\n" }
       error += "\n"
       raise NotImplementedError, error
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: govuk_publishing_components
 version: !ruby/object:Gem::Version
-  version: 24.0.0
+  version: 24.3.1
 platform: ruby
 authors:
 - GOV.UK Dev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-02-09 00:00:00.000000000 Z
+date: 2021-02-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: govuk_app_config
@@ -238,16 +238,16 @@ dependencies:
   name: rubocop-govuk
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '3'
+        version: 4.0.0.pre.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '3'
+        version: 4.0.0.pre.1
 - !ruby/object:Gem::Dependency
   name: sassc-rails
   requirement: !ruby/object:Gem::Requirement
@@ -453,6 +453,7 @@ files:
 - app/assets/javascripts/govuk_publishing_components/vendor/json2.js
 - app/assets/javascripts/govuk_publishing_components/vendor/modernizr.js
 - app/assets/javascripts/govuk_publishing_components/vendor/polyfills/closest.js
+- app/assets/javascripts/govuk_publishing_components/vendor/polyfills/common.js
 - app/assets/javascripts/govuk_publishing_components/vendor/polyfills/indexOf.js
 - app/assets/stylesheets/component_guide/application.scss
 - app/assets/stylesheets/component_guide/print.scss
@@ -673,9 +674,9 @@ files:
 - app/views/govuk_publishing_components/components/_title.html.erb
 - app/views/govuk_publishing_components/components/_translation_nav.html.erb
 - app/views/govuk_publishing_components/components/_warning_text.html.erb
-- app/views/govuk_publishing_components/components/attachment/_thumbnail_document.svg
-- app/views/govuk_publishing_components/components/attachment/_thumbnail_generic.svg
-- app/views/govuk_publishing_components/components/attachment/_thumbnail_spreadsheet.svg
+- app/views/govuk_publishing_components/components/attachment/_thumbnail_document.html.erb
+- app/views/govuk_publishing_components/components/attachment/_thumbnail_generic.html.erb
+- app/views/govuk_publishing_components/components/attachment/_thumbnail_spreadsheet.html.erb
 - app/views/govuk_publishing_components/components/contextual_sidebar/_brexit_cta.html.erb
 - app/views/govuk_publishing_components/components/docs/accordion.yml
 - app/views/govuk_publishing_components/components/docs/action_link.yml
@@ -1859,7 +1860,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="