govuk_publishing_components 21.67.2 → 21.68.0

Sign up to get free protection for your applications and to get access to all the features.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: dff3c8adb46566625a54c58136bffb72bbaec93fa9d803f04d6372c09065766a
4
- data.tar.gz: 48b13db7e001c01cbf4f230195f42248a3378e8f263e7abcb9dae8e88a4e382d
3
+ metadata.gz: c5472741da244e97899f84ef1a0e35c9aee688ae1f7f2f02f8090dc74c92b6b1
4
+ data.tar.gz: 936ca8437c60e546170a29792520431d7498d05198063d06d4181885b8db001c
5
5
  SHA512:
6
- metadata.gz: be93ed1a460324911d7e4626a028f5352b7d4a5cbe0838ec67516f1ed03ca6373559f45c60faa572acc112d56d52c035700d4e205dc01f60c057e6355a473dfe
7
- data.tar.gz: a46214b1b651dffebaf202c8c1a003c9b2275abd042f458dc8fab883e97a9aeacba0e9d1dbb76070e14f76b87c9d353a63a6a332bad3b291d1ed4d032f744293
6
+ metadata.gz: 479712e62c490344d7c916961ca9ec6416e614aef2d8012a680f6df4da57f92aa4d3045e042e7b359d032505c365187bdd8889a67d046b2849d6af53717cc757
7
+ data.tar.gz: 07fff22879ff514527f9d1da0162826060a1d671428d3bec15c75c629e99edb920c70c6986071220b41e97ca02786765bcd16894ebe67868081c132022b70e08
data/README.md CHANGED
@@ -1,4 +1,4 @@
1
- GOV.UK Publishing Components
1
+ GOV.UK Publishing Components
2
2
  [![status](https://badgen.net/github/status/alphagov/govuk_publishing_components/master)](https://ci.integration.publishing.service.gov.uk/job/govuk_publishing_components/job/master/)
3
3
  [![JavaScript Style Guide](https://img.shields.io/badge/code_style-standard-brightgreen.svg)](https://standardjs.com)
4
4
  [![Stylelint Style Guide](https://img.shields.io/badge/code_style-stylelint-brightgreen.svg)](https://github.com/alphagov/stylelint-config-gds/)
@@ -59,6 +59,10 @@ bundle install
59
59
  yarn install
60
60
  ```
61
61
 
62
+ ### Running a local app with a local gem
63
+
64
+ The GDS Developer Docs has a [guide on local frontend development](https://docs.publishing.service.gov.uk/manual/local-frontend-development.html) that covers setting up a local app to use the local version of the components gem in Docker and using the `./startup.sh` script.
65
+
62
66
  ### Running tests
63
67
 
64
68
  The default rake task runs all the linting and test tasks:
@@ -90,7 +90,7 @@
90
90
  }
91
91
 
92
92
  .gem-c-feedback__prompt-question {
93
- vertical-align: text-top;
93
+ vertical-align: top;
94
94
  display: inline-block;
95
95
  margin: govuk-spacing(2) govuk-spacing(4);
96
96
 
@@ -113,9 +113,17 @@
113
113
 
114
114
  .gem-c-feedback__prompt-link {
115
115
  @include govuk-font(19);
116
- box-shadow: 0 2px 0 govuk-colour("black");
116
+ background: transparent;
117
+ box-shadow: 0 2px 0 govuk-colour("white");
118
+ border: 1px govuk-colour("white") solid;
117
119
  min-width: 100%;
118
120
 
121
+ &:hover {
122
+ // backup style for browsers that don't support rgba
123
+ background: govuk-colour("black");
124
+ background: rgba(govuk-colour("black"), .2);
125
+ }
126
+
119
127
  @include govuk-media-query($from: mobile) {
120
128
  min-width: 100px;
121
129
  margin-bottom: 0;
@@ -6,18 +6,18 @@
6
6
  <div class="gem-c-feedback__prompt-questions js-prompt-questions">
7
7
  <h2 class="gem-c-feedback__prompt-question"><%= t("components.feedback.is_this_page_useful", default: "Is this page useful?") %></h2>
8
8
  <!-- Maybe button exists only to try and capture clicks by bots -->
9
- <button class="govuk-button govuk-button--secondary gem-c-feedback__prompt-link" data-track-category="yesNoFeedbackForm" data-track-action="ffMaybeClick" aria-expanded="false" style="display: none" hidden="hidden" aria-hidden="true">
9
+ <button data-track-category="yesNoFeedbackForm" data-track-action="ffMaybeClick" aria-expanded="false" style="display: none" hidden="hidden" aria-hidden="true">
10
10
  <%= t("components.feedback.maybe", default: "Maybe") %>
11
11
  </button>
12
12
 
13
13
  <ul class="gem-c-feedback__option-list">
14
14
  <li class="gem-c-feedback__option-list-item">
15
- <button class="govuk-button govuk-button--secondary gem-c-feedback__prompt-link js-page-is-useful" data-track-category="yesNoFeedbackForm" data-track-action="ffYesClick">
15
+ <button class="govuk-button gem-c-feedback__prompt-link js-page-is-useful" data-track-category="yesNoFeedbackForm" data-track-action="ffYesClick">
16
16
  <%= t("components.feedback.yes", default: "Yes") %> <span class="govuk-visually-hidden"><%= t("components.feedback.is_useful", default: "this page is useful") %></span>
17
17
  </button>
18
18
  </li>
19
19
  <li class="gem-c-feedback__option-list-item">
20
- <button class="govuk-button govuk-button--secondary gem-c-feedback__prompt-link js-toggle-form js-page-is-not-useful" data-track-category="yesNoFeedbackForm" data-track-action="ffNoClick" aria-controls="page-is-not-useful" aria-expanded="false">
20
+ <button class="govuk-button gem-c-feedback__prompt-link js-toggle-form js-page-is-not-useful" data-track-category="yesNoFeedbackForm" data-track-action="ffNoClick" aria-controls="page-is-not-useful" aria-expanded="false">
21
21
  <%= t("components.feedback.no", default: "No") %> <span class="govuk-visually-hidden"><%= t("components.feedback.is_not_useful", default: "this page is not useful") %></span>
22
22
  </button>
23
23
  </li>
@@ -27,8 +27,8 @@
27
27
  <%= t("components.feedback.thank_you_for_feedback", default: "Thank you for your feedback") %>
28
28
  </div>
29
29
  <div class="gem-c-feedback__prompt-questions gem-c-feedback__prompt-questions--something-is-wrong js-prompt-questions">
30
- <button class="govuk-button govuk-button--secondary gem-c-feedback__prompt-link js-toggle-form js-something-is-wrong" data-track-category="Onsite Feedback" data-track-action="GOV-UK Open Form" aria-controls="something-is-wrong" aria-expanded="false">
31
- <%= t("components.feedback.anything_wrong", default: "Is there anything wrong with this page?") %>
30
+ <button class="govuk-button gem-c-feedback__prompt-link js-toggle-form js-something-is-wrong" data-track-category="Onsite Feedback" data-track-action="GOV-UK Open Form" aria-controls="something-is-wrong" aria-expanded="false">
31
+ <%= t("components.feedback.something_wrong", default: "There is something wrong with this page") %>
32
32
  </button>
33
33
  </div>
34
34
  </div>
@@ -44,7 +44,7 @@ en:
44
44
  is_useful: "this page is useful"
45
45
  is_not_useful: "this page is not useful"
46
46
  thank_you_for_feedback: "Thank you for your feedback"
47
- anything_wrong: "Is there anything wrong with this page?"
47
+ something_wrong: "There is something wrong with this page"
48
48
  close: "Close"
49
49
  help_us_improve_govuk: "Help us improve GOV.UK"
50
50
  more_about_visit: "To help us improve GOV.UK, we’d like to know more about your visit today. We’ll send you a link to a feedback form. It will take only 2 minutes to fill in. Don’t worry we won’t send you spam or share your email address with anyone."
@@ -1,3 +1,3 @@
1
1
  module GovukPublishingComponents
2
- VERSION = "21.67.2".freeze
2
+ VERSION = "21.68.0".freeze
3
3
  end
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: govuk_publishing_components
3
3
  version: !ruby/object:Gem::Version
4
- version: 21.67.2
4
+ version: 21.68.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - GOV.UK Dev
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2020-09-28 00:00:00.000000000 Z
11
+ date: 2020-10-08 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: govuk_app_config
@@ -1803,7 +1803,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
1803
1803
  - !ruby/object:Gem::Version
1804
1804
  version: '0'
1805
1805
  requirements: []
1806
- rubygems_version: 3.0.3
1806
+ rubygems_version: 3.1.4
1807
1807
  signing_key:
1808
1808
  specification_version: 4
1809
1809
  summary: A gem to document components in GOV.UK frontend applications