govuk_publishing_components 21.62.0 → 21.63.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d338f19f706ae958279f7217d7b10ae3f3939a0e9b850dc481b4a8878249ec53
-  data.tar.gz: f9a356891d53fc81f49e2f467aefaa233947ebf501d27c1f5dd198574f2de370
+  metadata.gz: ca5313136ffde496204e61ad0ff9ac47a3a7fb9bb4b24a04698be2e64acd392f
+  data.tar.gz: 6d5956d2c5d2dceb4c7386c966b61cd3bb0201acfc591c13b1908a5cdeb0b840
 SHA512:
-  metadata.gz: 18644ee3c0753253a18d4fd13da292ad4a48e5b78de3be7d2f030a400b5b5b1937bb7433fef7161ca5f29576cf33db0fece60bbc38c0aea1d8c0b08866df6d10
-  data.tar.gz: 31ffd5af5a5472dc4e294c4b5af84750db0512ead35ecc784bad5b8bbb81f734efdf49d14d59e5e6acc643f62d47b2c016cf1720cdc6d84f6bf74f320b8dae6b
+  metadata.gz: 3988ac7785d2cd680e5a15a8ee039150477d3aae4cf9cb9b8436eafc0a892e5052f07fdfc9a39628667b5a092a2639e019ac821c19893e1c366756ac82a17865
+  data.tar.gz: 75b96e067b7dadea877d8ee84437653cdfbb088cf90a3eed87ce7618c6635bc22f56c7996a021c8f33e89f49bb607adeae24351bd46bc32f5d59aed97f63639d

data/app/assets/stylesheets/govuk_publishing_components/components/_breadcrumbs.scss

@@ -21,37 +21,24 @@
   border-color: govuk-colour("white");
 }
 
-.gem-c-breadcrumbs--collapse-on-mobile {
+.govuk-breadcrumbs--collapse-on-mobile {
   @include govuk-media-query($until: tablet) {
-    .govuk-breadcrumbs__list {
-      display: flex;
-    }
-
-    .govuk-breadcrumbs__list-item:not(:last-child):not(:first-child) {
-      display: none;
-    }
-
     .govuk-breadcrumbs__list-item {
       padding-top: 14px;
       padding-bottom: 14px;
     }
 
     .govuk-breadcrumbs__list-item:before {
-      margin: 0;
       top: 18px;
     }
 
-    .govuk-breadcrumbs__link {
-      position: relative;
-    }
-
     .govuk-breadcrumbs__link:after {
       content: "";
       position: absolute;
-      top: -14px;
+      top: 0;
       right: 0;
       left: 0;
-      bottom: -14px;
+      bottom: 0;
     }
   }
 }

data/app/views/govuk_publishing_components/components/_breadcrumbs.html.erb

@@ -5,7 +5,7 @@
   breadcrumb_presenter = GovukPublishingComponents::Presenters::Breadcrumbs.new(breadcrumbs)
 
   classes = "gem-c-breadcrumbs govuk-breadcrumbs"
-  classes << " gem-c-breadcrumbs--collapse-on-mobile" if collapse_on_mobile
+  classes << " govuk-breadcrumbs--collapse-on-mobile" if collapse_on_mobile
   classes << " gem-c-breadcrumbs--inverse" if inverse
 %>
 

data/app/views/govuk_publishing_components/components/_document_list.html.erb

@@ -33,6 +33,7 @@
               item[:link][:path],
               data: item[:link][:data_attributes],
               class: "#{item_classes} gem-c-document-list__item-link",
+              lang: item[:link][:locale].presence
             )
           else
             content_tag(
@@ -54,16 +55,24 @@
 
         <% if item[:metadata] %>
           <ul class="gem-c-document-list__item-metadata">
-            <% item[:metadata].compact.each do |item_metadata_key, item_metadata_value| %>
-              <li class="gem-c-document-list__attribute">
-                <% if item_metadata_key.to_s.eql?("public_updated_at") %>
-                  <time datetime="<%= item_metadata_value.iso8601 %>">
-                    <%= l(item_metadata_value, format: '%e %B %Y') %>
-                  </time>
-                <% else %>
-                  <%= item_metadata_value %>
+            <% item[:metadata].compact.each do |item_metadata_key, item_metadata_value| %> 
+              <% if !item_metadata_key.to_s.eql?("locale") %>
+                <% lang = item[:metadata][:locale].present? && item[:metadata][:locale][item_metadata_key].present? ? item[:metadata][:locale][item_metadata_key] : nil %>
+
+                <%= content_tag(
+                  :li, item_metadata_value,
+                  class: "gem-c-document-list__attribute",
+                  lang: lang
+                ) do %>
+                  <% if item_metadata_key.to_s.eql?("public_updated_at") %>
+                    <time datetime="<%= item_metadata_value.iso8601 %>">
+                      <%= l(item_metadata_value, format: '%e %B %Y') %>
+                    </time>
+                  <% else %>
+                    <%= item_metadata_value %>
+                  <% end %>
                 <% end %>
-              </li>
+              <% end %>
             <% end %>
           </ul>
         <% end %>

data/app/views/govuk_publishing_components/components/docs/document_list.yml

@@ -262,3 +262,21 @@ examples:
         - link:
             text: 'Criteria'
             description: 'no url provided, just text'
+  with_locale_specified:
+    description: |
+      The component is used on translated pages that don’t have a translation for the document link text or the metadata. This means that it could display the fallback English string if the translate method can’t find an appropriate translation. This makes sure that the lang can be set to ensure that browsers understand which parts of the page are in each language.
+
+      Locales can be set separately for the document link text and individual metadata items. To set link text locale, pass a locale attribute along with the link object. To set metadata locale, pass a locale attribute containing a parallel object to your metadata (depending on which metadata have translations and which need a lang attribute to specify that they are in a different language).
+
+      The lang attribute must be set to a [valid BCP47 string](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/lang#Language_tag_syntax). A valid code can be the two or three letter language code - for example, English is en or eng, Korean is ko or kor - but if in doubt please check.
+    data:
+      items:
+      - link:
+          text: 'Tryloywder Uwch Staff Ysgrifennydd Gwladol Cymru Ionawr-Mawrth 2020'
+          path: '/government/publications/office-of-the-secretary-of-state-for-wales-senior-staff-transparency-january-march-2020'
+          locale: 'cy'
+        metadata:
+          public_updated_at: 2016-06-27 10:29:44
+          document_type: 'Data tryloywder'
+          locale:
+            document_type: 'cy'

data/app/views/govuk_publishing_components/components/feedback/_problem_form.html.erb

@@ -10,7 +10,7 @@
     data-track-action="GOV.UK Close Form"
     aria-controls="something-is-wrong"
     aria-expanded="true"
-    role="button">Close</a>
+    role="button"><%= t("components.feedback.close", default: "Close") %></a>
 
   <div class="govuk-grid-row">
     <div class="govuk-grid-column-two-thirds">
@@ -18,12 +18,12 @@
 
       <input type="hidden" name="url" value="<%= url_without_pii %>">
 
-      <h3 class="gem-c-feedback__form-heading">Help us improve GOV.UK</h3>
-      <p id="feedback_explanation" class="gem-c-feedback__form-paragraph">Don’t include personal or financial information like your National Insurance number or credit card details.</p>
+      <h3 class="gem-c-feedback__form-heading"><%= t("components.feedback.help_us_improve_govuk", default: "Help us improve GOV.UK") %></h3>
+      <p id="feedback_explanation" class="gem-c-feedback__form-paragraph"><%= t("components.feedback.dont_include_personal_info", default: "Don’t include personal or financial information like your National Insurance number or credit card details.") %></p>
 
       <%= render "govuk_publishing_components/components/input", {
         label: {
-          text: "What were you doing?"
+          text: t("components.feedback.what_doing", default: "What were you doing?")
         },
         name: "what_doing",
         describedby: "feedback_explanation"
@@ -31,13 +31,13 @@
 
       <%= render "govuk_publishing_components/components/input", {
         label: {
-          text: "What went wrong?"
+          text: t("components.feedback.what_wrong", default: "What went wrong?")
         },
         name: "what_wrong"
       } %>
 
       <%= render "govuk_publishing_components/components/button", {
-        text: "Send"
+        text: t("components.feedback.send", default: "Send")
       } %>
     </div>
   </div>

data/app/views/govuk_publishing_components/components/feedback/_survey_signup_form.html.erb

@@ -10,7 +10,7 @@
     data-track-action="ffFormClose"
     aria-controls="page-is-not-useful"
     aria-expanded="true"
-    role="button">Close</a>
+    role="button"><%= t("components.feedback.close", default: "Close") %></a>
 
   <div class="govuk-grid-row">
     <div class="govuk-grid-column-two-thirds" id="survey-wrapper">
@@ -19,12 +19,12 @@
       <input name="email_survey_signup[survey_id]" type="hidden" value="footer_satisfaction_survey">
       <input name="email_survey_signup[survey_source]" type="hidden" value="<%= path_without_pii %>">
 
-      <h3 class="gem-c-feedback__form-heading">Help us improve GOV.UK</h3>
-      <p id="survey_explanation" class="gem-c-feedback__form-paragraph">To help us improve GOV.UK, we’d like to know more about your visit today. We’ll send you a link to a feedback form. It will take only 2 minutes to fill in. Don’t worry we won’t send you spam or share your email address with anyone.</p>
+      <h3 class="gem-c-feedback__form-heading"><%= t("components.feedback.help_us_improve_govuk", default: "Help us improve GOV.UK") %></h3>
+      <p id="survey_explanation" class="gem-c-feedback__form-paragraph"><%= t("components.feedback.more_about_visit", default: "To help us improve GOV.UK, we’d like to know more about your visit today. We’ll send you a link to a feedback form. It will take only 2 minutes to fill in. Don’t worry we won’t send you spam or share your email address with anyone.") %></p>
 
       <%= render "govuk_publishing_components/components/input", {
         label: {
-          text: "Email address"
+          text: t("components.feedback.email_address", default: "Email address")
         },
         name: "email_survey_signup[email_address]",
         type: "email",
@@ -32,8 +32,8 @@
         describedby: "survey_explanation"
       } %>
 
-      <%= render "govuk_publishing_components/components/button", {
-        text: "Send me the survey",
+       <%= render "govuk_publishing_components/components/button", {
+        text: t("components.feedback.send_me_survey", default: "Send me the survey"),
       } %>
     </div>
   </div>

data/app/views/govuk_publishing_components/components/feedback/_yes_no_banner.html.erb

@@ -4,9 +4,9 @@
 
 <div class="gem-c-feedback__prompt gem-c-feedback__js-show js-prompt" tabindex="-1">
   <div class="gem-c-feedback__prompt-questions js-prompt-questions">
-    <h2 class="gem-c-feedback__prompt-question">Is this page useful?</h2>
+    <h2 class="gem-c-feedback__prompt-question"><%= t("components.feedback.is_this_page_useful", default: "Is this page useful?") %></h2>
     <!-- Maybe button exists only to try and capture clicks by bots -->
-    <%= link_to contact_govuk_path, {
+    <%= link_to t("components.feedback.maybe", default: "Maybe"), contact_govuk_path, {
         class: 'gem-c-feedback__prompt-link',
         data: {
           'track-category' => 'yesNoFeedbackForm',
@@ -17,9 +17,7 @@
         style: 'display: none;',
         hidden: 'hidden',
         'aria-hidden': 'true',
-      } do %>
-        Maybe
-    <% end %>
+      } %>
     <ul class="gem-c-feedback__option-list">
       <li class="gem-c-feedback__option-list-item">
         <%= link_to contact_govuk_path, {
@@ -31,7 +29,7 @@
           'aria-expanded': false,
           role: 'button',
         } do %>
-          Yes <span class="govuk-visually-hidden">this page is useful</span>
+          <%= t("components.feedback.yes", default: "Yes") %> <span class="govuk-visually-hidden"><%= t("components.feedback.is_useful", default: "this page is useful") %></span>
         <% end %>
       </li>
       <li class="gem-c-feedback__option-list-item">
@@ -45,13 +43,13 @@
           'aria-expanded': false,
           role: 'button',
         } do %>
-          No <span class="govuk-visually-hidden">this page is not useful</span>
+          <%= t("components.feedback.no", default: "No") %> <span class="govuk-visually-hidden"><%= t("components.feedback.is_not_useful", default: "this page is not useful") %></span>
         <% end %>
       </li>
     </ul>
   </div>
-  <div class="gem-c-feedback__prompt-questions gem-c-feedback__prompt-success js-prompt-success js-hidden" tabindex="-1">
-    Thank you for your feedback
+  <div class="gem-c-feedback__prompt-questions gem-c-feedback__prompt-success js-prompt-success js-hidden" role="alert">
+    <%= t("components.feedback.thank_you_for_feedback", default: "Thank you for your feedback") %>
   </div>
   <div class="gem-c-feedback__prompt-questions gem-c-feedback__prompt-questions--something-is-wrong js-prompt-questions">
     <%= link_to contact_govuk_path, {
@@ -64,7 +62,7 @@
       'aria-expanded': false,
       role: 'button',
     } do %>
-      Is there anything wrong with this page?
+      <%= t("components.feedback.anything_wrong", default: "Is there anything wrong with this page?") %>
     <% end %>
   </div>
 </div>

data/config/locales/en.yml

@@ -36,6 +36,24 @@ en:
       or: 'or'
     contents_list:
       contents: Contents
+    feedback:
+      is_this_page_useful: "Is this page useful?"
+      yes: "Yes"
+      no: "No"
+      maybe: "Maybe"
+      is_useful: "this page is useful"
+      is_not_useful: "this page is not useful"
+      thank_you_for_feedback: "Thank you for your feedback"
+      anything_wrong: "Is there anything wrong with this page?"
+      close: "Close"
+      help_us_improve_govuk: "Help us improve GOV.UK"
+      more_about_visit: "To help us improve GOV.UK, we’d like to know more about your visit today. We’ll send you a link to a feedback form. It will take only 2 minutes to fill in. Don’t worry we won’t send you spam or share your email address with anyone."
+      dont_include_personal_info: "Don’t include personal or financial information like your National Insurance number or credit card details."
+      email_address: "Email address"
+      what_doing: "What were you doing?"
+      what_wrong: "What went wrong?"
+      send_me_survey: "Send me the survey"
+      send: "Send"
     organisation_schema:
       all_content_search_description: "Find all content from %{organisation}"
     radio:

data/lib/govuk_publishing_components/presenters/breadcrumb_selector.rb

@@ -18,6 +18,7 @@ module GovukPublishingComponents
       end
 
       def priority_breadcrumbs
+        return if hide_priority_breadcrumb?
         return parent_item_navigation.priority_breadcrumbs if content_item_navigation.html_publication_with_parent?
 
         content_item_navigation.priority_breadcrumbs
@@ -25,6 +26,10 @@ module GovukPublishingComponents
 
     private
 
+      def hide_priority_breadcrumb?
+        content_item_navigation.content_tagged_to_current_step_by_step? && content_item_navigation.tagged_to_brexit?
+      end
+
       def best_match_option
         return content_item_options unless content_item_navigation.html_publication_with_parent?
 

data/lib/govuk_publishing_components/version.rb

@@ -1,3 +1,3 @@
 module GovukPublishingComponents
-  VERSION = "21.62.0".freeze
+  VERSION = "21.63.0".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: govuk_publishing_components
 version: !ruby/object:Gem::Version
-  version: 21.62.0
+  version: 21.63.0
 platform: ruby
 authors:
 - GOV.UK Dev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-08-20 00:00:00.000000000 Z
+date: 2020-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: govuk_app_config