RubyGems - govuk_publishing_components - Versions diffs - 21.56.2 → 21.60.0 - Mend

govuk_publishing_components 21.56.2 → 21.60.0

Files changed (77) hide show

data/app/assets/stylesheets/govuk_publishing_components/components/_radio.scss CHANGED

@@ -1 +1,5 @@
 @import "govuk/components/radios/radios";
+.gem-c-radio__heading-text {
+  margin: 0;
+}

data/app/assets/stylesheets/govuk_publishing_components/components/_related-navigation.scss CHANGED

@@ -24,7 +24,7 @@
   margin-bottom: govuk-spacing(2);
 }
-.gem-c-related-navigation__main-heading  + .gem-c-related-navigation__sub-heading {
+.gem-c-related-navigation__main-heading + .gem-c-related-navigation__sub-heading {
   border-top: 0;
   padding-top: 0;
 }
@@ -62,7 +62,7 @@
   .js-enabled & {
     display: inline-block;
-   }
+  }
 }
 .gem-c-related-navigation__section-link {

data/app/assets/stylesheets/govuk_publishing_components/components/_search.scss CHANGED

@@ -9,6 +9,7 @@ $large-input-size: 50px;
 .gem-c-search__label {
   @include govuk-font($size: 19, $line-height: $input-size);
   display: block;
+  background: govuk-colour("white");
   h1 {
     @include govuk-font($size: 19, $line-height: $input-size);
@@ -17,8 +18,10 @@ $large-input-size: 50px;
   .js-enabled & {
     position: absolute;
-    left: govuk-spacing(3);
-    top: 1px;
+    left: 2px;
+    top: 2px;
+    bottom: 2px;
+    padding-left: govuk-spacing(3);
     z-index: 1;
     color: $govuk-secondary-text-colour;
   }
@@ -157,7 +160,6 @@ $large-input-size: 50px;
 }
 .gem-c-search--on-white {
   .gem-c-search__submit {
     background-color: govuk-colour("blue");
     color: govuk-colour("white");
@@ -201,6 +203,8 @@ $large-input-size: 50px;
 .gem-c-search--separate-label {
   .gem-c-search__label {
     position: relative;
+    top: auto;
     left: auto;
+    padding-left: 0;
   }
 }

data/app/assets/stylesheets/govuk_publishing_components/components/_step-by-step-nav-header.scss CHANGED

@@ -11,16 +11,11 @@
   }
 }
-// scss-lint:disable SelectorFormat
 .gem-c-step-nav-header__part-of {
   @include govuk-font(19, $weight: bold);
   display: block;
 }
 .gem-c-step-nav-header__title {
-  @extend %govuk-link;
   @include govuk-font(24, $weight: bold, $line-height: 1);
 }
-// scss-lint:enable SelectorFormat

data/app/assets/stylesheets/govuk_publishing_components/components/_step-by-step-nav-related.scss CHANGED

@@ -12,6 +12,7 @@
 .gem-c-step-nav-related__links {
   @include govuk-font(16);
+  list-style: none;
   margin: 0;
   padding: 0;
 }
@@ -42,10 +43,6 @@
   }
 }
-.gem-c-step-nav-related__links {
-  list-style: none;
-}
 .gem-c-step-nav-related__link-item {
   margin-top: govuk-spacing(3);
 }

data/app/assets/stylesheets/govuk_publishing_components/components/_step-by-step-nav.scss CHANGED

@@ -29,7 +29,7 @@ $top-border: solid 2px govuk-colour("mid-grey", $legacy: "grey-3");
 // we want to ensure that both large and small step navs have the same size font on mobile
 // this will stop text resizing if compatibility mode is turned off
 @mixin step-nav-font($size, $tablet-size: $size, $weight: normal, $line-height: 1.3, $tablet-line-height: $line-height) {
-  @include govuk-typography-common();
+  @include govuk-typography-common;
   font-size: $size + px;
   font-weight: $weight;
   line-height: $line-height;
@@ -122,7 +122,7 @@ $top-border: solid 2px govuk-colour("mid-grey", $legacy: "grey-3");
     @include govuk-media-query($from: tablet) {
       padding-left: govuk-spacing(9);
-      &:after {
+      &:after { // stylelint-disable-line max-nesting-depth
         @include step-nav-line-position-large;
         top: govuk-spacing(6);
       }
@@ -145,12 +145,8 @@ $top-border: solid 2px govuk-colour("mid-grey", $legacy: "grey-3");
   }
   &:after {
-    // scss-lint:disable DuplicateProperty
-    // sass-lint:disable no-duplicate-properties
     height: -webkit-calc(100% - #{govuk-spacing(3)}); // fallback for iphone 4
     height: calc(100% - #{govuk-spacing(3)});
-    // sass-lint:enable no-duplicate-properties
-    // scss-lint:enable DuplicateProperty
   }
   .gem-c-step-nav__help:after {
@@ -322,12 +318,6 @@ $top-border: solid 2px govuk-colour("mid-grey", $legacy: "grey-3");
   + .gem-c-step-nav__list {
     margin-top: -5px;
-    .gem-c-step-nav--large & {
-      @include govuk-media-query($from: tablet) {
-        margin-top: -govuk-spacing(3);
-      }
-    }
   }
   .gem-c-step-nav--large & {
@@ -335,6 +325,12 @@ $top-border: solid 2px govuk-colour("mid-grey", $legacy: "grey-3");
       padding-bottom: govuk-spacing(6);
     }
   }
+  .gem-c-step-nav--large & + .gem-c-step-nav__list {
+    @include govuk-media-query($from: tablet) {
+      margin-top: -govuk-spacing(3);
+    }
+  }
 }
 .gem-c-step-nav__list {

data/app/assets/stylesheets/govuk_publishing_components/components/_table.scss CHANGED

@@ -37,28 +37,26 @@ $table-row-even-background-colour: govuk-colour("light-grey", $legacy: "grey-4")
       padding-right: $sort-link-arrow-size;
       color: $govuk-link-colour;
       text-decoration: none;
+    }
-      &:focus {
-        @include govuk-focused-text;
-      }
-      &::after {
-        content: "";
-        position: absolute;
-        top: 5px;
-        right: 0;
-        @include govuk-shape-arrow($direction: up, $base: $sort-link-arrow-size-small, $display: block);
-      }
+    .app-table__sort-link:focus {
+      @include govuk-focused-text;
+    }
-      &::before {
-        content: "";
-        position: absolute;
-        top: 13px;
-        right: 0;
+    .app-table__sort-link:after {
+      content: "";
+      position: absolute;
+      top: 5px;
+      right: 0;
+      @include govuk-shape-arrow($direction: up, $base: $sort-link-arrow-size-small, $display: block);
+    }
-        @include govuk-shape-arrow($direction: down, $base: $sort-link-arrow-size-small, $display: block);
-      }
+    .app-table__sort-link:before {
+      content: "";
+      position: absolute;
+      top: 13px;
+      right: 0;
+      @include govuk-shape-arrow($direction: down, $base: $sort-link-arrow-size-small, $display: block);
     }
   }
@@ -81,12 +79,12 @@ $table-row-even-background-colour: govuk-colour("light-grey", $legacy: "grey-4")
       }
     }
-    .app-table__sort-link--ascending::before,
-    .app-table__sort-link--descending::before {
+    .app-table__sort-link--ascending:before,
+    .app-table__sort-link--descending:before {
       content: none;
     }
-    .app-table__sort-link--ascending::after {
+    .app-table__sort-link--ascending:after {
       content: "";
       position: absolute;
       top: $sort-link-arrow-spacing;
@@ -96,7 +94,7 @@ $table-row-even-background-colour: govuk-colour("light-grey", $legacy: "grey-4")
       @include govuk-shape-arrow($direction: up, $base: $sort-link-arrow-size, $display: inline-block);
     }
-    .app-table__sort-link--descending::after {
+    .app-table__sort-link--descending:after {
       content: "";
       position: absolute;
       top: $sort-link-arrow-spacing;
@@ -105,7 +103,6 @@ $table-row-even-background-colour: govuk-colour("light-grey", $legacy: "grey-4")
       @include govuk-shape-arrow($direction: down, $base: $sort-link-arrow-size, $display: inline-block);
     }
   }
   .govuk-table__row {

data/app/assets/stylesheets/govuk_publishing_components/components/_tabs.scss CHANGED

@@ -11,25 +11,21 @@
 // We have some styles within GOVUK (.content-block) which can leak into the list styles for this component.
 // These styles are defined in Static: https://github.com/alphagov/static/blob/a815620cada7ea1c65428c1c3b3ac4dbe28977bf/app/assets/stylesheets/helpers/_text.scss
 // This sets more specific selectors so those unwanted styles are overidden
-// scss-lint:disable QualifyingElement
-// sass-lint:disable no-qualifying-elements
-ul.govuk-tabs__list {
+ul.govuk-tabs__list { // stylelint-disable-line selector-no-qualifying-type
   margin: 0;
   padding: 0;
   list-style: none;
   @include govuk-responsive-margin(6, "bottom");
 }
-li.govuk-tabs__list-item {
+li.govuk-tabs__list-item { // stylelint-disable-line selector-no-qualifying-type
   margin-left: govuk-spacing(5);
 }
-.js-enabled {
+.js-enabled { // stylelint-disable-line no-duplicate-selectors
   @include govuk-media-query($from: tablet) {
-    ul.govuk-tabs__list {
+    ul.govuk-tabs__list { // stylelint-disable-line selector-no-qualifying-type
       margin-bottom: 0;
     }
   }
 }
-// scss-lint:enable QualifyingElement
-// sass-lint:enable no-qualifying-elements

data/app/assets/stylesheets/govuk_publishing_components/components/govspeak/_attachment.scss CHANGED

@@ -5,6 +5,8 @@
 // - alphagov/whitehall: ✔︎
 // - alphagov/govspeak: ✔︎
+// stylelint-disable max-nesting-depth
 .gem-c-govspeak {
   // Scope attachment and attachment-link component styles to gem-c-govspeak

data/app/assets/stylesheets/govuk_publishing_components/components/govspeak/_button.scss CHANGED

@@ -1,7 +1,6 @@
 @import "govuk/components/button/button";
-// scss-lint:disable PlaceholderInExtend
-// sass-lint:disable placeholder-in-extend
+// stylelint-disable scss/at-extend-no-missing-placeholder
 .gem-c-govspeak {
   .gem-c-button {
     @extend .govuk-button;
@@ -11,5 +10,3 @@
     @extend .govuk-button--start;
   }
 }
-// sass-lint:enable placeholder-in-extend
-// scss-lint:enable PlaceholderInExtend

data/app/assets/stylesheets/govuk_publishing_components/components/govspeak/_charts.scss CHANGED

@@ -9,6 +9,8 @@
 // adapted from magna-charta example stylesheet
 // https://github.com/alphagov/magna-charta/blob/master/demo/stylesheets/magna-charta.css
+// stylelint-disable max-nesting-depth
 .gem-c-govspeak {
   // DEFAULT CHART STYLES
@@ -266,10 +268,6 @@
     text-align: left;
   }
-  .mc-chart.mc-negative .mc-td.mc-key-cell {
-    padding-right: 25px;
-  }
   .mc-toggle-link {
     display: block;
     margin-top: 30px;

data/app/assets/stylesheets/govuk_publishing_components/components/govspeak/_contact.scss CHANGED

@@ -5,6 +5,8 @@
 // - alphagov/whitehall: ✔︎
 // - alphagov/govspeak: ✔︎
+// stylelint-disable max-nesting-depth
 .gem-c-govspeak {
   // .address is used by the `$A` markdown pattern
   .address,

data/app/assets/stylesheets/govuk_publishing_components/components/govspeak/_footnotes.scss CHANGED

@@ -9,6 +9,8 @@
 // - alphagov/whitehall: ✔︎
 // - alphagov/govspeak: ✔︎
+// stylelint-disable max-nesting-depth
 .gem-c-govspeak {
   .footnotes {
     border-top: 1px solid govuk-colour("mid-grey", $legacy: "grey-2");

data/app/assets/stylesheets/govuk_publishing_components/components/govspeak/_highlight-answer.scss CHANGED

@@ -1,3 +1,5 @@
+// stylelint-disable max-nesting-depth
 $highlight-answer-bg-color: govuk-colour("green");
 $highlight-answer-color: govuk-colour("white");

data/app/assets/stylesheets/govuk_publishing_components/components/govspeak/_place.scss CHANGED

@@ -1,4 +1,4 @@
-.gem-c-govspeak  .place {
+.gem-c-govspeak .place {
   margin: 1.5em 0;
   border-bottom: solid 1px govuk-colour("mid-grey", $legacy: "grey-2");
   padding-bottom: 1.5em;

data/app/assets/stylesheets/govuk_publishing_components/components/govspeak/_typography.scss CHANGED

@@ -9,6 +9,8 @@
 // - alphagov/whitehall: ✔︎
 // - alphagov/govspeak: ✔︎
+// stylelint-disable max-nesting-depth
 .gem-c-govspeak {
   @include markdown-typography;

data/app/assets/stylesheets/govuk_publishing_components/components/helpers/_markdown-typography.scss CHANGED

@@ -105,7 +105,7 @@
   }
   li {
-    margin: 0 0 5px 0;
+    margin: 0 0 5px;
     padding: 0;
     p {

data/app/assets/stylesheets/govuk_publishing_components/components/print/_govspeak.scss CHANGED

@@ -1,3 +1,5 @@
+// stylelint-disable max-nesting-depth
 .gem-c-govspeak {
   .media-player {
     display: none;
@@ -7,8 +9,12 @@
   .help-notice,
   .call-to-action {
     margin: govuk-spacing(3) 0;
-    padding: 0 govuk-spacing(3);
+  }
+  .call-to-action {
+    background: none;
     border: 1pt solid $govuk-border-colour;
+    padding: govuk-spacing(3);
   }
   .help-notice p {

data/app/assets/stylesheets/govuk_publishing_components/components/print/_step-by-step-nav-header.scss CHANGED

@@ -1,5 +1,3 @@
-// scss-lint:disable SelectorFormat
 .gem-c-step-nav-header__part-of {
   display: block;
 }
@@ -11,5 +9,3 @@
 .gem-c-step-nav-header__skip-link {
   display: none;
 }
-// scss-lint:enable SelectorFormat

data/app/assets/stylesheets/govuk_publishing_components/components/print/_step-by-step-nav.scss CHANGED

@@ -1,5 +1,3 @@
-// scss-lint:disable SelectorFormat
 $grey-2: #bfc1c3;
 $white: #ffffff;
 $number-circle-size: 35px;
@@ -40,6 +38,7 @@ $stroke-width: 3px;
 }
 .gem-c-step-nav__step {
+  padding-left: 60px;
   position: relative;
 }
@@ -74,14 +73,9 @@ $stroke-width: 3px;
   padding-bottom: 1em;
 }
-.gem-c-step-nav__step {
-  position: relative;
-  padding-left: 60px;
-}
 .gem-c-step-nav__title {
   @include govuk-font(19, $weight: bold);
-  margin: 0 0 .5em 0;
+  margin: 0 0 .5em;
   padding: 0;
 }
@@ -120,5 +114,3 @@ $stroke-width: 3px;
 .gem-c-step-nav__circle-step-colon {
   display: none;
 }
-// scss-lint:enable SelectorFormat

data/app/controllers/govuk_publishing_components/audit_controller.rb ADDED

@@ -0,0 +1,52 @@
+module GovukPublishingComponents
+  class AuditController < GovukPublishingComponents::ApplicationController
+    def show
+      path = Dir.pwd
+      components = AuditComponents.new(path)
+      applications = analyse_applications(File.expand_path("..", path))
+      compared_data = AuditComparer.new(components.data, applications)
+      @applications = compared_data.applications_data || []
+      @components = compared_data.gem_data || []
+    end
+  private
+    def analyse_applications(path)
+      results = []
+      applications = %w[
+        calculators
+        collections
+        collections-publisher
+        content-data-admin
+        content-publisher
+        email-alert-frontend
+        feedback
+        finder-frontend
+        frontend
+        government-frontend
+        govspeak-preview
+        info-frontend
+        licence-finder
+        manuals-frontend
+        release
+        search-admin
+        service-manual-frontend
+        signon
+        smart-answers
+        static
+        travel-advice-publisher
+        whitehall
+      ].sort
+      applications.each do |application|
+        application_path = [path, application].join("/")
+        app = AuditApplications.new(application_path, application)
+        results << app.data
+      end
+      results
+    end
+  end
+end